Re: [FFmpeg-devel] [PATCH 0/2] libavformat/matroskadec: set fixed duration for subtitles

2023-01-22 Thread Miguel Borges de Freitas
Hey guys, Any feedback on this patch? Regards ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe"

Re: [FFmpeg-devel] Late SEI is not implemented (providing a sample)

2023-01-15 Thread Miguel Borges de Freitas
Answering my own question here in case someone else stumbles into this, it turns out those streams were completely broken: - The CC data SEI NAL units were defined after the primary coded picture which violates the H264 standard - The user data part of SEI was lacking the marker_bits (0xFF) at t

[FFmpeg-devel] [PATCH 2/2] fate: update test reference data to include AV_PKT_FLAG_FIXED_DURATION

2023-01-10 Thread Miguel Borges de Freitas
From: Miguel Borges de Freitas Updates some of the test reference data to include the new AV_PKT_FLAG_FIXED_DURATION (this is the case for most matroska subtitles) Signed-off-by: Miguel Borges de Freitas --- tests/ref/fate/matroska-dvbsub-remux | 84 ++-- tests/ref/fate

[FFmpeg-devel] [PATCH 1/2] libavformat/matroskadec: set fixed duration for subtitles

2023-01-10 Thread Miguel Borges de Freitas
From: Miguel Borges de Freitas The matroska specification states the start time and duration of subtitle entries are encoded in the block TimeStamp and BlockDuration. Furthermore, for all subtitle formats except S_HDMV/PGS the BlockDuration must always be defined and have an absolute value even

[FFmpeg-devel] Late SEI is not implemented (providing a sample)

2022-12-29 Thread Miguel Borges de Freitas
Dear all, While updating Kodi to use the ffmpeg provided A53 side data for closed captions instead of our custom (old) demuxer (c.f. https://github.com/xbmc/xbmc/pull/22333) and running it against a battery of test samples I've found the following messages in the log for one particular sample: [f