Re: [FFmpeg-devel] [PATCH 1/1] segafilm: fetch duration from the container

2018-04-19 Thread Misty De Meo
On Thu, Apr 19, 2018 at 8:31 PM, James Almer wrote: > > > +film->sample_table[i].duration = AV_RB32([12]); > > While for video tracks this field seems to report the same packet > durations that were being calculated pre patch, this field for audio > tracks is always 1.

Re: [FFmpeg-devel] [PATCH 1/1] Add Sega FILM muxer

2018-04-07 Thread Misty De Meo
On Thu, Apr 5, 2018 at 2:06 PM, Josh de Kock wrote: > Thanks, pushed. I also clarified with wm4 on IRC that while he was against > it he wasn't blocking the muxer if someone else pushes it. Thank you! ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 0/1] Add Sega FILM muxer

2018-03-22 Thread Misty De Meo
On Thu, Mar 22, 2018 at 3:43 AM, wm4 wrote: > Why? Mainly to modify existing videos or encode new videos for Saturn games. It's particularly useful for fan translation - to mux in new audio, or encode new video for things like credits sequences.

Re: [FFmpeg-devel] [PATCH] avformat/segafilm - fix keyframe detection and set packet, flags

2018-03-21 Thread Misty De Meo
On Wed, Mar 21, 2018 at 1:32 PM, Carl Eugen Hoyos wrote: > 2018-03-21 14:37 GMT+01:00, Gyan Doshi : > Can you comment on why this 15-year old code was wrong? I think it was de facto unused before now. Since it wasn't passed through to AVPacket it wasn't

Re: [FFmpeg-devel] [PATCH 1/1] mpeg: add experimental support for PSMF audio.

2018-01-05 Thread Misty De Meo
Sorry about that - that was the placeholder title of a commit I squashed into the mpeg commit, and forgot to remove when rebasing. I'll remove it from the commit message. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 1/1] mpeg: add experimental support for PSMF audio.

2018-01-05 Thread Misty De Meo
> so this is unfinished code that work in progress ? > if so, what is missing ? > if not, then please write a better commit message Sorry about that - that was the placeholder title of a commit I squashed into the mpeg commit, and forgot to remove when rebasing. I'll remove it from the commit

Re: [FFmpeg-devel] [PATCH 2/6] mpeg: add experimental support for PSMF audio.

2017-12-26 Thread Misty De Meo
I originally left this patch alone since it was another person's commit; I can squash the fixes for that into this commit if you prefer, though. On Tue, Dec 26, 2017 at 8:39 AM, Michael Niedermayer wrote: > On Mon, Dec 25, 2017 at 10:28:30AM +0800, mi...@brew.sh wrote: >>

Re: [FFmpeg-devel] [PATCH 2/6] mpeg: add experimental support for PSMF audio.

2017-12-25 Thread Misty De Meo
On Tue, Dec 26, 2017 at 8:42 AM, Michael Niedermayer wrote: > returning errors from the parse function will cause assertion failure at: > > Assertion index > -0x2000 failed at libavcodec/parser.c:185 > > [...] What would be the preferred way to handle that?

Re: [FFmpeg-devel] [PATCH 2/6] mpeg: add experimental support for PSMF audio.

2017-12-25 Thread Misty De Meo
On Tue, Dec 26, 2017 at 8:39 AM, Michael Niedermayer wrote: > This fails to build without the next patch I originally left this patch alone since it was another person's commit; I can squash the fixes for that into this commit if you prefer, though.