Re: [FFmpeg-devel] [PATCH] hlsenc: single_file, support HLS ver 4 byteranges

2014-09-14 Thread Nicolas Martyanoff
. However I am happy my work ended up being useful :) Best regards, -- Nicolas Martyanoff http://wandrian.net khae...@gmail.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 4/7] avformat/hlsenc: do not regenerate the playlist for each segment

2014-07-30 Thread Nicolas Martyanoff
On 2014-07-29 15:59, Michael Niedermayer wrote: > On Fri, Jul 18, 2014 at 10:57:44AM +0200, Nicolas Martyanoff wrote: > > Since we need all segments to find out the target duration, we can only > > generate the playlist after writing all segments. > > > > There is no

Re: [FFmpeg-devel] [PATCH 2/7] avformat/hlsenc: make the code easier to read

2014-07-30 Thread Nicolas Martyanoff
On 2014-07-29 16:15, Michael Niedermayer wrote: > On Fri, Jul 18, 2014 at 10:57:42AM +0200, Nicolas Martyanoff wrote: > > Before adding new features, I read the code and cleaned it. The main issue > > was > > abstruse identifier names. > > > > The behaviour o

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: add single file mode

2014-07-23 Thread Nicolas Martyanoff
them whole for other purposes, it's useful to have a single file mode. Of course if you want to be able to switch resolution between segments, you will have to split the file. The fact that HLS version >=4 adds support for byte ranges shows that I am not the only

[FFmpeg-devel] [PATCH] avformat/hlsenc: add single file mode

2014-07-21 Thread Nicolas Martyanoff
HLS version 4 offers the possibility to keep the media file whole instead of splitting it. In that case, segments are specified with byte ranges. We introduce a new '-hls_flags' option for the hlsenc muxer, with a single flag for the time being, 'single_file'. --- doc/muxers.texi | 23 ++

[FFmpeg-devel] Update patch

2014-07-21 Thread Nicolas Martyanoff
Update the single file mode patch to correctly generate the last segment. Nicolas Martyanoff (1): avformat/hlsenc: add single file mode doc/muxers.texi | 23 ++--- libavformat/hlsenc.c | 94 ++-- 2 files changed, 96 insertions

[FFmpeg-devel] [PATCH 5/7] avformat/hlsenc: add single file mode

2014-07-18 Thread Nicolas Martyanoff
HLS version 4 offers the possibility to keep the media file whole instead of splitting it. In that case, segments are specified with byte ranges. We introduce a new '-hls_flags' option for the hlsenc muxer, with a single flag for the time being, 'single_file'. --- doc/muxers.texi | 23 ++

[FFmpeg-devel] [PATCH 6/7] avformat/hlsenc: add a flag disabling the filename in segment names

2014-07-18 Thread Nicolas Martyanoff
The default way to name segment is to use the name of the media file, with an optional prefix (-hls_base_url). However in applications where the URL used to fetch segments does not contain the name of the file, it is useful to have the ability not to include the filename in segment names. Of cour

[FFmpeg-devel] [PATCH 7/7] avformat/hlsenc: add an option to set the media filename

2014-07-18 Thread Nicolas Martyanoff
Works with or without the 'single_file' HLS flag. --- doc/muxers.texi | 11 +++ libavformat/hlsenc.c | 31 ++- 2 files changed, 29 insertions(+), 13 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index b97775b..63a0fdf 100644 --- a/doc/muxers.

[FFmpeg-devel] [PATCH 4/7] avformat/hlsenc: do not regenerate the playlist for each segment

2014-07-18 Thread Nicolas Martyanoff
Since we need all segments to find out the target duration, we can only generate the playlist after writing all segments. There is no need to rewrite the segment list every time we create a new segment file. --- libavformat/hlsenc.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-

[FFmpeg-devel] [PATCH 3/7] avformat/hlsenc: fix segmentation issues

2014-07-18 Thread Nicolas Martyanoff
- Select a reference stream (the first video stream, or the first audio stream if there is no video stream) instead of using the PTS of any video stream. - Control the segment length using the time since the last segment. --- libavformat/hlsenc.c | 165 +++-

[FFmpeg-devel] [PATCH 2/7] avformat/hlsenc: make the code easier to read

2014-07-18 Thread Nicolas Martyanoff
Before adding new features, I read the code and cleaned it. The main issue was abstruse identifier names. The behaviour of the muxer is *not* modified, by this patch, this is only cosmetic. If this is not the case, it is a mistake. --- libavformat/hlsenc.c | 360 ++

[FFmpeg-devel] [PATCH 1/7] avformat/hlsenc: correctly compute target duration

2014-07-18 Thread Nicolas Martyanoff
With HLS, the duration of all segments must be lower or equal to the target duration. Therefore floor(duration + 0.5) yields incorrect results. For example, for duration = 1.35, floor(duration + 0.5) yields 1.0, but the correct result is 2.0. --- libavformat/hlsenc.c | 2 +- 1 file changed, 1 ins

Re: [FFmpeg-devel] avformat/hlsenc: pull request for single file mode

2014-07-18 Thread Nicolas Martyanoff
The FFmpeg developer info page said it was fine to use github instead of mailing patches, but if you prefer, I can mail them. -- Nicolas Martyanoff http://wandrian.net khae...@gmail.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http

Re: [FFmpeg-devel] avformat/hlsenc: pull request for single file mode

2014-07-18 Thread Nicolas Martyanoff
Hi, Any chance someone could take a look to these patches ? -- Nicolas Martyanoff http://wandrian.net khae...@gmail.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] avformat/hlsenc: pull request for single file mode

2014-07-11 Thread Nicolas Martyanoff
I updated my pull request, taking the comments of Anssi Hannula into account, and splitting patches as much as possible. Contact me if there is any trouble. -- Nicolas Martyanoff http://wandrian.net khae...@gmail.com ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] avformat/hlsenc: pull request for single file mode

2014-07-10 Thread Nicolas Martyanoff
On 2014-07-10 03:36, Anssi Hannula wrote: > 10.07.2014 02:40, Nicolas Martyanoff kirjoitti: > > On 2014-07-10 01:32, Anssi Hannula wrote: > >> avformat/hlsenc: cleaning > >> - looks good to me, and there is no maintainer so I guess this is OK > >> - well, act

Re: [FFmpeg-devel] avformat/hlsenc: pull request for single file mode

2014-07-09 Thread Nicolas Martyanoff
ting hls_media_url and > hls_base_url? I do not know. On the one hand, it seems redundant to have two different options to specify the same thing, i.e. the URL used for segments. On the other hand, with (HLS_SINGLE_FILE | HLS_NO_FILENAME), there is no "base URL", only a "normal"

Re: [FFmpeg-devel] understanding usage of av_compare_ts() in avformat/hlsenc

2014-07-09 Thread Nicolas Martyanoff
On 2014-07-10 01:41, Anssi Hannula wrote: > 08.07.2014 13:19, Nicolas Martyanoff kirjoitti: > > Hi, > > Hi, > > > I am currently working on improving the hlsenc muxer to support byteranges > > (HLS version 4), and it is starting to work :) But there is a line t

Re: [FFmpeg-devel] avformat/hlsenc: pull request for single file mode

2014-07-09 Thread Nicolas Martyanoff
I added a new patch to the pull request, introducing a '-hls_media_filename' option to provide a filename (in single file mode) or a filename pattern (in default mode). https://github.com/galdor/FFmpeg/commit/cd45075eed0444ae0fd2410a8784bc472b315341 -- Nicolas Martyanoff http://wa

Re: [FFmpeg-devel] avformat/hlsenc: pull request for single file mode

2014-07-09 Thread Nicolas Martyanoff
I added a new patch to the pull request, introducing a flag to disable filenames in segment names: https://github.com/galdor/FFmpeg/commit/246bccaee75aea8ae5a46145bb38ff8071e5f6ef -- Nicolas Martyanoff http://wandrian.net khae...@gmail.com ___ ffmpeg

Re: [FFmpeg-devel] avformat/hlsenc: pull request for single file mode

2014-07-09 Thread Nicolas Martyanoff
On 2014-07-09 10:09, Carl Eugen Hoyos wrote: > Nicolas Martyanoff gmail.com> writes: > > > default subtitles format > > This patch is not ok (just reencode a random file > with subtitles to find out) You are right, you cannot just transcode a dvdsub stream into a web

[FFmpeg-devel] avformat/hlsenc: pull request for single file mode

2014-07-09 Thread Nicolas Martyanoff
for my job, and the company I work for officially authorizeded me to contribute to FFmpeg under the terms of its license. Regards, -- Nicolas Martyanoff http://wandrian.net khae...@gmail.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http