From: Niklesh
Generate the default style for movtext from the ASS style. Earlier, we used a
fixed default style.
Signed-off-by: Niklesh
---
libavcodec/movtextenc.c | 110
1 file changed, 82 insertions(+), 28 deletions(-)
diff --git a/libavcode
From: Niklesh
The value of wrap_flag in the Text Wrap Box specifies if the text is to be
wrapped or not.
Uses 'end of line wrap' amongst the wrap styles supported by ASS if the text is
to be wrapped, i.e; fill as much text in a line as possible, then break to next
line.
The 3GPP spec has no pr
From: Niklesh
As suggested, posting the combined patch with the fate changes.
The patch sets the default style in ASS from the default style information
present in the movtext header.
Signed-off-by: Niklesh
---
libavcodec/movtextdec.c | 82 +---
t
On Wed, Aug 12, 2015 at 3:24 PM, Carl Eugen Hoyos wrote:
> Niklesh Lalwani iitb.ac.in> writes:
>
> > The default style is set in the previous patch from
> > the information present in movtext header. This
> > changes the results of some fate tests.
>
> The f
From: Niklesh
The default style is set in the previous patch from the information present in
movtext header. This changes the results of some fate tests.
Signed-off-by: Niklesh
---
tests/ref/fate/sub-movtext | 2 +-
tests/ref/fate/sub-subripenc | 10 +-
2 files changed, 6 insertion
From: Niklesh
This is the updated patch to set the default style in ASS from the default
style information present in the movtext header.
Signed-off-by: Niklesh
---
libavcodec/movtextdec.c | 82 ++---
1 file changed, 78 insertions(+), 4 deletions(-)
>
> > +
> > +typedef struct {
> > +char *font;
> > +int fontsize;
> > +int color;
> > +int back_color;
> > +int bold;
> > +int italic;
> > +int underline;
> > +int alignment;
> > +} Movtext_default;
> > +
>
> This name is inconsistent. Use MovTextDefault.
>
Yes, mak
From: Niklesh
Sets the default style in ASS from the default style information present in
movtext header
Signed-off-by: Niklesh
---
libavcodec/movtextdec.c | 82 ++---
1 file changed, 78 insertions(+), 4 deletions(-)
diff --git a/libavcodec/movtext
From: Niklesh
Initialize m->count_f to 0 at the correct place to free memory allocs properly.
Signed-off-by: Niklesh
---
libavcodec/movtextdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c
index 83b0231..fc6993e 100644
iklesh Lalwani wrote:
> > Changes incorporated.
> > Updated patch attached.
> >
> > Thanks,
> > Niklesh
> >
> > On Thu, Aug 6, 2015 at 7:51 AM, Philip Langdale
> wrote:
> >
> > > On Thu, 6 Aug 2015 07:13:07 +0530
> > > Niklesh La
Changes incorporated.
Updated patch attached.
Thanks,
Niklesh
On Thu, Aug 6, 2015 at 7:51 AM, Philip Langdale wrote:
> On Thu, 6 Aug 2015 07:13:07 +0530
> Niklesh Lalwani wrote:
>
> > On Thu, Aug 6, 2015 at 2:02 AM, Philip Langdale
> > wrote:
> >
> > &g
On Thu, Aug 6, 2015 at 2:02 AM, Philip Langdale wrote:
> On Thu, 6 Aug 2015 00:12:07 +0530
> Niklesh Lalwani wrote:
>
> > From 90f466bb6a5d3cd24d7ea4d9fd8a2915cc68cdb2 Mon Sep 17 00:00:00 2001
> > From: Niklesh
> > Date: Thu, 6 Aug 2015 00:06:15 +0530
> > S
> I didn't mean this - it's ok for the value to be 0, but it's
> not ok for it to be some huge number that will cause you to
> read beyond the end of the buffer. So like you did for the other
> variable length fields, you need to sanity check this against the total
> packet size.
>
> > +t3xg_pt
Updated patch.
Thanks,
Niklesh
On Tue, Aug 4, 2015 at 8:58 AM, Philip Langdale wrote:
> On Fri, 31 Jul 2015 19:25:58 +0530
> Niklesh Lalwani wrote:
>
> > From: Niklesh
> >
> > The font names are extracted from the font table, present in text
> > sample
From: Niklesh
The font names are extracted from the font table, present in text sample entry.
More than one fonts can be present, which is taken care of in the patch.
Signed-off-by: Niklesh
---
libavcodec/movtextdec.c | 86 +++--
1 file changed, 83
From: Niklesh
Add support for fontsize in style records. The patch uses reset to directly
change back to default style instead of using closing tags, since we are not
handling the default styles right now.
Signed-off-by: Niklesh
---
libavcodec/movtextdec.c | 14 ++
1 file changed
From: Niklesh
This patch takes care of the secondary color changes in ASS through highlight
and hilightcolor boxes.
Signed-off-by: Niklesh
---
libavcodec/movtextenc.c | 60 +
1 file changed, 60 insertions(+)
diff --git a/libavcodec/movtextenc.
From: Niklesh
This patch reorganizes the code to make it easier to add support for different
text modifier boxes and other styles in the future.
Signed-off-by: Niklesh
---
libavcodec/movtextenc.c | 104 ++--
1 file changed, 65 insertions(+), 39 dele
On Mon, Jul 20, 2015 at 4:29 PM, Carl Eugen Hoyos wrote:
> Niklesh Lalwani iitb.ac.in> writes:
>
> > This patch adds support for secondary color changes
> > through highlight and hilightcolor box. The code is
> > also reorganised to make it easier to read and maintai
From: Niklesh
This patch adds support for secondary color changes through highlight and
hilightcolor box.
The code is also reorganised to make it easier to read and maintain.
Signed-off-by: Niklesh
---
libavcodec/movtextenc.c | 164
1 file chan
From: Niklesh
Signed-off-by: Niklesh
---
libavcodec/movtextdec.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c
index d564cf1..ca02107 100644
--- a/libavcodec/movtextdec.c
+++ b/libavcodec/movtextdec.c
@@ -181,14 +181,
On Sun, Jul 12, 2015 at 1:05 PM, Clément Bœsch wrote:
> On Tue, Jul 07, 2015 at 08:33:12PM +0530, Niklesh Lalwani wrote:
> [...]
> > > > +struct Box
> > > > +{
> > >
> > > style
> > >
> >
> > What about this?
> >
>
Updated patch attached. As Philip said, this was not a simple re-indent, so
indentation included.
Thanks,
Niklesh
From 7dff4a52e41fabe4748076e152cf600d426a5ee8 Mon Sep 17 00:00:00 2001
From: Niklesh
Date: Sun, 12 Jul 2015 12:44:48 +0530
Subject: [PATCH] movtextdec.c: Add support for highlight an
On Tue, Jul 7, 2015 at 3:12 AM, Clément Bœsch wrote:
> On Mon, Jul 06, 2015 at 10:27:47PM +0530, Niklesh Lalwani wrote:
> > From: Niklesh
> >
> > Signed-off-by: Niklesh
> > ---
> > libavcodec/movtextdec.c | 254
> +
From: Niklesh
Signed-off-by: Niklesh
---
libavcodec/movtextdec.c | 254 +---
1 file changed, 173 insertions(+), 81 deletions(-)
diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c
index a3afd91..7e9e4f5 100644
--- a/libavcodec/movtextdec.c
From: Niklesh
This patch adds support for decoding of Highlight and hilightcolor box as
defined by 3GPP standards.
The code is also reorganised to make it easier to maintain and read. Separate
functions are defined that process each type of box.
Signed-off-by: Niklesh
---
libavcodec/movtextd
Figured it out. Valgrind was pretty helpful.
Thanks again.
-Niklesh
On Sat, Jul 4, 2015 at 12:40 AM, Niklesh Lalwani
wrote:
> Thanks guys, I'll try it out.
>
> -Niklesh
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://f
Thanks guys, I'll try it out.
-Niklesh
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Hello everyone,
I am working with movtextdec.c to implement support for various Text
Modifier Boxes. I am getting a segmentation fault with m->style_temp =
av_malloc() and I cannot figure out why. I tried to play around with
several things to find out the reason, but in vain. Must be something
pre
On 27-Jun-2015 12:36 AM, "Philip Langdale" wrote:
>
> On 2015-06-26 09:48, Niklesh Lalwani wrote:
>>
>> The output produced here was actually different from the expected. Hence
>> the test failed. I produced ASS file for both the original file and the
>>
s no style information associated here as far as I can see.
Please correct me if I'm going wrong here.
Thanks,
Niklesh
On Tue, 23 Jun 2015 22:09:20 +0200
Michael Niedermayer wrote:
> On Wed, Jun 24, 2015 at 01:25:53AM +0530, Niklesh Lalwani wrote:
> > Updated patch.
> > Compile
On 26-Jun-2015 12:29 AM, "Michael Niedermayer" wrote:
>
> On Fri, Jun 26, 2015 at 12:16:10AM +0530, Niklesh Lalwani wrote:
> > Hi all,
> >
> > I am having trouble in running single fate tests. I want to perform the
> > test binsub-movtextenc. I am usi
Hi all,
I am having trouble in running single fate tests. I want to perform the
test binsub-movtextenc and I am using the following command- make
fate-binsub-movtextenc FATE=/home/niklesh/FFmpeg/fate-suite . The target
file MovText_capability_tester.mp4 is located in
/home/niklesh/FFmpeg/fate-sui
Hi all,
I am having trouble in running single fate tests. I want to perform the
test binsub-movtextenc. I am using the following command- make
fate-binsub-movtextenc FATE = /home/niklesh/FFmpeg/fate-suite/ and the
target file MovText_capability_tester.mp4 is located in
/home/niklesh/FFmpeg/fate-s
Updated patch.
Compiles without any warnings. Tested too.
Thanks,
Niklesh
On Tue, Jun 23, 2015 at 9:42 PM, Niklesh Lalwani wrote:
>
> On 23-Jun-2015 8:41 PM, "Philip Langdale" wrote:
> >
> > On Tue, 23 Jun 2015 16:54:08 +0200
> > wm4 wrote:
> >
&
On 23-Jun-2015 8:41 PM, "Philip Langdale" wrote:
>
> On Tue, 23 Jun 2015 16:54:08 +0200
> wm4 wrote:
>
> > In my opinion these warnings should either be silenced, or an
> > av_bprint function taking void* should be added and used. While the
> > warning is indeed a false positive here, they can ob
On 6/23/15, Philip Langdale wrote:
> I got a bunch of warnings when I compiled it. Please fix.
>
> Thanks.
>
> --
>
> CC libavcodec/movtextenc.o
> libavcodec/movtextenc.c: In function ‘mov_text_style_cb’:
> libavcodec/movtextenc.c:124:17: war
Updated patch.
Thanks,
Niklesh
0002-movtextenc.c-Support-for-Bold-Italic-and-Underlined-.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Updated patch.
Thanks,
Niklesh
0001-movtextdec.c-Improve-upon-dynarrays-and-text_to_ass.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Updated patch attached.
On 18-Jun-2015 2:52 PM, "Clément Bœsch" wrote:
av_dynarray_add(&style_flags, &index, flag);
> > +s_temp->style_flag = AV_RB8(tsmb);
> > +count = i;
>
> > +av_dynarray_add(&s, &count, s_temp);
>
> missing check
>
>
Updated patch.
Thanks,
Niklesh
movtextenc.c-Support-for-Bold-Italic-and-Underlined-.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
un-2015 2:35 PM, "Clément Bœsch" wrote:
> On Wed, Jun 17, 2015 at 08:43:26PM +0530, Niklesh Lalwani wrote:
> > From: Niklesh
> >
> > Support for Bold, Italic and Underlined styles. The style information is
> appended into the buffer after the text. Dynarray is used t
From: Niklesh
Support for Bold, Italic and Underlined styles. The style information is
appended into the buffer after the text. Dynarray is used to account for
multiple style records. Tested on QuickTime OSX and iPhone.
Signed-off-by: Niklesh
---
libavcodec/movtextenc.c | 165
From: Niklesh
This Patch uses a single dynarray instead of 3 dynarrays used before. Changes
are also done in text_to_ass() which previously failed to produce correct
results for a few specific cases.
Signed-off-by: Niklesh
---
libavcodec/movtextdec.c | 83 -
Yes, the patch is for single style record only. I'll work on multiple
style records now.
Thanks,
Niklesh
On 6/12/15, Philip Langdale wrote:
> On Thu, 11 Jun 2015 10:18:53 +0530
> Niklesh Lalwani wrote:
>
>> From: Niklesh
>>
>> Encoding of bold, Italic, under
Ok so it goes like this.
We first find out the height and width of the video stream from the header
box. The dimensions of the text track (subtitle track) is then set (in
pixels). Here, we have used the width equal to the width of the video, and
height equal to 1/10 of the video height.
The write
Tested on iPhone too. You might need to enable the subtitles first.
Thanks,
Niklesh
On 11-Jun-2015 2:22 PM, "Carl Eugen Hoyos" wrote:
> Niklesh Lalwani iitb.ac.in> writes:
>
> > Tested on QuickTime 10.3 on OSX
>
> Did you also test on an
Tested on QuickTime 10.3 on OSX, and VLC. For some reason, it doesn't work
on Quicktime Windows, I can't figure out why.
Thanks,
Niklesh
On Thu, Jun 11, 2015 at 10:18 AM, Niklesh Lalwani <
niklesh.lalw...@iitb.ac.in> wrote:
> From: Niklesh
>
> Encoding of bold, Ital
From: Niklesh
Encoding of bold, Italic, underlined styles for 3gpp timed text subtitles. All
the formatting information is appended into the buffer after the text, unlike
other encoders like srt, which can write out styling information as it goes.
Another tricky part is to take care of the End
From: Niklesh
This patch mostly replicates the concept patch posted by Philip
https://ffmpeg.org/pipermail/ffmpeg-devel/2013-March/140299.html. This sets the
proper dimensions for the subtitle tracks, by making use of the height and
width of the video stream. The patch is exlained in detail in
On 27-May-2015 9:38 PM, "Clément Bœsch" wrote:
>
> Unless I'm mistaken, my understanding is that srt_style_apply() honors the
> global style of the dialog. Typically in ASS, each dialogue has is
> associated with a style (generally "Default" but can be another one
> defined in the header), so thes
Hi everyone,
I was trying to understand how to encode the style descriptors for mov text
subtitles. Currently, I am looking at srtenc.c.
I see that srt_style_cb() handles the callbacks for styling information,
but then what does srt_style_apply() do? I am confused at several other
steps too.
Can s
Updated.
Thanks,
Niklesh
From 00647a47883b0b547da77d3101f3f890634a85b4 Mon Sep 17 00:00:00 2001
From: Niklesh
Date: Mon, 25 May 2015 22:46:04 +0530
Subject: [PATCH] Improve upon dynamic arrays- movtext subtitles
Signed-off-by: Niklesh
---
libavcodec/movtextdec.c | 34 ++---
Updated Patch.
Thanks,
Niklesh
On Mon, May 25, 2015 at 9:10 PM, Philip Langdale wrote:
> On Mon, 25 May 2015 00:37:03 +0530
> Niklesh Lalwani wrote:
>
> > From: Niklesh
> >
> > Signed-off-by: Niklesh
> > ---
> > libavcodec/movtextdec.c | 32 +
From: Niklesh
Signed-off-by: Niklesh
---
libavcodec/movtextdec.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c
index 04e1c8a..11934f9 100644
--- a/libavcodec/movtextdec.c
+++ b/libavcodec/
From: Niklesh
Using char** for style_start and style_end, and using uint8_t** for
style_entries. This seems to be the least messy way.
Signed-off-by: Niklesh
---
libavcodec/movtextdec.c | 29 +
1 file changed, 13 insertions(+), 16 deletions(-)
diff --git a/libavcod
Updated patch.
Thanks,
Niklesh
3gpp-largeboxes-21may.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Yes, that would be good. Thanks.
-Niklesh
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Do you mean using a variable equal to tracksize + 10/18? That wouldn't be
of much use imo.
-Niklesh
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
From: Niklesh
Signed-off-by: Niklesh
---
libavcodec/movtextdec.c | 20 +---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c
index 53ffef0..6ff02b3 100644
--- a/libavcodec/movtextdec.c
+++ b/libavcodec/movtextdec.c
Thanks. I'll do it separately for style entries.
-Niklesh
On 20-May-2015 11:41 PM, "Philip Langdale" wrote:
> On 2015-05-20 11:06, Niklesh Lalwani wrote:
>
>> I have done tracksize += 8 if there is a large box. This should account
>> for
>> it?
>>
I have done tracksize += 8 if there is a large box. This should account for
it?
On 20-May-2015 11:17 PM, "Philip Langdale" wrote:
> On 2015-05-20 07:40, Niklesh Lalwani wrote:
>
>> From: Niklesh
>>
>> This patch is to be applied over the previous patch to fix m
From: Niklesh
This patch is to be applied over the previous patch to fix movtext crashes
(which is yet to be committed)
Signed-off-by: Niklesh
---
libavcodec/movtextdec.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/libavcodec/movtextdec.c b/libavcodec/movtex
Thanks Philip. Updated.
-Niklesh
3gpp-fix-crashes-19may.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Updated patch.
-Niklesh
fix-movtext-crashes.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Oh yes. I'll correct that. Thank you.
Niklesh.
On 17-May-2015 10:40 PM, "Philip Langdale" wrote:
> On Mon, 27 Apr 2015 04:53:26 +0530
> Niklesh Lalwani wrote:
>
> > From: Niklesh
> >
> > Signed-off-by: Niklesh
> > ---
> > libavc
Just to be clear, I need to check for avpkt->size after reading box size,
box type, style entries because there can be bad packets, otherwise the
condition should work, right?
Yes, I'll add the support for large boxes after this. I have it in my
timeline.
Thanks,
Niklesh
From: Niklesh
Hi all,
This patch fixes some movtext crashes caused due to incorrect 'while' loop
condition. I will post several other patches to improve upon the code and null
pointer dereferences once this is applied.
Signed-off-by: Niklesh
---
libavcodec/movtextdec.c | 8 +---
1 file c
I can post them as
separate patches too. However, av_dynarray_add() used in the patch seems to
be tricky and hacky as pointed out by others. So, I'll post the separate
patches once we agree on a better alternative. I hope that is not a problem.
--
Niklesh Lalwani
Third
To use
size_t* in place to int** I had to reinterpret-cast an int to a pointer. As
someone else suggested, av_dynarray2_add() can be a better option.
--
Niklesh Lalwani
Third Year Undergraduate
Electrical Engineering
IIT Bombay
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
array functions are really a mess...)
> ___
>
> I can try av_dynarray2_add(). Which one of these three do you think will
be a better choice?
--
Niklesh Lalwani
Third Year Undergraduate
Electrical Engineering
IIT Bombay
___
ffmpeg-devel
This patch should apply properly. This contains both the patches- support
for large boxes, and using size_t for dynarrays.
I found out that the earlier patches was created against a branch which had
a single line different from the master. Hence, the patch didn't apply. My
bad. Apologies for the in
From: Niklesh
Signed-off-by: Niklesh
---
libavcodec/movtextdec.c | 54 +
1 file changed, 28 insertions(+), 26 deletions(-)
diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c
index 3059599..b134ac5 100644
--- a/libavcodec/movtextdec.c
On Mon, Apr 27, 2015 at 7:10 AM, Michael Niedermayer
>> wrote:
>>
>> > From: Niklesh
>> >
>> > Signed-off-by: Niklesh
>> > ---
>> > libavcodec/movtextdec.c | 45
>> -
>> > 1 file changed, 20 insertions(+), 25 deletions(-)
>> this doesnt apply cleanly
From: Niklesh
Signed-off-by: Niklesh
---
libavcodec/movtextdec.c | 45 -
1 file changed, 20 insertions(+), 25 deletions(-)
diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c
index a5d995d..ad1d324 100644
--- a/libavcodec/movtextdec.c
+++
From: Niklesh
Signed-off-by: Niklesh
---
libavcodec/movtextdec.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c
index ab4efdb..a5d995d 100644
--- a/libavcodec/movtextdec.c
+++ b/libavcodec/movtextdec.c
@@ -96,7 +96,9
On 26-Apr-2015 4:00 PM, "wm4" wrote:
>
>
> We usually write: text_style[i].face_style_flags
>
> It's the same.
Got it. Thank you. :)
-Niklesh
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On 26-Apr-2015 10:46 AM, "Philip Langdale" wrote:
>
> On Sun, 26 Apr 2015 05:04:07 +0200
> Michael Niedermayer wrote:
>
> > On Sun, Apr 26, 2015 at 08:22:56AM +0530, Niklesh Lalwani wrote:
> > > On Sun, Apr 26, 2015 at 6:56 AM, Mic
>
>
>
> On Sun, Apr 26, 2015 at 7:05 AM, Carl Eugen Hoyos
> wrote:
>
> Niklesh Lalwani iitb.ac.in> writes:
>
>
>> > +if ((text_style + i)->face_style_flags
>
>
>> This looks very strange imo...
>
>
What's
On Sun, Apr 26, 2015 at 6:56 AM, Michael Niedermayer
> wrote:
>
>>
>> > +struct __attribute__((__packed__)) StyleRecord {
>
>
>> you cant do this
>
> attribute packed is not ANSI/ISO C
>
>
>> How do I implement packed structures then here? ( since I don't want
padding for proper alignment with the
From: Niklesh
This patch uses struct for the Style Records. The pointer to this struct is
updated to point to the start of style records in the TextStyleModifierBox.
However, in doing this, I get a warning for incompatible pointer type
assignment. How to get over this? The patch gives proper o
From: Niklesh
Updated Patch. This patch stores indices in style_start and style_end rather
than addresses. Also corrected a bug while using av_dyarray_add() which went
unnoticed for the particular test samples used.
Signed-off-by: Niklesh
---
libavcodec/movtextdec.c | 97 +
Hi,
I am really sorry for replying late. I was stuck up with my end semester
examinations. Anyways, I was working on implementing structs and passing
style_start and style_end as indices rather than addresses, but with no
proper results till now. Here is my previous patch improved with C code
stand
Thank you for your suggestions.
I'll try to do as much as I can before the deadline.
-Niklesh
On Wed, Apr 22, 2015 at 10:57 PM, Philip Langdale wrote:
> On 2015-04-22 03:10, Niklesh Lalwani wrote:
>
>> From: Niklesh
>>
>> This patch supports decoding of Bold,
From: Niklesh
Updated patch for decoding of Bold-Italic-Underlined style records for 3gpp
timed text. Fixed several build warnings.
Signed-off-by: Niklesh
---
libavcodec/movtextdec.c | 91 +
1 file changed, 85 insertions(+), 6 deletions(-)
diff
From: Niklesh
This patch supports decoding of Bold, Italic, Underlined styles for 3gpp timed
text. While the code can be improved upon to make it more clean and well
structured, this works for now, even for multiple style records. Suggestions
awaited.
Signed-off-by: Niklesh
---
libavcodec/mo
From: Niklesh
This patch attempts to use dynamic arrays to support multiple style records.
However, I am unable to get proper output with using av_dynamic_array(). It
seems I am not using this function properly. Can anyone explain?
Signed-off-by: Niklesh
---
libavcodec/movtextdec.c | 65 +
From: Niklesh
This patch is a part of my qualification task to implement support for Bold,
Italic, and Underlined style records for 3GPP timed text subtitles. I am
continuing Wesley's work. This patch supports decoding of no more than one
style record. Patch[2/2] attempts to use dynamic arrays
Apologies. I'll do that.
I am relatively new to git, and hence wasn't able to send as you had asked.
Thanks
Niklesh
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Hi Everyone,
This is the fix for issue #2622 <https://trac.ffmpeg.org/ticket/2622>.
These changes enables to remux m2ts file so that the new file has playable
subtitles.
Thanks,
Niklesh Lalwani
---
libavformat/mpegts.h| 2 ++
libavformat/mpegtsenc.c | 3 +++
2 files changed, 5 inse
wn, which is maybe due to
missing description for HDMV_PGS_SUBTITLE under case AVMEDIA_TYPE_SUBTITLE
in mpegtsenc.c. Can anyone explain what is going on with the descriptor
handing?
Thanks
Niklesh Lalwani
___
ffmpeg-devel mailing list
ffmpeg-devel@ffm
91 matches
Mail list logo
