Re: [FFmpeg-devel] [PATCH] ffmpeg.c: fix calculation of input file duration in seek_to_start()

2017-11-04 Thread Peter Große
On Sun, 29 Oct 2017 21:45:04 +0100 Peter Große wrote: > On Sun, 29 Oct 2017 21:33:10 +0100 > Michael Niedermayer wrote: > > > seems this doesnt apply > > > > Yeah, it depends on the patch I started the thread with. > > I can swap the order of the two

Re: [FFmpeg-devel] [PATCH] ffmpeg.c: fix calculation of input file duration in seek_to_start()

2017-10-29 Thread Peter Große
On Sun, 29 Oct 2017 21:33:10 +0100 Michael Niedermayer wrote: > seems this doesnt apply > Yeah, it depends on the patch I started the thread with. I can swap the order of the two patches if you want, so that the style fix can go in first. But they will depend on each other either way, since th

[FFmpeg-devel] [PATCH v2 3/7] dashenc: set DASH related options for the subsequent matroska muxer when using webm

2017-10-29 Thread Peter Große
This patch is inspired by the ffmpeg webm_chunk muxer and fixes that all resulting tracks have the same track number. Signed-off-by: Peter Große --- v2: extended commit message libavformat/dashenc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/dashenc.c b/libavformat

[FFmpeg-devel] [PATCH v2 6/7] dashenc: Don't output frameRates at both AS and Representation-level. Only output maxFrameRate at AS-level.

2017-10-29 Thread Peter Große
From: Anton Schubert Fix conformance regarding section "3.2.4. Presence of Attributes and Element" of the "Guidelines for Implementation: DASH-IF Interoperability Points V4.1" (http://dashif.org/guidelines/) Signed-off-by: Anton Schubert Signed-off-by: Peter Große ---

[FFmpeg-devel] [PATCH v2 1/7] dashenc: fix bitrate estimation with correct scaling

2017-10-29 Thread Peter Große
From: Anton Schubert Signed-off-by: Anton Schubert Signed-off-by: Peter Große --- v2: Fixed double rescaling. libavformat/dashenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 04b0fd99e6..e25a660fbe 100644 --- a

Re: [FFmpeg-devel] [PATCH] ffmpeg.c: fix calculation of input file duration in seek_to_start()

2017-10-29 Thread Peter Große
On Sun, 29 Oct 2017 14:56:20 +0100 Moritz Barsnick wrote: > On Sun, Oct 29, 2017 at 12:08:05 +0100, Peter Große wrote: > > } else duration = 1; > > For style/readability, the statement should be on a new line, perhaps > even with brackets. (Not necessarily as

[FFmpeg-devel] [PATCH] libavformat/mov.c: use calculated dts offset when seeking in streams

2017-10-29 Thread Peter Große
mps. Then, av_index_search_timestamp() returns a valid negative timestamp, but mov_seek_stream bails out with AVERROR_INVALIDDATA. Fixes ticket #6139. Signed-off-by: Jonas Licht Signed-off-by: Peter Große --- Compared to the other seek results in this test, the values are not that far off. libavformat/mov.c

[FFmpeg-devel] [PATCH] ffmpeg.c: fix calculation of input file duration in seek_to_start()

2017-10-29 Thread Peter Große
Fixes looping files without audio or when using stream_copy, where ist->nb_samples is not set since no decoding is done. This fixes ticket #5719 and also fixes an endless loop with the sample in ticket #6139. Signed-off-by: Peter Große --- fftools/ffmpeg.c | 4 ++-- 1 file changed

[FFmpeg-devel] DASH manifest conformance (was: Re: [PATCH 0/7] dashenc fixes)

2017-10-27 Thread Peter Große
On Thu, 26 Oct 2017 18:32:57 +0200 Carl Eugen Hoyos wrote: > 2017-10-26 18:28 GMT+02:00 Peter Große : > > On Thu, 26 Oct 2017 18:07:55 +0200 > > Carl Eugen Hoyos wrote: > > > >> Did you test our dash muxer lately with some validation tool? > >> Errors

[FFmpeg-devel] [PATCH 1/1] libavformat/mov.c: use calculated dts offset when seeking in streams

2017-10-26 Thread Peter Große
From: Jonas Licht Subtract the calculated dts offset from the requested timestamp before seeking. This fixes an error "Error while filtering: Operation not permitted" observed with a short file which contains only one key frame and starts with negative timestamps. Then, av_index_search_timestamp

Re: [FFmpeg-devel] [PATCH 0/7] dashenc fixes

2017-10-26 Thread Peter Große
On Thu, 26 Oct 2017 18:07:55 +0200 Carl Eugen Hoyos wrote: > Did you test our dash muxer lately with some validation tool? > Errors were reported in the past. No official validation tool, no. I tried to get remuxing working with a pre-encoded multi-bitrate mkv file, but the official reference p

[FFmpeg-devel] [PATCH 5/7] dashenc: allow AdaptationSets to have different average frame rates

2017-10-26 Thread Peter Große
Signed-off-by: Peter Große --- libavformat/dashenc.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index c09b22bf7b..f3a12462be 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -55,6 +55,8

[FFmpeg-devel] [PATCH 6/7] dashenc: Don't output frameRates at both AS and Representation-level. Only output maxFrameRate at AS-level.

2017-10-26 Thread Peter Große
From: Anton Schubert Signed-off-by: Anton Schubert --- libavformat/dashenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index f3a12462be..b12a37a2e5 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -393,

[FFmpeg-devel] [PATCH 7/7] dashenc: copy stream frame rate to output stream

2017-10-26 Thread Peter Große
Leads to setting of DefaultDuration in Matroska muxer based on frame rate instead of timebase. Fixes playback in Chrome. Signed-off-by: Peter Große --- libavformat/dashenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index b12a37a2e5

[FFmpeg-devel] [PATCH 4/7] dashenc: don't write header data before the first packet arrives

2017-10-26 Thread Peter Große
Fixes: 1b8ef01f04ab ("dashenc: add webm support") Signed-off-by: Peter Große --- libavformat/dashenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index bde093646f..c09b22bf7b 100644 --- a/libavformat/dashe

[FFmpeg-devel] [PATCH 3/7] dashenc: set DASH related options for the subsequent matroska muxer when using webm

2017-10-26 Thread Peter Große
Signed-off-by: Peter Große --- libavformat/dashenc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 1b3acb7ac9..bde093646f 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -776,6 +776,9 @@ static int dash_init

[FFmpeg-devel] [PATCH 5/7] dashenc: allow AdaptaionSets to have different average frame rates

2017-10-26 Thread Peter Große
Signed-off-by: Peter Große --- libavformat/dashenc.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index c09b22bf7b..f3a12462be 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -55,6 +55,8

[FFmpeg-devel] [PATCH 1/7] dashenc: fix bitrate estimation with correct scaling

2017-10-26 Thread Peter Große
From: Anton Schubert Signed-off-by: Anton Schubert --- libavformat/dashenc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 240ff41380..a4b37403d6 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -953,

[FFmpeg-devel] [PATCH 2/7] dashenc: use av_dict_set_int instead of static function

2017-10-26 Thread Peter Große
Signed-off-by: Peter Große --- libavformat/dashenc.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index a4b37403d6..1b3acb7ac9 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -664,14 +664,6

[FFmpeg-devel] [PATCH 0/7] dashenc fixes

2017-10-26 Thread Peter Große
Some DASH muxer fixes after commits from libav got merged. Anton Schubert (2): dashenc: fix bitrate estimation with correct scaling dashenc: Don't output frameRates at both AS and Representation-level. Only output maxFrameRate at AS-level. Peter Große (5): dashenc: use av_dict_se

[FFmpeg-devel] [PATCH v2] fate: add vf_overlay test for main source with alpha channel

2017-07-20 Thread Peter Große
Signed-off-by: Peter Große --- This depends on patch "lavfi/testsrc2: fix completely transparent alpha." The test fails without the patch "avfilter/vf_overlay: fix alpha blending when main source has an alpha channel". tests/fate/filter-video.mak | 4

Re: [FFmpeg-devel] [PATCH] fate: add vf_overlay test for main source with alpha channel

2017-07-20 Thread Peter Große
On Thu, 20 Jul 2017 17:19:36 +0200 Tobias Rapp wrote: > > When I re-add --disable-optimizations --enable-mmx --disable-stripping to my > > configure command line, the test succeeds. > > > > Any further comments to the patch and test case? > > Maybe try adding -sws_flags +accurate_rnd+bitexact

Re: [FFmpeg-devel] [PATCH] fate: add vf_overlay test for main source with alpha channel

2017-07-20 Thread Peter Große
On Wed, 19 Jul 2017 21:00:49 +0200 Peter Große wrote: > I was able to reproduce your checksums only after removing > > --disable-optimizations --disable-mmx --disable-stripping > > from my configure command. I thought optimizations should have no > impact on the result?!

[FFmpeg-devel] [PATCH] fate: add vf_overlay test for main source with alpha channel

2017-07-19 Thread Peter Große
Signed-off-by: Peter Große --- Updated version of the test. I was able to reproduce your checksums only after removing --disable-optimizations --disable-mmx --disable-stripping from my configure command. I thought optimizations should have no impact on the result?! tests/fate/filter

[FFmpeg-devel] [PATCH] fate: add vf_overlay test for main source with alpha channel

2017-07-18 Thread Peter Große
Signed-off-by: Peter Große --- tests/fate/filter-video.mak | 5 + tests/ref/fate/filter-overlay-main-alpha | 15 +++ 2 files changed, 20 insertions(+) create mode 100644 tests/ref/fate/filter-overlay-main-alpha diff --git a/tests/fate/filter-video.mak b/tests/fate

Re: [FFmpeg-devel] [PATCH] avfilter/vf_overlay: fix alpha blending when main source has an alpha channel

2017-07-16 Thread Peter Große
On Sun, 16 Jul 2017 18:33:33 +0200 Paul B Mahol wrote: > > how can one reproduce this bug? ffmpeg -i fate-suite/mfx/track_01_v02.mxf -filter_complex \ "movie=fate-suite/png1/lena-rgba.png[logo];[v:0][logo]overlay" -an -vframes 1 out.png In this example files from the fate suite are used. The

[FFmpeg-devel] [PATCH] avfilter/vf_overlay: fix alpha blending when main source has an alpha channel

2017-07-15 Thread Peter Große
Use alpha value from alpha channel instead of selected component channel. Signed-off-by: Peter Große --- libavfilter/vf_overlay.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/libavfilter/vf_overlay.c b/libavfilter/vf_overlay.c index 5c9f590957

Re: [FFmpeg-devel] [PATCH 1/8] libavformat/dashenc: use avio_dynbuf instead of packet_write callback

2017-01-22 Thread Peter Große
On Sat, 21 Jan 2017 22:53:56 +0100 Moritz Barsnick wrote: > When adding new code, please stick to "if (" with a space. (Also in > some of your other patches.) >... > Two different ways of doing the same thing. ;-) (Assignment to ret > embedded in the "if"-clause versus before it.) Thanks for poi

[FFmpeg-devel] [PATCH 1/1] libavformat/dashenc: separate segments based on segment duration instead of total duration

2017-01-21 Thread Peter Große
and keyframe 5 (duration=10s >= total_duration=9s) ... Segment 2 is only 2s long, shorter than min_seg_duration = 3s. To fix this, either rename "min_seg_duration" to something more accurate. Or apply this patch to create new segments based on the actual written duration. Sig

[FFmpeg-devel] [PATCH v2 8/8] libavformat/dashenc: add support for assigning streams to AdaptationSets

2017-01-21 Thread Peter Große
andatory, calculate bandwith based on the size and duration of the first segment Signed-off-by: Peter Große --- Changes in v2: * removed changes related to min_seg_duration, since they are unrelated --- libavformat/dashenc.c | 286 +++--- 1 file

[FFmpeg-devel] [PATCH v2 1/1] libavformat/dashenc: add webm support

2017-01-21 Thread Peter Große
Use webm muxer for VP8, VP9 and Opus codec, mp4 muxer otherwise. Signed-off-by: Peter Große --- libavformat/dashenc.c | 46 +++--- 1 file changed, 39 insertions(+), 7 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index bd6bb88

[FFmpeg-devel] [PATCH 1/1] libavformat/dashenc: add webm support

2017-01-21 Thread Peter Große
Use webm muxer for VP8, VP9 and Opus codec, mp4 muxer otherwise. Signed-off-by: Peter Große --- libavformat/dashenc.c | 46 +++--- 1 file changed, 39 insertions(+), 7 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index bd6bb88

[FFmpeg-devel] [PATCH 7/8] libavformat/dashenc: support for hinting stream bandwidth using metadata option

2017-01-21 Thread Peter Große
Bandwidth information is required in the manifest, but not always provided by the demuxer. So enable hinting the stream bandwidth via a metadata field, supports same values as codec bitrate setting. Example: -metadata:s:v:0 bitrate=3500k Signed-off-by: Peter Große --- libavformat/dashenc.c

[FFmpeg-devel] [PATCH 8/8] libavformat/dashenc: add support for assigning streams to AdaptationSets

2017-01-21 Thread Peter Große
ts will be created independently from occurance of video key frames when exceeding given segment duration * Since the "bandwidth" attribute on a Representation is mandatory, calculate bandwith based on the size and duration of the first segment Signed-off

[FFmpeg-devel] [PATCH 5/8] libavformat/dashenc: add option to provide UTC timing source

2017-01-21 Thread Peter Große
If set, adds a UTCTime tag in the manifest. See http://vm2.dashif.org/dash.js/docs/jsdocs/MediaPlayer.html#addUTCTimingSource for more information. Usable default: "https://time.akamai.com/?iso"; Signed-off-by: Peter Große --- libavformat/dashenc.c | 4 1 file changed, 4

[FFmpeg-devel] [PATCH 1/8] libavformat/dashenc: use avio_dynbuf instead of packet_write callback

2017-01-21 Thread Peter Große
The dash_write function drops data, if no IOContext is initialized. This might happen when a subordinate muxer calls avio_flush(). Using a dynamic buffer fixes that. Signed-off-by: Peter Große --- libavformat/dashenc.c | 86 +++ 1 file changed, 53

[FFmpeg-devel] [PATCH 3/8] libavformat/dashenc: add mandatory id attribute to AdaptationSet and Period in manifest

2017-01-21 Thread Peter Große
Signed-off-by: Peter Große --- libavformat/dashenc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 3286c36..7273997 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -457,7 +457,7 @@ static int

[FFmpeg-devel] [PATCH 6/8] libavformat/dashenc: use avformat_alloc_output_context2 for initializing context

2017-01-21 Thread Peter Große
Also copy stream metadata to output stream. Signed-off-by: Peter Große --- libavformat/dashenc.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index fd1a304..0c0248f 100644 --- a/libavformat/dashenc.c +++ b

[FFmpeg-devel] [PATCH RFC 0/8] libavformat/dashenc: improvements to MPEG-DASH muxer

2017-01-21 Thread Peter Große
/PubliclyAvailableStandards/c065274_ISO_IEC_23009-1_2014.zip Anton Schubert (2): libavformat/dashenc: add Z to localtime to force correct UTC parsing libavformat/dashenc: increase buffer time hints in the manifest Peter Große (6): libavformat/dashenc: use avio_dynbuf instead of packet_write callback libavformat

[FFmpeg-devel] [PATCH 4/8] libavformat/dashenc: increase buffer time hints in the manifest

2017-01-21 Thread Peter Große
From: Anton Schubert Signed-off-by: Anton Schubert --- libavformat/dashenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 7273997..054d0c0 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -483,7 +483

[FFmpeg-devel] [PATCH 2/8] libavformat/dashenc: add Z to localtime to force correct UTC parsing

2017-01-21 Thread Peter Große
From: Anton Schubert Signed-off-by: Anton Schubert --- libavformat/dashenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index d0a2ab5..3286c36 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -447,7 +447,7 @