Looks like a nice improvement. It looks like the size of the
codestreams obtained when running `-q: 20` are larger after the patch
-- maybe related to the change in the step size calculation, which is
now the same for both bitexact and non-bit-exact. Is that expected? I
realize `-q` is arbitrary bu
Looks like more files need to be regenerated:
tests/ref/vsynth/vsynth1-jpeg2000-97
tests/ref/vsynth/vsynth2-jpeg2000-97
tests/ref/vsynth/vsynth3-jpeg2000-97
tests/ref/vsynth/vsynth_lena-jpeg2000-97
On Thu, Aug 29, 2024 at 7:07 PM Osamu Watanabe
wrote:
>
> Signed-off-by: Osamu Watanabe
> ---
>
On Thu, Aug 29, 2024 at 1:29 AM Osamu Watanabe
wrote:
>
> The FATE refs are updated to reflect changes in the [PATCH 1/2].
It looks like the fate-j2k-dwt and fate-jpeg2000-dcinema fate files
need to be regenerated as well.
>
> Signed-off-by: Osamu Watanabe
> ---
> tests/ref/fate/jpeg2000dec-p0
> I have confirmed that FFMPEG passes all the test cases without the flag.
>
> The problem has been locally solved with the updated code, however, the patch
> set is not yet ready.
> (It won't take long)
>
> Best,
> Osamu
>
>
> > 2024/08/22 1:01、Pierre-Ant
On Wed, Aug 21, 2024 at 8:54 AM Tomas Härdin wrote:
>
> mån 2024-08-19 klockan 23:03 -0700 skrev p...@sandflow.com:
> > From: Pierre-Anthony Lemieux
> >
> > ---
> > tests/fate/jpeg2000.mak | 129
>
> I presume you've tested that the fram
On Wed, Jun 19, 2024 at 1:42 AM Tomas Härdin wrote:
>
> tis 2024-06-18 klockan 07:59 -0700 skrev Pierre-Anthony Lemieux:
> > On Tue, Jun 18, 2024 at 7:25 AM Tomas Härdin wrote:
> > >
> > > lör 2024-06-15 klockan 21:47 -0700 skrev p...@sandflow.com:
> &
I plan to apply on Friday, after fixing the few errant trailing spaces.
On Tue, Aug 6, 2024 at 8:48 PM Osamu Watanabe
wrote:
>
> This commit adds support for CAP and CPF markers. Decoding will exit when
> encountering Ilegal input codestreams.
>
> Signed-off-by: Osamu Watanabe
> ---
> libavcod
Hi Osamu,
Below are suggested improvements to error messages.
There are also a couple of errant trailing white spaces in jpeg2000htdec.c.
Can you fix them?
Best,
-- Pierre
On Sat, Aug 3, 2024 at 10:27 PM Osamu Watanabe
wrote:
>
> This commit adds support for CAP and CPF markers. Decoding wi
On Fri, Jul 26, 2024 at 2:29 PM Michael Niedermayer
wrote:
>
> On Thu, Jul 25, 2024 at 05:06:04PM -0700, Pierre-Anthony Lemieux wrote:
> > On Thu, Jul 25, 2024 at 2:17 AM Tomas Härdin wrote:
> > >
> > > sön 2024-07-21 klockan 14:07 +0900 skrev Pierre-Anthony Lemieux
On Fri, Jul 26, 2024 at 1:04 AM Tomas Härdin wrote:
>
> tor 2024-07-25 klockan 17:06 -0700 skrev Pierre-Anthony Lemieux:
> > On Thu, Jul 25, 2024 at 2:17 AM Tomas Härdin wrote:
> > >
> > > sön 2024-07-21 klockan 14:07 +0900 skrev Pierre-Anthony Lemieux:
> >
On Thu, Jul 25, 2024 at 2:17 AM Tomas Härdin wrote:
>
> sön 2024-07-21 klockan 14:07 +0900 skrev Pierre-Anthony Lemieux:
> > On Sat, Jul 20, 2024 at 5:12 PM Tomas Härdin wrote:
> > >
> > > tor 2024-07-18 klockan 23:10 +0900 skrev Pierre-Anthony Lemieux:
> >
On Sat, Jul 20, 2024 at 5:12 PM Tomas Härdin wrote:
>
> tor 2024-07-18 klockan 23:10 +0900 skrev Pierre-Anthony Lemieux:
> > On Mon, Jul 15, 2024 at 10:33 PM Tomas Härdin wrote:
> > >
> > > fre 2024-07-12 klockan 12:51 -0700 skrev Pierre-Anthony Lemieux:
> >
On Mon, Jul 15, 2024 at 10:33 PM Tomas Härdin wrote:
>
> fre 2024-07-12 klockan 12:51 -0700 skrev Pierre-Anthony Lemieux:
> > On Thu, Jul 11, 2024 at 10:28 PM Tomas Härdin wrote:
> > >
> > > > +if (s->in_tile_headers == 1 &am
On Thu, Jul 11, 2024 at 10:28 PM Tomas Härdin wrote:
>
> > +if (s->in_tile_headers == 1 && s->isHT && (!s-
> > >Ccap15_b11))
> > +av_log(s->avctx, AV_LOG_WARNING, "COD marker is
> > found in HOMOGENEOUS HT set\n");
>
> How bad is this and the other markers being present
I checked that the patch results in FFMPEG decoding without error the
additional conformance codestreams at [1].
[1] https://ffmpeg.org/pipermail/ffmpeg-devel/2024-June/329727.html
@Osamu, did you check if the decoded images fall within the tolerances
specified in 15444-4?
There is an errant spa
On Wed, Jun 19, 2024 at 1:42 AM Tomas Härdin wrote:
>
> tis 2024-06-18 klockan 07:59 -0700 skrev Pierre-Anthony Lemieux:
> > On Tue, Jun 18, 2024 at 7:25 AM Tomas Härdin wrote:
> > >
> > > lör 2024-06-15 klockan 21:47 -0700 skrev p...@sandflow.com:
> &
On Tue, Jun 18, 2024 at 7:25 AM Tomas Härdin wrote:
>
> lör 2024-06-15 klockan 21:47 -0700 skrev p...@sandflow.com:
> > From: Pierre-Anthony Lemieux
> >
> > p0_10.j2k is one of the reference codestreams included in Rec. ITU-T
> > T.803 | ISO/IEC 15444-4.
> &
Hi Osamu,
Can you provide the list of J2K reference codestreams that this code
allows FFMPEG to support -- not including those already supported [1]?
[1] https://github.com/FFmpeg/FFmpeg/blob/master/tests/fate/jpeg2000.mak
Best,
-- Pierre
On Fri, Jun 14, 2024 at 8:15 PM Osamu Watanabe
wrote:
LGTM. Will merge over the weekend unless I hear otherwise.
On Thu, Jun 6, 2024 at 5:25 PM Osamu Watanabe
wrote:
>
> From: Osamu Watanabe <65328111+osamu...@users.noreply.github.com>
>
> Fix http://trac.ffmpeg.org/ticket/10121
>
> Signed-off-by: Osamu Watanabe
> ---
> libavcodec/jpeg2000dec.c |
On Sun, Jun 9, 2024 at 9:00 AM Pierre-Anthony Lemieux wrote:
>
> On Sun, Jun 9, 2024 at 6:41 AM James Almer wrote:
> >
> > On 6/9/2024 2:56 AM, Pierre-Anthony Lemieux wrote:
> > > On Sat, Jun 8, 2024 at 6:13 PM James Almer wrote:
> > >>
> > &g
On Sun, Jun 9, 2024 at 6:41 AM James Almer wrote:
>
> On 6/9/2024 2:56 AM, Pierre-Anthony Lemieux wrote:
> > On Sat, Jun 8, 2024 at 6:13 PM James Almer wrote:
> >>
> >> On 6/8/2024 9:59 PM, p...@sandflow.com wrote:
> >>> From: Pierre-Anthony Lemi
On Sat, Jun 8, 2024 at 6:13 PM James Almer wrote:
>
> On 6/8/2024 9:59 PM, p...@sandflow.com wrote:
> > From: Pierre-Anthony Lemieux
> >
> > If `--toolchain=valgrind-memcheck` is selected, fate-lavf-asf fails on a
> > false positive.
>
> I can't
LGTM
On Sun, Jun 2, 2024 at 7:16 PM Michael Niedermayer
wrote:
>
> This also makes the code more robust
>
> Fixes: CID1512414 Uninitialized pointer read
>
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer
> ---
> libavformat/imfdec.c | 5 +
> 1 file changed, 1 inserti
On Fri, May 31, 2024 at 8:32 AM Gyan Doshi wrote:
>
> Decoding is no longer possible as the decoder wrapper was removed
> in 60ccb3fe78
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 96b181fd21..6c5b8aab9a 100755
> --- a/co
Will apply on 5/30 unless I hear otherwise.
On Mon, May 27, 2024 at 9:25 AM wrote:
>
> From: Pierre-Anthony Lemieux
>
> Addresses https://trac.ffmpeg.org/ticket/10905
>
> Co-authored-by: Osamu Watanabe
> Signed-off-by: Pierre-Anthony Lemieux
> ---
>
On Sat, May 25, 2024 at 7:57 AM Andreas Rheinhardt
wrote:
>
> Andreas Rheinhardt:
> > This is against the 80 char line length limit, but it is not
> > a hard rule anyway.
> >
> > Signed-off-by: Andreas Rheinhardt
> > ---
> > This is an alternative to modifying check-source.sh (for which I also
>
On Wed, May 22, 2024 at 4:38 AM Andreas Rheinhardt
wrote:
>
> Several files already had standard license header (namely
> 2-clause BSD files), yet due to the 80 char line length limit,
> they were not treated as such by source-check.sh (which
> fate-source uses). Therefore relax the BSD check.
LG
On Sun, May 19, 2024 at 9:02 AM Andreas Rheinhardt
wrote:
>
> p...@sandflow.com:
> > From: Pierre-Anthony Lemieux
> >
> > Addresses https://trac.ffmpeg.org/ticket/10905
> >
> > Co-authored-by: Osamu Watanabe
> > Signed-off-by: Pierre-Ant
On Thu, Feb 8, 2024 at 5:37 AM Derek Buitenhuis
wrote:
>
> Hello,
>
> On 2/8/2024 6:02 AM, Pierre-Anthony Lemieux wrote:
> > The suggested approach is that interested individuals email me, no
> > later than Feb 10 at 23:59 UTC, a completed SOW using the template at
> &
Hi all,
Below is a proposal for creating a proposal to the STF -- I offered to
Michael to help, and here we are.
The objective, as I understand it, is to unlock funds for individuals
that are interested in contributing to the FFMPEG codebase, subject to
the STF criteria [1].
The suggested approa
On Fri, Jan 26, 2024 at 10:02 AM Cédric Le Barz wrote:
>
> Set aspect ratio for jpeg2000 images.
"The image area on the reference grid is defined by its upper left
hand reference grid point at location (XOsiz, YOsiz), and its lower
right hand reference grid point at location (Xsiz – 1, Ysiz – 1)"
On Wed, Sep 13, 2023 at 2:35 AM Tomas Härdin wrote:
>
> ons 2023-09-06 klockan 16:16 -0300 skrev James Almer:
> > On 9/6/2023 2:53 PM, Tomas Härdin wrote:
> > > ons 2023-09-06 klockan 11:38 -0300 skrev James Almer:
> > > > Signed-off-by: James Almer
> > > > ---
> > > > This is an initial proof of
On Mon, Aug 14, 2023 at 1:14 AM Tomas Härdin wrote:
>
> lör 2023-08-12 klockan 13:31 -0700 skrev p...@sandflow.com:
> > From: Pierre-Anthony Lemieux
> >
> > Intended to replace
> > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20230802000135.26482-3-mich...@n
On Sat, Aug 12, 2023 at 1:31 PM Pierre-Anthony Lemieux
wrote:
>
> On Sat, Aug 12, 2023 at 11:39 AM Michael Niedermayer
> wrote:
> >
> > On Thu, Aug 10, 2023 at 04:48:56PM -0700, p...@sandflow.com wrote:
> > > From: Pierre-Anthony Lemieux
> > >
On Sat, Aug 12, 2023 at 11:39 AM Michael Niedermayer
wrote:
>
> On Thu, Aug 10, 2023 at 04:48:56PM -0700, p...@sandflow.com wrote:
> > From: Pierre-Anthony Lemieux
> >
> > Intended to replace
> > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20230802000135.
On Sun, Aug 6, 2023 at 9:28 AM Pierre-Anthony Lemieux wrote:
>
> On Sat, Aug 5, 2023 at 9:30 AM Michael Niedermayer
> wrote:
> >
> > On Fri, Aug 04, 2023 at 06:19:46PM -0700, Pierre-Anthony Lemieux wrote:
> > > On Tue, Aug 1, 2023 at 5:02 PM Michael Niedermayer
>
On Sat, Aug 5, 2023 at 9:30 AM Michael Niedermayer
wrote:
>
> On Fri, Aug 04, 2023 at 06:19:46PM -0700, Pierre-Anthony Lemieux wrote:
> > On Tue, Aug 1, 2023 at 5:02 PM Michael Niedermayer
> > wrote:
> > >
> > > This also fixes assertion failures
> > >
On Tue, Aug 1, 2023 at 5:02 PM Michael Niedermayer
wrote:
>
> Code should make more sense now
>
> Fixes: out of array access
> Fixes:
> 58299/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-6627570448465920
>
> Found-by: continuous fuzzing process
> https://github.com/google/os
On Tue, Aug 1, 2023 at 5:02 PM Michael Niedermayer
wrote:
>
> This also fixes assertion failures
>
> Fixes: shift exponent 95 is too large for 64-bit type 'unsigned long long'
> Fixes:
> 58299/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-5828618092937216
>
> Found-by: continu
On Thu, Aug 3, 2023 at 1:50 PM Tomas Härdin wrote:
>
> tor 2023-08-03 klockan 17:36 +0200 skrev Michael Niedermayer:
> > On Thu, Aug 03, 2023 at 10:20:29AM +0200, Tomas Härdin wrote:
> > > ons 2023-08-02 klockan 02:01 +0200 skrev Michael Niedermayer:
> > > > Fixes: freeing of uninitialized pointer
LGTM.
On Mon, Jul 24, 2023 at 5:46 PM Michael Niedermayer
wrote:
>
> Suggested-by: Pierre-Anthony Lemieux
> Signed-off-by: Michael Niedermayer
> ---
> libavformat/imf_cpl.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/libavformat/imf_cpl.c b/libav
Would this patch be an opportunity to set `cpl->content_title_utf8` to
an empty string at fill_content_title() at libavformat/imf_cpl.c if
xmlNodeListGetString() returns NULL? It could be done as a separate
patch alternatively.
LGTM otherwise.
On Sun, Jul 23, 2023 at 11:03 AM Michael Niedermayer
+1
On Mon, Jul 3, 2023 at 19:32 Tomas Härdin wrote:
> tis 2023-07-04 klockan 01:00 +0200 skrev Michael Niedermayer:
> > Suggested-by: Anton
> >
> > Signed-off-by: Michael Niedermayer
> > ---
> > doc/developer.texi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/d
Will apply "soon".
On Mon, May 29, 2023 at 9:59 AM wrote:
>
> From: Pierre-Anthony Lemieux
>
> ---
> libavformat/imf.h | 6 +-
> libavformat/imf_cpl.c | 179 +++-
> libavformat/imfdec.c| 2 +-
> libavform
On Fri, May 19, 2023 at 5:21 AM "zhilizhao(赵志立)" wrote:
>
>
> > On May 20, 2023, at 01:40, Zhao Zhili wrote:
> >
> > From: Zhao Zhili
> >
> > It breaks fate test with asan.
> >
> > Signed-off-by: Zhao Zhili
> > ---
> > libavformat/tests/imf.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
>
> I
Will apply shortly.
On Mon, May 15, 2023 at 11:33 AM wrote:
>
> From: Pierre-Anthony Lemieux
>
> ---
> libavformat/tests/imf.c | 11 ++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/libavformat/tests/imf.c b/libavformat/tests/imf.c
> i
Couple of follow-up comments.
- "mxf_parse_jpeg2000_frame" could be moved to one of jpeg2000 source
files, to keep J2K parsing code together. Maybe there is a way to
reuse jpeg2000_read_main_headers() at jpeg2000dec.c?
- when defining the J2K descriptor items, please refer to the symbol
name from
On Mon, May 8, 2023 at 3:01 PM Michael Niedermayer
wrote:
>
> On Mon, May 08, 2023 at 11:40:49AM -0700, Pierre-Anthony Lemieux wrote:
> > On Mon, May 8, 2023 at 11:23 AM Michael Niedermayer
> > wrote:
> > >
> > > On Sun, May 07, 2023 at 10:09:58PM -0700, Pier
On Mon, May 8, 2023 at 11:23 AM Michael Niedermayer
wrote:
>
> On Sun, May 07, 2023 at 10:09:58PM -0700, Pierre-Anthony Lemieux wrote:
> > On Sun, May 7, 2023 at 12:18 PM Michael Niedermayer
> > wrote:
> > >
> > > On Sat, May 06, 2023 at 11:01:20AM -0700, Pier
On Mon, May 8, 2023 at 10:11 AM Michael Niedermayer
wrote:
>
> On Mon, May 08, 2023 at 04:05:40PM +0200, Tobias Rapp wrote:
> > On 08/05/2023 14:00, James Almer wrote:
> >
> > > On 5/6/2023 10:25 AM, Michael Niedermayer wrote:
> > > > Its unexpected that a .avi or other "standard" file turns into
On Mon, May 8, 2023 at 7:05 AM Tobias Rapp wrote:
>
> On 08/05/2023 14:00, James Almer wrote:
>
> > On 5/6/2023 10:25 AM, Michael Niedermayer wrote:
> >> Its unexpected that a .avi or other "standard" file turns into a
> >> playlist.
> >> The goal of this patch is to avoid this unexpected behavior
On Sun, May 7, 2023 at 12:18 PM Michael Niedermayer
wrote:
>
> On Sat, May 06, 2023 at 11:01:20AM -0700, Pierre-Anthony Lemieux wrote:
> > On Sat, May 6, 2023 at 6:25 AM Michael Niedermayer
> > wrote:
> > >
> > > Its unexpected that a .avi or other &
On Sat, May 6, 2023 at 6:25 AM Michael Niedermayer
wrote:
>
> Its unexpected that a .avi or other "standard" file turns into a playlist.
> The goal of this patch is to avoid this unexpected behavior and possible
> privacy or security differences.
Per the IMF specification, a CPL can have any exte
On Tue, Apr 25, 2023 at 11:25 AM wrote:
>
> From: caleb
>
> Prevents un-necessary casts when calculating buf_size
This is to address Coverity CID 1528149: """Suspicious implicit sign
extension: "quad_height" with type "uint16_t const" (16 bits,
unsigned) is promoted in "4 * quad_width * quad_hei
On Wed, Mar 29, 2023 at 1:54 PM Cédric Le Barz wrote:
>
> Add jpeg2000 subdescriptor in MXF file.
>
> Signed-off-by: Cedric Le Barz
> ---
> ffmpeg/libavformat/mxf.h| 1 +
> ffmpeg/libavformat/mxfenc.c | 74 -
> 2 files changed, 74 insertions(+), 1 dele
On Wed, Apr 19, 2023 at 1:55 PM Tomas Härdin wrote:
>
> Looks like my comments have been addressed, especially per-CB style
Thanks for the review.
I plan to merge the patchset this weekend.
>
> /Tomas
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel
On Mon, Mar 13, 2023 at 3:30 PM Marton Balint wrote:
>
>
>
> On Fri, 10 Mar 2023, Marton Balint wrote:
>
> >
> >
> > On Mon, 6 Mar 2023, Nicolas Gaullier wrote:
> >
> > The width is one thing; for whatever reason, there is a divergence
> > between DV100 on one hand and AVCI/XDCAMHD35 on
Hi Caleb, Tomas et al.,
I have been experimenting with combining the HTJ2K patchset [1] and
the J2K test patchset [2]:
(a) neither valgrind nor the fuzzer seem to complain
(b) there are code style/cosmetic issues
(c) the HTJ2K block decoder does not yet support placeholder passes
[3], which are n
On Mon, Feb 20, 2023 at 9:55 AM Anton Khirnov wrote:
>
> Quoting p...@sandflow.com (2023-01-06 00:29:44)
> > From: Pierre-Anthony Lemieux
> >
> > ---
> > libavformat/imfdec.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >
On Fri, Feb 3, 2023 at 7:54 AM Tomas Härdin wrote:
>
> We need something better for proper tonemap support, but this is at
> least useful for getting the HDR discussion going.
Below is a demonstration of two tonemap methods:
https://www.sandflow.com/public/tone-mapping/index.html
>
> /Tomas
> _
On Fri, Jan 13, 2023 at 9:27 AM rcombs wrote:
>
> Not yet ready for merge, pending finalization of the standard proposal for
> this mapping:
> https://github.com/ietf-wg-cellar/matroska-specification/pull/724
Is sample ARIB caption available?
> ---
> libavformat/matroska.c| 1 +
> libavfo
Quick ping. This adds an audio test for the IMF demuxer FATE suite,
which currently only has image tests.
On Thu, Dec 29, 2022 at 11:12 PM wrote:
>
> From: Pierre-Anthony Lemieux
>
> Adds an audio test for the IMF demuxer.
>
> FATE content at https://www.sandflow.com/public/c
On Fri, Jan 6, 2023 at 8:09 AM Tomas Härdin wrote:
>
> fre 2023-01-06 klockan 07:50 -0800 skrev Pierre-Anthony Lemieux:
> > On Fri, Jan 6, 2023 at 7:45 AM Tomas Härdin wrote:
> > >
> > > tor 2023-01-05 klockan 15:29 -0800 skrev p...@sandflow.com:
> &
On Fri, Jan 6, 2023 at 7:45 AM Tomas Härdin wrote:
>
> tor 2023-01-05 klockan 15:29 -0800 skrev p...@sandflow.com:
> > From: Pierre-Anthony Lemieux
> >
> > ---
> > libavformat/imfdec.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> &g
I have updated the page with the HTJ2K project.
This is a good opportunity to ask for help completing the review of
the patchset:
https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=8078
All known issues have been resolved and it would be good to merge
soon, i.e. beat the iron while it is h
On Fri, Dec 2, 2022 at 10:46 AM Tomas Härdin wrote:
>
> fre 2022-12-02 klockan 21:11 +0300 skrev etemesica...@gmail.com:
> >
> > +/**
> > + * Given a precomputed c, checks whether n % d == 0
> > + */
> > +static av_always_inline uint32_t is_divisible(uint32_t n, uint64_t
> > c)
> > +{
> > +re
Hi Zane et al.,
Quick ping on the revised patchset below.
It addresses https://trac.ffmpeg.org/ticket/9842.
Best,
-- Pierre
On Sun, Oct 2, 2022 at 9:28 AM wrote:
>
> From: Pierre-Anthony Lemieux
>
> The IMF CPL contains an optional timecode start address. This patch reads the
On Tue, Oct 4, 2022 at 7:59 AM Tomas Härdin wrote:
>
> tis 2022-10-04 klockan 07:50 -0700 skrev Pierre-Anthony Lemieux:
> > On Tue, Oct 4, 2022 at 7:29 AM Tomas Härdin wrote:
> > >
> > > mån 2022-10-03 klockan 11:47 + skrev Richard Ayres:
> > > >
On Tue, Oct 4, 2022 at 7:29 AM Tomas Härdin wrote:
>
> mån 2022-10-03 klockan 11:47 + skrev Richard Ayres:
> > Thanks, Pierre-Anthony. I've updated the patch to remove the
> > unnecessary UL and it's now using mxf_match_uid() to detect the EKLV
> > packet.
> >
> > Signed-off-by: Richard Ayres
On Mon, Oct 3, 2022 at 1:11 AM Julio C. Rocha wrote:
>
> On Sun, Oct 2, 2022 at 5:19 PM Pierre-Anthony Lemieux
> wrote:
>
> > On Sun, Oct 2, 2022 at 5:14 PM Timo Rothenpieler
> > wrote:
> > >
> > > On 03.10.2022 01:47, Julio C. Rocha
On Sun, Oct 2, 2022 at 5:14 PM Timo Rothenpieler wrote:
>
> On 03.10.2022 01:47, Julio C. Rocha wrote:
> > ---
> > configure | 7 ++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/configure b/configure
> > index 6712d045d9..f5f5eb29dd 100755
> > --- a/configure
> >
On Tue, Sep 27, 2022 at 5:40 AM Zane van Iperen wrote:
>
> Looks mostly ok from a cursory glance, just one minor nit.
>
> On 23/8/22 15:10, p...@sandflow.com wrote:
> >
> > +static int ff_imf_xml_read_boolean(xmlNodePtr element, int *value)
> > +{
> > +xmlChar *element_text = NULL;
> > +in
On Fri, Sep 30, 2022 at 7:08 AM Richard Ayres
wrote:
>
> We had an issue where ffmpeg was unable to unpack the EKLV of an encrypted 3D
> SMPTE DC MXF.
>
> The patch adds the SMPTE UL for EKLV packets
> (060e2b34.02040101.0d010301.027e0100), to mxfdec.c in order to unpack an EKLV
> packet found
/48fa27e77a6d71be89f216cee13ae7e99d2b5003
Now that [1] has been merged,
On Mon, Sep 5, 2022 at 11:06 AM Pierre-Anthony Lemieux
wrote:
>
> Just a quick ping.
>
> Looking forward to feedback.
>
> This patchset is intended to address https://trac.ffmpeg.org/ticket/9842.
>
>
> On Mon, Aug
On Mon, Sep 19, 2022 at 7:42 AM Michael Niedermayer
wrote:
>
> On Sat, Sep 17, 2022 at 08:57:37AM -0700, Pierre-Anthony Lemieux wrote:
> > On Sat, Sep 17, 2022 at 7:43 AM Michael Niedermayer
> > wrote:
> > >
> > > On Fri, Sep 16, 2022 at 01:19:09PM -0700, Pier
On Sat, Sep 17, 2022 at 7:43 AM Michael Niedermayer
wrote:
>
> On Fri, Sep 16, 2022 at 01:19:09PM -0700, Pierre-Anthony Lemieux wrote:
> > On Fri, Sep 16, 2022 at 1:15 PM Michael Niedermayer
> > wrote:
> > >
> > > On Fri, Sep 16, 2022 at 10:39:22AM -0700, Pier
On Fri, Sep 16, 2022 at 1:15 PM Michael Niedermayer
wrote:
>
> On Fri, Sep 16, 2022 at 10:39:22AM -0700, Pierre-Anthony Lemieux wrote:
> > On Fri, Sep 16, 2022 at 10:27 AM Michael Niedermayer
> > wrote:
> > >
> > > On Wed, Sep 07, 2022 at 01:02:33PM -0700, p
On Fri, Sep 16, 2022 at 10:39 AM Pierre-Anthony Lemieux
wrote:
>
> On Fri, Sep 16, 2022 at 10:27 AM Michael Niedermayer
> wrote:
> >
> > On Wed, Sep 07, 2022 at 01:02:33PM -0700, p...@sandflow.com wrote:
> > > From: Pierre-Anthony Lemieux
> >
On Fri, Sep 16, 2022 at 10:27 AM Michael Niedermayer
wrote:
>
> On Wed, Sep 07, 2022 at 01:02:33PM -0700, p...@sandflow.com wrote:
> > From: Pierre-Anthony Lemieux
> >
> > Addresses coverity 1512414
> >
> > ---
> > libavformat/imfdec.c | 15
On Thu, Sep 15, 2022 at 4:07 PM Lynne wrote:
>
> Sep 16, 2022, 00:46 by p...@sandflow.com:
>
> > From: Pierre-Anthony Lemieux
> >
> > ---
> > MAINTAINERS | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINER
Ping.
This patchset addresses a coverity issue #1512414.
On Wed, Sep 7, 2022 at 1:02 PM wrote:
>
> From: Pierre-Anthony Lemieux
>
> Addresses coverity 1512414
>
> ---
> libavformat/imfdec.c | 15 ---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
Ping. All outstanding feedback has been addressed AFAIK.
This patchset addresses https://trac.ffmpeg.org/ticket/9856
On Tue, Sep 6, 2022 at 2:51 PM wrote:
>
> From: Pierre-Anthony Lemieux
>
> The MXF demuxer does not currently set AVStream::avg_frame_rate and
> ::r_frame_
See [1] for a patchset that is intended to address the coverity issue
and simplify error handling.
[1]
https://patchwork.ffmpeg.org/project/ffmpeg/patch/20220907200233.21255-1-...@sandflow.com/
On Sat, Aug 27, 2022 at 10:25 AM Pierre-Anthony Lemieux
wrote:
>
> On Sat, Aug 27, 2022 at 5
On Tue, Sep 6, 2022 at 2:33 PM Andreas Rheinhardt
wrote:
>
> Pierre-Anthony Lemieux:
> > On Tue, Sep 6, 2022 at 2:24 PM Andreas Rheinhardt
> > wrote:
> >>
> >> p...@sandflow.com:
> >>> From: Pierre-Anthony Lemieux
> >>>
> >>&g
On Tue, Sep 6, 2022 at 2:24 PM Andreas Rheinhardt
wrote:
>
> p...@sandflow.com:
> > From: Pierre-Anthony Lemieux
> >
> > ---
> > tests/fate/mxf.mak | 4 ++
> > tests/ref/fate/mxf-probe-j2k | 78
> > 2 f
Ping.
This fixes Coverity issue #1512406.
On Thu, Aug 25, 2022 at 8:22 PM wrote:
>
> From: Pierre-Anthony Lemieux
>
> Fixes Coverity issue #1512406
>
> ---
> libavformat/imfdec.c | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/liba
Just a quick ping.
Looking forward to feedback.
This patchset is intended to address https://trac.ffmpeg.org/ticket/9842.
On Mon, Aug 22, 2022 at 10:11 PM wrote:
>
> From: Pierre-Anthony Lemieux
>
> The IMF CPL contains an optional timecode start address. This patch reads the
On Sat, Sep 3, 2022 at 11:26 AM Tomas Härdin wrote:
>
> sön 2022-08-28 klockan 08:31 -0700 skrev p...@sandflow.com:
> > From: Pierre-Anthony Lemieux
> >
> > The MXF demuxer does not currently set AVStream::avg_frame_rate and
> > ::r_frame_rate
> > when J2K e
On Sat, Aug 27, 2022 at 5:25 AM Steven Liu wrote:
>
> Pierre-Anthony Lemieux 于2022年8月27日周六 00:06写道：
> >
> > On Fri, Aug 26, 2022 at 9:01 AM Andreas Rheinhardt
> > wrote:
> > >
> > > Pierre-Anthony Lemieux:
> > > > On Fri, Aug
On Fri, Aug 26, 2022 at 9:01 AM Andreas Rheinhardt
wrote:
>
> Pierre-Anthony Lemieux:
> > On Fri, Aug 26, 2022 at 1:37 AM Andreas Rheinhardt
> > wrote:
> >>
> >> Steven Liu:
> >>> fix CID: 1512414
> >>> And return AVERROR_INVALIDDATA w
On Fri, Aug 26, 2022 at 1:22 AM Andreas Rheinhardt
wrote:
>
> Pierre-Anthony Lemieux:
> > On Thu, Aug 25, 2022 at 1:58 PM Andreas Rheinhardt
> > wrote:
> >>
> >> Improves the test; also should fix Coverity issue #1512408.
> >>
> >> Signed-
On Fri, Aug 26, 2022 at 1:37 AM Andreas Rheinhardt
wrote:
>
> Steven Liu:
> > fix CID: 1512414
> > And return AVERROR_INVALIDDATA when get_next_track_with_minimum_timestamp
> > incorrect in imf_read_packet;
> >
> > Signed-off-by: Steven Liu
> > ---
> > libavformat/imfdec.c | 7 +--
> > 1 fil
On Thu, Aug 25, 2022 at 1:58 PM Andreas Rheinhardt
wrote:
>
> Improves the test; also should fix Coverity issue #1512408.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/tests/imf.c | 10 ++
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/libavformat/tests/im
Since we are protecting against the algorithm within
get_next_track_with_minimum_timestamp() return NULL, should this patch
also include immediately returning from imf_read_packet() if
get_next_track_with_minimum_timestamp() returns NULL?
On Thu, Aug 25, 2022 at 7:53 PM Steven Liu wrote:
>
> fix
LGTM
On Thu, Aug 25, 2022 at 2:01 PM Andreas Rheinhardt
wrote:
>
> Fixes Coverity issue #1512407.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/imf_cpl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/imf_cpl.c b/libavformat/imf_cpl.c
> index 4a
On Tue, Aug 9, 2022 at 6:05 PM Pierre-Anthony Lemieux wrote:
>
> On Mon, Aug 8, 2022 at 7:50 AM Pierre-Anthony Lemieux
> wrote:
> >
> > On Mon, Aug 8, 2022 at 7:48 AM Andreas Rheinhardt
> > wrote:
> > >
> > > p...@sandflow.com:
> > > >
On Mon, Aug 8, 2022 at 7:50 AM Pierre-Anthony Lemieux wrote:
>
> On Mon, Aug 8, 2022 at 7:48 AM Andreas Rheinhardt
> wrote:
> >
> > p...@sandflow.com:
> > > From: Pierre-Anthony Lemieux
> > >
> > > Addresses http://ffmpeg.or
On Mon, Aug 8, 2022 at 7:48 AM Andreas Rheinhardt
wrote:
>
> p...@sandflow.com:
> > From: Pierre-Anthony Lemieux
> >
> > Addresses http://ffmpeg.org/pipermail/ffmpeg-devel/2022-August/299726.html
> >
> > --
On Sat, Aug 6, 2022 at 2:43 AM Andreas Rheinhardt
wrote:
>
> p...@sandflow.com:
> > From: Pierre-Anthony Lemieux
> >
> > Addresses http://ffmpeg.org/pipermail/ffmpeg-devel/2022-August/299685.html
> >
> > --
On Thu, Aug 4, 2022 at 4:24 PM Pierre-Anthony Lemieux wrote:
>
> On Thu, Aug 4, 2022 at 4:13 PM Andreas Rheinhardt
> wrote:
> >
> > Pierre-Anthony Lemieux:
> > > On Thu, Aug 4, 2022 at 3:22 PM Andreas Rheinhardt
> > > wrote:
> > >>
> >
1 - 100 of 192 matches
Mail list logo
