[FFmpeg-devel] [PATCH 4/4] swscale/aarch64/yuv2rgb: add neon yuv42{0, 2}p -> gbrp unscaled colorspace converters

2024-07-23 Thread Ramiro Polla
--- libswscale/aarch64/swscale_unscaled.c | 58 + libswscale/aarch64/yuv2rgb_neon.S | 73 ++- 2 files changed, 118 insertions(+), 13 deletions(-) diff --git a/libswscale/aarch64/swscale_unscaled.c b/libswscale/aarch64/swscale_unscaled.c index

[FFmpeg-devel] [PATCH 3/4] swscale/x86/yuv2rgb: add ssse3 yuv42{0, 2}p -> gbrp unscaled colorspace converters

2024-07-23 Thread Ramiro Polla
Note: this implementation is limited to x86_64 due to general purpose register pressure. --- libswscale/x86/yuv2rgb.c | 39 libswscale/x86/yuv_2_rgb.asm | 24 +- 2 files changed, 62 insertions(+), 1 deletion(-) diff --git

[FFmpeg-devel] [PATCH 2/4] swscale/yuv2rgb: add yuv42{0, 2}p -> gbrp unscaled colorspace converters

2024-07-23 Thread Ramiro Polla
--- libswscale/yuv2rgb.c| 16 ++ tests/checkasm/sw_yuv2rgb.c | 60 +++-- 2 files changed, 60 insertions(+), 16 deletions(-) diff --git a/libswscale/yuv2rgb.c b/libswscale/yuv2rgb.c index c283d6d1bd..3a41c4eba6 100644 --- a/libswscale/yuv2rgb.c +++

[FFmpeg-devel] [PATCH 1/4] swscale/yuv2rgb: prepare YUV2RGBFUNC macro for multi-planar rgb

2024-07-23 Thread Ramiro Polla
This will be used in the upcoming yuv42{0,2}p -> gbrp unscaled colorspace converters. --- libswscale/yuv2rgb.c | 279 ++- 1 file changed, 142 insertions(+), 137 deletions(-) diff --git a/libswscale/yuv2rgb.c b/libswscale/yuv2rgb.c index

Re: [FFmpeg-devel] [PATCH v2] libavformat/vapoursynth: Update to API version 4, load library at runtime

2024-07-22 Thread Ramiro Polla
On Mon, Jul 22, 2024 at 4:01 PM Hendrik Leppkes wrote: > On Mon, Jul 22, 2024 at 2:14 PM Ramiro Polla wrote: > > On Mon, Jul 22, 2024 at 12:15 AM Hendrik Leppkes > > wrote: > > > On Mon, Jul 22, 2024 at 12:08 AM Stefan Oltmanns via ffmpeg-devel > > > wr

Re: [FFmpeg-devel] [PATCH v2] libavformat/vapoursynth: Update to API version 4, load library at runtime

2024-07-22 Thread Ramiro Polla
On Mon, Jul 22, 2024 at 12:15 AM Hendrik Leppkes wrote: > On Mon, Jul 22, 2024 at 12:08 AM Stefan Oltmanns via ffmpeg-devel > wrote: > > > > Am 18.07.24 um 17:23 schrieb epira...@gmail.com: > > > > > >>> > > >>> Well, the DLL directory is added to PATH by the VapourSynth installer, > > >>> but

Re: [FFmpeg-devel] [PATCH v2] libavformat/vapoursynth: Update to API version 4, load library at runtime

2024-07-18 Thread Ramiro Polla
On Thu, Jul 18, 2024 at 3:41 PM Stefan Oltmanns via ffmpeg-devel wrote: > Am 18.07.24 um 15:04 schrieb Ramiro Polla: > >>>> [...] > >>>> > >>>> +static VSScriptLibrary vs_script_library; > >>> > >>> Does vs_script_libra

Re: [FFmpeg-devel] [PATCH v2] libavformat/vapoursynth: Update to API version 4, load library at runtime

2024-07-18 Thread Ramiro Polla
On Thu, Jul 18, 2024 at 2:48 PM Stefan Oltmanns via ffmpeg-devel wrote: > Am 18.07.24 um 13:08 schrieb Ramiro Polla: > >> [...] > >> + > >> +#include > >> + > >> struct VSState { > >> VSScript *vss; > >> }; >

Re: [FFmpeg-devel] [PATCH v2] libavformat/vapoursynth: Update to API version 4, load library at runtime

2024-07-18 Thread Ramiro Polla
Hi Stefan, On 7/6/24 23:08, Stefan Oltmanns via ffmpeg-devel wrote: this is revised patch, to sum up the changes: The current VapourSynth implementation is rarely used, as it links the VapourSynth library at build time, making the resulting build unable to run when VapourSynth is not

Re: [FFmpeg-devel] [PATCH 2/2] swscale/x86/yuv2rgb: Detemplatize

2024-07-08 Thread Ramiro Polla
On Thu, Jul 4, 2024 at 11:40 AM Ramiro Polla wrote: > Every function in yuv2rgb_template.c is only compiled exactly > once, so detemplatize it. I'll apply in a few days if there are no comments. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmp

Re: [FFmpeg-devel] [PATCH] configure: restore autodetection of v4l2 and fbdev

2024-07-08 Thread Ramiro Polla
On Wed, Jul 3, 2024 at 12:30 AM Ramiro Polla wrote: > The detection logic for v4l2 and fbdev was accidentally modified to > depend on v4l2-m2m in 43b3412. I'll apply in a few days if there are no comments. ___ ffmpeg-devel mailing list ffmpeg

Re: [FFmpeg-devel] [PATCH v2] libswscale/x86/yuv2rgb: Add missing EMMS

2024-07-05 Thread Ramiro Polla
Hi, On Thu, Jul 4, 2024 at 7:52 PM Mario Hros wrote: > It is possible that removal would be faster, though I haven't benchmarked > that. I think that Kodi only uses this function for UI textures, so nothing > performance-intensive. My main point was that the current MMX code without > EMMS is

[FFmpeg-devel] [PATCH 2/2] swscale/x86/yuv2rgb: Detemplatize

2024-07-04 Thread Ramiro Polla
Every function in yuv2rgb_template.c is only compiled exactly once, so detemplatize it. --- libswscale/x86/yuv2rgb.c | 167 +- libswscale/x86/yuv2rgb_template.c | 188 -- 2 files changed, 162 insertions(+), 193 deletions(-) delete mode

[FFmpeg-devel] [PATCH 1/2] swscale: remove unconditional #define DITHER1XBPP

2024-07-04 Thread Ramiro Polla
This seems to have had an use in the past, but it is now defined unconditionally. --- libswscale/swscale_internal.h | 2 -- libswscale/utils.c| 4 libswscale/x86/swscale.c | 2 -- libswscale/x86/swscale_template.c | 20

[FFmpeg-devel] [PATCH] configure: restore autodetection of v4l2 and fbdev

2024-07-02 Thread Ramiro Polla
The detection logic for v4l2 and fbdev was accidentally modified to depend on v4l2-m2m in 43b3412. --- configure | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/configure b/configure index b28221f258..fa2e384350 100755 --- a/configure +++ b/configure @@ -7145,11

Re: [FFmpeg-devel] [PATCH] avdevice/v4l2: add limited support for multiplanar API

2024-07-01 Thread Ramiro Polla
On Fri, Jun 28, 2024 at 2:54 PM Ramiro Polla wrote: > I'll apply this after the weekend if there are no objections. I realized this patch would have caused a regression on buffers with corrupted data or an unexpected size. New patch attached. Alexander, Stephen, since you worked on this bef

Re: [FFmpeg-devel] [FFmpeg-cvslog] checkasm: add tests for yuv2rgb

2024-07-01 Thread Ramiro Polla
On Fri, Jun 28, 2024 at 2:50 PM Ramiro Polla wrote: > > ffmpeg | branch: master | Ramiro Polla | Sun Jun 16 > 22:40:13 2024 +0200| [1fb77347c8d96f4feff8f9328b40e6ee71191ac1] | committer: > Ramiro Polla > > checkasm: add tests for yuv2rgb > > > http://git.videola

Re: [FFmpeg-devel] [PATCH v2] libswscale/x86/yuv2rgb: Add missing EMMS

2024-07-01 Thread Ramiro Polla
On Wed, Jun 26, 2024 at 8:55 PM Ramiro Polla wrote: > On Wed, Jun 26, 2024 at 8:03 PM Mario Hros wrote: > > Previous rewrite from inline assembly into nasm (commit e934194) missed the > > required EMMS instruction to bring the x87 FPU back into usable state. > > This needs

Re: [FFmpeg-devel] [PATCH] avfilter/asubprocess: add audio subprocess filter

2024-06-30 Thread Ramiro Polla
Hi, On Sun, Jun 30, 2024 at 6:19 PM Stefan Westerfeld wrote: > Am 27.06.24 um 23:35 schrieb Ramiro Polla: [...] > Note that this isn't much different than what my asubprocess filter > would do. However it is less readable and maintainable, and just leaves > subprocess management

Re: [FFmpeg-devel] [PATCH] avdevice/v4l2: add limited support for multiplanar API

2024-06-28 Thread Ramiro Polla
On Thu, Jun 27, 2024 at 4:13 PM Ramiro Polla wrote: > On Tue, Jun 25, 2024 at 1:56 PM Ramiro Polla wrote: > > On Tue, Jun 25, 2024 at 11:19 AM Anton Khirnov wrote: > > > Quoting Ramiro Polla (2024-06-20 17:40:39) > > > > This commit adds support for V4L2's

Re: [FFmpeg-devel] [PATCH v2] avdevice/v4l2: add NV16 and NV24 pixel formats

2024-06-28 Thread Ramiro Polla
On Wed, Jun 26, 2024 at 1:19 PM Ramiro Polla wrote: > > --- > libavdevice/v4l2-common.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/libavdevice/v4l2-common.c b/libavdevice/v4l2-common.c > index b5b4448a31..ebfd2b6d8d 100644 > --- a/libavdevice/v4l2-comm

Re: [FFmpeg-devel] [PATCH] avdevice/v4l2: add limited support for multiplanar API

2024-06-28 Thread Ramiro Polla
On Thu, Jun 27, 2024 at 6:06 PM Anton Khirnov wrote: > Quoting Ramiro Polla (2024-06-27 16:13:24) > > Is anyone fundamentally opposed to this approach to implement limited > > support for multiplanar API? I figure it could still be useful even > > when full multiplanar API s

Re: [FFmpeg-devel] [PATCH] avfilter/asubprocess: add audio subprocess filter

2024-06-27 Thread Ramiro Polla
Hi Stefan, On Thu, Jun 27, 2024 at 6:32 PM Stefan Westerfeld wrote: > This will send the audio stream to an external command as wav file and > read back the output of the subprocess which is also supposed to be a > wav file of the same format and length. Subprocesses are a pita to support and

Re: [FFmpeg-devel] [PATCH] libavcodec/mjpeg: keep last_dc value unclipped

2024-06-27 Thread Ramiro Polla
On Fri, Jun 7, 2024 at 10:10 PM Ramiro Polla wrote: > On Fri, Jun 7, 2024 at 9:35 PM Andreas Rheinhardt > wrote: > > Ramiro Polla: > > > Do av_clip_int16(val) _after_ copying the value to last_dc. > > > > > > Related commits: c28f648b19d and

Re: [FFmpeg-devel] [PATCH] avdevice/v4l2: add limited support for multiplanar API

2024-06-27 Thread Ramiro Polla
On Tue, Jun 25, 2024 at 1:56 PM Ramiro Polla wrote: > On Tue, Jun 25, 2024 at 11:19 AM Anton Khirnov wrote: > > Quoting Ramiro Polla (2024-06-20 17:40:39) > > > This commit adds support for V4L2's multiplanar API, but only when the > > > number of planes is 1. >

Re: [FFmpeg-devel] [PATCH 5/6] checkasm: add tests for yuv2rgb

2024-06-27 Thread Ramiro Polla
On Tue, Jun 25, 2024 at 11:19 PM Ramiro Polla wrote: > On Thu, Jun 20, 2024 at 4:59 PM Ramiro Polla wrote: > > checkasm gets a little spammy with this commit by printing "No > > accelerated colorspace conversion found from %s to %s.\n" from > > libswscal

Re: [FFmpeg-devel] [PATCH v2] libswscale/x86/yuv2rgb: Add missing EMMS

2024-06-26 Thread Ramiro Polla
Hi, On Wed, Jun 26, 2024 at 8:03 PM Mario Hros wrote: > Previous rewrite from inline assembly into nasm (commit e934194) missed the > required EMMS instruction to bring the x87 FPU back into usable state. > This needs to be done for 8-byte MMX or Extended MMX only. Sorry I didn't catch this

[FFmpeg-devel] [PATCH v2] avdevice/v4l2: add NV16 and NV24 pixel formats

2024-06-26 Thread Ramiro Polla
--- libavdevice/v4l2-common.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavdevice/v4l2-common.c b/libavdevice/v4l2-common.c index b5b4448a31..ebfd2b6d8d 100644 --- a/libavdevice/v4l2-common.c +++ b/libavdevice/v4l2-common.c @@ -50,6 +50,12 @@ const struct fmt_map

[FFmpeg-devel] [PATCH] avdevice/v4l2: add NV16 and NV24 pixel formats

2024-06-26 Thread Ramiro Polla
--- libavdevice/v4l2-common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavdevice/v4l2-common.c b/libavdevice/v4l2-common.c index b5b4448a31..ada9b91263 100644 --- a/libavdevice/v4l2-common.c +++ b/libavdevice/v4l2-common.c @@ -50,6 +50,8 @@ const struct fmt_map

Re: [FFmpeg-devel] [PATCH 5/6] checkasm: add tests for yuv2rgb

2024-06-25 Thread Ramiro Polla
On Thu, Jun 20, 2024 at 4:59 PM Ramiro Polla wrote: > checkasm gets a little spammy with this commit by printing "No > accelerated colorspace conversion found from %s to %s.\n" from > libswscale/yuv2rgb.c multiple times. Any suggestions? Perhaps > downgrading that mes

Re: [FFmpeg-devel] [PATCH] avdevice/v4l2: add limited support for multiplanar API

2024-06-25 Thread Ramiro Polla
On Tue, Jun 25, 2024 at 11:19 AM Anton Khirnov wrote: > Quoting Ramiro Polla (2024-06-20 17:40:39) > > This commit adds support for V4L2's multiplanar API, but only when the > > number of planes is 1. > > > > Adding full support for the multiplanar API would require

[FFmpeg-devel] [PATCH] avdevice/v4l2: add limited support for multiplanar API

2024-06-20 Thread Ramiro Polla
This commit adds support for V4L2's multiplanar API, but only when the number of planes is 1. Adding full support for the multiplanar API would require a device that actually uses more than 1 plane, which I have not found yet. --- libavdevice/v4l2.c | 93

Re: [FFmpeg-devel] [PATCH 5/6] checkasm: add tests for yuv2rgb

2024-06-20 Thread Ramiro Polla
On Mon, Jun 17, 2024 at 12:28 AM Ramiro Polla wrote: > > --- > tests/checkasm/Makefile | 2 +- > tests/checkasm/checkasm.c | 1 + > tests/checkasm/checkasm.h | 1 + > tests/checkasm/sw_yuv2rgb.c | 205 > tests/fate/checkasm

Re: [FFmpeg-devel] [PATCH 6/6] swscale/yuv2rgb/x86: remove mmx/mmxext yuv2rgb functions

2024-06-20 Thread Ramiro Polla
On Mon, Jun 17, 2024 at 2:46 PM Ramiro Polla wrote: > On Mon, Jun 17, 2024 at 1:16 AM James Almer wrote: > > On 6/16/2024 7:28 PM, Ramiro Polla wrote: > > > These functions are either slower or barely faster than the C LUT > > > yuv2rgb code. > > >

Re: [FFmpeg-devel] [PATCH v2 4/4] swscale/aarch64: add neon {lum, chr}ConvertRange

2024-06-18 Thread Ramiro Polla
On Tue, Jun 18, 2024 at 7:42 PM Ramiro Polla wrote: > > On Tue, Jun 11, 2024 at 2:29 PM Ramiro Polla wrote: > > > > chrRangeFromJpeg_8_c: 29.2 > > chrRangeFromJpeg_8_neon: 19.5 > > chrRangeFromJpeg_24_c: 80.5 > > chrRangeFromJpeg_24_neon: 34

Re: [FFmpeg-devel] [PATCH v2 4/4] swscale/aarch64: add neon {lum, chr}ConvertRange

2024-06-18 Thread Ramiro Polla
On Tue, Jun 11, 2024 at 2:29 PM Ramiro Polla wrote: > > chrRangeFromJpeg_8_c: 29.2 > chrRangeFromJpeg_8_neon: 19.5 > chrRangeFromJpeg_24_c: 80.5 > chrRangeFromJpeg_24_neon: 34.0 > chrRangeFromJpeg_128_c: 413.7 > chrRangeFromJpeg_128_neon: 156.0 > chrRa

Re: [FFmpeg-devel] [PATCH 6/6] swscale/yuv2rgb/x86: remove mmx/mmxext yuv2rgb functions

2024-06-17 Thread Ramiro Polla
On Mon, Jun 17, 2024 at 1:16 AM James Almer wrote: > On 6/16/2024 7:28 PM, Ramiro Polla wrote: > > These functions are either slower or barely faster than the C LUT > > yuv2rgb code. > > --- > > libswscale/x86/yuv2rgb.c | 51 - > >

[FFmpeg-devel] [PATCH 6/6] swscale/yuv2rgb/x86: remove mmx/mmxext yuv2rgb functions

2024-06-16 Thread Ramiro Polla
These functions are either slower or barely faster than the C LUT yuv2rgb code. --- libswscale/x86/yuv2rgb.c | 51 - libswscale/x86/yuv2rgb_template.c | 4 -- libswscale/x86/yuv_2_rgb.asm | 93 +-- 3 files changed, 3 insertions(+), 145

[FFmpeg-devel] [PATCH 5/6] checkasm: add tests for yuv2rgb

2024-06-16 Thread Ramiro Polla
--- tests/checkasm/Makefile | 2 +- tests/checkasm/checkasm.c | 1 + tests/checkasm/checkasm.h | 1 + tests/checkasm/sw_yuv2rgb.c | 205 tests/fate/checkasm.mak | 1 + 5 files changed, 209 insertions(+), 1 deletion(-) create mode 100644

[FFmpeg-devel] [PATCH 4/6] swscale/yuv2rgb: reindent after previous commit

2024-06-16 Thread Ramiro Polla
--- libswscale/yuv2rgb.c | 78 ++-- 1 file changed, 39 insertions(+), 39 deletions(-) diff --git a/libswscale/yuv2rgb.c b/libswscale/yuv2rgb.c index 1ea87ac17a..977eb3a7dd 100644 --- a/libswscale/yuv2rgb.c +++ b/libswscale/yuv2rgb.c @@ -593,45 +593,45 @@

[FFmpeg-devel] [PATCH 3/6] swscale/yuv2rgb: fix yuv422p input in C code

2024-06-16 Thread Ramiro Polla
The C code was silently ignoring the second chroma line on yuv422p input. --- libswscale/yuv2rgb.c | 228 +-- 1 file changed, 196 insertions(+), 32 deletions(-) diff --git a/libswscale/yuv2rgb.c b/libswscale/yuv2rgb.c index 7386d3a2a2..1ea87ac17a 100644

[FFmpeg-devel] [PATCH 2/6] swscale/yuv2rgb: add macros to simplify code generation

2024-06-16 Thread Ramiro Polla
--- libswscale/yuv2rgb.c | 574 +-- 1 file changed, 113 insertions(+), 461 deletions(-) diff --git a/libswscale/yuv2rgb.c b/libswscale/yuv2rgb.c index e641c765c7..7386d3a2a2 100644 --- a/libswscale/yuv2rgb.c +++ b/libswscale/yuv2rgb.c @@ -72,13 +72,13 @@

[FFmpeg-devel] [PATCH 1/6] swscale/yuv2rgb: fix conversion for widths not aligned to 8

2024-06-16 Thread Ramiro Polla
The C code for some pixel formats (rgb555, rgb565, rgb444, and monob) was not converting the last pixels on widths not aligned to 8. NOTE: the last pixel for odd widths is still not converted for any of the pixel formats in the C code for yuv2rgb except for monob. --- libswscale/yuv2rgb.c

Re: [FFmpeg-devel] [PATCH v2 2/4] swscale/x86: add sse4 {lum, chr}ConvertRange

2024-06-14 Thread Ramiro Polla
On Wed, Jun 12, 2024 at 4:54 PM Ramiro Polla wrote: > > Hi, > > On Tue, Jun 11, 2024 at 8:42 PM James Almer wrote: > > > > On 6/11/2024 3:26 PM, Michael Niedermayer wrote: > > > On Tue, Jun 11, 2024 at 02:28:56PM +0200, Ramiro Polla wrote:

Re: [FFmpeg-devel] [PATCH v2 1/4] checkasm: add tests for {lum, chr}ConvertRange

2024-06-14 Thread Ramiro Polla
On Tue, Jun 11, 2024 at 2:29 PM Ramiro Polla wrote: > > --- > tests/checkasm/Makefile | 2 +- > tests/checkasm/checkasm.c | 1 + > tests/checkasm/checkasm.h | 1 + > tests/checkasm/sw_range_convert.c | 134 ++ >

Re: [FFmpeg-devel] [PATCH v2 2/4] swscale/x86: add sse4 {lum, chr}ConvertRange

2024-06-12 Thread Ramiro Polla
Hi, On Tue, Jun 11, 2024 at 8:42 PM James Almer wrote: > > On 6/11/2024 3:26 PM, Michael Niedermayer wrote: > > On Tue, Jun 11, 2024 at 02:28:56PM +0200, Ramiro Polla wrote: > >> chrRangeFromJpeg_8_c: 28.7 > >> chrRangeFromJpeg_8_sse4: 16.2 >

Re: [FFmpeg-devel] [PATCH 4/4] swscale/aarch64: add neon {lum, chr}ConvertRange

2024-06-11 Thread Ramiro Polla
On Mon, Jun 10, 2024 at 1:56 PM Martin Storsjö wrote: > On Fri, 7 Jun 2024, Ramiro Polla wrote: > > > chrRangeFromJpeg_8_c: 28.5 > > chrRangeFromJpeg_8_neon: 21.2 > > chrRangeFromJpeg_24_c: 81.2 > > chrRangeFromJpeg_24_neon: 34.7 > > chrRangeFromJpeg_128_c:

[FFmpeg-devel] [PATCH v2 4/4] swscale/aarch64: add neon {lum, chr}ConvertRange

2024-06-11 Thread Ramiro Polla
/range_convert_neon.S b/libswscale/aarch64/range_convert_neon.S new file mode 100644 index 00..ea56dc2e32 --- /dev/null +++ b/libswscale/aarch64/range_convert_neon.S @@ -0,0 +1,99 @@ +/* + * Copyright (c) 2024 Ramiro Polla + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you

[FFmpeg-devel] [PATCH v2 3/4] swscale/x86: add avx2 {lum, chr}ConvertRange

2024-06-11 Thread Ramiro Polla
chrRangeFromJpeg_8_c: 24.1 chrRangeFromJpeg_8_sse4: 16.1 chrRangeFromJpeg_8_avx2: 19.9 chrRangeFromJpeg_24_c: 72.6 chrRangeFromJpeg_24_sse4: 34.6 chrRangeFromJpeg_24_avx2: 30.9 chrRangeFromJpeg_128_c: 341.1 chrRangeFromJpeg_128_sse4: 160.9 chrRangeFromJpeg_128_avx2: 94.1 chrRangeFromJpeg_144_c:

[FFmpeg-devel] [PATCH v2 2/4] swscale/x86: add sse4 {lum, chr}ConvertRange

2024-06-11 Thread Ramiro Polla
mode 100644 index 00..13983a386b --- /dev/null +++ b/libswscale/x86/range_convert.asm @@ -0,0 +1,130 @@ +;** +;* Copyright (c) 2024 Ramiro Polla +;* +;* This file is part of FFmpeg. +;* +;* FFmpeg is free software

[FFmpeg-devel] [PATCH v2 1/4] checkasm: add tests for {lum, chr}ConvertRange

2024-06-11 Thread Ramiro Polla
--- tests/checkasm/Makefile | 2 +- tests/checkasm/checkasm.c | 1 + tests/checkasm/checkasm.h | 1 + tests/checkasm/sw_range_convert.c | 134 ++ 4 files changed, 137 insertions(+), 1 deletion(-) create mode 100644

Re: [FFmpeg-devel] [PATCH 1/2] ffplay: add -scaling_quality option for SDL

2024-06-11 Thread Ramiro Polla
Hi, On Mon, Jun 10, 2024 at 9:04 PM Marton Balint wrote: > On Tue, 4 Jun 2024, Ramiro Polla wrote: > > On Thu, May 30, 2024 at 11:36 PM Ramiro Polla > > wrote: > >> > >> --- > >> doc/ffplay.texi | 2 ++ > >> fftools/ffplay.c | 6 +-

Re: [FFmpeg-devel] [PATCH] libavcodec/mjpeg: keep last_dc value unclipped

2024-06-07 Thread Ramiro Polla
On Fri, Jun 7, 2024 at 9:35 PM Andreas Rheinhardt wrote: > Ramiro Polla: > > Do av_clip_int16(val) _after_ copying the value to last_dc. > > > > Related commits: c28f648b19d and dffae122d0f > > Related ticket: 4683 > > --- > > libavcodec/mjpegdec.c|

Re: [FFmpeg-devel] [PATCH 1/4] tests/checkasm: cosmetics, one object per line in Makefile

2024-06-07 Thread Ramiro Polla
On Fri, Jun 7, 2024 at 9:27 PM Andreas Rheinhardt wrote: > > Ramiro Polla: > > # swscale tests > > -SWSCALEOBJS += sw_gbrp.o sw_rgb.o sw_scale.o > > +SWSCALEOBJS += sw_gbrp.o \ > > +

[FFmpeg-devel] [PATCH] libavcodec/mjpeg: keep last_dc value unclipped

2024-06-07 Thread Ramiro Polla
Do av_clip_int16(val) _after_ copying the value to last_dc. Related commits: c28f648b19d and dffae122d0f Related ticket: 4683 --- libavcodec/mjpegdec.c| 3 +-- tests/ref/fate/jpg-12bpp | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/libavcodec/mjpegdec.c

Re: [FFmpeg-devel] [PATCH 1/4] tests/checkasm: cosmetics, one object per line in Makefile

2024-06-07 Thread Ramiro Polla
On Fri, Jun 7, 2024 at 8:46 PM Andreas Rheinhardt wrote: > > Ramiro Polla: > > --- > > tests/checkasm/Makefile | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/tests/checkasm/Makefile b/tests/checkasm/Makefile >

Re: [FFmpeg-devel] [PATCH] swscale/x86: add avx2 {lum, chr}ConvertRange

2024-06-07 Thread Ramiro Polla
On Fri, Jun 7, 2024 at 7:38 PM Ramiro Polla wrote: > > chrRangeFromJpeg_8_c: 49.4 > chrRangeFromJpeg_8_sse4: 15.9 > chrRangeFromJpeg_8_avx2: 22.6 > chrRangeFromJpeg_24_c: 129.4 > chrRangeFromJpeg_24_sse4: 32.1 > chrRangeFromJpeg_24_avx2: 35.1 > chrRa

[FFmpeg-devel] [PATCH] swscale/x86: add avx2 {lum, chr}ConvertRange

2024-06-07 Thread Ramiro Polla
chrRangeFromJpeg_8_c: 49.4 chrRangeFromJpeg_8_sse4: 15.9 chrRangeFromJpeg_8_avx2: 22.6 chrRangeFromJpeg_24_c: 129.4 chrRangeFromJpeg_24_sse4: 32.1 chrRangeFromJpeg_24_avx2: 35.1 chrRangeFromJpeg_128_c: 534.6 chrRangeFromJpeg_128_sse4: 165.6 chrRangeFromJpeg_128_avx2: 100.4 chrRangeFromJpeg_144_c:

Re: [FFmpeg-devel] [PATCH 3/4] swscale/x86: add sse4 {lum, chr}ConvertRange

2024-06-07 Thread Ramiro Polla
On Fri, Jun 7, 2024 at 4:05 PM Ramiro Polla wrote: > > chrRangeFromJpeg_8_c: 19.9 > chrRangeFromJpeg_8_sse4: 16.2 > chrRangeFromJpeg_24_c: 60.7 > chrRangeFromJpeg_24_sse4: 28.9 > chrRangeFromJpeg_128_c: 325.7 > chrRangeFromJpeg_128_sse4: 160.2 > chrRa

[FFmpeg-devel] [PATCH 4/4] swscale/aarch64: add neon {lum, chr}ConvertRange

2024-06-07 Thread Ramiro Polla
/range_convert_neon.S new file mode 100644 index 00..5e104971f0 --- /dev/null +++ b/libswscale/aarch64/range_convert_neon.S @@ -0,0 +1,103 @@ +/* + * Copyright (c) 2024 Ramiro Polla + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under

[FFmpeg-devel] [PATCH 3/4] swscale/x86: add sse4 {lum, chr}ConvertRange

2024-06-07 Thread Ramiro Polla
mode 100644 index 00..333265fb65 --- /dev/null +++ b/libswscale/x86/range_convert.asm @@ -0,0 +1,100 @@ +;** +;* Copyright (c) 2024 Ramiro Polla +;* +;* This file is part of FFmpeg. +;* +;* FFmpeg is free software

[FFmpeg-devel] [PATCH 2/4] checkasm: add tests for {lum, chr}ConvertRange

2024-06-07 Thread Ramiro Polla
--- tests/checkasm/Makefile | 1 + tests/checkasm/checkasm.c | 1 + tests/checkasm/checkasm.h | 1 + tests/checkasm/sw_range_convert.c | 134 ++ 4 files changed, 137 insertions(+) create mode 100644 tests/checkasm/sw_range_convert.c

[FFmpeg-devel] [PATCH 1/4] tests/checkasm: cosmetics, one object per line in Makefile

2024-06-07 Thread Ramiro Polla
--- tests/checkasm/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/checkasm/Makefile b/tests/checkasm/Makefile index 6eb94d10d5..3ce152e818 100644 --- a/tests/checkasm/Makefile +++ b/tests/checkasm/Makefile @@ -63,7 +63,9 @@

Re: [FFmpeg-devel] [PATCH] libswscale/x86/yuv_2_rgb: fix some comments

2024-06-05 Thread Ramiro Polla
On Tue, Jun 4, 2024 at 3:15 PM Ramiro Polla wrote: > > --- > libswscale/x86/yuv_2_rgb.asm | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libswscale/x86/yuv_2_rgb.asm b/libswscale/x86/yuv_2_rgb.asm > index e3470fd9ad..a1f9134e08 100644 &

Re: [FFmpeg-devel] [PATCH] libavcodec/libxvid: code cleanup (replace magic numbers)

2024-06-05 Thread Ramiro Polla
On Tue, Jun 4, 2024 at 2:54 PM Ramiro Polla wrote: > On Thu, May 30, 2024 at 11:24 PM Sean McGovern wrote: > > On Thu, May 30, 2024 at 5:20 PM Ramiro Polla wrote: > > > > > > --- > > > libavcodec/libxvid.c | 4 ++-- > > > 1 file changed, 2 inserti

Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: give magic number a name

2024-06-05 Thread Ramiro Polla
On Wed, Jun 5, 2024 at 1:51 AM Michael Niedermayer wrote: > On Tue, Jun 04, 2024 at 03:05:35PM +0200, Ramiro Polla wrote: > > --- > > libavcodec/mpegvideo_enc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > LGTM Pushed. ___

[FFmpeg-devel] [PATCH] libswscale/x86/yuv_2_rgb: fix some comments

2024-06-04 Thread Ramiro Polla
--- libswscale/x86/yuv_2_rgb.asm | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libswscale/x86/yuv_2_rgb.asm b/libswscale/x86/yuv_2_rgb.asm index e3470fd9ad..a1f9134e08 100644 --- a/libswscale/x86/yuv_2_rgb.asm +++ b/libswscale/x86/yuv_2_rgb.asm @@ -195,15 +195,15 @@

[FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: give magic number a name

2024-06-04 Thread Ramiro Polla
--- libavcodec/mpegvideo_enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index 73a9082265..82bab43e14 100644 --- a/libavcodec/mpegvideo_enc.c +++ b/libavcodec/mpegvideo_enc.c @@ -562,7 +562,7 @@ av_cold int

Re: [FFmpeg-devel] [PATCH 1/2] ffplay: add -scaling_quality option for SDL

2024-06-04 Thread Ramiro Polla
On Thu, May 30, 2024 at 11:36 PM Ramiro Polla wrote: > > --- > doc/ffplay.texi | 2 ++ > fftools/ffplay.c | 6 +- > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/doc/ffplay.texi b/doc/ffplay.texi > index 93f77eeece..60f883e159 100644 > --- a/

Re: [FFmpeg-devel] [PATCH] libavcodec/libxvid: code cleanup (replace magic numbers)

2024-06-04 Thread Ramiro Polla
On Thu, May 30, 2024 at 11:24 PM Sean McGovern wrote: > On Thu, May 30, 2024 at 5:20 PM Ramiro Polla wrote: > > > > --- > > libavcodec/libxvid.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/libavcodec/libxvid.c b/li

[FFmpeg-devel] [PATCH 2/2] ffplay: set default scaling_quality to "best" instead of "linear"

2024-05-30 Thread Ramiro Polla
These values are aliases in SDL, but "best" is a more intuitive name. --- doc/ffplay.texi | 2 +- fftools/ffplay.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/ffplay.texi b/doc/ffplay.texi index 60f883e159..e7ff62ae16 100644 --- a/doc/ffplay.texi +++

[FFmpeg-devel] [PATCH 1/2] ffplay: add -scaling_quality option for SDL

2024-05-30 Thread Ramiro Polla
--- doc/ffplay.texi | 2 ++ fftools/ffplay.c | 6 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/doc/ffplay.texi b/doc/ffplay.texi index 93f77eeece..60f883e159 100644 --- a/doc/ffplay.texi +++ b/doc/ffplay.texi @@ -72,6 +72,8 @@ as 100. Force format. @item -window_title

[FFmpeg-devel] [PATCH] libavcodec/libxvid: code cleanup (replace magic numbers)

2024-05-30 Thread Ramiro Polla
--- libavcodec/libxvid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/libxvid.c b/libavcodec/libxvid.c index b9ac39429d..a490f16b3f 100644 --- a/libavcodec/libxvid.c +++ b/libavcodec/libxvid.c @@ -422,13 +422,13 @@ static av_cold int

Re: [FFmpeg-devel] [PATCH v3 1/2] checkasm: add test for fdct

2024-05-13 Thread Ramiro Polla
On Mon, May 13, 2024 at 6:49 PM James Almer wrote: > On 5/6/2024 2:49 PM, Rémi Denis-Courmont wrote: > > Le maanantaina 6. toukokuuta 2024, 20.18.11 EEST Ramiro Polla a écrit : > >> I'll send a similar patch to fix checkasm/idctdsp after this is merged. > > > > The

Re: [FFmpeg-devel] [PATCH v3 0/2] lavc/aarch64/fdct: add neon-optimized fdct for aarch64

2024-05-13 Thread Ramiro Polla
On Wed, Apr 17, 2024 at 10:49 PM Martin Storsjö wrote: > On Wed, 17 Apr 2024, Ramiro Polla wrote: > > This patch set adds fdct to checkasm and neon-optimized fdct for aarch64. > > > > Ramiro Polla (2): > > checkasm: add test for fdct > > lavc/aarch64/fdct: ad

Re: [FFmpeg-devel] [PATCH] lavc/aarch64: fix include for cpu.h

2024-05-13 Thread Ramiro Polla
On Mon, May 13, 2024 at 12:15 PM Martin Storsjö wrote: > On Sat, 11 May 2024, Ramiro Polla wrote: > > On Sun, Jan 21, 2024 at 10:57 PM Ramiro Polla > > wrote: > >> > >> --- > >> libavcodec/aarch64/idctdsp_init_aarch64.c | 2 +- > >> 1 file ch

Re: [FFmpeg-devel] [PATCH v4 1/2] checkasm: add test for fdct

2024-05-11 Thread Ramiro Polla
On Sat, May 11, 2024 at 10:32 AM Ramiro Polla wrote: > On Mon, May 6, 2024 at 7:46 PM Rémi Denis-Courmont wrote: [...] > > No objections from me, but it would be nice and seemingly trivial to add 9 > > and > > 10 bits while at it. [...] > I'll add checks for the 9 and 10

Re: [FFmpeg-devel] [PATCH v4 1/2] checkasm: add test for fdct

2024-05-11 Thread Ramiro Polla
On Mon, May 6, 2024 at 7:46 PM Rémi Denis-Courmont wrote: > Le maanantaina 6. toukokuuta 2024, 20.18.39 EEST Ramiro Polla a écrit : > > Reviewed-by: Martin Storsjö > > Reviewed-by: Rémi Denis-Courmont > > --- > > tests/checkasm/Makefile | 1 + > >

Re: [FFmpeg-devel] [PATCH] lavc/aarch64: fix include for cpu.h

2024-05-11 Thread Ramiro Polla
On Sun, Jan 21, 2024 at 10:57 PM Ramiro Polla wrote: > > --- > libavcodec/aarch64/idctdsp_init_aarch64.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/aarch64/idctdsp_init_aarch64.c > b/libavcodec/aarch64/idctdsp_init_aarch64

Re: [FFmpeg-devel] [PATCH v2 1/2] libavcodec/mpegvideo_enc: fix multi-threaded motion estimation rounding for mpeg4

2024-05-11 Thread Ramiro Polla
On Thu, May 9, 2024 at 2:44 AM Michael Niedermayer wrote: > On Wed, May 08, 2024 at 05:19:49PM +0200, Ramiro Polla wrote: > > ff_init_me() was being called after ff_update_duplicate_context(), > > which caused the propagation of the initialization to other thread > > contexts

Re: [FFmpeg-devel] [PATCH v2 2/2] libavcodec/motion_est: fix penalty_factor for b frames

2024-05-11 Thread Ramiro Polla
On Wed, May 8, 2024 at 11:47 PM Michael Niedermayer wrote: > On Wed, May 08, 2024 at 05:19:50PM +0200, Ramiro Polla wrote: > > In direct_search() and ff_estimate_b_frame_motion(), penalty_factor > > would be used before being initialized in estimate_motion_b(). Also, > > the

[FFmpeg-devel] [PATCH v2 2/2] libavcodec/motion_est: fix penalty_factor for b frames

2024-05-08 Thread Ramiro Polla
In direct_search() and ff_estimate_b_frame_motion(), penalty_factor would be used before being initialized in estimate_motion_b(). Also, the initialization would happen more than once unnecessarily. --- libavcodec/motion_est.c | 15 ---

[FFmpeg-devel] [PATCH v2 1/2] libavcodec/mpegvideo_enc: fix multi-threaded motion estimation rounding for mpeg4

2024-05-08 Thread Ramiro Polla
ff_init_me() was being called after ff_update_duplicate_context(), which caused the propagation of the initialization to other thread contexts to be delayed by one frame. In the case of mpeg4 (or flipflop_rounding), this would make the hpel_put functions differ between the first thread (which

[FFmpeg-devel] [PATCH v4 1/2] checkasm: add test for fdct

2024-05-06 Thread Ramiro Polla
Reviewed-by: Martin Storsjö Reviewed-by: Rémi Denis-Courmont --- tests/checkasm/Makefile | 1 + tests/checkasm/checkasm.c | 3 ++ tests/checkasm/checkasm.h | 1 + tests/checkasm/fdctdsp.c | 71 +++ tests/fate/checkasm.mak | 1 + 5 files changed, 77

Re: [FFmpeg-devel] [PATCH v3 1/2] checkasm: add test for fdct

2024-05-06 Thread Ramiro Polla
On Thu, May 2, 2024 at 8:05 PM Rémi Denis-Courmont wrote: > Le keskiviikkona 17. huhtikuuta 2024, 21.01.37 EEST Ramiro Polla a écrit : [...] > > +static void check_fdct(void) > > +{ > > +LOCAL_ALIGNED_16(int16_t, block0, [64]); > > +LOCAL_ALIG

[FFmpeg-devel] [PATCH v3 2/2] lavc/aarch64/fdct: add neon-optimized fdct for aarch64

2024-04-17 Thread Ramiro Polla
The code is imported from libjpeg-turbo-3.0.1. The neon registers used have been changed to avoid modifying v8-v15. Reviewed-by: Martin Storsjö --- libavcodec/aarch64/Makefile | 2 + libavcodec/aarch64/fdct.h | 26 ++ libavcodec/aarch64/fdctdsp_init_aarch64.c |

[FFmpeg-devel] [PATCH v3 1/2] checkasm: add test for fdct

2024-04-17 Thread Ramiro Polla
Reviewed-by: Martin Storsjö --- tests/checkasm/Makefile | 1 + tests/checkasm/checkasm.c | 3 ++ tests/checkasm/checkasm.h | 1 + tests/checkasm/fdctdsp.c | 68 +++ tests/fate/checkasm.mak | 1 + 5 files changed, 74 insertions(+) create mode 100644

[FFmpeg-devel] [PATCH v3 0/2] lavc/aarch64/fdct: add neon-optimized fdct for aarch64

2024-04-17 Thread Ramiro Polla
This patch set adds fdct to checkasm and neon-optimized fdct for aarch64. Ramiro Polla (2): checkasm: add test for fdct lavc/aarch64/fdct: add neon-optimized fdct for aarch64 libavcodec/aarch64/Makefile | 2 + libavcodec/aarch64/fdct.h | 26 ++ libavcodec

[FFmpeg-devel] [PATCH v2] lavc/aarch64/fdct: add neon-optimized fdct for aarch64

2024-04-16 Thread Ramiro Polla
The code is imported from libjpeg-turbo-3.0.1. The neon registers used have been changed to avoid modifying v8-v15. --- libavcodec/aarch64/Makefile | 2 + libavcodec/aarch64/fdct.h | 26 ++ libavcodec/aarch64/fdctdsp_init_aarch64.c | 39 +++

Re: [FFmpeg-devel] [PATCH] lavc/aarch64/fdct: add neon-optimized fdct for aarch64

2024-04-16 Thread Ramiro Polla
Hi, On Wed, Feb 14, 2024 at 10:42 AM Martin Storsjö wrote: > On Sun, 4 Feb 2024, Ramiro Polla wrote: > > > The code is imported from libjpeg-turbo-3.0.1. The neon registers used > > have been changed to avoid modifying v8-v15. > > --- > > I don't remember if we h

Re: [FFmpeg-devel] [PATCH] lavc/aarch64/fdct: add neon-optimized fdct for aarch64

2024-03-06 Thread Ramiro Polla
ping On Sun, Feb 4, 2024 at 3:42 PM Ramiro Polla wrote: > > The code is imported from libjpeg-turbo-3.0.1. The neon registers used > have been changed to avoid modifying v8-v15. > --- > libavcodec/aarch64/Makefile | 2 + > libavcodec/aarch64/fdct.h

[FFmpeg-devel] [PATCH] lavc/aarch64/fdct: add neon-optimized fdct for aarch64

2024-02-04 Thread Ramiro Polla
The code is imported from libjpeg-turbo-3.0.1. The neon registers used have been changed to avoid modifying v8-v15. --- libavcodec/aarch64/Makefile | 2 + libavcodec/aarch64/fdct.h | 26 ++ libavcodec/aarch64/fdctdsp_init_aarch64.c | 39 +++

[FFmpeg-devel] [PATCH] lavc/aarch64: fix include for cpu.h

2024-01-21 Thread Ramiro Polla
--- libavcodec/aarch64/idctdsp_init_aarch64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aarch64/idctdsp_init_aarch64.c b/libavcodec/aarch64/idctdsp_init_aarch64.c index eec21aa5a2..8efd5f5323 100644 --- a/libavcodec/aarch64/idctdsp_init_aarch64.c +++

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/motion_est: fix penalty_factor for b frames

2020-03-23 Thread Ramiro Polla
On Mon, Mar 23, 2020 at 10:42 PM Michael Niedermayer wrote: > On Sun, Mar 22, 2020 at 04:55:25PM +0100, Ramiro Polla wrote: > > In ff_estimate_b_frame_motion(), penalty_factor would be used before > > being initialized in estimate_motion_b(). Also, the initialization > > w

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add my gpg fingerprint

2020-03-23 Thread Ramiro Polla
Hi Michael, On Mon, Mar 23, 2020 at 8:44 PM Michael Niedermayer wrote: > > On Mon, Mar 23, 2020 at 04:11:04AM +0100, Ramiro Polla wrote: > > --- > > MAINTAINERS | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS >

[FFmpeg-devel] [PATCH] MAINTAINERS: add my gpg fingerprint

2020-03-22 Thread Ramiro Polla
6571 13A3 33D9 3726 F728 AA98 F643 B12E ECF3 E029 Peter RossA907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B Philip Langdale 5DC5 8D66 5FBA 3A43 18EC 045E F8D6 B194 6A75 682E +Ramiro Polla 1E0D 3820 ACCB 36AF 97B4 F18C 648E 2B0A E905 E26A

[FFmpeg-devel] [PATCH 1/2] avcodec/mpegvideo_enc: fix multi-threaded motion estimation rounding for mpeg4

2020-03-22 Thread Ramiro Polla
ff_init_me() was being called after ff_update_duplicate_context(), which caused the propagation of the initialization to other thread contexts to be delayed by one frame. In the case of mpeg4 (or flipflop_rounding), this would make the hpel_put functions differ between the first thread (which

[FFmpeg-devel] [PATCH 2/2] avcodec/motion_est: fix penalty_factor for b frames

2020-03-22 Thread Ramiro Polla
In ff_estimate_b_frame_motion(), penalty_factor would be used before being initialized in estimate_motion_b(). Also, the initialization would happen more than once unnecessarily. --- libavcodec/motion_est.c | 15 --- tests/ref/vsynth/vsynth2-mpeg2-422 | 6

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/get_bits: cosmetics

2020-03-22 Thread Ramiro Polla
On Tue, Nov 5, 2019 at 2:35 PM Michael Niedermayer wrote: > On Tue, Nov 05, 2019 at 11:13:49AM +0100, Ramiro Polla wrote: > > libavcodec/get_bits.h | 8 > > 1 file changed, 4 insertions(+), 4 deletions(-) > > LGTM ping ___

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/wmadec: cosmetics

2020-03-22 Thread Ramiro Polla
On Tue, Nov 5, 2019 at 2:35 PM Michael Niedermayer wrote: > On Tue, Nov 05, 2019 at 11:13:50AM +0100, Ramiro Polla wrote: > > libavcodec/wmadec.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > LGTM ping ___ ffmp

  1   2   >