> On Sep 3, 2023, at 11:53 PM, Jun Zhao wrote:
>
> Dump the encoder, it's will help debug some case
>
> Signed-off-by: Jun Zhao
> ---
> libavcodec/videotoolboxenc.c | 20
> 1 file changed, 20 insertions(+)
>
> diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videot
> On Sep 1, 2023, at 12:07 AM, myp...@gmail.com wrote:
>
> On Fri, Sep 1, 2023 at 11:50 AM "zhilizhao(赵志立)"
> wrote:
>>
>>
>>
On Sep 1, 2023, at 09:13, myp...@gmail.com wrote:
>>>
>>> On Fri, Sep 1, 2023 at 2:13 AM Zhao Zhili wrote:
> From: ffmpeg-devel On Behalf Of
> On May 1, 2022, at 1:31 PM, Simone Karin Lehmann wrote:
>
> Hi,
>
> may I kindly ask you to check, if this patch could now be applied?
I’ll look at it today.
>
> Regards
> Simone
>
> Von meinem iPad gesendet
>
>> Am 25.04.2022 um 22:33 schrieb Simone Karin Lehmann :
>>
>>
>>
>
> On Aug 13, 2021, at 9:12 AM, Nicolas George wrote:
>
> Anselm Busse (12021-08-13):
>> Fix for bug #9231: B-frames parameter is ignored in videotoolboxenc
>
> To whoever pushed this: this is not a correct first line for a commit
> message. It should have been something like:
>
> libavc/vide
> On Feb 22, 2021, at 6:13 PM, Nomis101 wrote:
>
> Hi,
>
> back in January it was asked if it would be possible to add constant quality
> encoding for videotoolbox on macOS to FFmpeg. Later, somebody provided a
> patch.
> http://ffmpeg.org/pipermail/ffmpeg-devel/2021-January/274989.html
>
> On Sep 10, 2020, at 11:13 AM, Zhao Zhili wrote:
>
>
>> 在 2020年9月10日，下午10:21，Richard Kern 写道：
>>
>>
>>
>>>> On Sep 10, 2020, at 8:57 AM, zhilizhao wrote:
>>>
>>>
>>>
>>>>> On Aug 28, 2020, at
> On Sep 10, 2020, at 8:57 AM, zhilizhao wrote:
>
>
>
>> On Aug 28, 2020, at 8:55 AM, Steven Liu wrote:
>>
>> 于2020年8月27日周四 下午5:39写道：
>>>
>>> From: Zhao Zhili
>>>
>>> The lock is used in clear_frame_queue().
>>> ---
>>> libavcodec/videotoolboxenc.c | 11 +++
>>> 1 file changed,
> On Nov 16, 2019, at 7:03 PM, Nomis101 wrote:
>
> Thanks for reviewing. Would be nice, if somebody could push to master then.
> I can't.
>
>
I’ll test it out tomorrow and push.
>
>> Am 15.11.19 um 15:58 schrieb Limin Wang:
>>> On Sun, Nov 03, 2019 at 01:20:38AM +0100, Nomis101 wrote:
>>
I’ll look at it this weekend.
> On Aug 27, 2019, at 10:40 AM, Limin Wang wrote:
>
>
> ping the patchset.
>
>> On Tue, Aug 20, 2019 at 07:04:29PM +0800, lance.lmw...@gmail.com wrote:
>> From: Limin Wang
>>
>> Signed-off-by: Limin Wang
>> ---
>> libavcodec/videotoolboxenc.c | 14
> On Jun 15, 2019, at 7:54 PM, Lance Wang wrote:
>
>> On Fri, Jun 7, 2019 at 11:13 PM wrote:
>>
>> From: Limin Wang
>>
>> Signed-off-by: Limin Wang
>> ---
>> libavcodec/videotoolboxenc.c | 5 +
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/libavcodec/videotoolboxenc.c b/libavcod
On June 17, 2017 at 6:46:58 PM, Steven Liu (lingjiujia...@gmail.com) wrote:
2017-06-17 11:17 GMT+08:00 姜 文杰 :
> when use videotoolboxencoder in ffmpeg, some codes will lead to crash.
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://
On March 14, 2017 at 10:54:47 AM, Steven Liu (l...@chinaffmpeg.org) wrote:
add kVTCompressionPropertyKey_DataRateLimits support by rc_max_bitrate
Reviewed-by: Rick Kern
Signed-off-by: Steven Liu
---
libavcodec/videotoolboxenc.c | 47
1 file changed, 4
On March 12, 2017 at 11:55:55 PM, Steven Liu (l...@chinaffmpeg.org) wrote:
add kVTCompressionPropertyKey_DataRateLimits support by rc_max_bitrate
Signed-off-by: Steven Liu
---
libavcodec/videotoolboxenc.c | 27 +++
1 file changed, 27 insertions(+)
diff --git a/libavcodec/
On February 6, 2017 at 8:39:30 PM, Aman Gupta (ffm...@tmm1.net) wrote:
Last October, kernrj and I commited a series of patches to add a53cc
support to the videotoolbox encoder.
In using that feature over the past few months, I've discovered that the
generated streams can sometimes contain random/
> On Oct 19, 2016, at 8:45 PM, Aman Gupta wrote:
>
> From: Aman Gupta
>
> ff_videotoolbox_avcc_extradata_create() was never being called if
> avctx->extradata_size==0, even though the function does not need or use
> the avctx->extradata.
Could this be a bug in another part of the code? It see
> On Oct 18, 2016, at 2:30 PM, Aman Gupta wrote:
>
>
>
> On Mon, Oct 17, 2016 at 6:03 PM, Aman Gupta <mailto:ffm...@tmm1.net>> wrote:
>
>
> On Mon, Oct 17, 2016 at 5:51 PM, Richard Kern <mailto:ker...@gmail.com>> wrote:
>
>> On Oct 17,
> On Oct 17, 2016, at 8:47 PM, Aman Gupta wrote:
>
>
>
> On Mon, Oct 17, 2016 at 6:35 AM, Richard Kern <mailto:ker...@gmail.com>> wrote:
>
>> On Sep 19, 2016, at 10:30 AM, Aman Gupta > <mailto:ffm...@tmm1.net>> wrote:
>>
>>
>>
> On Sep 19, 2016, at 10:30 AM, Aman Gupta wrote:
>
>
>
> On Monday, September 19, 2016, Richard Kern <mailto:ker...@gmail.com>> wrote:
>
>> On Sep 10, 2016, at 10:33 PM, Aman Gupta > wrote:
>>
>>
>>
>> On Sunday, September 11,
> On Sep 10, 2016, at 10:33 PM, Aman Gupta wrote:
>
>
>
> On Sunday, September 11, 2016, Richard Kern <mailto:ker...@gmail.com>> wrote:
>
> > On Sep 8, 2016, at 4:19 AM, Aman Gupta > wrote:
> >
> > From: Aman Gupta >
> On Sep 8, 2016, at 4:19 AM, Aman Gupta wrote:
>
> From: Aman Gupta
>
> ---
> libavcodec/videotoolboxenc.c | 76 ++--
> 1 file changed, 67 insertions(+), 9 deletions(-)
>
> diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
> index
> On Jun 27, 2016, at 11:18 AM, Michael Niedermayer
> wrote:
>
> On Mon, Jun 27, 2016 at 10:55:08AM -0400, Richard Kern wrote:
>>
>>> On Jun 27, 2016, at 10:29 AM, Michael Niedermayer
>>> wrote:
>>>
>>> Some entries fr
> On Jun 27, 2016, at 10:29 AM, Michael Niedermayer
> wrote:
>
> Some entries from the changelog are used
> ---
> src/index | 27 +++
> 1 file changed, 27 insertions(+)
>
> diff --git a/src/index b/src/index
> index ff0caf2..79a71e8 100644
> --- a/src/index
> +++ b/src
> On Jun 27, 2016, at 4:58 AM, Michael Niedermayer
> wrote:
>
> On Sun, Jun 26, 2016 at 08:24:49PM -0400, Rick Kern wrote:
>> decklink_common.cpp includes a .cpp file from the DeckLink API which fails
>> to build because there are non-static functions in the included .cpp file.
>> This disables
> On Jun 26, 2016, at 11:03 PM, Roger Pack wrote:
>
> could you post a copy of the compile failure for reference?
See below - the error is only generated when -I is used.
g++ -I. -Isrc/ -D_ISOC99_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
-I/Users/rick/projects/ffmpeg/compat/dispatch_s
> On Jun 25, 2016, at 3:16 PM, Michael Niedermayer
> wrote:
>
> On Sat, Jun 25, 2016 at 05:29:56PM +, Carl Eugen Hoyos wrote:
>> Michael Niedermayer niedermayer.cc> writes:
>>
>>> why does this happen ?
>>
>> I thought it happens because FFmpeg include third-party
>> files that do not c
> On Jun 26, 2016, at 6:20 PM, Michael Niedermayer
> wrote:
>
> On Sun, Jun 26, 2016 at 06:00:41PM -0400, Richard Kern wrote:
>>
>>> On Jun 26, 2016, at 5:55 PM, Michael Niedermayer
>>> wrote:
>>>
>>> On Sun, Jun 26, 2016 at 05:44:11PM
> On Jun 26, 2016, at 5:55 PM, Michael Niedermayer
> wrote:
>
> On Sun, Jun 26, 2016 at 05:44:11PM -0400, Richard Kern wrote:
>>
>>> On Jun 26, 2016, at 5:26 PM, Michael Niedermayer
>>> wrote:
>>>
>>> On Sun, Jun 26, 2016 at 05:22:01PM
> On Jun 26, 2016, at 5:26 PM, Michael Niedermayer
> wrote:
>
> On Sun, Jun 26, 2016 at 05:22:01PM -0400, Richard Kern wrote:
>>
>>> On Jun 26, 2016, at 5:10 PM, Michael Niedermayer
>>> wrote:
>>>
>>> On Sun, Jun 26, 2016 at 04:4
> On Jun 26, 2016, at 5:10 PM, Michael Niedermayer
> wrote:
>
> On Sun, Jun 26, 2016 at 04:44:40PM -0400, Rick Kern wrote:
>> Use c++98 standard instead of c++11.
>>
>> Signed-off-by: Rick Kern
>> ---
>> configure | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/con
> On Jun 26, 2016, at 4:10 PM, James Almer wrote:
>
> On 6/23/2016 8:08 PM, Rick Kern wrote:
>> Fixes #4124: Invalid argument '-std=c99' not allowed with 'C++/ObjC++'
>> C++ files fail to compile. This adds '-std=c++11' to CXX_FLAGS to fix.
>>
>> Signed-off-by: Rick Kern
>> ---
>> common.mak |
> On Jun 23, 2016, at 8:06 PM, Carl Eugen Hoyos wrote:
>
> Rick Kern gmail.com> writes:
>
>> This temporarily disables the missing-prototypes error so
>> the file can be included.
>
> Can't you add -Wno-error=missing-prototypes to the cxx flags
> just as you did in 1/2?
This was just disab
> On Jun 21, 2016, at 11:48 AM, Matthieu Bouron
> wrote:
>
> From: Matthieu Bouron
>
> Fixes properly ticket #5638.
>
> Since 772ad7142dff590c7bb30370acf5d3c9a8fb512b PPS and SPS contain the
> nal type byte.
>
> This reverts commit b8d754c5d0a2e99022c27bd1159ea3f597f67452.
> This reverts co
> On Jun 19, 2016, at 6:11 PM, Dan Dennedy wrote:
>
> Fixes error:
> libavcodec/videotoolbox.c:511:18: error: implicit declaration of
> function 'CMVideoFormatDescriptionCreateFromH264ParameterSets' is
> invalid in C99
>
> This was added in 10.9:
> https://developer.apple.com/reference/coremedi
> On Jun 17, 2016, at 10:36 AM, Clément Bœsch wrote:
>
> On Fri, Jun 17, 2016 at 09:43:09AM -0400, Richard Kern wrote:
>> Since ca2f19b9cc (h264: switch to h2645_parse for NAL parsing) the hwaccel
>> wouldn’t init (when the first h.264 frame is decoded). It was the sam
> On Jun 17, 2016, at 10:10 AM, Clément Bœsch wrote:
>
> $subj
>
> (sorry no mac available right now)
OS X works fine. I can test iOS later today if you like, but it’s small. LGTM.
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> htt
> On Jun 17, 2016, at 5:31 AM, Clément Bœsch wrote:
>
> On Fri, Jun 17, 2016 at 03:24:10AM +0200, Rick Kern wrote:
>> ffmpeg | branch: master | Rick Kern | Wed Jun 1 21:40:22
>> 2016 -0400| [8e47a99f576da10b2a36e33b6b9acbf1c2da7485] | committer: Rick Kern
>>
>> lavc/videotoolbox: fix H.264 h
> On Jun 2, 2016, at 2:32 AM, Rick Kern wrote:
>
> AudioConverterFillComplexBuffer() doesn't always call its callback. A frame
> queue is used to prevent skipped audio samples.
>
> Signed-off-by: Rick Kern
> ---
> libavcodec/audiotoolboxenc.c | 78 +---
>
> On Jun 8, 2016, at 5:48 AM, Michael Niedermayer
> wrote:
>
> On Thu, Jun 02, 2016 at 02:43:56AM -0400, Rick Kern wrote:
>> VideoToolbox doesn't supply parameter sets until the first frame is done
>> encoding. This spins up a temporary encoder and encodes a single frame to
>> get this data.
>>
> On Jun 6, 2016, at 9:00 AM, Richard Kern wrote:
>
> Ping. This fixes #5595.
>
>> On Jun 1, 2016, at 10:06 PM, Rick Kern wrote:
>>
>> Fixes VTDecompressionSessionCreate() error.
>>
>> Signed-off-by: Rick Kern
Ping.
> On Jun 2, 2016, at 2:32 AM, Rick Kern wrote:
>
> AudioConverterFillComplexBuffer() doesn't always call its callback. A frame
> queue is used to prevent skipped audio samples.
>
> Signed-off-by: Rick Kern
> ---
> libavcodec/audiotoolboxenc.c | 78 +---
Apple confirmed there’s no way to get the parameter sets earlier through
VideoToolbox. If no one reviews, I’ll push in about 24 h.
> On Jun 2, 2016, at 2:43 AM, Rick Kern wrote:
>
> VideoToolbox doesn't supply parameter sets until the first frame is done
> encoding. This spins up a temporary en
Ping. This fixes #5595.
> On Jun 1, 2016, at 10:06 PM, Rick Kern wrote:
>
> Fixes VTDecompressionSessionCreate() error.
>
> Signed-off-by: Rick Kern
> ---
> libavcodec/videotoolbox.c | 59 ---
> 1 file changed, 45 insertions(+), 14 deletions(-)
>
>
> On May 5, 2016, at 9:35 AM, Derek Buitenhuis
> wrote:
>
> On 5/5/2016 2:08 PM, Rick Kern wrote:
>> Fixes "Could not find codec parameters for stream" error (#5494)
>>
>> Signed-off-by: Rick Kern
>> ---
>> libavdevice/avfoundation.m | 26 +-
>> 1 file changed, 13 inser
ping
> On Apr 27, 2016, at 10:53 AM, Rick Kern wrote:
>
> Updates from code review:
> Have allow_sw for both OS X and iOS
> Changed "entropy" option to "coder" to match libx264
> Updated configure for CONFIG_VT_BT2020 macro
> Bool option usage
> Formatting
>
>
> Rick Kern (12):
> lavc/videoto
> On Apr 26, 2016, at 8:14 AM, Carl Eugen Hoyos wrote:
>
> Richard Kern gmail.com> writes:
>
>>>> static const enum AVPixelFormat pix_fmts[] = {
>>>>AV_PIX_FMT_NV12,
>>>> -#if !TARGET_OS_IPHONE
>>>>AV_PIX_FMT_YUV420P,
&
> On Apr 23, 2016, at 12:23 PM, Carl Eugen Hoyos wrote:
>
> Rick Kern gmail.com> writes:
>
>> +if(!*refPtr) return;
>
> Is this needed (I don't know)?
> If yes, please make it two lines.
>
>> +CFRelease(*refPtr);
>> +*refPtr = NULL;
>> +switch (fmt) {
>> +case AV_PIX_
> On Apr 23, 2016, at 12:25 PM, Carl Eugen Hoyos wrote:
>
> Rick Kern gmail.com> writes:
>
>> +#if !TARGET_OS_IPHONE
>> +{ "allow_sw", "Allow software encoding", OFFSET(allow_sw),
>
> I have no strong opinion, but shouldn't the option
> always exist (but only work in some cases)?
iOS do
> On Apr 10, 2016, at 12:27 AM, Carl Eugen Hoyos wrote:
>
> Rick Kern gmail.com> writes:
>
>> +enabled kCVImageBufferColorPrimaries_ITU_R_2020 &&
>> add_cppflags -DHAVE_VT_BT2020_KEYS
>
> This is not ok, the define should be added to config.h.
>
>> +#ifndef HAVE_VT_BT2020_KEYS
>> +# define
> On Apr 10, 2016, at 12:24 AM, Carl Eugen Hoyos wrote:
>
> Rick Kern gmail.com> writes:
>
>> +if (status) {
>> +av_log(
>> + avctx,
>> + AV_LOG_ERROR,
>> + "Error setting pixel aspect ratio to %d:%d: %d.\n",
>
> Why wo
> On Apr 10, 2016, at 3:47 AM, Hendrik Leppkes wrote:
>
> On Sun, Apr 10, 2016 at 6:17 AM, Carl Eugen Hoyos wrote:
>> Rick Kern gmail.com> writes:
>>
>>> Don't require hardware encoding and explicitly fallback to
>>> software if it fails. Enabling it without requiring it
>>> will use hardware
> On Mar 24, 2016, at 1:56 PM, Rick Kern wrote:
>
> CMVideoFormatDescriptionGetH264ParameterSetAtIndex() fails on some
> hardware/OS versions when retrieving the parameter set count alone.
>
> Signed-off-by: Rick Kern
> ---
> libavcodec/videotoolboxenc.c | 43 -
> On Mar 24, 2016, at 12:46 PM, Richard Kern wrote:
>
>>
>> On Mar 25, 2016, at 12:37 AM, wm4 wrote:
>>
>> On Mon, 21 Mar 2016 00:55:56 +0800
>> Rick Kern wrote:
>>
>>> Fixes crash in #5352. VTCompressionSessionInvalidate() crashes if the
> On Mar 25, 2016, at 12:45 AM, wm4 wrote:
>
> On Mon, 21 Mar 2016 19:55:24 +0800
> Rick Kern mailto:ker...@gmail.com>> wrote:
>
>> Fixes bug #5352: Error when fetching parameter sets.
>>
>> Signed-off-by: Rick Kern mailto:ker...@gmail.com>>
>
> Could use some more explanations. A referenced
> On Mar 25, 2016, at 12:37 AM, wm4 wrote:
>
> On Mon, 21 Mar 2016 00:55:56 +0800
> Rick Kern wrote:
>
>> Fixes crash in #5352. VTCompressionSessionInvalidate() crashes if the
>> internal encoder hasn't completed, but hasn't experienced an error. The
>> function call isn't needed since the e
Can this one be reviewed too?
> On Mar 21, 2016, at 12:55 AM, Rick Kern wrote:
>
> Fixes crash in #5352. VTCompressionSessionInvalidate() crashes if the
> internal encoder hasn't completed, but hasn't experienced an error. The
> function call isn't needed since the encoder is invalidated when
Ping - can this be reviewed?
> On Mar 21, 2016, at 7:55 PM, Rick Kern wrote:
>
> Fixes bug #5352: Error when fetching parameter sets.
>
> Signed-off-by: Rick Kern
> ---
> libavcodec/videotoolboxenc.c | 38 --
> 1 file changed, 24 insertions(+), 14 deletions(-
> On Mar 20, 2016, at 11:49 PM, Thilo Borgmann wrote:
>
> Hi,
>
> trying to handle software fallback more consistently for videotoolbox and
> probably other hardware accelerations.
>
> Addresses ticket #5352 where software fallback is demanded which has been
> removed on purpose before. With t
> On Mar 3, 2016, at 11:46 AM, Rodger Combs wrote:
>
> These macros were added in OS X 10.11, and the file compiles without warnings
> on both 10.10 and 10.11 with them removed.
>
> Thanks to mark4o on IRC for pointing out the failure and testing the patch.
Lgtm - thanks for the quick fix.
> -
> On Mar 2, 2016, at 12:11 AM, wm4 wrote:
>
> On Tue, 01 Mar 2016 14:57:29 +
> Timothy Gu mailto:timothyg...@gmail.com>> wrote:
>
>> Hi,
>>
>> On Mon, Feb 29, 2016 at 9:42 PM Rick Kern wrote:
>>
>>> Autodetected by default. Encode using -codec:v vtenc.
>>>
>>> Signed-off-by: Rick Kern
Please ignore this patch - the options code need to be updated.
> On Feb 29, 2016, at 11:58 PM, wm4 wrote:
>
> On Mon, 29 Feb 2016 23:14:17 +0800
> Rick Kern wrote:
>
>> Autodetected by default. Encode using -codec:v vtenc.
>>
>> Signed-off-by: Rick Kern
>> ---
>
> OK, autodetection seems t
> On Feb 29, 2016, at 11:19 PM, Clément Bœsch wrote:
>
> On Mon, Feb 29, 2016 at 11:14:17PM +0800, Rick Kern wrote:
> [...]
>> +if (!profile) {
>> +//VideoToolbox auto-selects profile and level.
>> +return true;
>> +} else if (!av_strcasecmp("baseline", profile)) {
>> +
> On Feb 16, 2016, at 5:28 PM, wm4 wrote:
>
> On Tue, 16 Feb 2016 09:58:30 +0800
> Rick Kern mailto:ker...@gmail.com>> wrote:
>
>> Enable with configure --enable-vtenc and encode using -codec:v vtenc_h264.
>>
>> Signed-off-by: Rick Kern
>> ---
>> MAINTAINERS|1 +
>> configure
> On Feb 16, 2016, at 5:18 PM, Carl Eugen Hoyos wrote:
>
> wm4 googlemail.com> writes:
>
>> On Tue, 16 Feb 2016 08:32:40 + (UTC)
>> Carl Eugen Hoyos ag.or.at> wrote:
>>
>>> Rick Kern gmail.com> writes:
>>>
+enabled vtenc &&
require VideoToolbox VideoToolbox/VTCom
VideoToolbox Encoder for OSX/iOS: https://github.com/FFmpeg/FFmpeg/pull/177
I submitted a patch a while ago and had it reviewed, but it was never pushed.
Rick
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmp
On Nov 28, 2015, at 5:23 PM, Richard Kern wrote:
>
> On Nov 28, 2015, at 5:07 PM, Timothy Gu wrote:
>>
>> On Sat, Nov 28, 2015 at 02:06:07PM -0500, Rick Kern wrote:
>>> vtenc.c was updated to match the coding style of the project.
>>>
>>> I u
On Nov 28, 2015, at 5:07 PM, Timothy Gu wrote:
>
> On Sat, Nov 28, 2015 at 02:06:07PM -0500, Rick Kern wrote:
>> vtenc.c was updated to match the coding style of the project.
>>
>> I used several other files to get a feel for the project's coding
>> style. Is there documentation for this?
>
> Y
66 matches
Mail list logo
