Philip Langdale, Carl Eugen Hoyos
> - videotoolbox* Rick Kern, Aman Gupta
> + videotoolbox* Rick Kern, Aman Gupta, Zhao Zhili
Sounds good on the videotoolbox files.
>
>
> libavdevice
> --
> 2.25.1
>
>
On Fri, May 26, 2023 at 7:37 AM 徐福隆 <839789...@qq.com> wrote:
> Kern, please help to review this patch, which has added CBP profile with
> profile options.
> As for the VT_H264Profile replacement, let you take over, follow up this
> patch.
>
Thanks. Pushed with minor modifications.
>
> Thanks
>
zhilizhao mentioned.
>
> -- 原始邮件 --
> *发件人:* ""zhilizhao(赵志立)"" ;
> *发送时间:* 2023年5月22日(星期一) 中午11:11
> *收件人:* "FFmpeg development discussions and patches"<
> ffmpeg-devel@ffmpeg.org>;
> *抄送:* "徐福隆"<839789..
On Sun, May 21, 2023 at 7:22 AM xufuji456 <839789...@qq.com> wrote:
> The CBP/CHP profile has available with H264 in iOS 15.0.
> Official Doc:
> https://developer.apple.com/documentation/videotoolbox/kvtprofilelevel_h264_constrainedbaseline_autolevel
>
> Signed-off-by: xufuji456 <839789...@qq.com>
Added support for more VideoToolbox encoder options:
- qmin and qmax options are now used
- max_slice_bytes: Max number of bytes per H.264 slice
- max_ref_frames: Limit the number of reference frames
- Disable open GOP when the cgop flag is set
- power_efficient: Enable power-efficient mode
---
li
On Fri, May 19, 2023 at 2:06 PM Zhao Zhili wrote:
>
> > From: ffmpeg-devel On Behalf Of Rick
> Kern
> > Sent: 2023年5月19日 21:37
> > To: FFmpeg development discussions and patches
> > Cc: zhilizhao(赵志立)
> > Subject: Re: [FFmpeg-devel] 回复： [PATCH] avcode
On Fri, May 19, 2023 at 1:56 AM 徐福隆 <839789...@qq.com> wrote:
> Thank you for your review, and point out the details.
> Actually, I have also considered this issue.
> I see that some keys are used directly, some are used by compatibility.
>
The compat_keys are used for symbols that might not exis
On Sun, Dec 4, 2022 at 12:51 PM Alessandro Di Nepi <
alessandro.din...@gmail.com> wrote:
> On 4 Dec 2022, 17:01 +0200, FFmpeg development discussions and patches <
> ffmpeg-devel@ffmpeg.org>, wrote:
> > When this happens, does it continue happening, or is it transient? My
> main
> > concern is log
On Tue, Nov 29, 2022 at 11:47 AM Alessandro Di Nepi <
alessandro.din...@gmail.com> wrote:
> Just to add that this fix, once approved, should be cherry-picked to all
> the release branches where d7f4ad88a0df3c1339e142957bf2c40cd056b8ce has
> been cherry-picked.
> Basically, 4.4, 5.0, and 5.1.
>
> T
Instead of allocating/freeing, use objpool for data passed from an
input frame to an output packet.
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 80
1 file changed, 71 insertions(+), 9 deletions(-)
diff --git a/libavcodec/videotoolboxenc.c b
Moved objpool to libavutil to make it available outside of fftools.
Signed-off-by: Rick Kern
---
fftools/Makefile | 1 -
fftools/ffmpeg_mux.c | 8
fftools/sync_queue.c | 18 +-
fftools/thread_queue.c | 14
Update inclusion guards in objpool.h start with AVUTIL_ instead of FFTOOLS_.
Rick Kern (2):
fftools/objpool: move objpool to libavutil
lavc/videotoolboxenc: use objectpool for encoder output information
fftools/Makefile | 1 -
fftools/ffmpeg_mux.c | 8
Instead of allocating/freeing, use objpool for data passed from an
input frame to an output packet.
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 80
1 file changed, 71 insertions(+), 9 deletions(-)
diff --git a/libavcodec/videotoolboxenc.c b
Moved objpool to libavutil to make it available outside of fftools.
Signed-off-by: Rick Kern
---
fftools/Makefile | 1 -
fftools/ffmpeg_mux.c | 8
fftools/sync_queue.c | 18 +-
fftools/thread_queue.c | 14
Added 'av' prefix to ObjPool and its functions.
Rick Kern (2):
fftools/objpool: move objpool to libavutil
lavc/videotoolboxenc: use objectpool for encoder output information
fftools/Makefile | 1 -
fftools/ffmpeg_mux.c | 8 ++--
fftools/sy
Instead of allocating/freeing, use objpool for data passed from an
input frame to an output packet.
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 80
1 file changed, 71 insertions(+), 9 deletions(-)
diff --git a/libavcodec/videotoolboxenc.c b
Moved objpool to libavutil to make it available outside of fftools.
Signed-off-by: Rick Kern
---
fftools/Makefile | 1 -
fftools/ffmpeg_mux.c | 2 +-
fftools/sync_queue.c | 2 +-
fftools/thread_queue.c | 2 +-
fftools/thread_queue.h
objpool was only being used in fftools, but it's useful in other components to
reduce alloation time and memory fragmentation.
This patch set moves objpool to libavutil, so it can be used by
lavc/videotoolboxenc for data being passed from input frames to output packets.
Rick Ke
On Mon, Aug 29, 2022 at 9:05 AM Sebastian Beckmann <
beckmann.sebast...@outlook.de> wrote:
>
> > The patch doesn't apply. Can you create a .patch file with git
> format-patch
> > and send the file as an attachment? Sometimes email clients/providers
> > corrupt inline patches.
>
Thanks, pushed.
On Sun, Aug 28, 2022 at 4:27 PM Sebastian Beckmann <
beckmann.sebast...@outlook.de> wrote:
> Adds an option to use constant bitrate instead of average bitrate to the
> videotoolbox encoders. This is enabled via -constant_bit_rate true.
> macOS 13 is required for this option to work.
>
> Signed-off
On Fri, Aug 26, 2022 at 7:42 AM Sebastian Beckmann <
beckmann.sebast...@outlook.de> wrote:
> Adds an option to use constant bitrate instead of average bitrate to the
> videotoolbox encoders. This is enabled via -constant_bit_rate true.
> macOS 13 is required for this option to work.
>
> Signed-off
t;> Simone
> >>
> >> Von meinem iPad gesendet
> >>
> >>> Am 25.04.2022 um 22:33 schrieb Simone Karin Lehmann >:
> >>>
> >>>
> >>>
> >>>>>> Am 25.04.2022 um 21:14 schrieb Rick Kern :
> >>&g
On Sat, Apr 23, 2022 at 8:31 AM Simone Karin Lehmann
wrote:
>
>
> > Am 22.04.2022 um 18:52 schrieb Thilo Borgmann :
> >
> >
>
> > For that version I get:
> >
> > libavcodec/videotoolboxenc.c:1153:39: error: use of undeclared
> identifier 'kVTCompressionPropertyKey_PrioritizeEncodingSpeedOverQuali
On Thu, Dec 16, 2021 at 7:12 PM rcombs wrote:
> This patchset includes several infrastructural improvements to
> videotoolboxenc,
> an added group of output formats for swscale, and a ProRes encoder wrapper.
>
> Also available as a GitHub PR here:
> https://github.com/FFmpeg/FFmpeg/pull/378
>
> R
On Thu, Dec 16, 2021 at 7:13 PM rcombs wrote:
> ---
> libavcodec/videotoolboxenc.c | 149 +--
> 1 file changed, 92 insertions(+), 57 deletions(-)
>
> diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
> index 82e01fbe29..67bb563639 100644
> -
On Thu, Dec 16, 2021 at 7:13 PM rcombs wrote:
> No longer requires per-format switch cases.
>
> The frame==0 path was unused (and would've crashed anyway).
> ---
> libavcodec/videotoolboxenc.c | 69 +++-
> 1 file changed, 13 insertions(+), 56 deletions(-)
>
> diff
On Thu, Dec 16, 2021 at 7:13 PM rcombs wrote:
> ---
> libavcodec/videotoolboxenc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
> index fa8f717a6c..e10373dded 100644
> --- a/libavcodec/videotoolboxenc.c
> +++ b/libavcodec
On Tue, Nov 9, 2021 at 5:57 AM Steven Liu wrote:
> <13102179...@163.com> 于2021年11月9日周二 下午6:52写道：
> >
> > From: songyutong
> >
> > In function vtenc_populate_extradata(), there is a manually created
> > pixel buffer that has not been released. So we should use
> CVPixelBufferRelease
> > to releas
On Sun, Sep 26, 2021 at 8:48 AM NoHalfBits
wrote:
> Sets vtctx->has_b_frames to 0 if the VideoToolbox compression
> session will not emit B-frames (and, in consequence, no valid
> DTSs). Required for the handling of invalid DTSs in
> 'vtenc_cm_to_avpacket' (line 2018ff) to work correctly and not
On Fri, Aug 13, 2021 at 5:39 AM "zhilizhao(赵志立)"
wrote:
>
>
> > On Aug 13, 2021, at 3:00 PM, Anselm Busse
> wrote:
> >
> > Hey everyone,
> >
> > I posted this patch almost a month ago and got no reaction. Is there
> anything else I have to/can do to get this fix merged? I’m a little bit
> worrie
On Fri, Jul 23, 2021 at 4:31 AM Hao Guan wrote:
> Signed-off-by: Hao Guan
> ---
>
> Notes:
> I have checked out the code about other functions introduced after
> macOS 10.13 and noticed that the availability is checked during configure.
> Therefore I add the check for sRGB function too. It s
On Thu, Jul 15, 2021 at 12:47 AM Hao Guan wrote:
> ---
> libavcodec/videotoolboxenc.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
> index 4eaabed5d8..61eb6e1921 100644
> --- a/libavcodec/videotoolboxenc.c
> +++ b/libavc
On Thu, Apr 29, 2021 at 8:04 PM Andreas Rheinhardt <
andreas.rheinha...@outlook.com> wrote:
> Here the packet size is known before allocating the packet because
> the encoder provides said information (and works with internal buffers
> itself), so one use this information to avoid the implicit use
On Mon, Apr 26, 2021 at 3:24 AM "zhilizhao(赵志立)"
wrote:
>
>
> > On Apr 25, 2021, at 11:31 PM, Rick Kern wrote:
> >
> > On Sun, Apr 25, 2021 at 4:06 AM Zhao Zhili
> wrote:
> >
> >> From the comment it's not available on old version.
On Sun, Apr 25, 2021 at 4:06 AM Zhao Zhili wrote:
> From the comment it's not available on old version. It works now
> by testing on macOS 11.2.1. There is no document about since when.
> So trying to set the configuration and ignore the error for hevc.
> ---
> libavcodec/videotoolboxenc.c | 10
On Fri, Jan 22, 2021 at 3:28 PM wrote:
> From: Simone Karin Lehmann
>
> Signed-off-by: Simone Karin Lehmann
>
Applied
> ---
> libavcodec/videotoolboxenc.c | 54
> 1 file changed, 42 insertions(+), 12 deletions(-)
>
> diff --git a/libavcodec/videotoolboxen
On Tue, Mar 16, 2021 at 5:59 AM wrote:
> Greetings,
>
> Thank you for your help in advance.
> Unfortunately, my patch, which add support the "HEVC with alpha" profile
> to the videotoolbox encoder, has not been reviewed for nearly three weeks.
> Would it be possible to give me why nobody has revi
On Mon, Feb 15, 2021 at 7:51 AM Andreas Rheinhardt <
andreas.rheinha...@gmail.com> wrote:
> sharpbai:
> > Before macOS 11, the encoded h264 sample contains fixed SEI before
> > IDR frame, which the content is below
> >
> > 06 05 10 b9 ed b9 30 5d 21 4b 71 83 71 2c 10 a3
> > 14 bb 29 80
> >
> > The
On Wed, Aug 26, 2020 at 10:53 PM Steven Liu wrote:
> From: Tian Qi
>
> because there is run in thread mode, few times will block
> the workflow at the wait, so check the status is flushing data,
> don't wait when flushing data.
>
I'd like to reproduce the issue and test the fix before the patch
On Wed, Mar 18, 2020 at 12:32 PM Nomis101 wrote:
> Am 29.02.20 um 02:39 schrieb Nomis101:
> > From: Damiano Galassi
> >
> > Signed-off-by: Nomis101
> > ---
> > libavcodec/videotoolboxenc.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/
On Wed, Nov 20, 2019 at 11:29 AM Hendrik Leppkes
wrote:
> On Wed, Nov 20, 2019 at 5:00 PM Timo Rothenpieler
> wrote:
> >
> > On 20.11.2019 13:51, Rick Kern wrote:
> > > The current version of clang enables stack checking by default, causing
> > > a crash whe
The current version of clang enables stack checking by default, causing
a crash when binaries are run.
Fixes #8073 using the -fno-stack-check work-around mentioned in the ticket.
---
configure | 1 +
1 file changed, 1 insertion(+)
diff --git a/configure b/configure
index 8f4f2884cf..97e614f18a 1
The default ./configure produces binaries that segfault on MacOS 10.15.
Fixes #8073 using the work-around mentioned in the ticket.
---
configure | 1 +
1 file changed, 1 insertion(+)
diff --git a/configure b/configure
index 31a3744dc6..6e371ae433 100755
--- a/configure
+++ b/configure
@@ -6878,6
On Sun, Nov 17, 2019 at 10:25 AM Nomis101 wrote:
> Am 17.11.19 um 01:05 schrieb Richard Kern:
> >
> >> On Nov 16, 2019, at 7:03 PM, Nomis101 wrote:
> >>
> >> Thanks for reviewing. Would be nice, if somebody could push to master
> then. I can't.
> >>
> >>
> > I’ll test it out tomorrow and push.
On Mon, Sep 2, 2019 at 9:53 AM Limin Wang wrote:
> On Tue, Aug 27, 2019 at 10:56:42AM -0400, Richard Kern wrote:
>
> > I’ll look at it this weekend.
> ping
>
>
It shows error kVTParameterErr when using the software encoder:
Error setting profile/level property: -12902
I used the following comma
On Sat, Aug 10, 2019 at 11:02 AM Limin Wang wrote:
>
>
> ping the change!
>
Tests look good. Pushed.
>
> On Thu, Jul 18, 2019 at 06:59:35AM +0800, lance.lmw...@gmail.com wrote:
> > From: Limin Wang
> >
> > The current function will report one error message, but the caller func
> > haven't chec
On Wed, Jul 10, 2019 at 5:29 AM Dennis Mungai wrote:
> On Wed, Jul 10, 2019, 11:06 Hendrik Leppkes wrote:
>
> > On Wed, Jul 10, 2019 at 4:23 AM Dennis Mungai wrote:
> > >
> > > On Wed, Jul 10, 2019, 03:05 Aman Gupta wrote:
> > >
> > > > On Wed, Jun 26, 2019 at 4:25 AM wrote:
> > > >
> > > > >
On Fri, May 24, 2019 at 6:34 PM Thilo Borgmann
wrote:
> Am 22.05.19 um 14:27 schrieb Thilo Borgmann:
> > Am 22.05.19 um 01:41 schrieb Jan Ekström:
> >> Hi,
> >>
> >> On Tue, May 14, 2019 at 4:16 PM Thilo Borgmann
> wrote:
> >>>
> >>> $Subject
> >>>
> >>> Tested compilation only, sanity test actu
Ivo van Poorten
vc2* Rostislav Pehlivanov
vcr1.cMichael Niedermayer
- videotoolboxenc.c Rick Kern
+ videotoolboxenc.c Rick Kern, Aman Gupta
vima.c
decklink_common.cpp includes a .cpp file from the DeckLink API which fails
to build because there are non-static functions in the included .cpp file.
This disables the missing-prototypes error so the file can be included.
Signed-off-by: Rick Kern
---
libavdevice/Makefile | 2 ++
1 file changed
d=c99 when
the -std option is supported.
Signed-off-by: Rick Kern
---
common.mak | 2 +-
configure | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/common.mak b/common.mak
index 3f2096d..c4ab049 100644
--- a/common.mak
+++ b/common.mak
@@ -39,7 +39,7 @@ CCFLAGS = $(CPP
Use c++98 standard instead of c++11.
Signed-off-by: Rick Kern
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 19aea61..76d2d27 100755
--- a/configure
+++ b/configure
@@ -4529,7 +4529,7 @@ fi
add_cppflags -D_ISOC99_SOURCE
decklink_common.cpp includes a .cpp file from the DeckLink API which fails
to build because there are non-static functions in the included .cpp file.
This disables the missing-prototypes error so the file can be included.
Signed-off-by: Rick Kern
---
configure | 3 ++-
1 file changed, 2
Fixes #5654.
The linesize can be greater than the minimum required. This copies the
frame taking linesize into account.
Signed-off-by: Rick Kern
---
libavdevice/avfoundation.m | 56 --
1 file changed, 49 insertions(+), 7 deletions(-)
diff --git a
Fixes #4124: Invalid argument '-std=c99' not allowed with 'C++/ObjC++'
C++ files fail to compile. This adds '-std=c++11' to CXX_FLAGS to fix.
Signed-off-by: Rick Kern
---
common.mak | 2 +-
configure | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff -
decklink_common.cpp includes a .cpp file from the DeckLink API which fails
to build because there are non-static functions in the included .cpp file.
This temporarily disables the missing-prototypes error so the file can
be included.
Signed-off-by: Rick Kern
---
libavdevice/decklink_common.cpp
This fixes two build issues on OS X when --enable-decklink.
Rick Kern (2):
lavd/decklink: Fix compile issue on OS X
lavd/decklink_common: Fix error caused by -Werror=missing-prototypes
common.mak | 2 +-
configure | 1 +
libavdevice
Person in MAINTAINERS hasn't responded to a patch on the ML or private
email, and doesn't maintain the files according to git.
Signed-off-by: Rick Kern
---
MAINTAINERS | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 4fe999d..ef23
VideoToolbox doesn't supply parameter sets until the first frame is done
encoding. This spins up a temporary encoder and encodes a single frame to
get this data.
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 326 ---
1 file changed
Allocates a buffer with padding, and with enough room for start codes when
length codes are smaller.
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 223 ++-
1 file changed, 94 insertions(+), 129 deletions(-)
diff --git a/libavcodec
AudioConverterFillComplexBuffer() doesn't always call its callback. A frame
queue is used to prevent skipped audio samples.
Signed-off-by: Rick Kern
---
libavcodec/audiotoolboxenc.c | 78 +---
1 file changed, 52 insertions(+), 26 deletions(-)
diff
Fixes VTDecompressionSessionCreate() error.
Signed-off-by: Rick Kern
---
libavcodec/videotoolbox.c | 59 ---
1 file changed, 45 insertions(+), 14 deletions(-)
diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c
index 2f4d531..cadfb23
Fixes "Could not find codec parameters for stream" error (#5494)
Signed-off-by: Rick Kern
---
libavdevice/avfoundation.m | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m
ind
Some devices output an invalid DTS when B-frames aren't used. Using PTS for
the DTS in this case.
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index 25
Now set by the encoder, not used as an input parameter.
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index bd153e7..25c9648 100644
--- a
Hint to the encoder that encoding should be done in real-time, even at the
expense of quality.
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index f53015a
Handle AV_PIX_FMT_VIDEOTOOLBOX.
This results in better energy usage and faster encoding, especially on iOS.
When the buffer comes from the media server, no memcpy's are needed.
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 26 +-
1 file change
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index 72c7ba8..f53015a 100644
--- a/libavcodec/videotoolboxenc.c
+++ b/libavcodec/videotoolboxenc.c
@@ -706,9 +706,14
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 63
1 file changed, 63 insertions(+)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index 5f02756..4a40f35 100644
--- a/libavcodec/videotoolboxenc.c
+++ b
Signed-off-by: Rick Kern
---
configure| 5 +-
libavcodec/videotoolboxenc.c | 209 +++
2 files changed, 213 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index ef0b689..43d21fa 100755
--- a/configure
+++ b/configure
Setting AVFrame.pic_type to AV_PICTURE_TYPE_I will force an I-frame.
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 26 +-
1 file changed, 25 insertions(+), 1 deletion(-)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index e155383
Add an entropy setting to choose between CAVLC and CABAC.
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 33 +
1 file changed, 33 insertions(+)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index 90b9a96..bd153e7 100644
Add frames_before and frames_after as hints that there will be frames before
or after the frames produced in this session. This may help with
concatenation issues like bit rate spikes.
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 31 +++
1 file changed
This reduces the chance of a memcpy in the media server.
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 204 +--
1 file changed, 160 insertions(+), 44 deletions(-)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
Software encoding can be allowed by setting allow_sw to 1.
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 38 +-
1 file changed, 17 insertions(+), 21 deletions(-)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index
Updates from code review:
Have allow_sw for both OS X and iOS
Changed "entropy" option to "coder" to match libx264
Updated configure for CONFIG_VT_BT2020 macro
Bool option usage
Formatting
Rick Kern (12):
lavc/videotoolboxenc: Use shared pixel buffer pool
lavc/videotoolbo
Some devices output an invalid DTS when B-frames aren't used. Using PTS for
the DTS in this case.
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index 6a
Signed-off-by: Rick Kern
---
configure| 5 +-
libavcodec/videotoolboxenc.c | 209 +++
2 files changed, 213 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index 97f374b..c484a10 100755
--- a/configure
+++ b/configure
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 63
1 file changed, 63 insertions(+)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index 5935d09..768405d 100644
--- a/libavcodec/videotoolboxenc.c
+++ b
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index 5594e69..073b87a 100644
--- a/libavcodec/videotoolboxenc.c
+++ b/libavcodec/videotoolboxenc.c
@@ -728,9 +728,12
Now set by the encoder, not used as an input parameter.
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index 07577b6..6a9a2fe 100644
--- a
Setting AVFrame.pic_type to AV_PICTURE_TYPE_I will force an I-frame.
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 26 +-
1 file changed, 25 insertions(+), 1 deletion(-)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index c630825
Add frames_before and frames_after as hints that there will be frames before
or after the frames produced in this session. This may help with
concatenation issues like bit rate spikes.
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 30 ++
1 file changed
Hint to the encoder that encoding should be done in real-time, even at the
expense of quality.
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index 073b87a
Add an entropy setting to choose between CAVLC and CABAC.
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index ec69bb1..07577b6 100644
Handle AV_PIX_FMT_VIDEOTOOLBOX.
This results in better energy usage and faster encoding, especially on iOS.
When the buffer comes from the media server, no memcpy's are needed.
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 26 +-
1 file change
Software encoding can be allowed by setting allow_sw to 1.
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 42 +-
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index
Sorry for the delay. The commit for the keyframes_only property was removed -
this was already supported with -g 1.
Rick Kern (12):
lavc/videotoolboxenc: Use shared pixel buffer pool
lavc/videotoolboxenc: Handle hwaccel format as input
lavc/videotoolboxenc: Require hardware encoding
lavc
This reduces the chance of a memcpy in the media server.
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 224 ++-
1 file changed, 180 insertions(+), 44 deletions(-)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
Setting AVFrame.pic_type to AV_PICTURE_TYPE_I will force an I-frame.
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 26 +-
1 file changed, 25 insertions(+), 1 deletion(-)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index ff914f7
Add an entropy setting to choose between CAVLC and CABAC.
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 32
1 file changed, 32 insertions(+)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index 2bcd3ef..6586ca7 100644
Outputs only I-frames when set.
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 12
1 file changed, 12 insertions(+)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index 5430479..c9a60b7 100644
--- a/libavcodec/videotoolboxenc.c
+++ b
Signed-off-by: Rick Kern
---
configure| 3 +
libavcodec/videotoolboxenc.c | 209 +++
2 files changed, 212 insertions(+)
diff --git a/configure b/configure
index 94a66d8..10d4bab 100755
--- a/configure
+++ b/configure
@@ -5425,6
Added several encoding parameters (ticket #5357), and fixed some bugs.
Rick Kern (13):
lavc/videotoolboxenc: Use shared pixel buffer pool
lavc/videotoolboxenc: Handle hwaccel format as input
lavc/videotoolboxenc: Remove redundant code
lavc/videotoolboxenc: Add entropy setting
lavc
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 54
1 file changed, 54 insertions(+)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index 0a79ee0..72743b5 100644
--- a/libavcodec/videotoolboxenc.c
+++ b
Now set by the encoder, not used as an input parameter.
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index 6586ca7..8352ba9 100644
--- a
Add frames_before and frames_after as hints that there will be frames before
or after the frames produced in this session. This may help with
concatenation issues like bit rate spikes.
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 30 ++
1 file changed
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index 196f00b..a3f7e5e 100644
--- a/libavcodec/videotoolboxenc.c
+++ b/libavcodec/videotoolboxenc.c
@@ -714,9 +714,12
Some devices output an invalid DTS when B-frames aren't used. Using PTS for
the DTS in this case.
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index 83
Hint to the encoder that encoding should be done in real-time, even at the
expense of quality.
Signed-off-by: Rick Kern
---
libavcodec/videotoolboxenc.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index a3f7e5e
1 - 100 of 121 matches
Mail list logo
