[FFmpeg-devel] [PATCH] avcodec/decode: clean-up if get_hw_frames_parameters fails

2024-10-07 Thread Thomas Guillem via ffmpeg-devel
Fixes the following assert: [7f1df83d17e0] vaapi generic error: avcodec_get_hw_frames_parameters failed: -22 Assertion p_dst->hwaccel_threadsafe || (!dst->hwaccel && !dst->internal->hwaccel_priv_data) failed at libavcodec/pthread_frame.c:349 Reproduced from VLC with VAAPI, when fallbacking

Re: [FFmpeg-devel] [PATCH] avcodec/decode: clean-up if get_hw_frames_parameters fails

2024-10-07 Thread Thomas Guillem via ffmpeg-devel
On Mon, Oct 7, 2024, at 17:12, Rémi Denis-Courmont wrote: > Le 30 septembre 2024 17:27:46 GMT+09:00, Thomas Guillem via > ffmpeg-devel a écrit : >>Fixes the following assert: >> >>[7f1df83d17e0] vaapi generic error: avcodec_get_hw_frames_parameters >>

Re: [FFmpeg-devel] [PATCH] avcodec/decode: clean-up if get_hw_frames_parameters fails

2024-10-06 Thread Thomas Guillem via ffmpeg-devel
Ping. On Mon, Sep 30, 2024, at 13:44, Thomas Guillem via ffmpeg-devel wrote: > cf. https://trac.ffmpeg.org/ticket/11013 > > > On Mon, Sep 30, 2024, at 10:27, Thomas Guillem via ffmpeg-devel wrote: >> Fixes the following assert: >> >> [7f1

Re: [FFmpeg-devel] [PATCH] avcodec/decode: clean-up if get_hw_frames_parameters fails

2024-09-30 Thread Thomas Guillem via ffmpeg-devel
cf. https://trac.ffmpeg.org/ticket/11013 On Mon, Sep 30, 2024, at 10:27, Thomas Guillem via ffmpeg-devel wrote: > Fixes the following assert: > > [7f1df83d17e0] vaapi generic error: > avcodec_get_hw_frames_parameters failed: -22 > Assertion p_dst->hwaccel_threadsafe

[FFmpeg-devel] [PATCH] avcodec/decode: clean-up if get_hw_frames_parameters fails

2024-09-30 Thread Thomas Guillem via ffmpeg-devel
Fixes the following assert: [7f1df83d17e0] vaapi generic error: avcodec_get_hw_frames_parameters failed: -22 Assertion p_dst->hwaccel_threadsafe || (!dst->hwaccel && !dst->internal->hwaccel_priv_data) failed at libavcodec/pthread_frame.c:349 Reproduced from VLC with VAAPI, when fallbacking

Re: [FFmpeg-devel] [PATCH 3/3] h264: fix data-race with FF_DECODE_ERROR_DECODE_SLICES

2023-09-12 Thread Thomas Guillem via ffmpeg-devel
On Tue, Sep 12, 2023, at 15:11, Andreas Rheinhardt wrote: > Thomas Guillem via ffmpeg-devel: >> Same than the previous commit but with FF_DECODE_ERROR_DECODE_SLICES >> >> Fix the following data-race: >> >> WARNING: ThreadSanitizer: data race (pid=55935) >&

[FFmpeg-devel] [PATCH 2/3] h264: fix data-race with FF_DECODE_ERROR_CONCEALMENT_ACTIVE

2023-09-12 Thread Thomas Guillem via ffmpeg-devel
Set the FF_DECODE_ERROR_CONCEALMENT_ACTIVE flags on the AVFrane before outputing it. Store in in the H264Picture in the meantime, where it won't be read/write by other threads. Fix the following data-race: WARNING: ThreadSanitizer: data race (pid=55134) Write of size 4 at 0x7b507f78 by thre

[FFmpeg-devel] [PATCH 3/3] h264: fix data-race with FF_DECODE_ERROR_DECODE_SLICES

2023-09-12 Thread Thomas Guillem via ffmpeg-devel
Same than the previous commit but with FF_DECODE_ERROR_DECODE_SLICES Fix the following data-race: WARNING: ThreadSanitizer: data race (pid=55935) Write of size 4 at 0x7b509378 by thread T1 (mutexes: write M608): #0 decode_nal_units src/libavcodec/h264dec.c:742 (ffmpeg+0xb19dd6) #1 h

[FFmpeg-devel] [PATCH 1/3] error_resilience: set the decode_error_flags outside

2023-09-12 Thread Thomas Guillem via ffmpeg-devel
This will allow to fix data-races when ff_er_frame_end() is called after ff_thread_finish_setup() --- libavcodec/error_resilience.c | 12 ++-- libavcodec/error_resilience.h | 2 +- libavcodec/h263dec.c | 6 -- libavcodec/h264dec.c | 3 ++- libavcodec/mpeg12dec.c