On Sat, Sep 12, 2020 at 3:01 PM Lynne wrote:
> On 11/09/2020 08:36, Josef Zlomek wrote:
> > Adds the demuxer of animated WebP files.
> > It supports non-animated, animated, truncated, and concatenated files.
> > Reading from a pipe (and other non-seekable inputs) is also supported.
> >
> > The
Dne so 12. 9. 2020 22:35 uživatel Carl Eugen Hoyos
napsal:
> Am Fr., 11. Sept. 2020 um 08:36 Uhr schrieb Josef Zlomek :
>
> This is not the requested review, I am just curious about the
> behaviour:
>
> > +static int webp_probe(const AVProbeData *p)
> > +{
> > +const uint8_t *b = p->buf;
> >
Adds support for animated WebP
v5:
* added version bumps
v4:
* using av_packet_new_side_data instead of av_packet_add_side_data
v3:
* generalized alpha blending to a common method
* added support for seeking
* updated existing tests for fate suite for WebP
v2:
* multi-threading support in
On Thu, Sep 10, 2020 at 1:27 PM Moritz Barsnick wrote:
> On Wed, Sep 09, 2020 at 09:57:24 +0200, Zlomek, Josef wrote:
> > On Tue, Sep 8, 2020 at 3:19 PM Moritz Barsnick wrote:
> > > Missing version bumps.
> > There is a version bump for libavformat, as new demuxer was
On Tue, Sep 8, 2020 at 3:19 PM Moritz Barsnick wrote:
> On Fri, Sep 04, 2020 at 00:59:46 +0200, Lynne wrote:
> Missing version bumps.
There is a version bump for libavformat, as new demuxer was added.
I did not know that version should be increased also when there is a change
in existing
On Wed, Aug 26, 2020 at 11:16 AM Andreas Rheinhardt <
andreas.rheinha...@gmail.com> wrote:
> Josef Zlomek:
> > tests/ref/fate/exif-image-webp | 8 +-
> > tests/ref/fate/webp-rgb-lena-lossless | 2 +-
> > tests/ref/fate/webp-rgb-lena-lossless-rgb24 | 2 +-
> >
On Wed, Jul 29, 2020 at 5:43 PM Lynne wrote:
> Jul 29, 2020, 14:05 by jo...@pex.com:
>
> > +if (canvas->format == AV_PIX_FMT_ARGB) {
> > +height = canvas->height;
> > +memset(canvas->data[0], 0, height * canvas->linesize[0]);
> >
>
> At least some of those image-wide memsets
On Wed, Jul 29, 2020 at 12:01 PM Nicolas George wrote:
> I am afraid ff_make_absolute_url() as it is is broken beyond repair. For
> example:
>
> http://server/menu redirect?url=http://otherserver/target =>
> redirect?url=http://otherserver/target
>
> while the result should have been
>
>
I have removed tmp_path from function trim_double_dot_url
I did not change the function ff_make_absolute_url much, as I wanted to
just fix handling of "..".
Josef
On Tue, Jul 28, 2020 at 12:59 PM Steven Liu wrote:
> Zlomek, Josef 于2020年7月28日周二 下午6:58写道：
> >
> &
see version 3
On Tue, Jul 28, 2020 at 12:37 PM Steven Liu wrote:
> Josef Zlomek 于2020年7月28日周二 下午12:11写道：
> >
> > Fixes: 8814
> >
> > The logic for removing ".." path components and their corresponding
> > upper directories was reworked.
> >
> > Now, the function trim_double_dot_url splits the
You are right, it is a typo.
On Tue, Jul 28, 2020 at 12:02 PM Zane van Iperen
wrote:
> On Tue, 28 Jul 2020 06:10:57 +0200
> "Josef Zlomek" wrote:
>
> >
> > Now, the function trim_double_dot_url splits the path by "/" into
> > components, and processes the components one ny one:
>
> Typo: ny
On Mon, Jul 27, 2020 at 8:57 PM Marton Balint wrote:
> It should be implemented in a way which does not use a temporary buffer.
> Seems doable.
>
You are right. I will submit a new version.
Best regards,
Josef
___
ffmpeg-devel mailing list
This does not work for the following testcases, + lines are invalid:
+test("/foo/bar", "..");
+test("/foo/bar/baz", "..");
- /foo/bar .. =>
/
- /foo/bar/baz .. =>
/foo/
+
Generally, this seems to be too complicated with too much of copying.
On Mon, Jul 27, 2020 at 3:08 PM Steven Liu wrote:
> use two buffer for storage the path and node of URI
> remove the last node of the path if the next node is ..
> change the static strings to dynamic alloc space by size
If your code is correct then good.
I also resubmit improved version.
Josef
On Mon, Jul 27, 2020 at 2:05 PM Steven Liu wrote:
> Zlomek, Josef 于2020年7月27日周一 下午7:45写道：
> >
> > Hi Steven,
> >
> > ".." is always a directory.
> >
> > your tes
I also noticed that the 3rd part did not make it to patchwork.
Maybe it is because it modifies the same file. I will squash it with the
first part.
Josef
On Mon, Jul 27, 2020 at 1:36 PM Steven Liu wrote:
> Josef Zlomek 于2020年7月27日周一 下午6:57写道：
> >
> > Signed-off-by: Josef Zlomek
> > ---
> >
Hi Steven,
".." is always a directory.
your tests (diff starting with -) are not correct.
My results (lines starting with +) are correct.
Josef
On Mon, Jul 27, 2020 at 1:36 PM Steven Liu wrote:
> Josef Zlomek 于2020年7月27日周一 下午6:57写道：
> >
> > Fixes: 8814
> >
> > The logic for removing ".."
I will submit patch on monday.
Josef
On Sat, Jul 25, 2020 at 8:27 AM 刘歧 wrote:
>
>
> 在 2020/7/25 下午2:11，“ffmpeg-devel 代表 Zlomek, Josef”<
> ffmpeg-devel-boun...@ffmpeg.org 代表 jo...@pex.com> 写入:
>
> Hi Steven,
>
> It is better but still not correct. Co
Hi Steven,
It is better but still not correct. Consider this test:
test("http://server/foo/bar;,
"a/b/../c/d/../e../.../..f/g../h../other/url/a.mp3/...");
It should give "
http://server/foo/bar/a/c/e../.../..f/g../h../other/url/a.mp3/...;.
I think the best would be to use strtok(p, "/") to
On Thu, Jul 9, 2020 at 11:44 AM Nicolas George wrote:
> Josef Zlomek (12020-07-08):
>
> > +@item min_delay
> > +Set the minimum valid delay between frames in milliseconds.
> > +Range is 0 to 6. Default value is 10.
> > +
> > +@item max_webp_delay
> > +Set the maximum valid delay between
On Wed, Jul 8, 2020 at 10:04 AM Steven Liu wrote:
>
> (base) liuqi05:dash liuqi$ ./ffplay_g test.webp
> [...]
> Segmentation fault: 11
> (base) liuqi05:dash liuqi$
>
The segfault was caused by the usage of unaligned buffers for frames.
When using aligned buffers, it does not crash anymore.
On Wed, Jul 8, 2020 at 10:34 PM Carl Eugen Hoyos wrote:
> Am Mi., 8. Juli 2020 um 07:28 Uhr schrieb Josef Zlomek :
> >
> > Fixes: 4907
>
> It seems surprising that two commits should fix a ticket.
>
My understanding of ffmpeg internals is limited:
The parser is used for input from a pipe, the
On Wed, Jul 8, 2020 at 11:57 AM Lynne wrote:
> Jul 8, 2020, 06:28 by jo...@pex.com:
>
> > Fixes: 4907
> >
> > Adds support for decoding of animated WebP.
> >
> > The WebP parser now splits the input stream into packets containing one
> frame.
> >
> > The WebP decoder adds the animation related
23 matches
Mail list logo
