> Yes, but it's not needed. These are constants, so they have to be
> referenced within a function. There are two suitable ones: e and eif
>
> e.g.
>
> drawtext=text='pos %{e\:pkt_pos}, dur %{e\:pkt_duration}, size
> %{e\:pkt_size}'
Oh my goodness gracious that's amazing! Thanks, I'll try that out
> You haven't tested your patch?
Correct
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
> What output were you expecting with the first patch and what command did
> you test to check?
I was hoping it would make
-filter_complex [0:v]drawtext=text='%{pkt_duration}'
(and also pkt_size and pkt_pos) work the same way as
-filter_complex [0:v]drawtext=text='%{frame_num}'
does currently, but
> > This makes very little sense, please try hard to avoid similar commits in
> > the future.
> What makes very little sense?
>
> Gyan
Carl, if you mean the language is confusing I'm happy to write stuff
differently! I'm very new to ffmpeg-devel in general.
If you mean you can't picture someone
> If the joined version is preferred it's been submitted at
> http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245662.html
Pinging. Would it be possible to get one of these two versions
applied, if no other changes are required?
___
ffmpeg-devel mailin
>
> is there a functionality in the ffmpeg library to print AVFrame pts
> values in respect to AVRational time_base in human readable form?
I wonder if vf_drawtext might have an example of what you’re looking for
with the pts keyword?
>
___
ffmpeg-dev
Hello,
Just wondering if there’s anything else I should do to get this in
Thanks!
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffm
There's also a version as two separate patches submitted at
http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245625.html if
that's better etiquette.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> These were two different and independent patches written by two different
> persons.
I'm totally fine with them going in either way, but just to clarify
the 0002 file was written as a companion to update the documentation
to go along with 0001, it isn't meant to exist on its own. I can't
speak
Info at https://trac.ffmpeg.org/ticket/7947
Changes to vf_drawtext.c written by
Calvin Walton
Changes to filters.texi written by
greg Luce
with lots of help from Moritz Barsnick and Gyan
[PATCH]-vf_drawtext-Add-pkt_pos-pkt_duration-pkt_size-as-var.patch
Description: Binary data
> Do you consider the doc change to be more important than the code
> change?
>
> If not, you need to change the From line of the commit.
Makes sense!
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Info at https://trac.ffmpeg.org/ticket/7947
Changes to vf_drawtext.c written by
Calvin Walton
Changes to filters.texi written by
greg Luce
with lots of help from Moritz Barsnick and Gyan
[PATCH]-vf_drawtext-Add-pkt_pos-pkt_duration-pkt_size-as-var.patch
Description: Binary data
Thanks will resubmit that way
On Fri, 21 Jun 2019 at 08:53, Nicolas George wrote:
>
> greg Luce (12019-06-21):
> > I had them in a single patch before but split them as requested here
> > http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245613.html
> > Is there so
> code changes should be ok
> the doc and code belong in the same patch/commit though
I had them in a single patch before but split them as requested here
http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245613.html
Is there something I'm missing that allows me to split the patch but
have the co
Split this patch off since it just deals with documentation for
features already present in the code. Hope I formatted everything
correctly!
Gyan and kepstin helped write the documentation
0001-vf_drawtext documentation additions and correction.patch
Description: Binary data
_
> > +A 1 character description of the current packet's picture type.
>
> packet --> frame.
You know I was thinking about that. I'll change and resubmit
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-deve
Split this patch off since it just deals with documentation for
features already present in the code. Hope I formatted everything
correctly!
Gyan and kepstin helped write the documentation
0001-vf_drawtext documentation additions and correction.patch
Description: Binary data
_
Info at https://trac.ffmpeg.org/ticket/7947
C code in file 0001, documentation and version tick in file 0002
Documentation written with help from Gyan and Moritz Barsnick
Documentation patch has info in what I hope is the commit message
0001-vf_drawtext-Add-pkt_pos-pkt_duration-pkt_size-as-var.pa
> Who has written the patch that you attached?
>
> Thank you, Carl Eugen
The C code was written by kepstin
I wrote the change to the documentation with help from several people
There's a trac ticket at https://trac.ffmpeg.org/ticket/7947
___
ffmpeg-deve
Adds pkt_pos, pkt_duration, and pkt_size to drawtext as variables for
text expansion, and adds documentation for pict_type which already
exists.
[PATCH v3] vf_drawtext - Add variables.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-d
> > the background for this is the extension for DASH media files
> > used to be *.m4s and it is now *.mp4
I don't know about the official standard, but at least one
implimentation (vimeo.com) has a bunch of moov atoms in a .mp4 file at
the start of the stream, followed by .m4s segments
__
> This doesn't look correct. It's supposed to contain
> Subject: vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables
> and the Signed-off-by line is to be somewhere in the remaining commit
> message. How did you create the patch?
I just cloned the main, made the change, and then did
"git
Ooops apologies, .patch file attached and with hopefully better line breaks
On Wed, 12 Jun 2019 at 03:43, Michael Niedermayer
wrote:
>
> On Tue, Jun 11, 2019 at 06:02:10PM -0400, greg Luce wrote:
> > This is on the bug tracker at https://trac.ffmpeg.org/ticket/7947
> > Create
This is on the bug tracker at https://trac.ffmpeg.org/ticket/7947
Created with the help of the excellent Calvin Walton
and rewritten with the advice of the excellent Gyan
---
doc/filters.texi | 24 +++-
libavfilter/vf_drawtext.c | 9 +
2 files changed, 32 i
On Mon, 10 Jun 2019 at 19:05, greg Luce wrote:
> +If you're trying to read data from teh frames in a stream or file, run
Sorry, this should read "the" not "teh"
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https:/
I created this issue on the bugtracker but I'm trying to format it
properly for this channel
https://trac.ffmpeg.org/ticket/7947
The actual filter change was written by Calvin Walton
---
diff --git a/doc/filters.texi b/doc/filters.texi
index ec1c7c7591..332f4ddc80 100644
--- a/doc/filters.texi
++
26 matches
Mail list logo
