[FFmpeg-devel] [PATCH v4 1/7] lavc: add new API for iterating codecs and codec parsers

2018-02-02 Thread Josh de Kock
Based on an unfinished patch by atomnuker. --- Makefile |3 +- configure | 12 +- doc/APIchanges |4 + libavcodec/.gitignore |2 + libavcodec/allcodecs.c | 1473 libavcodec/avcodec.h | 31 +

[FFmpeg-devel] [PATCH v4 2/7] lavf/rtp: replace linked list with array

2018-02-02 Thread Josh de Kock
--- libavformat/allformats.c | 4 -- libavformat/rdt.c| 9 +--- libavformat/rdt.h| 5 -- libavformat/rtpdec.c | 138 ++- libavformat/rtpdec.h | 25 +++-- 5 files changed, 100 insertions(+), 81 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH v3 1/6] lavc: add new API for iterating codecs and codec parsers

2018-02-02 Thread Josh de Kock
On Fri, Feb 2, 2018, at 6:53 PM, James Almer wrote: > On 2/2/2018 12:23 PM, Josh de Kock wrote: > > > >> On 1 Feb 2018, at 18:51, Muhammad Faiz <mfc...@gmail.com> wrote: > >> > >>> On Thu, Feb 1, 2018 at 3:25 AM, Josh de Kock <j...@itanimul.li>

Re: [FFmpeg-devel] [PATCH v3 1/6] lavc: add new API for iterating codecs and codec parsers

2018-02-02 Thread Josh de Kock
> On 2 Feb 2018, at 15:41, Rostislav Pehlivanov <atomnu...@gmail.com> wrote: > >> On 31 January 2018 at 20:25, Josh de Kock <j...@itanimul.li> wrote: >> >> Also replace linked list with an array. >> --- >> configure | 12 +-

Re: [FFmpeg-devel] [PATCH v3 1/6] lavc: add new API for iterating codecs and codec parsers

2018-02-02 Thread Josh de Kock
> On 1 Feb 2018, at 18:51, Muhammad Faiz <mfc...@gmail.com> wrote: > >> On Thu, Feb 1, 2018 at 3:25 AM, Josh de Kock <j...@itanimul.li> wrote: >> Also replace linked list with an array. >> --- >> configure | 12 +- >> doc/APIchanges

Re: [FFmpeg-devel] [PATCH v3 1/6] lavc: add new API for iterating codecs and codec parsers

2018-02-01 Thread Josh de Kock
> On 1 Feb 2018, at 03:03, Michael Niedermayer <mich...@niedermayer.cc> wrote: > >> On Wed, Jan 31, 2018 at 08:25:50PM +, Josh de Kock wrote: >> Also replace linked list with an array. >> --- >> configure | 12 +- >> doc/APIchanges

[FFmpeg-devel] [PATCH v3 6/6] cmdutils: make use of new iteration APIs

2018-01-31 Thread Josh de Kock
--- fftools/cmdutils.c | 122 +++-- 1 file changed, 43 insertions(+), 79 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 6920ca0..9ecc51b 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -1250,19 +1250,11 @@ int

[FFmpeg-devel] [PATCH v3 5/6] lavd: add new API for iterating input and output devices

2018-01-31 Thread Josh de Kock
This also adds an avpriv function to register devices in libavformat --- configure| 27 +-- libavdevice/alldevices.c | 181 --- libavdevice/avdevice.c | 46 libavdevice/avdevice.h | 28

[FFmpeg-devel] [PATCH v3 1/6] lavc: add new API for iterating codecs and codec parsers

2018-01-31 Thread Josh de Kock
Also replace linked list with an array. --- configure | 12 +- doc/APIchanges |4 + libavcodec/.gitignore |2 + libavcodec/allcodecs.c | 1473 libavcodec/avcodec.h | 31 + libavcodec/parser.c| 84 ++-

[FFmpeg-devel] [PATCH v3 3/6] lavf: add new API for iterating muxers and demuxers

2018-01-31 Thread Josh de Kock
--- configure| 6 +- doc/APIchanges | 7 +- libavformat/.gitignore | 2 + libavformat/allformats.c | 866 --- libavformat/avformat.h | 31 ++ libavformat/format.c | 68 +--- libavformat/version.h| 3 + 7

[FFmpeg-devel] [PATCH v3 4/6] lavf: move fifo test muxer into separate file

2018-01-31 Thread Josh de Kock
This fixes the fate-fifo-muxer test. --- libavformat/Makefile | 2 +- libavformat/allformats.c | 1 + libavformat/fifo_test.c| 150 + libavformat/tests/fifo_muxer.c | 115 +-- 4 files changed, 154

[FFmpeg-devel] [PATCH v3 2/6] lavf/rtp: replace linked list with array

2018-01-31 Thread Josh de Kock
--- libavformat/allformats.c | 4 -- libavformat/rdt.c| 9 +--- libavformat/rdt.h| 5 -- libavformat/rtpdec.c | 138 ++- libavformat/rtpdec.h | 25 +++-- 5 files changed, 100 insertions(+), 81 deletions(-) diff --git

[FFmpeg-devel] [PATCH] rtmp: Plug leak if sending bytes read report fails.

2018-01-23 Thread Josh Allmann
--- libavformat/rtmpproto.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index faf2a6f244..b741e421af 100644 --- a/libavformat/rtmpproto.c +++ b/libavformat/rtmpproto.c @@ -2431,8 +2431,10 @@ static int

[FFmpeg-devel] [PATCH 6/6] lavf: add avpriv function to register devices

2018-01-02 Thread Josh de Kock
--- libavdevice/alldevices.c | 6 +- libavformat/allformats.c | 44 +++- libavformat/avformat.h | 4 3 files changed, 48 insertions(+), 6 deletions(-) diff --git a/libavdevice/alldevices.c b/libavdevice/alldevices.c index 6b2a512..041eb85

[FFmpeg-devel] [PATCH 4/6] lavf: move fifo test muxer into separate file

2018-01-02 Thread Josh de Kock
This fixes the fate-fifo-muxer test. --- libavformat/Makefile | 2 +- libavformat/allformats.c | 1 + libavformat/fifo_test.c| 150 + libavformat/tests/fifo_muxer.c | 115 +-- 4 files changed, 154

[FFmpeg-devel] [PATCH 5/6] lavd: add new API for iterating input and output devices

2018-01-02 Thread Josh de Kock
--- configure| 27 ++-- libavdevice/alldevices.c | 172 +++ libavdevice/avdevice.c | 46 - libavdevice/avdevice.h | 28 libavdevice/version.h| 4 ++ 5 files changed, 184 insertions(+), 93

[FFmpeg-devel] [PATCH 2/6] lavf/rtp: replace linked list with array

2018-01-02 Thread Josh de Kock
--- libavformat/allformats.c | 4 -- libavformat/rdt.c| 8 +-- libavformat/rdt.h| 3 + libavformat/rtpdec.c | 157 ++- libavformat/rtpdec.h | 29 - libavformat/version.h| 4 +- 6 files changed, 136

[FFmpeg-devel] [PATCH 3/6] lavf: add new API for iterating muxers and demuxers

2018-01-02 Thread Josh de Kock
--- configure| 6 +- doc/APIchanges | 5 + libavformat/allformats.c | 870 --- libavformat/avformat.h | 31 ++ libavformat/format.c | 56 +-- libavformat/version.h| 3 + 6 files changed, 564 insertions(+), 407

[FFmpeg-devel] [PATCH v2 1/6] lavc: add new API for iterating codecs and codec parsers

2018-01-02 Thread Josh de Kock
Also replace linked list with an array. --- configure | 12 +- doc/APIchanges |4 + libavcodec/allcodecs.c | 1473 libavcodec/avcodec.h | 31 + libavcodec/parser.c| 87 ++- libavcodec/utils.c | 105

Re: [FFmpeg-devel] [MSVC toolchain] Patch to allow building FFmpeg with Linux bash on Windows (WSL)

2017-12-29 Thread Josh de Kock
e" to the end of Windows executables is not rocket science, as you > said. > [...] I've been working on a patch to do this and fixup testing FATE with mingw cross compilation within WSL. I was planning on submitting it within the next

[FFmpeg-devel] [PATCH] lavc: add new API for iterating codecs and codec parsers

2017-12-23 Thread Josh de Kock
stuff so if that's incorrect some advice would be appreciated. -- Josh de Kock <j...@itanimul.li> >From 1d84641556eea563b82b17a6ffe54226e0e31c4e Mon Sep 17 00:00:00 2001 From: Josh de Kock <j...@itanimul.li> Date: Fri, 22 Dec 2017 22:17:00 + Subject: [PATCH] lavc: add new AP

Re: [FFmpeg-devel] CoC enforcement activated

2017-12-17 Thread Josh de Kock
On Sun, 17 Dec 2017 17:12:24 -0500 Compn <te...@mi.rr.com> wrote: > On Sun, 17 Dec 2017 21:57:07 +0000, Josh de Kock <j...@itanimul.li> > wrote: > > > On Sun, 17 Dec 2017 15:36:53 -0500 > > Compn <te...@mi.rr.com> wrote: > > > > > [...]

Re: [FFmpeg-devel] CoC enforcement activated

2017-12-17 Thread Josh de Kock
ill not be tolerated. > Note that there is nothing on how the CoC should be 'enforced'. Also consider that the CoC in our case is more of guidelines than strict rules to be followed. There has also been no consensus on moderation being enabled under what circumstances. -

Re: [FFmpeg-devel] [PATCH] avutil/atomics: replace avpriv atomics with stdatomics

2017-12-15 Thread Josh de Kock
On Fri, 15 Dec 2017 18:08:02 + Josh de Kock <j...@itanimul.li> wrote: > [...] Attached again with the correct mime... -- Josh de Kock <j...@itanimul.li> >From 2c4771a24510adfb3f6346c3fbed0554034eab3b Mon Sep 17 00:00:00 2001 From: Josh de Kock <j...@itanimul.li> D

[FFmpeg-devel] [PATCH] avutil/atomics: replace avpriv atomics with stdatomics

2017-12-15 Thread Josh de Kock
much about development on the platform, but I've been told that _Atomic may not be available on it. -- Josh de Kock <j...@itanimul.li> 0001-avutil-atomics-replace-avpriv-atomics-with-stdatomics.patch Description: plain/text ___ ffmpeg-devel mailin

Re: [FFmpeg-devel] [PATCH] Added Turing codec to ffmpeg

2017-12-13 Thread Josh de Kock
s patch were to be merged and then turingcodec to actually go stale we'd be left with dead code for longer than is ideal (forever). My opinion is that you should just maintain this separately as an out-of-tree patch as it doesn't benefit us. -- Josh de Kock <j

Re: [FFmpeg-devel] lavd: remove deprecated dv1394 device

2017-09-27 Thread Josh de Kock
On 27/09/2017 13:33, wm4 wrote: > On Wed, 27 Sep 2017 13:09:02 +0100 > Josh de Kock <j...@itanimul.li> wrote: > >> Support for this device has been removed in kernel since v2.6.37. dv1394 >> has been superseded by libiec61883 which is functionally equivalent. >>

Re: [FFmpeg-devel] Deprecation of visual output devices

2017-09-27 Thread Josh de Kock
On 27/09/2017 16:28, Carl Eugen Hoyos wrote: > 2017-09-27 17:21 GMT+02:00 Josh de Kock <j...@itanimul.li>: >> On 27/09/2017 16:17, Carl Eugen Hoyos wrote: >>> 2017-09-27 17:15 GMT+02:00 wm4 <nfx...@googlemail.com>: >>>> On Wed, 27 Sep 2017 17:08:06 +0200

Re: [FFmpeg-devel] Deprecation of visual output devices

2017-09-27 Thread Josh de Kock
On 27/09/2017 16:17, Carl Eugen Hoyos wrote: > 2017-09-27 17:15 GMT+02:00 wm4 <nfx...@googlemail.com>: >> On Wed, 27 Sep 2017 17:08:06 +0200 >> Carl Eugen Hoyos <ceffm...@gmail.com> wrote: >> >>> 2017-09-27 15:18 GMT+02:00 Josh de Kock <j...@itani

[FFmpeg-devel] Deprecation of visual output devices

2017-09-27 Thread Josh de Kock
have been quick hacky in libavdevice for a long time. There are three patches attached to deprecate the SDL2, OpenGL, and libcaca devices. -- Josh From f950674e8893da8438ade6cee1050062d2bfb86c Mon Sep 17 00:00:00 2001 From: Josh de Kock <j...@itanimul.li> Date: Wed, 27 Sep 2017 13:26:19

[FFmpeg-devel] lavd: remove deprecated dv1394 device

2017-09-27 Thread Josh de Kock
Support for this device has been removed in kernel since v2.6.37. dv1394 has been superseded by libiec61883 which is functionally equivalent. Signed-off-by: Josh de Kock <j...@itanimul.li> --- configure| 3 - doc/indevs.texi | 25 libavdevice/Makefile

Re: [FFmpeg-devel] [PATCH] avformat/libopenmpt: Query duration and metadata after selecting subsong

2017-09-26 Thread Josh de Kock
osm...@problemloesungsmaschine.de> --- ping? This looks fine I've tested with latest libopenmpt. Pushed. Thanks, -- Josh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavc/libzvbi: base support for multiple levels

2017-02-17 Thread Josh de Kock
On 18/02/2017 00:51, Marton Balint wrote: > > On Fri, 17 Feb 2017, Josh de Kock wrote: > >> Also add support for level 1.0 explicitly. >> > > What is the use case for this? Reducing the number of colors? > Pretty much. > I don't think you can reduce the n

[FFmpeg-devel] [PATCH] lavc/libzvbi: base support for multiple levels

2017-02-17 Thread Josh de Kock
Also add support for level 1.0 explicitly. Signed-off-by: Josh de Kock <j...@itanimul.li> --- libavcodec/libzvbi-teletextdec.c | 60 1 file changed, 42 insertions(+), 18 deletions(-) diff --git a/libavcodec/libzvbi-teletextdec.c b/libavcodec/l

[FFmpeg-devel] [PATCH] lavf/mpegts: document DVB teletext PMT fields

2017-02-17 Thread Josh de Kock
Signed-off-by: Josh de Kock <j...@itanimul.li> --- libavformat/mpegts.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 590abb0..bcf2118 100644 --- a/libavformat/mpegts.c +++ b/libavformat/mpegts.c @@ -1718,6 +1718,11

Re: [FFmpeg-devel] [PATCH v2] lavc/libzvbi: remove deprecated API usage

2017-02-12 Thread Josh de Kock
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 12/02/2017 15:28, Marton Balint wrote: > > On Sun, 12 Feb 2017, Josh de Kock wrote: > >> Hi Carl, >> >> I'm not sure, 0.2.28 doesn't compile on my system. It has been >> tested with the latest version 0.2.3

[FFmpeg-devel] [PATCH v2] lavc/libzvbi: remove deprecated API usage

2017-02-12 Thread Josh de Kock
Hi Carl, I'm not sure, 0.2.28 doesn't compile on my system. It has been tested with the latest version 0.2.38. Does the updated patch look better? Josh Signed-off-by: Josh de Kock <j...@itanimul.li> --- libavcodec/libzvbi-teletextdec.c | 15 +-- 1 file changed, 13 insertions

[FFmpeg-devel] [PATCH] lavc/libzvbi: remove deprecated API usage

2017-02-11 Thread Josh de Kock
Signed-off-by: Josh de Kock <j...@itanimul.li> --- libavcodec/libzvbi-teletextdec.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/libavcodec/libzvbi-teletextdec.c b/libavcodec/libzvbi-teletextdec.c index d1f0a9f..2ed4a82 100644 --- a/libavcodec/l

[FFmpeg-devel] [PATCH] lavf/vsrc_testsrc: fix SMPTE segfault with small output size

2016-12-15 Thread Josh de Kock
The memset (line 1336) in draw_bar is passed a negative size if the output width is less than 36 pixels Signed-off-by: Josh de Kock <j...@itanimul.li> --- libavfilter/vsrc_testsrc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavfilter/vsrc_testsrc.c b/libavfilter/vsrc_tes

Re: [FFmpeg-devel] [PATCH] Added Turing codec interface for ffmpeg

2016-11-29 Thread Josh de Kock
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 29/11/2016 17:18, Matteo Naccari wrote: > [...] Please send any later versions of this patch as a reply to the same thread with a v3 (or later). For example (for this email): [PATCH v3] Thanks, - -- Josh PGP fingerpr

Re: [FFmpeg-devel] [PATCH] Remove the ffserver program and the ffm muxer/demuxer

2016-11-27 Thread Josh de Kock
gt; Yeah, let's not rush things, I wouldn't mind waiting until then > either. And I agree that ffserver shouldn't be in the main repo in > the 3.3 release. I don't think anyone is rushing things, this has waited long enough. We have an ultimatum, which is to push this on the 29th of November.

Re: [FFmpeg-devel] [PATCH] travis.yml: Whitelist "coverity" branch in preparation for Coverity integration

2016-11-27 Thread Josh de Kock
s no limit on travis org builds, as far as I know. And if Travis is going to be added as a FATE client in the future then this commit would have to be reverted. - -- Josh PGP fingerprint: A93A602D7A6D3C5388D792BCD052D40DDEF9703D -BEGIN PGP SIGNATURE- Comment: GPGTools - https://gpgtools.or

Re: [FFmpeg-devel] coverity testing of FFmpeg

2016-11-27 Thread Josh de Kock
d to be configured to build - just run the > coverity scan. I'd be happy to investigate this, but I'd need admin > permissions on github to configure travis integration. > > --phil I can help with Travis CI + GitHub, if any is needed, I have used it extensively with o

Re: [FFmpeg-devel] [PATCH] Remove the ffserver program and the ffm muxer/demuxer

2016-11-24 Thread Josh de Kock
ailable somewhere? > > Best regards, > Andreas There's no benefit in waiting for this to occur before ffserver is removed as it will always be in git history. Removing ffserver from master may even speed up the "resurrection of ffserver". I think this shouldn't be delayed any furth

Re: [FFmpeg-devel] [PATCH] sbgdec: prevent NULL pointer access

2016-11-22 Thread Josh de Kock
On 22/11/2016 23:37, Andreas Cadhalpun wrote: > On 23.11.2016 00:01, Josh de Kock wrote: >> On 22/11/2016 22:22, Andreas Cadhalpun wrote: >>> On 10.11.2016 22:24, Andreas Cadhalpun wrote: >>>> Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com>

Re: [FFmpeg-devel] [PATCH] configure: fail if sdl2 was requested but not found

2016-11-22 Thread Josh de Kock
On 22/11/2016 23:11, Andreas Cadhalpun wrote: On 22.11.2016 23:43, Josh de Kock wrote: On 22/11/2016 22:33, Andreas Cadhalpun wrote: Because it avoids confusing users. And the checks for other system libraries should do this, too. I see no real reason to add this, but neither a reason

Re: [FFmpeg-devel] [PATCH] sbgdec: prevent NULL pointer access

2016-11-22 Thread Josh de Kock
Ping. It would be good to have this fixed in 3.2.1. I don't see how s->tseq can be NULL unless the functions are externally invoked without a proper state (which they shouldn't be because they're static). -- Josh ___ ffmpeg-devel mailing list ffmpe

Re: [FFmpeg-devel] [PATCH] mxfdec: fix NULL pointer dereference in mxf_read_packet_old

2016-11-22 Thread Josh de Kock
k->intra_only) { /* intra-only -> PTS = EditUnit. * let utils.c figure out DTS since it can be < PTS if low_delay = 0 (Sony IMX30) */ pkt->pts = mxf->current_edit_unit; Ping. It would be

Re: [FFmpeg-devel] [PATCH] configure: fail if sdl2 was requested but not found

2016-11-22 Thread Josh de Kock
nk that it should stay as-is, or all other system libraries should have the same behavior as well. Consistency is key. -- Josh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [RFC] lavf: add CoreMedia AVCodecTag mappings

2016-11-21 Thread Josh de Kock
On 21/11/2016 09:51, Carl Eugen Hoyos wrote: 2016-11-21 10:35 GMT+01:00 Josh de Kock <j...@itanimul.li>: On 20/11/2016 22:49, Carl Eugen Hoyos wrote: 2016-11-19 17:37 GMT+01:00 Josh de Kock <j...@itanimul.li>: I've mapped a fair amount of the CoreMedia FourCCs to their respectiv

Re: [FFmpeg-devel] [RFC] lavf: add CoreMedia AVCodecTag mappings

2016-11-21 Thread Josh de Kock
On 20/11/2016 22:49, Carl Eugen Hoyos wrote: 2016-11-19 17:37 GMT+01:00 Josh de Kock <j...@itanimul.li>: I've mapped a fair amount of the CoreMedia FourCCs to their respective AVCodecIDs. The ones I didn't know or thought didn't exist in FFmpeg have been mapped to AV_CODEC_ID_NONE. Cou

[FFmpeg-devel] [RFC] lavf: add CoreMedia AVCodecTag mappings

2016-11-19 Thread Josh de Kock
I've mapped a fair amount of the CoreMedia FourCCs to their respective AVCodecIDs. The ones I didn't know or thought didn't exist in FFmpeg have been mapped to AV_CODEC_ID_NONE. Signed-off-by: Josh de Kock <j...@itanimul.li> --- libavformat/Makefile| 1 + libavformat/avformat.h

Re: [FFmpeg-devel] [PATCH] Added the interface for the Turing codec

2016-11-18 Thread Josh de Kock
of(libturingEncodeContext, options), AV_OPT_TYPE_STRING,{ 0 }, 0, 0, AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_ENCODING_PARAM }, +{ NULL } +}; + +static const AVClass class = { +.class_name = "libturing", +.item_name = av_default_item_name, +.option = options, +.version = LIBAVUTIL_VERS

Re: [FFmpeg-devel] [PATCH] ffplay: allow fallback to software renderer

2016-11-17 Thread Josh de Kock
, AV_LOG_VERBOSE, "Initialized %s renderer.\n", info.name); If the hwaccel renderer fails, it may be useful to give the user the SDL_Error as well. F.ex: av_log(NULL, AV_LOG_WARNING, "Failed to intialize a hardware accelerated renderer: %s\n", SDL_GetError()); -- Josh Sorry

Re: [FFmpeg-devel] [PATCH] vf_colorspace: don't spam console with warnings if range is unspecified.

2016-10-20 Thread Josh de Kock
fall-through +} case AVCOL_RANGE_MPEG: *off = 16 << (depth - 8); *y_rng = 219 << (depth - 8); I think did_warn_range would sound more natural. LGTM otherwise (with or without the change). -- Josh ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Apple Quicktime fix / MP4 and MOV Timebase

2016-10-12 Thread Josh de Kock
On 11/10/2016 22:53, Moritz Barsnick wrote: On Tue, Oct 11, 2016 at 19:32:14 +0100, Josh de Kock wrote: On 11/10/2016 18:24, Alexey Eromenko wrote: *** BLURB HERE *** This commit message isn't very useful, it doesn't describe the change at all. See: https://www.ffmpeg.org/developer.html

[FFmpeg-devel] [PATCH v2] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Josh de Kock
Fixes ticket #5882. While it doesn't automatically set the timescale for the user as that would destroy data without prompt, it will tell the user how they could set the timescale (as this is mostly likely what they want). Signed-off-by: Josh de Kock <j...@itanimul.li> --- >Would it

Re: [FFmpeg-devel] [PATCH] avformat/udp: deprecate local_port option

2016-10-11 Thread Josh de Kock
al_port; } diff --git a/libavformat/version.h b/libavformat/version.h index 92801b4..71c03ef 100644 --- a/libavformat/version.h +++ b/libavformat/version.h @@ -85,6 +85,9 @@ #ifndef FF_API_HTTP_USER_AGENT #define FF_API_HTTP_USER_AGENT (LIBAVFORMAT_VERSION_MAJOR < 58) #endif +#ifndef FF_API_UDP_LOCAL

Re: [FFmpeg-devel] [PATCH] Apple Quicktime fix / MP4 and MOV Timebase

2016-10-11 Thread Josh de Kock
://www.ffmpeg.org/developer.html#Patches_002fCommitting -- Josh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Apple Quicktime fix

2016-10-11 Thread Josh de Kock
ot;); Keep the logic in the same place please. if (track->mode == MODE_MOV && track->par->codec_id == AV_CODEC_ID_RAWVIDEO && track->tag == MKTAG('r','a','w',' ')) { -- Josh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Josh de Kock
if (pix_fmt == AV_PIX_FMT_NONE && track->par->bits_per_coded_sample == 1) pix_fmt = AV_PIX_FMT_MONOWHITE; I don't think it's good to have the default behaviour destroy the original timestamps. -- Josh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Josh de Kock
Fixes ticket #5882. While it doesn't automatically set the timescale for the user as that would destroy data without prompt, it will tell the user how they could set the timescale (as this is mostly likely what they want). Signed-off-by: Josh de Kock <j...@itanimul.li> --- libavformat/mo

[FFmpeg-devel] [PATCH] doc/developer: remove duplicate policies and fix error

2016-10-04 Thread Josh de Kock
Fixes regression as of ee72b6d1 Signed-off-by: Josh de Kock <j...@itanimul.li> --- The irony of this patch is terrible, but oh well. Maybe we're missing a 'everyone makes mistakes' policy. doc/developer.texi | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff

Re: [FFmpeg-devel] [PATCH 0/4] V12 - SCTE-35 support

2016-10-04 Thread Josh de Kock
disable SCTE35 entirely? -- Josh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v2 1/2] doc/developer: reword some of the policies

2016-10-04 Thread Josh de Kock
On 03/10/2016 00:05, Michael Niedermayer wrote: On Sun, Oct 02, 2016 at 11:16:49PM +0100, Josh de Kock wrote: On 02/10/2016 22:47, Michael Niedermayer wrote: On Sun, Oct 02, 2016 at 01:51:41AM +0100, Josh de Kock wrote: Explicitly state that FATE should pass, and code should work for all

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/ivi_dsp.c: fix warning due to misleading indentation

2016-10-04 Thread Josh de Kock
On 03/10/2016 15:40, Josh de Kock wrote: On 02/10/2016 19:46, Adriano Pallavicino wrote: LGTM. Will apply both patches squashed in a day if there are no further comments. Applied. -- Josh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http

Re: [FFmpeg-devel] [PATCH] libavformat/bink.c: fix warning due to misleading indentation

2016-10-03 Thread Josh de Kock
On 02/10/2016 19:35, Josh de Kock wrote: Hi Adriano, We appreciate the patches, but is it possible you could maybe collate your cosmetic patches and send them as a larger set? This patch LGTM though, will push tomorrow if no further comments. Applied. -- Josh

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/ivi_dsp.c: fix warning due to misleading indentation

2016-10-03 Thread Josh de Kock
On 02/10/2016 19:46, Adriano Pallavicino wrote: LGTM. Will apply both patches squashed in a day if there are no further comments. -- Josh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]doc/platform: Mention musl where x86_32 is not supported

2016-10-02 Thread Josh de Kock
sco.com/developers/devspecs/abi386-4.pdf pages 37-38 -- Josh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v2] doc/t2h: use container

2016-10-02 Thread Josh de Kock
On 03/10/2016 00:07, Timothy Gu wrote: On Sun, Oct 02, 2016 at 02:53:22PM +0100, Josh de Kock wrote: Full width text is really difficult to read, this makes it more more legible on larger (widescreen) screens. It also means we aren't inventing our own container instead of using the bootstrap

Re: [FFmpeg-devel] [PATCH v2 1/2] doc/developer: reword some of the policies

2016-10-02 Thread Josh de Kock
On 02/10/2016 22:47, Michael Niedermayer wrote: On Sun, Oct 02, 2016 at 01:51:41AM +0100, Josh de Kock wrote: Explicitly state that FATE should pass, and code should work for all reviewers who tested. Signed-off-by: Josh de Kock <j...@itanimul.li> --- doc/developer.tex

Re: [FFmpeg-devel] [PATCH] libavformat/bink.c: fix warning due to misleading indentation

2016-10-02 Thread Josh de Kock
Hi Adriano, We appreciate the patches, but is it possible you could maybe collate your cosmetic patches and send them as a larger set? This patch LGTM though, will push tomorrow if no further comments. -- Josh ___ ffmpeg-devel mailing list ffmpeg

[FFmpeg-devel] [PATCH v2] doc/t2h: use container

2016-10-02 Thread Josh de Kock
Full width text is really difficult to read, this makes it more more legible on larger (widescreen) screens. It also means we aren't inventing our own container instead of using the bootstrap one. Signed-off-by: Josh de Kock <j...@itanimul.li> --- doc/t2h.init | 2 +- doc/t2h.pm | 2

[FFmpeg-devel] [PATCH v2 2/2] doc/developer: add sections for policies

2016-10-01 Thread Josh de Kock
And sort policies into these sections. Signed-off-by: Josh de Kock <j...@itanimul.li> --- doc/developer.texi | 95 +++--- 1 file changed, 48 insertions(+), 47 deletions(-) diff --git a/doc/developer.texi b/doc/developer.texi index 0075a27..e

[FFmpeg-devel] [PATCH v2 1/2] doc/developer: reword some of the policies

2016-10-01 Thread Josh de Kock
Explicitly state that FATE should pass, and code should work for all reviewers who tested. Signed-off-by: Josh de Kock <j...@itanimul.li> --- doc/developer.texi | 91 ++ 1 file changed, 44 insertions(+), 47 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] doc/t2h: add max-width to css.

2016-10-01 Thread Josh de Kock
On 01/10/2016 02:28, Josh de Kock wrote: Full width text is really difficult to read, this just makes it slightly more legible on larger (widescreen) screens. Signed-off-by: Josh de Kock <j...@itanimul.li> --- See http://screenshotcomparison.com/comparison/186256 for a comparison of

[FFmpeg-devel] [PATCH 2/2] doc/developer: add sections for policies

2016-10-01 Thread Josh de Kock
And sort policies into these sections. Signed-off-by: Josh de Kock <j...@itanimul.li> --- doc/developer.texi | 95 +++--- 1 file changed, 48 insertions(+), 47 deletions(-) diff --git a/doc/developer.texi b/doc/developer.texi index d4344ff..b

[FFmpeg-devel] [PATCH 1/2] doc/developer: reword some of the policies

2016-10-01 Thread Josh de Kock
Removed allowing for commiting disabled, unfinished code. Code should always try be in a working state. Explicitly state that FATE should pass, and code should work for all reviewers who tested. Signed-off-by: Josh de Kock <j...@itanimul.li> --- doc/developer.tex

Re: [FFmpeg-devel] [PATCH] configure: define posix source on cygwin

2016-10-01 Thread Josh de Kock
On 01/10/2016 20:41, Timo Rothenpieler wrote: Will push tomorrow if nobody objects. LGTM, maybe add a note which says that it may have been a cygwin update which broke the build. -- Josh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http

Re: [FFmpeg-devel] [PATCH 1/2] ffplay: use decoder avctx for decoded subtitle width/height

2016-10-01 Thread Josh de Kock
h; +sp->height = is->subdec.avctx->height; sp->uploaded = 0; /* now we can update the picture count */ Feels backwards to go to a avctx from codecpar, but if it fixes 5873 then it's fine, it can alway

Re: [FFmpeg-devel] [PATCH 2/2] ffplay: remove unused viddec_width/viddec_height

2016-10-01 Thread Josh de Kock
tx->width; -is->viddec_height = avctx->height; - decoder_init(>viddec, avctx, >videoq, is->continue_read_thread); if ((ret = decoder_start(>viddec, video_thread, is)) < 0) goto out; LGTM. -- Josh ___ ffmpeg-

[FFmpeg-devel] [PATCH v2] doc/developer: improve development policy formatting

2016-10-01 Thread Josh de Kock
This commit also rewords some of the policies for more clarity. Signed-off-by: Josh de Kock <j...@itanimul.li> --- doc/developer.texi | 172 + 1 file changed, 82 insertions(+), 90 deletions(-) diff --git a/doc/developer.texi

Re: [FFmpeg-devel] [PATCH] doc/developer: improve Development Policy formatting

2016-10-01 Thread Josh de Kock
and eventually fixed. This text disappears Nice catch, I was going to rewrite this one, seems I missed it somehow. will update the patch. -- Josh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] fate: Add fate-svq3-watermark

2016-09-30 Thread Josh de Kock
On 01/10/2016 02:56, Michael Niedermayer wrote: On Sat, Oct 01, 2016 at 02:27:15AM +0200, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer --- tests/fate/qt.mak | 3 ++- tests/ref/fate/svq3-watermark | 15 +++ 2 files changed, 17

[FFmpeg-devel] [PATCH] doc/t2h: add max-width to css.

2016-09-30 Thread Josh de Kock
Full width text is really difficult to read, this just makes it slightly more legible on larger (widescreen) screens. Signed-off-by: Josh de Kock <j...@itanimul.li> --- See http://screenshotcomparison.com/comparison/186256 for a comparison of before/after. doc/t2h.init | 2 +- doc/t2h.pm

[FFmpeg-devel] [PATCH] doc/developer: improve Development Policy formatting

2016-09-30 Thread Josh de Kock
Signed-off-by: Josh de Kock <j...@itanimul.li> --- doc/developer.texi | 163 - 1 file changed, 74 insertions(+), 89 deletions(-) diff --git a/doc/developer.texi b/doc/developer.texi index 4d3a7ae..2df58a9 100644 --- a/doc/developer.texi

Re: [FFmpeg-devel] [PATCH] lavc/mediacodecdec_h2645: fix nalu data_size type

2016-09-30 Thread Josh de Kock
data_size = 0; if ((ret = h2645_ps_to_nalu(sps->data, sps->data_size, , _size)) < 0) { goto done; Shouldn't you change h2645_ps_to_nalu()'s size arguments to size_t as well? -- Josh ___ ffmpeg-devel mailing list ffmpe

Re: [FFmpeg-devel] [PATCH] lavc: remove libfaac wrapper

2016-09-29 Thread Josh de Kock
s it possible to confirm that there are no other encoders which could produce the same issue in movenc as libfaac? Also, related to libfaac would be irrelevant if it were dropped. -- Josh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavc: remove libfaac wrapper

2016-09-29 Thread Josh de Kock
s you attack another developer personally? wm4 didn't attack anyone, they just said that the argument was ambiguous and may benefit from further explanation. -- Josh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/lis

[FFmpeg-devel] [PATCH] lavc: remove libfaac wrapper

2016-09-29 Thread Josh de Kock
it themselves (which at that point should just use fdk-aac). Signed-off-by: Josh de Kock <j...@itanimul.li> --- Changelog | 1 + LICENSE.md | 2 - configure | 6 -- doc/encoders.texi | 105 - doc/ffserver.conf | 2 +

Re: [FFmpeg-devel] [PATCH] lavf: add ffprobe demuxer

2016-09-29 Thread Josh de Kock
t's also just another hack in for a non-standardised, exclusive format. Lavf is really not a good fit for this and it should be done outside of libav*. -- Josh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/2] movenc: Add support for writing language codes into ISML manifests

2016-09-29 Thread Josh de Kock
ot;systemLanguage", lang ? lang->value : "und"); if (track->par->codec_type == AVMEDIA_TYPE_VIDEO) { if (track->par->codec_id == AV_CODEC_ID_H264) { uint8_t *ptr; Thanks, applied. -- Josh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/2] movenc: Add support for writing language codes into ISML manifests

2016-09-28 Thread Josh de Kock
ot;systemLanguage", lang ? lang->value : "und"); if (track->par->codec_type == AVMEDIA_TYPE_VIDEO) { if (track->par->codec_id == AV_CODEC_ID_H264) { uint8_t *ptr; LGTM. Will push tomorrow if no further comments. -- Josh _

Re: [FFmpeg-devel] [PATCH] libavcodec/qdm2.c: fix warning due to misleading indentation

2016-09-28 Thread Josh de Kock
On 27/09/2016 23:11, Josh de Kock wrote: On 27/09/2016 20:47, Adriano Pallavicino wrote: Sure Adriano This patch looks good to me, just going to give it a little time for others to comment. Thanks, applied. -- Josh ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] ffprobe: don't use AVStream.codec to set decoder framerate

2016-09-27 Thread Josh de Kock
av_log(NULL, AV_LOG_WARNING, "Could not open codec for input stream %d\n", LGTM -- Josh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] libavcodec/qdm2.c: fix warning due to misleading indentation

2016-09-27 Thread Josh de Kock
On 27/09/2016 20:47, Adriano Pallavicino wrote: Sure Adriano This patch looks good to me, just going to give it a little time for others to comment. -- Josh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo

Re: [FFmpeg-devel] [PATCH] libavcodec/qdm2.c: fix warning due to misleading indentation

2016-09-27 Thread Josh de Kock
coding_method[ch][sb][j] = 30; -} +if (coding_method[ch][sb][j] < 30) +coding_method[ch][sb][j] = 30; } + } } else { // superblocktype_2_3 != 0 for (ch = 0; ch < nb_channels; ch++)

Re: [FFmpeg-devel] [PATCH] doc/libav-merge: complete TODO section

2016-09-25 Thread Josh de Kock
On 25/09/2016 18:35, Clément Bœsch wrote: --- What else is missing? --- doc/libav-merge.txt | 10 ++ 1 file changed, 10 insertions(+) diff --git a/doc/libav-merge.txt b/doc/libav-merge.txt index 4fd863e..e200bdb 100644 --- a/doc/libav-merge.txt +++ b/doc/libav-merge.txt @@ -84,4 +84,14

Re: [FFmpeg-devel] [PATCH] lavd/sdl2: remove unused code

2016-09-25 Thread Josh de Kock
On 24/09/2016 19:01, Josh de Kock wrote: Signed-off-by: Josh de Kock <j...@itanimul.li> --- libavdevice/sdl2.c | 27 +-- 1 file changed, 5 insertions(+), 22 deletions(-) [...] Applied. ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH v3] lavd/sdl2: add sdl alias

2016-09-25 Thread Josh de Kock
On 25/09/2016 14:51, Josh de Kock wrote: On 25/09/2016 14:50, Carl Eugen Hoyos wrote: 2016-09-25 15:48 GMT+02:00 Josh de Kock <j...@itanimul.li>: On 25/09/2016 14:43, Carl Eugen Hoyos wrote: 2016-09-25 15:40 GMT+02:00 Josh de Kock <j...@itanimul.li>: On 25/09/2016 14:38, Carl

<    1   2   3   4   5   >