Re: [FFmpeg-devel] [PATCH] libavformat/mxfdec: read source timecode from pulldown component

2014-10-27 Thread tomas . hardin
On 2014-10-26 00:33, Mark Reid wrote: On Sat, Oct 25, 2014 at 1:42 PM, Tomas Härdin wrote: On Fri, 2014-10-24 at 17:31 -0700, Mark Reid wrote: > --- > libavformat/mxf.h | 1 + > libavformat/mxfdec.c | 31 +-- > tests/ref/lavf/mxf | 6 +++--- > tests/r

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Fix false positive in infinite loop detector

2014-10-27 Thread tomas . hardin
On 2014-10-27 16:27, Michael Niedermayer wrote: Fixes Ticket4040 Signed-off-by: Michael Niedermayer --- libavformat/mxfdec.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index b01dd0c..a1abc34 100644 --- a/libavfo

[FFmpeg-devel] [PATCH 1/5] mxfdec: Break out parts of mxf_read_header() into separate functions

2014-10-28 Thread tomas . hardin
This is part of a series of patches that fix tickets 3278 and 4040 (http://trac.ffmpeg.org/ticket/3278 http://trac.ffmpeg.org/ticket/4040), plus some refactoring. I uploaded a file called deadlock3.mxf (and corresponding deadlock3.txt) to incoming that demonstrates another issue similar to Tic

Re: [FFmpeg-devel] [PATCH 1/5] mxfdec: Break out parts of mxf_read_header() into separate functions

2014-10-28 Thread tomas . hardin
This fixes the actual issue (Ticket 3278). See also deadlock3.mxf on FTP. /TomasFrom 783aaa31271266587fad8f60a588ed755744a765 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Tue, 28 Oct 2014 13:38:18 +0100 Subject: [PATCH 2/5] mxfdec: Parse PreviousPartition in mxf_seek_to

[FFmpeg-devel] [PATCH 3/5] Revert "avformat/mxfdec: detect loops during header parsing

2014-10-28 Thread tomas . hardin
From 662adc4db39b1925c90fc78fb83d58c0e3e6dfd4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Tue, 28 Oct 2014 13:33:47 +0100 Subject: [PATCH 3/5] Revert "avformat/mxfdec: detect loops during header parsing" This reverts commit 1c010fd035c1a14dc73827b84f21f593e969a5d6. ---

[FFmpeg-devel] [PATCH 4/5] mxfdec: Merge last_partition and footer_partition

2014-10-28 Thread tomas . hardin
From 86ce75449ef2febb584d7f337a4035ef2cee2b1a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Tue, 28 Oct 2014 14:27:06 +0100 Subject: [PATCH 4/5] mxfdec: Merge last_partition and footer_partition FooterPartition offset specified in RIP takes precedence over any value written

[FFmpeg-devel] [PATCH 5/5] mxfdec: Tighten RIP length bounds in mxf_read_random_index_pack()

2014-10-28 Thread tomas . hardin
From d1827479c17186db7bda472e92b272bbdf4ddcfb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Tue, 28 Oct 2014 14:36:27 +0100 Subject: [PATCH 5/5] mxfdec: Tighten RIP length bounds in mxf_read_random_index_pack() --- libavformat/mxfdec.c | 27 +-- 1

[FFmpeg-devel] [PATCH 2/5] mxfdec: Parse PreviousPartition in mxf_seek_to_previous_partition()

2014-10-28 Thread tomas . hardin
On 2014-10-28 15:31, tomas.har...@codemill.se wrote: This fixes the actual issue (Ticket 3278). See also deadlock3.mxf on FTP. /Tomas Oops, wrong subject - I should probably set up git-send-email.. Reattached patch just to be sure. /TomasFrom 783aaa31271266587fad8f60a588ed755744a765 Mon Se

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: AVC Intra support

2014-10-29 Thread tomas . hardin
On 2014-10-28 23:38, Thomas Mundt wrote: Carl Eugen, I changed the indentations and attached a unified diff. Since I´m on windows I used turtoise git. I hope that´s okay. Regards, Thomas Looks good to me /Tomas ___ ffmpeg-devel mailing list ffmpeg-d

Re: [FFmpeg-devel] [Patch]support more AVC Intra formats without SPS/PPS header

2014-10-29 Thread tomas . hardin
On 2014-10-29 14:04, Thomas Mundt wrote: Hi, this patch will add support for AVC Intra 50 720p and 1080p without SPS/PPS header in mxf and mov demuxers. I got the SPS/PPS tables from libbmx. Regards, Thomas Looks OK to me. /Tomas ___ ffmpeg-devel ma

Re: [FFmpeg-devel] [PATCH v3] libavformat/mxfdec.c: support demuxing opatom audio without index

2015-01-14 Thread tomas . hardin
On 2015-01-12 02:18, Mark Reid wrote: changes since v2: *removed log line and changed av_mallocz sizeof --- libavformat/mxfdec.c | 55 1 file changed, 55 insertions(+) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 4715169.

Re: [FFmpeg-devel] [PATCH] test/fate: added mxf_opatom regression tests

2015-02-10 Thread tomas . hardin
On 2015-02-10 04:19, Mark Reid wrote: --- configure | 1 + tests/fate/avformat.mak| 1 + tests/fate/seek.mak| 2 ++ tests/lavf-regression.sh | 4 tests/ref/lavf/mxf_opatom | 3 +++ tests/ref/seek/lavf-mxf_opatom | 53

Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: write package name metadata

2015-02-16 Thread tomas . hardin
On 2015-02-13 01:36, Mark Reid wrote: /** + * Convert an UTF-8 string to UTF-16BE and write it. + * @return number of bytes written. + */ +int avio_put_str16be(AVIOContext *s, const char *str); You could maybe split this patch up by making the part that adds this function a separate patch. No

Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: write package name metadata

2015-02-17 Thread tomas . hardin
On 2015-02-16 20:24, Mark Reid wrote: On Mon, Feb 16, 2015 at 4:07 AM, wrote: On 2015-02-13 01:36, Mark Reid wrote: /** + * Convert an UTF-8 string to UTF-16BE and write it. + * @return number of bytes written. + */ +int avio_put_str16be(AVIOContext *s, const char *str); You could maybe

Re: [FFmpeg-devel] [PATCH v3 2/2] libavformat/mxfenc: write package name metadata

2015-03-04 Thread tomas . hardin
On 2015-03-03 05:06, Mark Reid wrote: +/* + * Returns the calculated length a local tag containing an utf-8 string as utf-16 + */ +static uint64_t mxf_utf16_local_tag_length(const char *utf8_str) +{ +return utf8_str? 4 + mxf_utf16len(utf8_str) * 2: 0; Should return zero if mxf_utf16len()*2

Re: [FFmpeg-devel] [PATCH] mxfenc: ensure mxf->body_partition_offset is not NULL before using it

2015-03-17 Thread tomas . hardin
On 2015-03-14 18:03, Andreas Cadhalpun wrote: On 14.03.2015 02:17, Mark Reid wrote: On Fri, Mar 13, 2015 at 6:02 AM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: On 13.03.2015 11:59, Tomas Härdin wrote: A better solution would be to figure out why mxf->body_partition_offset be

Re: [FFmpeg-devel] [PATCH] mxfenc: ensure mxf->body_partition_offset is not NULL before using it

2015-03-18 Thread tomas . hardin
On 2015-03-17 16:13, Andreas Cadhalpun wrote: On 17.03.2015 10:17, tomas.har...@codemill.se wrote: On 2015-03-14 18:03, Andreas Cadhalpun wrote: [PATCH 2/2] mxfenc: don't try to write footer without header: +if (!mxf->header_written || +(s->oformat == &ff_mxf_opatom_muxer && !mxf-

Re: [FFmpeg-devel] [PATCH] Add 'Presentation Y offset' metadata

2015-03-30 Thread tomas . hardin
On 2015-03-30 12:19, tim nicholson wrote: Some software mis decodes IMX material in mxf if this metadata field is missing. See the discussion on the ffmpeg ML:- "[FFmpeg-user] How to set 3 specific metadata flags (ITU601/displayoffset) in FFmpegs IMX50 MXF-OP1a encoding?" This patch add this fi

Re: [FFmpeg-devel] [PATCH] Add 'Presentation Y offset' metadata

2015-03-30 Thread tomas . hardin
On 2015-03-30 14:21, Michael Niedermayer wrote: On Mon, Mar 30, 2015 at 12:31:04PM +0200, tomas.har...@codemill.se wrote: On 2015-03-30 12:19, tim nicholson wrote: >Some software mis decodes IMX material in mxf if this metadata field is >missing. See the discussion on the ffmpeg ML:- > >"[FFmpeg

Re: [FFmpeg-devel] [PATCH]Set interlaced flag when muxing interlaced dnxhd into mxf

2015-05-04 Thread tomas . hardin
On 2015-05-04 12:18, Carl Eugen Hoyos wrote: On Monday 20 April 2015 12:26:50 am Tomas Härdin wrote: On Fri, 2015-04-17 at 00:31 +0200, Carl Eugen Hoyos wrote: > Hi! > > Completely untested. The original patch was successfully tested: http://ffmpeg.gusari.org/viewtopic.php?f=11&t=2065 No ide

Re: [FFmpeg-devel] opw@ffmpeg mail alias

2014-10-13 Thread tomas . hardin
On 2014-10-13 03:49, Michael Niedermayer wrote: Hi all does any mentor want to be added to the opw@ffmpeg alias if so, tell me and ill add you thanks Add me too. I had an applicant PM me on IRC (shreshtha), but I haven't been able to reply to them since they're only online sporadically. /T