Re: [FFmpeg-devel] [PATCH] avformat/avidec: ensure that palette does not contain the BottomUp info.

2014-09-24 Thread Michael Niedermayer
On Wed, Sep 24, 2014 at 08:57:31AM +0200, Benoit Fouet wrote: > Hi, > > - Mail original - > > On Tue, Sep 23, 2014 at 03:11:58PM +0200, Michael Niedermayer wrote: > > > On Tue, Sep 23, 2014 at 01:33:30PM +0200, Benoit Fouet wrote: > > > > Hi, > > > > > > > > - Mail original - > >

Re: [FFmpeg-devel] [PATCH] avformat/avidec: ensure that palette does not contain the BottomUp info.

2014-09-23 Thread Benoit Fouet
Hi, - Mail original - > On Tue, Sep 23, 2014 at 03:11:58PM +0200, Michael Niedermayer wrote: > > On Tue, Sep 23, 2014 at 01:33:30PM +0200, Benoit Fouet wrote: > > > Hi, > > > > > > - Mail original - > > > > Hi, > > > > > > > > - Mail original - > > > > > On Tue, Sep 23, 2

Re: [FFmpeg-devel] [PATCH] avformat/avidec: ensure that palette does not contain the BottomUp info.

2014-09-23 Thread Michael Niedermayer
On Tue, Sep 23, 2014 at 03:11:58PM +0200, Michael Niedermayer wrote: > On Tue, Sep 23, 2014 at 01:33:30PM +0200, Benoit Fouet wrote: > > Hi, > > > > - Mail original - > > > Hi, > > > > > > - Mail original - > > > > On Tue, Sep 23, 2014 at 10:19:17AM +0200, Benoit Fouet wrote: > >

Re: [FFmpeg-devel] [PATCH] avformat/avidec: ensure that palette does not contain the BottomUp info.

2014-09-23 Thread Michael Niedermayer
On Tue, Sep 23, 2014 at 01:33:30PM +0200, Benoit Fouet wrote: > Hi, > > - Mail original - > > Hi, > > > > - Mail original - > > > On Tue, Sep 23, 2014 at 10:19:17AM +0200, Benoit Fouet wrote: > > > > > > Here is a patch to illustrate this... > > > > > > this looks better but: >

Re: [FFmpeg-devel] [PATCH] avformat/avidec: ensure that palette does not contain the BottomUp info.

2014-09-23 Thread Benoit Fouet
Hi, - Mail original - > Hi, > > - Mail original - > > On Tue, Sep 23, 2014 at 10:19:17AM +0200, Benoit Fouet wrote: > > > > Here is a patch to illustrate this... > > > > this looks better but: > > > > > > [...] > > > -ff_put_bmp_header(pb, enc, ff_codec_bmp_tag

Re: [FFmpeg-devel] [PATCH] avformat/avidec: ensure that palette does not contain the BottomUp info.

2014-09-23 Thread Benoit Fouet
Hi, - Mail original - > On Tue, Sep 23, 2014 at 10:19:17AM +0200, Benoit Fouet wrote: > > Here is a patch to illustrate this... > > this looks better but: > > > [...] > > -ff_put_bmp_header(pb, enc, ff_codec_bmp_tags, 0, > > 0); > > +if (keep_height) { >

Re: [FFmpeg-devel] [PATCH] avformat/avidec: ensure that palette does not contain the BottomUp info.

2014-09-23 Thread Michael Niedermayer
On Tue, Sep 23, 2014 at 10:19:17AM +0200, Benoit Fouet wrote: > Hi, > > - Mail original - > > Hi, > > > > - Mail original - > > > > [...] > > > > > > > > avienc.c |7 +++ > > > > > > 1 file changed, 7 insertions(+) > > > > > > 8ae96276e07eb00474ab2115f9ff9c3d0f690723 a

Re: [FFmpeg-devel] [PATCH] avformat/avidec: ensure that palette does not contain the BottomUp info.

2014-09-23 Thread Benoit Fouet
Hi, - Mail original - > Hi, > > - Mail original - > > [...] > > > > > > avienc.c |7 +++ > > > > > 1 file changed, 7 insertions(+) > > > > > 8ae96276e07eb00474ab2115f9ff9c3d0f690723 avienc.diff > > > > > diff --git a/libavformat/avienc.c b/libavformat/avienc.c > > > >

Re: [FFmpeg-devel] [PATCH] avformat/avidec: ensure that palette does not contain the BottomUp info.

2014-09-23 Thread Benoit Fouet
Hi, - Mail original - [...] > > > > avienc.c |7 +++ > > > > 1 file changed, 7 insertions(+) > > > > 8ae96276e07eb00474ab2115f9ff9c3d0f690723 avienc.diff > > > > diff --git a/libavformat/avienc.c b/libavformat/avienc.c > > > > index c9d8b7f..2855293 100644 > > > > --- a/libavfo

Re: [FFmpeg-devel] [PATCH] avformat/avidec: ensure that palette does not contain the BottomUp info.

2014-09-22 Thread Michael Niedermayer
On Mon, Sep 22, 2014 at 12:14:53PM +0200, Benoit Fouet wrote: > Hi, > > - Mail original - > > On Mon, Sep 22, 2014 at 11:28:31AM +0200, Benoit Fouet wrote: > > > Hi, > > > > > > - Mail original - > > > > On Mon, Sep 22, 2014 at 09:57:37AM +0200, Benoit Fouet wrote: > > > > > Consi

Re: [FFmpeg-devel] [PATCH] avformat/avidec: ensure that palette does not contain the BottomUp info.

2014-09-22 Thread Benoit Fouet
Hi, - Mail original - > On Mon, Sep 22, 2014 at 11:28:31AM +0200, Benoit Fouet wrote: > > Hi, > > > > - Mail original - > > > On Mon, Sep 22, 2014 at 09:57:37AM +0200, Benoit Fouet wrote: > > > > Considering the palette is located at the end of extradata may > > > > be > > > > fla

Re: [FFmpeg-devel] [PATCH] avformat/avidec: ensure that palette does not contain the BottomUp info.

2014-09-22 Thread Michael Niedermayer
On Mon, Sep 22, 2014 at 11:28:31AM +0200, Benoit Fouet wrote: > Hi, > > - Mail original - > > On Mon, Sep 22, 2014 at 09:57:37AM +0200, Benoit Fouet wrote: > > > Considering the palette is located at the end of extradata may be > > > flawed > > > when the extradata contains the palette fol

Re: [FFmpeg-devel] [PATCH] avformat/avidec: ensure that palette does not contain the BottomUp info.

2014-09-22 Thread Benoit Fouet
Hi, - Mail original - > On Mon, Sep 22, 2014 at 09:57:37AM +0200, Benoit Fouet wrote: > > Considering the palette is located at the end of extradata may be > > flawed > > when the extradata contains the palette followed by the BottomUp > > field. > > When the BottomUp field is present, exc

Re: [FFmpeg-devel] [PATCH] avformat/avidec: ensure that palette does not contain the BottomUp info.

2014-09-22 Thread Michael Niedermayer
On Mon, Sep 22, 2014 at 09:57:37AM +0200, Benoit Fouet wrote: > Considering the palette is located at the end of extradata may be flawed > when the extradata contains the palette followed by the BottomUp field. > When the BottomUp field is present, exclude it from the palette. > Fixes ticket #1304

[FFmpeg-devel] [PATCH] avformat/avidec: ensure that palette does not contain the BottomUp info.

2014-09-22 Thread Benoit Fouet
Considering the palette is located at the end of extradata may be flawed when the extradata contains the palette followed by the BottomUp field. When the BottomUp field is present, exclude it from the palette. Fixes ticket #1304 --- libavformat/avidec.c | 4 1 file changed, 4 insertions(+) d