Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-11-13 Thread Nicolas George
Le duodi 22 brumaire, an CCXXIII, Binathi Bingi a écrit : > From a7c6a1f74902b6df8e4cc62480e8fd6f023905c4 Mon Sep 17 00:00:00 2001 > From: Binathi Bingi > Date: Tue, 4 Nov 2014 21:42:07 +0530 > Subject: [PATCH] Restore Daemon mode in FFserver > > Signed-off-by: Binathi Bingi > > Author:Bin

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-11-12 Thread Binathi Bingi
Hi there, Updated changes in the patch. Please let me know if any further enhancements are required. Thanks, Binathi On Wed, Nov 12, 2014 at 8:50 PM, Stefano Sabatini wrote: > On date Wednesday 2014-11-12 00:46:09 +0530, Binathi Bingi encoded: > [...] > > From 692fb9ee19d5f9acf080eb98d22ca15f

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-11-12 Thread Stefano Sabatini
On date Wednesday 2014-11-12 00:46:09 +0530, Binathi Bingi encoded: [...] > From 692fb9ee19d5f9acf080eb98d22ca15fa1176393 Mon Sep 17 00:00:00 2001 > From: Binathi Bingi > Date: Tue, 4 Nov 2014 21:42:07 +0530 > Subject: [PATCH] Restore Daemon mode in FFserver > > Signed-off-by: Binathi Bingi > >

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-11-11 Thread Reynaldo H. Verdejo Pinochet
Hello On 11/11/2014 04:16 PM, Binathi Bingi wrote: [..] Updated patch. Please let me know if there are any other changes needed. [..] Hello Binathi. Thanks for your continuous attention to this matter. Appreciated. Your patch does no longer apply cleanly, you need to rebase it on top of a rec

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-11-11 Thread Binathi Bingi
Hi there, Updated patch. Please let me know if there are any other changes needed. I meant FFmpeg version 2.4, by "2.4 level". In case Daemon mode is made default, and user launches FFserver in debug mode, in that case, FFserver would be prevented from forking, forcing foreground mode. I am not

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-11-11 Thread Binathi Bingi
Hi there, Updated patch. Please let me know if there are any other changes needed. I meant FFmpeg version 2.4, by "2.4 level". In case Daemon mode is made default, and user launches FFserver in debug mode, in that case, FFserver would be prevented from forking, forcing foreground mode. I am not

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-11-11 Thread Stefano Sabatini
On date Tuesday 2014-11-11 00:19:26 +0530, Binathi Bingi encoded: > Hi there, > > Please find the attached patch with modifications. [...] > From 091b4a02c9325bea32b7f745d028ea72c8e1537e Mon Sep 17 00:00:00 2001 > From: Binathi Bingi > Date: Tue, 4 Nov 2014 21:42:07 +0530 > Subject: [PATCH] Resto

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-11-10 Thread Binathi Bingi
Hi there, Please find the attached patch with modifications. Regards, Binathi On Mon, Nov 10, 2014 at 8:42 PM, Stefano Sabatini wrote: > On date Monday 2014-11-10 13:26:14 +0530, Binathi Bingi encoded: > [...] > > From c9d037758693a1522258a64849f7629d7cbd7408 Mon Sep 17 00:00:00 2001 > > From

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-11-10 Thread Stefano Sabatini
On date Monday 2014-11-10 13:26:14 +0530, Binathi Bingi encoded: [...] > From c9d037758693a1522258a64849f7629d7cbd7408 Mon Sep 17 00:00:00 2001 > From: Binathi Provide complete name, the patch is used to track copyright. > Date: Tue, 4 Nov 2014 21:42:07 +0530 > Subject: [PATCH] Restore Daemon mo

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-11-10 Thread Nicolas George
Le decadi 20 brumaire, an CCXXIII, Binathi Bingi a écrit : > I use nano editor. If you expect you will work on source codes (not necessarily just FFmpeg) a lot, I believe taking the time of learning a better editor would be a very good investment. > I tried to remove trailing whitespace in git pa

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-11-09 Thread Binathi Bingi
Hi there, I use nano editor. I tried to remove trailing whitespace in git patch using "git format-patch -b -w -1" Please find the attached patch. Regards, Binathi On Sun, Nov 9, 2014 at 3:40 PM, Nicolas George wrote: > Le septidi 17 brumaire, an CCXXIII, Binathi Bingi a écrit : > > From f06f2

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-11-09 Thread Nicolas George
Le septidi 17 brumaire, an CCXXIII, Binathi Bingi a écrit : > From f06f2b656feb9b01c42533bcdf51fc5190ca6f91 Mon Sep 17 00:00:00 2001 > From: Binathi > Date: Tue, 4 Nov 2014 21:42:07 +0530 > Subject: [PATCH] Restore Daemon mode in FFserver > > Signed-off-by: Binathi Bingi > --- > doc/ffserver.co

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-11-07 Thread Binathi Bingi
Hi there, Please find the attached patch. Regards Binathi On Thu, Nov 6, 2014 at 1:55 AM, Nicolas George wrote: > Le quintidi 15 brumaire, an CCXXIII, Binathi Bingi a écrit : > > I see, we need dup2() to redirect the output to logfile. Therefore, I put > > it back in the patch. > > > > But, I

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-11-05 Thread Nicolas George
Le quintidi 15 brumaire, an CCXXIII, Binathi Bingi a écrit : > I see, we need dup2() to redirect the output to logfile. Therefore, I put > it back in the patch. > > But, I am not sure if we should definitely use it, because I can't see any > messages on the console as all are being redirected to l

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-11-04 Thread Binathi Bingi
Hi there, I see, we need dup2() to redirect the output to logfile. Therefore, I put it back in the patch. But, I am not sure if we should definitely use it, because I can't see any messages on the console as all are being redirected to log file For instance, when I run ffserver, I can't see the o

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-11-04 Thread Binathi Bingi
Hi there, I am sorry for the indentation errors in the above mail, it was because of bad email agent. In the attached patch, if the config.logfilename is not "-", then stdout is closed and then I reopened. Reynaldo, is right. I don't think it is good idea to use dup2(). There were problems in ru

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-11-03 Thread Reynaldo H. Verdejo Pinochet
Hi On 11/03/2014 04:09 PM, Binathi Bingi wrote: > Hello, > > Inside the child process, I closed the file descriptor and then reopened > and redirected them using dup2() and later closed the opened file. I am not > sure if I understood and used the functionality of dup2() in the right > sense. >

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-11-03 Thread Binathi Bingi
Hello, Inside the child process, I closed the file descriptor and then reopened and redirected them using dup2() and later closed the opened file. I am not sure if I understood and used the functionality of dup2() in the right sense. Regards, Binathi On Sat, Nov 1, 2014 at 10:18 PM, Lukasz Marek

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-11-01 Thread Lukasz Marek
On 01.11.2014 17:20, Binathi Bingi wrote: +if (config.ffserver_daemon) { +int ffserver_id = 0; You may change int to pid_t too, which is actually returned by fork() +pid_t sid = 0; + +ffserver_id = fork(); ___ ffmpeg-de

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-11-01 Thread Nicolas George
Le primidi 11 brumaire, an CCXXIII, Binathi Bingi a écrit : > I tried to incorporate the changes suggested in above mail. > Now we have NoDaemon as by default as per the current standard. > NoDaemon and Daemon are now treated as two separate options. > Code is indented. > Reason for fork fail inclu

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-11-01 Thread Binathi Bingi
Hello I tried to incorporate the changes suggested in above mail. Now we have NoDaemon as by default as per the current standard. NoDaemon and Daemon are now treated as two separate options. Code is indented. Reason for fork fail included. Documentation has been changed. From e4b0cc451b7ffcf42f0a

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-11-01 Thread Nicolas George
Le decadi 10 brumaire, an CCXXIII, Binathi Bingi a écrit : > Hello > > I tried to include the changes specified by Nicholas. > We can switch between both Daemon and NoDaemon mode, using the option in > ffserver.conf file. > > >From 018f8c1e1acf062a9e6a3ec94f671d574ec4b712 Mon Sep 17 00:00:00 2001

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-10-31 Thread Michael Niedermayer
On Fri, Oct 31, 2014 at 11:32:37PM +0530, Binathi Bingi wrote: > Hello > > I tried to include the changes specified by Nicholas. > We can switch between both Daemon and NoDaemon mode, using the option in > ffserver.conf file. > > From 018f8c1e1acf062a9e6a3ec94f671d574ec4b712 Mon Sep 17 00:00:00 2

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-10-31 Thread Binathi Bingi
Hello I tried to include the changes specified by Nicholas. We can switch between both Daemon and NoDaemon mode, using the option in ffserver.conf file. >From 018f8c1e1acf062a9e6a3ec94f671d574ec4b712 Mon Sep 17 00:00:00 2001 From: Binathi Date: Fri, 31 Oct 2014 23:27:20 +0530 Subject: [PATCH] En

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-10-30 Thread Reynaldo H. Verdejo Pinochet
Hello On 10/30/2014 10:50 AM, Nicolas George wrote: > [..] Third, I do not think this exact version is correct. If you > make the daemon mode the default, then NoDaemon must not be > ignored, it must have its specified effect: turn daemon off; if you > do not make the daemon mode the default, then

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-10-30 Thread Nicolas George
Le nonidi 9 brumaire, an CCXXIII, Binathi Bingi a écrit : > >From 0fb7dcf1f126bd137e2b2025c5cd6cff4af65801 Mon Sep 17 00:00:00 2001 > From: Binathi Bingi > Date: Thu, 30 Oct 2014 01:14:08 +0530 > Subject: [PATCH] ffserver: enable back deamon mode > > --- > ffserver.c| 34

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-10-30 Thread Binathi Bingi
I see your point. Changing the ffserver_config.c would help in addressing config files having NoDaemon option. You were right! Thanks. >From 476c8605fab4d6c575c38796dd9dccaf854cf536 Mon Sep 17 00:00:00 2001 From: Binathi Bingi Date: Thu, 30 Oct 2014 13:43:13 +0530 Subject: [PATCH] Restoring back

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-10-29 Thread Michael Niedermayer
On Thu, Oct 30, 2014 at 07:49:10AM +0530, Binathi Bingi wrote: > If you check the latest ffserver.conf file on GIT [ > http://git.videolan.org/?p=ffmpeg.git > ], > there

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-10-29 Thread Binathi Bingi
If you check the latest ffserver.conf file on GIT [ http://git.videolan.org/?p=ffmpeg.git ], there is NoDaemon option in it. So the patch is written as per latest versio

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-10-29 Thread Michael Niedermayer
On Thu, Oct 30, 2014 at 02:14:59AM +0530, Binathi Bingi wrote: > From 0fb7dcf1f126bd137e2b2025c5cd6cff4af65801 Mon Sep 17 00:00:00 2001 > From: Binathi Bingi > Date: Thu, 30 Oct 2014 01:14:08 +0530 > Subject: [PATCH] ffserver: enable back deamon mode > > --- > ffserver.c| 34

[FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-10-29 Thread Binathi Bingi
>From 0fb7dcf1f126bd137e2b2025c5cd6cff4af65801 Mon Sep 17 00:00:00 2001 From: Binathi Bingi Date: Thu, 30 Oct 2014 01:14:08 +0530 Subject: [PATCH] ffserver: enable back deamon mode --- ffserver.c| 34 ++ ffserver_config.c | 2 -- 2 files changed, 30 inser