Re: [FFmpeg-devel] [External Sender] Re: [PATCH] fftools/ffmpeg_enc: Prevent duplicate A53 Closed Captions at frame rate up-conversion

2023-06-09 Thread Artem Smorodin
Hi David, I think the reworking of the "-r" option is a breaking change. I understand that output won't conform to the spec, but at least CC won't be broken. For example libx264->a53cc option is 1 by default, so any h264 output with CC with frame rate up-conversion will be broken. The behavi

Re: [FFmpeg-devel] [External Sender] Re: [PATCH] fftools/ffmpeg_enc: Prevent duplicate A53 Closed Captions at frame rate up-conversion

2023-06-13 Thread Devin Heitmueller
On Fri, Jun 9, 2023 at 12:33 PM Artem Smorodin wrote: > The behavior that adds this patch was there before, but was removed after > about 5.1.1, so I think it's safe to restore it until a better solution is > implemented. I have to admit that I'm hesitant about introducing a patch that only wor