Re: [FFmpeg-devel] [PATCH/RFC]lavf/aacdec: Do not auto-detect a single frame

2016-09-24 Thread Carl Eugen Hoyos
2016-09-24 16:04 GMT+02:00 Ronald S. Bultje : >> >> An alternative would be to return "1" for two frames. >> > >> > Is there any point in detecting two AAC frames? I mean, we're >> > talking about a split second audio... >> >> True, but I believe if it is the beginning of the file, a positive >> s

Re: [FFmpeg-devel] [PATCH/RFC]lavf/aacdec: Do not auto-detect a single frame

2016-09-24 Thread Ronald S. Bultje
Hi, On Sat, Sep 24, 2016 at 9:11 AM, Carl Eugen Hoyos wrote: > Hi! > > 2016-09-24 14:58 GMT+02:00 Ronald S. Bultje : > > > > On Fri, Sep 23, 2016 at 6:00 PM, Carl Eugen Hoyos > wrote: > >> > >> I use this patch locally for some time. It fixes > >> many misdetections, a similar patch was applied

Re: [FFmpeg-devel] [PATCH/RFC]lavf/aacdec: Do not auto-detect a single frame

2016-09-24 Thread wm4
On Sat, 24 Sep 2016 15:11:33 +0200 Carl Eugen Hoyos wrote: > Hi! > > 2016-09-24 14:58 GMT+02:00 Ronald S. Bultje : > > > > On Fri, Sep 23, 2016 at 6:00 PM, Carl Eugen Hoyos wrote: > > > >> > >> I use this patch locally for some time. It fixes > >> many misdetections, a similar patch was appl

Re: [FFmpeg-devel] [PATCH/RFC]lavf/aacdec: Do not auto-detect a single frame

2016-09-24 Thread Carl Eugen Hoyos
Hi! 2016-09-24 14:58 GMT+02:00 Ronald S. Bultje : > > On Fri, Sep 23, 2016 at 6:00 PM, Carl Eugen Hoyos wrote: >> >> I use this patch locally for some time. It fixes >> many misdetections, a similar patch was applied to >> loas detection three years ago. >> An alternative would be to return "1" f

Re: [FFmpeg-devel] [PATCH/RFC]lavf/aacdec: Do not auto-detect a single frame

2016-09-24 Thread Ronald S. Bultje
Hi, On Fri, Sep 23, 2016 at 6:00 PM, Carl Eugen Hoyos wrote: > Hi! > > I use this patch locally for some time. It fixes > many misdetections, a similar patch was applied to > loas detection three years ago. > An alternative would be to return "1" for two frames. Is there any point in detecting

Re: [FFmpeg-devel] [PATCH/RFC]lavf/aacdec: Do not auto-detect a single frame

2016-09-24 Thread compn
On Sat, 24 Sep 2016 00:00:35 +0200 Carl Eugen Hoyos wrote: > Hi! > > I use this patch locally for some time. It fixes > many misdetections, a similar patch was applied to > loas detection three years ago. > An alternative would be to return "1" for two frames. this prevents all of those files

[FFmpeg-devel] [PATCH/RFC]lavf/aacdec: Do not auto-detect a single frame

2016-09-23 Thread Carl Eugen Hoyos
Hi! I use this patch locally for some time. It fixes many misdetections, a similar patch was applied to loas detection three years ago. An alternative would be to return "1" for two frames. Please comment, Carl Eugen From f3d9ebedcbc137c4d639efdbed485298f9dc9f3e Mon Sep 17 00:00:00 2001 From: C