Re: [FFmpeg-devel] [PATCH][GSoC] lavf/http: Parse and set HTTP method when listening on HTTP(S)

2015-06-04 Thread Nicolas George
Le sextidi 16 prairial, an CCXXIII, Stephan Holljes a écrit : I hope I understood what you meant. Exactly. The order of the patches attached was reversed, maybe that's why it looked like the indentation was done first. I was a bit confused at first then I noticed. It was just advice for

Re: [FFmpeg-devel] [PATCH][GSoC] lavf/http: Parse and set HTTP method when listening on HTTP(S)

2015-06-03 Thread Stephan Holljes
On Tue, Jun 2, 2015 at 10:56 AM, Nicolas George geo...@nsup.org wrote: Le quartidi 14 prairial, an CCXXIII, Stephan Holljes a écrit : I agree, I have probably thought a little bit too far ahead. I hope the attached patches are okay. I'm somewhat unsure about the first patch, because it checks

Re: [FFmpeg-devel] [PATCH][GSoC] lavf/http: Parse and set HTTP method when listening on HTTP(S)

2015-06-03 Thread Stephan Holljes
On Wed, Jun 3, 2015 at 10:39 PM, Nicolas George geo...@nsup.org wrote: http_listen(), you wrote it yourself. Maybe I was not clear enough, I just suggested to move the code in a function for better readability (the name of the function is self-documentating), nothing more complicated. I hope I

Re: [FFmpeg-devel] [PATCH][GSoC] lavf/http: Parse and set HTTP method when listening on HTTP(S)

2015-06-02 Thread Nicolas George
Le quartidi 14 prairial, an CCXXIII, Stephan Holljes a écrit : I agree, I have probably thought a little bit too far ahead. I hope the attached patches are okay. I'm somewhat unsure about the first patch, because it checks ret and sets it explicitly if no other error occurred. I also added

Re: [FFmpeg-devel] [PATCH][GSoC] lavf/http: Parse and set HTTP method when listening on HTTP(S)

2015-06-01 Thread Stephan Holljes
On Sat, May 30, 2015 at 10:13 AM, Nicolas George geo...@nsup.org wrote: Le decadi 10 prairial, an CCXXIII, Stephan Holljes a écrit : Should method be reassigned or should the set value be kept? As far as I can tell the only way to set method is by specifying it as an option in the command

Re: [FFmpeg-devel] [PATCH][GSoC] lavf/http: Parse and set HTTP method when listening on HTTP(S)

2015-06-01 Thread Nicolas George
Le tridi 13 prairial, an CCXXIII, Stephan Holljes a écrit : After looking at the ffserver code, I'm wondering if maintaining a list of clients as HTTPContext or custom wrapper structs would make sense. For the time being it would only contain the singular client context which can be accepted

Re: [FFmpeg-devel] [PATCH][GSoC] lavf/http: Parse and set HTTP method when listening on HTTP(S)

2015-06-01 Thread Stephan Holljes
On Mon, Jun 1, 2015 at 10:52 PM, Nicolas George geo...@nsup.org wrote: Le tridi 13 prairial, an CCXXIII, Stephan Holljes a écrit : After looking at the ffserver code, I'm wondering if maintaining a list of clients as HTTPContext or custom wrapper structs would make sense. For the time being

Re: [FFmpeg-devel] [PATCH][GSoC] lavf/http: Parse and set HTTP method when listening on HTTP(S)

2015-05-30 Thread Nicolas George
Le decadi 10 prairial, an CCXXIII, Stephan Holljes a écrit : Should method be reassigned or should the set value be kept? As far as I can tell the only way to set method is by specifying it as an option in the command line. I don't think overwriting specific values set by the user is good.

Re: [FFmpeg-devel] [PATCH][GSoC] lavf/http: Parse and set HTTP method when listening on HTTP(S)

2015-05-29 Thread Michael Niedermayer
On Fri, May 29, 2015 at 05:05:08AM +0200, Stephan Holljes wrote: Signed-off-by: Stephan Holljes klaxa1...@googlemail.com --- libavformat/http.c | 8 1 file changed, 8 insertions(+) diff --git a/libavformat/http.c b/libavformat/http.c index 4f6716a..3fad43d 100644 ---

Re: [FFmpeg-devel] [PATCH][GSoC] lavf/http: Parse and set HTTP method when listening on HTTP(S)

2015-05-29 Thread Stephan Holljes
On Fri, May 29, 2015 at 4:19 PM, wm4 nfx...@googlemail.com wrote: On Fri, 29 May 2015 16:12:27 +0200 Stephan Holljes klaxa1...@googlemail.com wrote: Hi, On Fri, May 29, 2015 at 11:54 AM, Michael Niedermayer michae...@gmx.at wrote: On Fri, May 29, 2015 at 05:05:08AM +0200, Stephan Holljes

Re: [FFmpeg-devel] [PATCH][GSoC] lavf/http: Parse and set HTTP method when listening on HTTP(S)

2015-05-29 Thread Stephan Holljes
On Fri, May 29, 2015 at 4:34 PM, Stephan Holljes klaxa1...@googlemail.com wrote: On Fri, May 29, 2015 at 4:19 PM, wm4 nfx...@googlemail.com wrote: On Fri, 29 May 2015 16:12:27 +0200 Stephan Holljes klaxa1...@googlemail.com wrote: Hi, On Fri, May 29, 2015 at 11:54 AM, Michael Niedermayer

Re: [FFmpeg-devel] [PATCH][GSoC] lavf/http: Parse and set HTTP method when listening on HTTP(S)

2015-05-29 Thread Stephan Holljes
On Fri, May 29, 2015 at 7:10 PM, Nicolas George geo...@nsup.org wrote: Le decadi 10 prairial, an CCXXIII, Stephan Holljes a écrit : From 33a479200b9a941d0783d941c6ea68f8b85cc4de Mon Sep 17 00:00:00 2001 From: Stephan Holljes klaxa1...@googlemail.com Date: Fri, 29 May 2015 16:47:11 +0200

Re: [FFmpeg-devel] [PATCH][GSoC] lavf/http: Parse and set HTTP method when listening on HTTP(S)

2015-05-29 Thread Nicolas George
Le decadi 10 prairial, an CCXXIII, Stephan Holljes a écrit : From 33a479200b9a941d0783d941c6ea68f8b85cc4de Mon Sep 17 00:00:00 2001 From: Stephan Holljes klaxa1...@googlemail.com Date: Fri, 29 May 2015 16:47:11 +0200 Subject: [PATCH] lavf/http: Parse and set HTTP method when listening on

Re: [FFmpeg-devel] [PATCH][GSoC] lavf/http: Parse and set HTTP method when listening on HTTP(S)

2015-05-29 Thread wm4
On Fri, 29 May 2015 16:12:27 +0200 Stephan Holljes klaxa1...@googlemail.com wrote: Hi, On Fri, May 29, 2015 at 11:54 AM, Michael Niedermayer michae...@gmx.at wrote: On Fri, May 29, 2015 at 05:05:08AM +0200, Stephan Holljes wrote: Signed-off-by: Stephan Holljes klaxa1...@googlemail.com

[FFmpeg-devel] [PATCH][GSoC] lavf/http: Parse and set HTTP method when listening on HTTP(S)

2015-05-28 Thread Stephan Holljes
Signed-off-by: Stephan Holljes klaxa1...@googlemail.com --- libavformat/http.c | 8 1 file changed, 8 insertions(+) diff --git a/libavformat/http.c b/libavformat/http.c index 4f6716a..3fad43d 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -556,6 +556,14 @@ static int