Re: [FFmpeg-devel] [PATCH] Add DXV encoder with support for DXT1 texture format

2024-01-19 Thread Vittorio Giovara
On Fri, Jan 19, 2024 at 5:56 PM Connor Worley wrote: > Thanks for the feedback! For the next revision, is it preferred to reply > to this thread or create a new one? > here is fine > On 1/19/24 08:23, Vittorio Giovara wrote: > >> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c > >

Re: [FFmpeg-devel] [PATCH] Add DXV encoder with support for DXT1 texture format

2024-01-19 Thread Connor Worley
Thanks for the feedback! For the next revision, is it preferred to reply to this thread or create a new one? On 1/19/24 08:23, Vittorio Giovara wrote: >> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c >> index 93ce8e3224..ef8c3a6d7d 100644 >> --- a/libavcodec/allcodecs.c >> +++ b/li

Re: [FFmpeg-devel] [PATCH] Add DXV encoder with support for DXT1 texture format

2024-01-19 Thread Vittorio Giovara
Hi, thanks for the patch, below a few minor nits On Wed, Jan 17, 2024 at 9:57 PM Connor Worley wrote: > diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c > index 93ce8e3224..ef8c3a6d7d 100644 > --- a/libavcodec/allcodecs.c > +++ b/libavcodec/allcodecs.c > @@ -106,6 +106,7 @@ extern co

[FFmpeg-devel] [PATCH] Add DXV encoder with support for DXT1 texture format

2024-01-17 Thread Connor Worley
Signed-off-by: Connor Worley --- Changelog | 1 + configure | 1 + doc/general_contents.texi | 3 +- libavcodec/Makefile | 1 + libavcodec/allcodecs.c| 1 + libavcodec/dxvenc.c | 358 ++ libavcodec/versi

Re: [FFmpeg-devel] [PATCH] Add DXV encoder with support for DXT1 texture format

2024-01-17 Thread Connor Worley
On 1/17/24 08:55, Connor Worley wrote: Signed-off-by: Connor Worley ---  Changelog |   1 +  configure |   1 +  doc/general_contents.texi |   3 +-  libavcodec/Makefile   |   1 +  libavcodec/allcodecs.c    |   1 +  libavcodec/dxvenc.c   | 362 ++

[FFmpeg-devel] [PATCH] Add DXV encoder with support for DXT1 texture format

2024-01-17 Thread Connor Worley
Signed-off-by: Connor Worley --- Changelog | 1 + configure | 1 + doc/general_contents.texi | 3 +- libavcodec/Makefile | 1 + libavcodec/allcodecs.c| 1 + libavcodec/dxvenc.c | 362 ++ libavcodec/vers

Re: [FFmpeg-devel] [PATCH] Add DXV encoder with support for DXT1 texture format

2024-01-17 Thread Michael Niedermayer
On Wed, Jan 17, 2024 at 12:27:40AM -0800, Connor Worley wrote: > Signed-off-by: Connor Worley > --- > Changelog | 1 + > configure | 1 + > doc/general_contents.texi | 3 +- > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c| 1 + > libavcode

[FFmpeg-devel] [PATCH] Add DXV encoder with support for DXT1 texture format

2024-01-17 Thread Connor Worley
Signed-off-by: Connor Worley --- Changelog | 1 + configure | 1 + doc/general_contents.texi | 3 +- libavcodec/Makefile | 1 + libavcodec/allcodecs.c| 1 + libavcodec/dxvenc.c | 362 ++ libavcodec/vers