Re: [FFmpeg-devel] [PATCH] Add bitrate and framerate option for openH264

2016-07-14 Thread Carl Eugen Hoyos
Steven Liu gmail.com> writes: > This patch can modified the bitrate and frame at > the encoder runtime, for example: Simply compare iBitrate and s->bitrate for every frame and reconfigure if necessary: No new option needed. Carl Eugen ___ ffmpeg-d

Re: [FFmpeg-devel] [PATCH] Add bitrate and framerate option for openH264

2016-07-14 Thread Steven Liu
2016-07-14 18:22 GMT+08:00 Carl Eugen Hoyos : > Steven Liu gmail.com> writes: > > > +{ "bitrate", "Set bitrate", OFFSET(bitrate), > > AV_OPT_TYPE_INT, { 0 }, 0, 70, VE }, > > +{ "framerate", "Set framerate", OFFSET(framerate), > > AV_OPT_TYPE_INT, { 0 }, 0, 30, VE }, > > Both options

Re: [FFmpeg-devel] [PATCH] Add bitrate and framerate option for openH264

2016-07-14 Thread Carl Eugen Hoyos
Steven Liu gmail.com> writes: > +{ "bitrate", "Set bitrate", OFFSET(bitrate), > AV_OPT_TYPE_INT, { 0 }, 0, 70, VE }, > +{ "framerate", "Set framerate", OFFSET(framerate), > AV_OPT_TYPE_INT, { 0 }, 0, 30, VE }, Both options already exist in FFmpeg, it may be a good idea to map them

[FFmpeg-devel] [PATCH] Add bitrate and framerate option for openH264

2016-07-14 Thread Steven Liu
Signed-off-by: ErLiu <88486...@qq.com> --- libavcodec/libopenh264enc.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c index 24bc228..f7f11f9 100644 --- a/libavcodec/libopenh264enc.c +++ b/libavco