Re: [FFmpeg-devel] [PATCH] Allow 'concat' filter to support inputs with different frame rates

2017-03-08 Thread Calvin Walton
On Wed, 2017-03-08 at 20:35 +0100, Nicolas George wrote: > L'octidi 18 ventôse, an CCXXV, Calvin Walton a écrit : > > Hmm. Setting it to the same as the input value if all inputs match > > shouldn't be too hard, I think. > > > > In the actual case of inputs with different frame rates, would it be

Re: [FFmpeg-devel] [PATCH] Allow 'concat' filter to support inputs with different frame rates

2017-03-08 Thread Nicolas George
L'octidi 18 ventôse, an CCXXV, Calvin Walton a écrit : > Hmm. Setting it to the same as the input value if all inputs match > shouldn't be too hard, I think. > > In the actual case of inputs with different frame rates, would it be > better to use the '1/0' value, or should it attempt to calculate

Re: [FFmpeg-devel] [PATCH] Allow 'concat' filter to support inputs with different frame rates

2017-03-08 Thread wm4
On Wed, 08 Mar 2017 14:14:25 -0500 Calvin Walton wrote: > On Wed, 2017-03-08 at 19:27 +0100, Nicolas George wrote: > > L'octidi 18 ventôse, an CCXXV, Calvin Walton a écrit : > > > > > > If a later input is higher framerate, this results in dropped frames; if > > > a

Re: [FFmpeg-devel] [PATCH] Allow 'concat' filter to support inputs with different frame rates

2017-03-08 Thread Calvin Walton
On Wed, 2017-03-08 at 19:27 +0100, Nicolas George wrote: > L'octidi 18 ventôse, an CCXXV, Calvin Walton a écrit : > > > > If a later input is higher framerate, this results in dropped frames; if > > a later input is lower framerate it might cause judder. > > > > The simplest fix is to just set

Re: [FFmpeg-devel] [PATCH] Allow 'concat' filter to support inputs with different frame rates

2017-03-08 Thread Nicolas George
L'octidi 18 ventôse, an CCXXV, Calvin Walton a écrit : > Right now, the concat filter does not set the frame_rate value on any of > the out links. As a result, the default ffmpeg behaviour kicks in - to > copy the framerate from the first input to the outputs. > > If a later input is higher

[FFmpeg-devel] [PATCH] Allow 'concat' filter to support inputs with different frame rates

2017-03-08 Thread Calvin Walton
Right now, the concat filter does not set the frame_rate value on any of the out links. As a result, the default ffmpeg behaviour kicks in - to copy the framerate from the first input to the outputs. If a later input is higher framerate, this results in dropped frames; if a later input is lower