Re: [FFmpeg-devel] [PATCH] Decoding of Bold-Italic-Underlined styles for 3gpp timed text

2015-04-24 Thread Niklesh Lalwani
Hi, I am really sorry for replying late. I was stuck up with my end semester examinations. Anyways, I was working on implementing structs and passing style_start and style_end as indices rather than addresses, but with no proper results till now. Here is my previous patch improved with C code stand

Re: [FFmpeg-devel] [PATCH] Decoding of Bold-Italic-Underlined styles for 3gpp timed text

2015-04-22 Thread Niklesh Lalwani
Thank you for your suggestions. I'll try to do as much as I can before the deadline. -Niklesh On Wed, Apr 22, 2015 at 10:57 PM, Philip Langdale wrote: > On 2015-04-22 03:10, Niklesh Lalwani wrote: > >> From: Niklesh >> >> This patch supports decoding of Bold, Italic, Underlined styles for >> 3

Re: [FFmpeg-devel] [PATCH] Decoding of Bold-Italic-Underlined styles for 3gpp timed text

2015-04-22 Thread Philip Langdale
On 2015-04-22 03:10, Niklesh Lalwani wrote: From: Niklesh This patch supports decoding of Bold, Italic, Underlined styles for 3gpp timed text. While the code can be improved upon to make it more clean and well structured, this works for now, even for multiple style records. Suggestions awaited.

Re: [FFmpeg-devel] [PATCH] Decoding of Bold-Italic-Underlined styles for 3gpp timed text

2015-04-22 Thread Carl Eugen Hoyos
Niklesh Lalwani iitb.ac.in> writes: > +int i=0; Usual style is: int i = 0; > +for (i=0; i +} > +else > +text_to_ass(&buf, ptr, end, NULL, NULL, 0, 0); Please make this: } else { text_to_ass(&buf, ptr, end, NULL, NULL, 0, 0); } There is a script tools/patcheck t

[FFmpeg-devel] [PATCH] Decoding of Bold-Italic-Underlined styles for 3gpp timed text

2015-04-22 Thread Niklesh Lalwani
From: Niklesh Updated patch for decoding of Bold-Italic-Underlined style records for 3gpp timed text. Fixed several build warnings. Signed-off-by: Niklesh --- libavcodec/movtextdec.c | 91 + 1 file changed, 85 insertions(+), 6 deletions(-) diff

Re: [FFmpeg-devel] [PATCH] Decoding of Bold-Italic-Underlined styles for 3gpp timed text

2015-04-22 Thread Michael Niedermayer
Hi On Wed, Apr 22, 2015 at 03:40:03PM +0530, Niklesh Lalwani wrote: > From: Niklesh > > This patch supports decoding of Bold, Italic, Underlined styles for 3gpp > timed text. While the code can be improved upon to make it more clean and > well structured, this works for now, even for multiple

[FFmpeg-devel] [PATCH] Decoding of Bold-Italic-Underlined styles for 3gpp timed text

2015-04-22 Thread Niklesh Lalwani
From: Niklesh This patch supports decoding of Bold, Italic, Underlined styles for 3gpp timed text. While the code can be improved upon to make it more clean and well structured, this works for now, even for multiple style records. Suggestions awaited. Signed-off-by: Niklesh --- libavcodec/mo