Re: [FFmpeg-devel] [PATCH] FATE: fix colorbalance fate test failed on x86_32

2020-07-02 Thread lance . lmwang
On Thu, Jul 02, 2020 at 10:44:22AM +0200, Paul B Mahol wrote: > lgtm thanks, will apply. > > On 7/2/20, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > floating point precision will cause rgb*max generate different value on > > x86_32 and x86_64. have pass fate test on x86_32 and x8

Re: [FFmpeg-devel] [PATCH] FATE: fix colorbalance fate test failed on x86_32

2020-07-02 Thread Paul B Mahol
lgtm On 7/2/20, lance.lmw...@gmail.com wrote: > From: Limin Wang > > floating point precision will cause rgb*max generate different value on > x86_32 and x86_64. have pass fate test on x86_32 and x86_64 by using > lrintf to get the nearest integral value for rgb * max before av_clip. > > Signed-

[FFmpeg-devel] [PATCH] FATE: fix colorbalance fate test failed on x86_32

2020-07-01 Thread lance . lmwang
From: Limin Wang floating point precision will cause rgb*max generate different value on x86_32 and x86_64. have pass fate test on x86_32 and x86_64 by using lrintf to get the nearest integral value for rgb * max before av_clip. Signed-off-by: Limin Wang --- libavfilter/vf_colorbalance.c