Re: [FFmpeg-devel] [PATCH] Ignore invalid sprop-parameter-sets missing PPS

2016-02-29 Thread Andrew Shulgin
Thanks :) On Tue, Mar 1, 2016 at 2:43 AM, Michael Niedermayer wrote: > On Tue, Mar 01, 2016 at 02:11:28AM +0200, Andrew Shulgin wrote: > > Yep, you're right. > > ok, applied > > thanks > > > > > > On Tue, Mar 1, 2016 at 2:09 AM, Michael Niedermayer > > > wrote: > > > > > On Mon, Feb 29, 2016 at

Re: [FFmpeg-devel] [PATCH] Ignore invalid sprop-parameter-sets missing PPS

2016-02-29 Thread Michael Niedermayer
On Tue, Mar 01, 2016 at 02:11:28AM +0200, Andrew Shulgin wrote: > Yep, you're right. ok, applied thanks > > On Tue, Mar 1, 2016 at 2:09 AM, Michael Niedermayer > wrote: > > > On Mon, Feb 29, 2016 at 03:10:41PM +0200, Andrew Shulgin wrote: > > > Extracting SPS without the missig PPS results i

Re: [FFmpeg-devel] [PATCH] Ignore invalid sprop-parameter-sets missing PPS

2016-02-29 Thread Andrew Shulgin
Yep, you're right. On Tue, Mar 1, 2016 at 2:09 AM, Michael Niedermayer wrote: > On Mon, Feb 29, 2016 at 03:10:41PM +0200, Andrew Shulgin wrote: > > Extracting SPS without the missig PPS results in unplayable FLV. > > > > ffmpeg -thread_queue_size 512 -rtsp_transport tcp -i rtsp:// > > admin:1234

Re: [FFmpeg-devel] [PATCH] Ignore invalid sprop-parameter-sets missing PPS

2016-02-29 Thread Michael Niedermayer
On Mon, Feb 29, 2016 at 03:10:41PM +0200, Andrew Shulgin wrote: > Extracting SPS without the missig PPS results in unplayable FLV. > > ffmpeg -thread_queue_size 512 -rtsp_transport tcp -i rtsp:// > admin:12345@192.88.99.1/h264/ch1/main/av_stream -ar 44100 -ac 2 -acodec > pcm_s16le -f s16le -ac 2 -

Re: [FFmpeg-devel] [PATCH] Ignore invalid sprop-parameter-sets missing PPS

2016-02-29 Thread Andrew Shulgin
Also i can send you an email with public RTSP URL privately if you ask. On Mon, Feb 29, 2016 at 3:10 PM, Andrew Shulgin wrote: > Extracting SPS without the missig PPS results in unplayable FLV. > > ffmpeg -thread_queue_size 512 -rtsp_transport tcp -i rtsp:// > admin:12345@192.88.99.1/h264/ch1/ma

Re: [FFmpeg-devel] [PATCH] Ignore invalid sprop-parameter-sets missing PPS

2016-02-29 Thread Andrew Shulgin
Extracting SPS without the missig PPS results in unplayable FLV. ffmpeg -thread_queue_size 512 -rtsp_transport tcp -i rtsp:// admin:12345@192.88.99.1/h264/ch1/main/av_stream -ar 44100 -ac 2 -acodec pcm_s16le -f s16le -ac 2 -i /dev/zero -c:v copy -acodec aac -strict experimental -ab 128k -f flv wro

Re: [FFmpeg-devel] [PATCH] Ignore invalid sprop-parameter-sets missing PPS

2016-02-29 Thread Michael Niedermayer
On Mon, Feb 29, 2016 at 01:59:22PM +0200, Andrew Shulgin wrote: > Corrected the patch a bit, now setting extradata_size to 0 > > On Mon, Feb 29, 2016 at 1:13 PM, Andrew Shulgin > wrote: > > > Correct SPS and PPS are in the stream. > > Maybe it's reasonale to use existing SPS. But i'm not sure ho

Re: [FFmpeg-devel] [PATCH] Ignore invalid sprop-parameter-sets missing PPS

2016-02-29 Thread Andrew Shulgin
Corrected the patch a bit, now setting extradata_size to 0 On Mon, Feb 29, 2016 at 1:13 PM, Andrew Shulgin wrote: > Correct SPS and PPS are in the stream. > Maybe it's reasonale to use existing SPS. But i'm not sure how to > implement that. > Yeah really, setting extradata_size to 0 should not b

Re: [FFmpeg-devel] [PATCH] Ignore invalid sprop-parameter-sets missing PPS

2016-02-29 Thread Andrew Shulgin
Correct SPS and PPS are in the stream. Maybe it's reasonale to use existing SPS. But i'm not sure how to implement that. Yeah really, setting extradata_size to 0 should not be skipped. On Mon, Feb 29, 2016 at 1:01 PM, Michael Niedermayer wrote: > On Sat, Feb 27, 2016 at 09:56:01PM +0200, Andrew

Re: [FFmpeg-devel] [PATCH] Ignore invalid sprop-parameter-sets missing PPS

2016-02-29 Thread Michael Niedermayer
On Sat, Feb 27, 2016 at 09:56:01PM +0200, Andrew Shulgin wrote: > Some Hikvison RTSP cameras send wrong sprop-parameter-sets in SDP - it's > missing PPS. > > Example of correct sprop-parameter-sets: > sprop-parameter-sets=Z0IAH5W4PASaEAAAcIAAFfkAQA==,aM48gA== > Example of wrong sprop-parameter-set

[FFmpeg-devel] [PATCH] Ignore invalid sprop-parameter-sets missing PPS

2016-02-28 Thread Andrew Shulgin
--- libavformat/rtpdec_h264.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/rtpdec_h264.c b/libavformat/rtpdec_h264.c index b399be4..e707d03 100644 --- a/libavformat/rtpdec_h264.c +++ b/libavformat/rtpdec_h264.c @@ -166,6 +166,10 @@ static int sdp_parse_fmtp_config_h264(AVFor

Re: [FFmpeg-devel] [PATCH] Ignore invalid sprop-parameter-sets missing PPS

2016-02-27 Thread Andrew Shulgin
Some Hikvison RTSP cameras send wrong sprop-parameter-sets in SDP - it's missing PPS. Example of correct sprop-parameter-sets: sprop-parameter-sets=Z0IAH5W4PASaEAAAcIAAFfkAQA==,aM48gA== Example of wrong sprop-parameter-sets: sprop-parameter-sets=Z0IAH5WoPASaEAAAcIAAFfkIQA==, My patch adds a worka

Re: [FFmpeg-devel] [PATCH] Ignore invalid sprop-parameter-sets missing PPS

2016-02-27 Thread Andrew Shulgin
Sorry, wrong From: header, sended again with correct On Sat, Feb 27, 2016 at 9:30 PM, Andrew Shulgin wrote: > --- > libavformat/rtpdec_h264.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavformat/rtpdec_h264.c b/libavformat/rtpdec_h264.c > index b399be4..e707d03 100644 > ---

[FFmpeg-devel] [PATCH] Ignore invalid sprop-parameter-sets missing PPS

2016-02-27 Thread Andrew Shulgin
--- libavformat/rtpdec_h264.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/rtpdec_h264.c b/libavformat/rtpdec_h264.c index b399be4..e707d03 100644 --- a/libavformat/rtpdec_h264.c +++ b/libavformat/rtpdec_h264.c @@ -166,6 +166,10 @@ static int sdp_parse_fmtp_config_h264(AVFor