Re: [FFmpeg-devel] [PATCH] Revert "lavc/v4l2_m2m_enc: Add missing braces around initializers."

2018-11-04 Thread Mark Thompson
On 04/11/18 03:46, Ronak wrote: > >> On Oct 31, 2018, at 5:58 PM, Mark Thompson wrote: >> >> On 31/10/18 00:07, Ronak Patel wrote: >>> On Oct 27, 2018, at 5:25 PM, Carl Eugen Hoyos wrote: 2018-10-27 20:50 GMT+02:00, Mark Thompson : > This reverts commit 6dbb64fdccafe846aaec75d

Re: [FFmpeg-devel] [PATCH] Revert "lavc/v4l2_m2m_enc: Add missing braces around initializers."

2018-11-03 Thread Ronak
> On Oct 31, 2018, at 5:58 PM, Mark Thompson wrote: > > On 31/10/18 00:07, Ronak Patel wrote: >> >>> On Oct 27, 2018, at 5:25 PM, Carl Eugen Hoyos wrote: >>> >>> 2018-10-27 20:50 GMT+02:00, Mark Thompson : This reverts commit 6dbb64fdccafe846aaec75d3784f7ad49d8af5df. The addit

Re: [FFmpeg-devel] [PATCH] Revert "lavc/v4l2_m2m_enc: Add missing braces around initializers."

2018-10-31 Thread Mark Thompson
On 31/10/18 00:07, Ronak Patel wrote: > >> On Oct 27, 2018, at 5:25 PM, Carl Eugen Hoyos wrote: >> >> 2018-10-27 20:50 GMT+02:00, Mark Thompson : >>> This reverts commit 6dbb64fdccafe846aaec75d3784f7ad49d8af5df. >>> >>> The additional braces cause build errors with Linux headers earlier >>> than

Re: [FFmpeg-devel] [PATCH] Revert "lavc/v4l2_m2m_enc: Add missing braces around initializers."

2018-10-31 Thread Carl Eugen Hoyos
2018-10-31 1:07 GMT+01:00, Ronak Patel : > >> On Oct 27, 2018, at 5:25 PM, Carl Eugen Hoyos wrote: >> >> 2018-10-27 20:50 GMT+02:00, Mark Thompson : >>> This reverts commit 6dbb64fdccafe846aaec75d3784f7ad49d8af5df. >>> >>> The additional braces cause build errors with Linux headers earlier >>> tha

Re: [FFmpeg-devel] [PATCH] Revert "lavc/v4l2_m2m_enc: Add missing braces around initializers."

2018-10-30 Thread Ronak Patel
> On Oct 27, 2018, at 5:25 PM, Carl Eugen Hoyos wrote: > > 2018-10-27 20:50 GMT+02:00, Mark Thompson : >> This reverts commit 6dbb64fdccafe846aaec75d3784f7ad49d8af5df. >> >> The additional braces cause build errors with Linux headers earlier >> than 4.5 because the first element of the structur

Re: [FFmpeg-devel] [PATCH] Revert "lavc/v4l2_m2m_enc: Add missing braces around initializers."

2018-10-27 Thread Carl Eugen Hoyos
2018-10-27 20:50 GMT+02:00, Mark Thompson : > This reverts commit 6dbb64fdccafe846aaec75d3784f7ad49d8af5df. > > The additional braces cause build errors with Linux headers earlier > than 4.5 because the first element of the structure was not originally > a union. > Not sure what compiler was warni

Re: [FFmpeg-devel] [PATCH] Revert "lavc/v4l2_m2m_enc: Add missing braces around initializers."

2018-10-27 Thread Mark Thompson
On 27/10/18 19:56, James Almer wrote: > On 10/27/2018 3:50 PM, Mark Thompson wrote: >> This reverts commit 6dbb64fdccafe846aaec75d3784f7ad49d8af5df. >> >> The additional braces cause build errors with Linux headers earlier >> than 4.5 because the first element of the structure was not originally >>

Re: [FFmpeg-devel] [PATCH] Revert "lavc/v4l2_m2m_enc: Add missing braces around initializers."

2018-10-27 Thread Nicolas George
James Almer (2018-10-27): > > Not sure what compiler was warning about these, but it's definitely > > incorrect for it to do so. Maybe an old gcc? Recent gcc should > > have this fixed - see > > . > Clang seems to do it as well. See > http://ffm

Re: [FFmpeg-devel] [PATCH] Revert "lavc/v4l2_m2m_enc: Add missing braces around initializers."

2018-10-27 Thread James Almer
On 10/27/2018 3:50 PM, Mark Thompson wrote: > This reverts commit 6dbb64fdccafe846aaec75d3784f7ad49d8af5df. > > The additional braces cause build errors with Linux headers earlier > than 4.5 because the first element of the structure was not originally > a union. > --- > Not sure what compiler was

[FFmpeg-devel] [PATCH] Revert "lavc/v4l2_m2m_enc: Add missing braces around initializers."

2018-10-27 Thread Mark Thompson
This reverts commit 6dbb64fdccafe846aaec75d3784f7ad49d8af5df. The additional braces cause build errors with Linux headers earlier than 4.5 because the first element of the structure was not originally a union. --- Not sure what compiler was warning about these, but it's definitely incorrect for i