Re: [FFmpeg-devel] [PATCH] Waveform Archiver decoder and demuxer

2023-02-02 Thread Tomas Härdin
ons 2023-02-01 klockan 10:42 +0100 skrev Nicolas George: > Tomas Härdin (12023-02-01): > > This belongs in the demuxer. In fact it appears the decoder > > duplicates > > code from the demuxer. Why? > > Because sharing code between demuxer and decoder is extremely > annoying, > because somebody dec

Re: [FFmpeg-devel] [PATCH] Waveform Archiver decoder and demuxer

2023-02-01 Thread Andreas Rheinhardt
Paul B Mahol: > +if (AV_RL32(par->extradata + 28) != MKTAG('f','m','t',' ')) > +return AVERROR_INVALIDDATA; > + > +av_channel_layout_uninit(&par->ch_layout); You do not need this; the channel layout of a freshly allocated stream is always blank. > +av_channel_layout_default(&p

Re: [FFmpeg-devel] [PATCH] Waveform Archiver decoder and demuxer

2023-02-01 Thread Paul B Mahol
On 2/1/23, Tomas Härdin wrote: >> +if (avctx->extradata_size < 44) >> +return AVERROR_INVALIDDATA; >> +if (AV_RL32(avctx->extradata + 16) != MKTAG('R','I','F','F')) >> +return AVERROR_INVALIDDATA; >> +if (AV_RL32(avctx->extradata + 24) != MKTAG('W','A','V','E')) >> +

Re: [FFmpeg-devel] [PATCH] Waveform Archiver decoder and demuxer

2023-02-01 Thread Nicolas George
Tomas Härdin (12023-02-01): > This belongs in the demuxer. In fact it appears the decoder duplicates > code from the demuxer. Why? Because sharing code between demuxer and decoder is extremely annoying, because somebody decided the libraries must be separate even though all the technical reasons f

Re: [FFmpeg-devel] [PATCH] Waveform Archiver decoder and demuxer

2023-02-01 Thread Tomas Härdin
> +if (avctx->extradata_size < 44) > +return AVERROR_INVALIDDATA; > +if (AV_RL32(avctx->extradata + 16) != MKTAG('R','I','F','F')) > +return AVERROR_INVALIDDATA; > +if (AV_RL32(avctx->extradata + 24) != MKTAG('W','A','V','E')) > +return AVERROR_INVALIDDATA; > +

Re: [FFmpeg-devel] [PATCH] Waveform Archiver decoder and demuxer

2023-01-31 Thread Anton Khirnov
Quoting Paul B Mahol (2023-01-31 18:11:10) > On 1/29/23, Paul B Mahol wrote: > > Patches attached > > > > will apply soon needs FATE tests -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmp

Re: [FFmpeg-devel] [PATCH] Waveform Archiver decoder and demuxer

2023-01-31 Thread Paul B Mahol
On 1/29/23, Paul B Mahol wrote: > Patches attached > will apply soon ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with

[FFmpeg-devel] [PATCH] Waveform Archiver decoder and demuxer

2023-01-29 Thread Paul B Mahol
Patches attached From 5516601630ae83098e2a3d27823f21e86bc0e60d Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Sat, 21 Jan 2023 19:25:41 +0100 Subject: [PATCH 1/2] avcodec: add WavArc decoder Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + lib