Re: [FFmpeg-devel] [PATCH] aacdec: padding skip improvements

2023-10-06 Thread Thierry Foucu
On Fri, Oct 6, 2023 at 10:02 AM Derek Buitenhuis wrote: > On 10/5/2023 6:32 PM, Lynne wrote: > > I counted 2048 with af-convert. Are you referring to qaac? > > Referring to Apple's own documents, which have 2112 plastered everywhere. > And another Fraunhofer implementation is padding 1600

Re: [FFmpeg-devel] [PATCH] aacdec: padding skip improvements

2023-10-06 Thread Derek Buitenhuis
On 10/5/2023 6:32 PM, Lynne wrote: > I counted 2048 with af-convert. Are you referring to qaac? Referring to Apple's own documents, which have 2112 plastered everywhere. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] aacdec: padding skip improvements

2023-10-05 Thread Lynne
Oct 5, 2023, 14:24 by derek.buitenh...@gmail.com: > On 10/3/2023 5:07 AM, Lynne wrote: > >> Despite this being a standard MDCT-based codec with a frame size of 1024, >> hence a delay of 1024 samples at the start, all major encoders, excluding >> faac and FFmpeg, use 2048 samples of padding. >> >

Re: [FFmpeg-devel] [PATCH] aacdec: padding skip improvements

2023-10-05 Thread Cosmin Stejerean via ffmpeg-devel
> On Oct 4, 2023, at 7:37 PM, Lynne wrote: > > 2048 is just more widely encountered. I'm posting these patches > to get an opinion: > - do we cut nothing at all (currently) > - do we cut 1024 (required by the standard/algorithm, and currently what our > AAC ENcoder outputs) > - do we cut

Re: [FFmpeg-devel] [PATCH] aacdec: padding skip improvements

2023-10-05 Thread Derek Buitenhuis
On 10/3/2023 5:07 AM, Lynne wrote: > Despite this being a standard MDCT-based codec with a frame size of 1024, > hence a delay of 1024 samples at the start, all major encoders, excluding > faac and FFmpeg, use 2048 samples of padding. Apple's uses 2112. - Derek

Re: [FFmpeg-devel] [PATCH] aacdec: padding skip improvements

2023-10-04 Thread Lynne
Oct 3, 2023, 18:39 by andreas.rheinha...@outlook.com: > Lynne: > >> The FFmpeg encoder will be modified to also output 2048 samples of >> padding at the start, to make it in line with other encoders. >> > > Once again: What is the advantage? Doing what lots of other codecs do is > not a real

Re: [FFmpeg-devel] [PATCH] aacdec: padding skip improvements

2023-10-03 Thread Andreas Rheinhardt
Lynne: > The FFmpeg encoder will be modified to also output 2048 samples of > padding at the start, to make it in line with other encoders. Once again: What is the advantage? Doing what lots of other codecs do is not a real advantage. > > +{ "padding", "Override the padding at the start of

[FFmpeg-devel] [PATCH] aacdec: padding skip improvements

2023-10-02 Thread Lynne
For some reason, this was never set, which meant all **raw** AAC in ADTS streams, except faac, had extra samples at the start. Despite this being a standard MDCT-based codec with a frame size of 1024, hence a delay of 1024 samples at the start, all major encoders, excluding faac and FFmpeg, use