Re: [FFmpeg-devel] [PATCH] aacenc_utils: unroll loops to allow compiler to use SIMD.

2016-03-08 Thread Ganesh Ajjanagadde
On Tue, Mar 8, 2016 at 2:30 PM, Reimar Döffinger wrote: > On Mon, Mar 07, 2016 at 10:50:53PM -0500, Ganesh Ajjanagadde wrote: >> On Mon, Mar 7, 2016 at 2:54 AM, Reimar Döffinger >> wrote: >> >> Can you be more specific, and are you sure about this? >> > >> > Just run your favourite performance an

Re: [FFmpeg-devel] [PATCH] aacenc_utils: unroll loops to allow compiler to use SIMD.

2016-03-08 Thread Reimar Döffinger
On Mon, Mar 07, 2016 at 10:50:53PM -0500, Ganesh Ajjanagadde wrote: > On Mon, Mar 7, 2016 at 2:54 AM, Reimar Döffinger > wrote: > >> Can you be more specific, and are you sure about this? > > > > Just run your favourite performance analysis tool and you'll see. > > As it is non-inlined libc code I

Re: [FFmpeg-devel] [PATCH] aacenc_utils: unroll loops to allow compiler to use SIMD.

2016-03-07 Thread Reimar Döffinger
On 08.03.2016, at 04:50, Ganesh Ajjanagadde wrote: > On Mon, Mar 7, 2016 at 2:54 AM, Reimar Döffinger > wrote: >> >>> Can you be more specific, and are you sure about this? >> >> Just run your favourite performance analysis tool and you'll see. >> As it is non-inlined libc code I'm fairly sure

Re: [FFmpeg-devel] [PATCH] aacenc_utils: unroll loops to allow compiler to use SIMD.

2016-03-07 Thread Ganesh Ajjanagadde
On Mon, Mar 7, 2016 at 2:54 AM, Reimar Döffinger wrote: > On 07.03.2016, at 04:04, Ganesh Ajjanagadde wrote: >> On Sun, Mar 6, 2016 at 1:43 PM, Reimar Döffinger >> wrote: >>> On Sun, Mar 06, 2016 at 07:35:58PM +0100, Reimar Döffinger wrote: Approximately 10% faster transcode from mp3 to aac

Re: [FFmpeg-devel] [PATCH] aacenc_utils: unroll loops to allow compiler to use SIMD.

2016-03-06 Thread Reimar Döffinger
On 07.03.2016, at 04:04, Ganesh Ajjanagadde wrote: > On Sun, Mar 6, 2016 at 1:43 PM, Reimar Döffinger > wrote: >> On Sun, Mar 06, 2016 at 07:35:58PM +0100, Reimar Döffinger wrote: >>> Approximately 10% faster transcode from mp3 to aac >>> with default settings. >> >> Note to anyone wanting to op

Re: [FFmpeg-devel] [PATCH] aacenc_utils: unroll loops to allow compiler to use SIMD.

2016-03-06 Thread Ganesh Ajjanagadde
On Sun, Mar 6, 2016 at 1:43 PM, Reimar Döffinger wrote: > On Sun, Mar 06, 2016 at 07:35:58PM +0100, Reimar Döffinger wrote: >> Approximately 10% faster transcode from mp3 to aac >> with default settings. > > Note to anyone wanting to optimize it further: > There is almost 25% on the table if you c

Re: [FFmpeg-devel] [PATCH] aacenc_utils: unroll loops to allow compiler to use SIMD.

2016-03-06 Thread Reimar Döffinger
On Sun, Mar 06, 2016 at 04:46:08PM -0300, James Almer wrote: > On 3/6/2016 4:14 PM, Reimar Döffinger wrote: > > On Sun, Mar 06, 2016 at 03:49:00PM -0300, James Almer wrote: > >> On 3/6/2016 3:35 PM, Reimar Döffinger wrote: > >> Are you sure this wasn't vectorized already? I remember i checked and i

Re: [FFmpeg-devel] [PATCH] aacenc_utils: unroll loops to allow compiler to use SIMD.

2016-03-06 Thread James Almer
On 3/6/2016 4:14 PM, Reimar Döffinger wrote: > On Sun, Mar 06, 2016 at 03:49:00PM -0300, James Almer wrote: >> On 3/6/2016 3:35 PM, Reimar Döffinger wrote: >>> Approximately 10% faster transcode from mp3 to aac >>> with default settings. >>> >>> Signed-off-by: Reimar Döffinger >>> --- >>> libavco

Re: [FFmpeg-devel] [PATCH] aacenc_utils: unroll loops to allow compiler to use SIMD.

2016-03-06 Thread Reimar Döffinger
On Sun, Mar 06, 2016 at 03:49:00PM -0300, James Almer wrote: > On 3/6/2016 3:35 PM, Reimar Döffinger wrote: > > Approximately 10% faster transcode from mp3 to aac > > with default settings. > > > > Signed-off-by: Reimar Döffinger > > --- > > libavcodec/aacenc_utils.h | 47 > > ++

Re: [FFmpeg-devel] [PATCH] aacenc_utils: unroll loops to allow compiler to use SIMD.

2016-03-06 Thread James Almer
On 3/6/2016 3:35 PM, Reimar Döffinger wrote: > Approximately 10% faster transcode from mp3 to aac > with default settings. > > Signed-off-by: Reimar Döffinger > --- > libavcodec/aacenc_utils.h | 47 > ++- > 1 file changed, 38 insertions(+), 9 deletion

Re: [FFmpeg-devel] [PATCH] aacenc_utils: unroll loops to allow compiler to use SIMD.

2016-03-06 Thread Reimar Döffinger
On Sun, Mar 06, 2016 at 07:35:58PM +0100, Reimar Döffinger wrote: > Approximately 10% faster transcode from mp3 to aac > with default settings. Note to anyone wanting to optimize it further: There is almost 25% on the table if you can replace the pow() and cos() function uses by something more eff

[FFmpeg-devel] [PATCH] aacenc_utils: unroll loops to allow compiler to use SIMD.

2016-03-06 Thread Reimar Döffinger
Approximately 10% faster transcode from mp3 to aac with default settings. Signed-off-by: Reimar Döffinger --- libavcodec/aacenc_utils.h | 47 ++- 1 file changed, 38 insertions(+), 9 deletions(-) diff --git a/libavcodec/aacenc_utils.h b/libavcodec/aace