Re: [FFmpeg-devel] [PATCH] all: avoid data imports across DLL boundaries

2017-08-24 Thread James Almer
On 8/24/2017 9:36 PM, Ivan Kalvachev wrote: > On 8/25/17, James Almer wrote: >> On 8/24/2017 8:26 PM, Ivan Kalvachev wrote: >>> On 8/24/17, James Almer wrote: On 8/24/2017 12:01 PM, wm4 wrote: > On Thu, 24 Aug 2017 11:20:17 +0200 > Michael Niedermayer wrote: > >> On Thu, Aug

Re: [FFmpeg-devel] [PATCH] all: avoid data imports across DLL boundaries

2017-08-24 Thread Ivan Kalvachev
On 8/25/17, James Almer wrote: > On 8/24/2017 8:26 PM, Ivan Kalvachev wrote: >> On 8/24/17, James Almer wrote: >>> On 8/24/2017 12:01 PM, wm4 wrote: On Thu, 24 Aug 2017 11:20:17 +0200 Michael Niedermayer wrote: > On Thu, Aug 24, 2017 at 10:52:55AM +0200, wm4 wrote: >> On W

Re: [FFmpeg-devel] [PATCH] all: avoid data imports across DLL boundaries

2017-08-24 Thread James Almer
On 8/24/2017 8:26 PM, Ivan Kalvachev wrote: > On 8/24/17, James Almer wrote: >> On 8/24/2017 12:01 PM, wm4 wrote: >>> On Thu, 24 Aug 2017 11:20:17 +0200 >>> Michael Niedermayer wrote: >>> On Thu, Aug 24, 2017 at 10:52:55AM +0200, wm4 wrote: > On Wed, 23 Aug 2017 19:23:12 -0300 > Jame

Re: [FFmpeg-devel] [PATCH] all: avoid data imports across DLL boundaries

2017-08-24 Thread Ivan Kalvachev
On 8/24/17, James Almer wrote: > On 8/24/2017 12:01 PM, wm4 wrote: >> On Thu, 24 Aug 2017 11:20:17 +0200 >> Michael Niedermayer wrote: >> >>> On Thu, Aug 24, 2017 at 10:52:55AM +0200, wm4 wrote: On Wed, 23 Aug 2017 19:23:12 -0300 James Almer wrote: > On 8/21/2017 2:51 PM, wm4

Re: [FFmpeg-devel] [PATCH] all: avoid data imports across DLL boundaries

2017-08-24 Thread James Almer
On 8/24/2017 12:01 PM, wm4 wrote: > On Thu, 24 Aug 2017 11:20:17 +0200 > Michael Niedermayer wrote: > >> On Thu, Aug 24, 2017 at 10:52:55AM +0200, wm4 wrote: >>> On Wed, 23 Aug 2017 19:23:12 -0300 >>> James Almer wrote: >>> On 8/21/2017 2:51 PM, wm4 wrote: > From: Pedro Pombeiro >

Re: [FFmpeg-devel] [PATCH] all: avoid data imports across DLL boundaries

2017-08-24 Thread wm4
On Thu, 24 Aug 2017 11:20:17 +0200 Michael Niedermayer wrote: > On Thu, Aug 24, 2017 at 10:52:55AM +0200, wm4 wrote: > > On Wed, 23 Aug 2017 19:23:12 -0300 > > James Almer wrote: > > > > > On 8/21/2017 2:51 PM, wm4 wrote: > > > > From: Pedro Pombeiro > > > > > > > > DLL data imports cause

Re: [FFmpeg-devel] [PATCH] all: avoid data imports across DLL boundaries

2017-08-24 Thread James Almer
On 8/24/2017 5:52 AM, wm4 wrote: > On Wed, 23 Aug 2017 19:23:12 -0300 > James Almer wrote: > >> On 8/21/2017 2:51 PM, wm4 wrote: >>> From: Pedro Pombeiro >>> >>> DLL data imports cause problems on Windows. They normally require >>> each variable to be correctly marked with dllimport/dllexport >>

Re: [FFmpeg-devel] [PATCH] all: avoid data imports across DLL boundaries

2017-08-24 Thread Hendrik Leppkes
On Thu, Aug 24, 2017 at 10:52 AM, wm4 wrote: > On Wed, 23 Aug 2017 19:23:12 -0300 > James Almer wrote: > >> On 8/21/2017 2:51 PM, wm4 wrote: >> > From: Pedro Pombeiro >> > >> > DLL data imports cause problems on Windows. They normally require >> > each variable to be correctly marked with dllimp

Re: [FFmpeg-devel] [PATCH] all: avoid data imports across DLL boundaries

2017-08-24 Thread Michael Niedermayer
On Thu, Aug 24, 2017 at 10:52:55AM +0200, wm4 wrote: > On Wed, 23 Aug 2017 19:23:12 -0300 > James Almer wrote: > > > On 8/21/2017 2:51 PM, wm4 wrote: > > > From: Pedro Pombeiro > > > > > > DLL data imports cause problems on Windows. They normally require > > > each variable to be correctly mark

Re: [FFmpeg-devel] [PATCH] all: avoid data imports across DLL boundaries

2017-08-24 Thread wm4
On Wed, 23 Aug 2017 19:23:12 -0300 James Almer wrote: > On 8/21/2017 2:51 PM, wm4 wrote: > > From: Pedro Pombeiro > > > > DLL data imports cause problems on Windows. They normally require > > each variable to be correctly marked with dllimport/dllexport > > declspecs. For MSVC, we define av_exp

Re: [FFmpeg-devel] [PATCH] all: avoid data imports across DLL boundaries

2017-08-23 Thread James Almer
On 8/21/2017 2:51 PM, wm4 wrote: > From: Pedro Pombeiro > > DLL data imports cause problems on Windows. They normally require > each variable to be correctly marked with dllimport/dllexport > declspecs. For MSVC, we define av_export to dllimport declspec. This > is not entirely correct - dependin

Re: [FFmpeg-devel] [PATCH] all: avoid data imports across DLL boundaries

2017-08-23 Thread wm4
On Mon, 21 Aug 2017 19:51:56 +0200 wm4 wrote: > From: Pedro Pombeiro > > DLL data imports cause problems on Windows. They normally require > each variable to be correctly marked with dllimport/dllexport > declspecs. For MSVC, we define av_export to dllimport declspec. This > is not entirely cor

[FFmpeg-devel] [PATCH] all: avoid data imports across DLL boundaries

2017-08-21 Thread wm4
From: Pedro Pombeiro DLL data imports cause problems on Windows. They normally require each variable to be correctly marked with dllimport/dllexport declspecs. For MSVC, we define av_export to dllimport declspec. This is not entirely correct - depending on which sub-lib is built, they should be m