Re: [FFmpeg-devel] [PATCH] area changed:in cfhd height initialization was buggy for chroma plane

2018-03-19 Thread Carl Eugen Hoyos
2018-03-16 11:27 GMT+01:00, Gagandeep Singh : > From: Gagandeep Singh > diff --git a/libavcodec/cfhd.c b/libavcodec/cfhd.c > index fd834b..a064cd1599 100644 > --- a/libavcodec/cfhd.c > +++ b/libavcodec/cfhd.c > @@ -195,14 +195,14 @@ static int alloc_buffers(AVCodecContext *avctx) > i

Re: [FFmpeg-devel] [PATCH] area changed:in cfhd height initialization was buggy for chroma plane

2018-03-17 Thread Carl Eugen Hoyos
2018-03-17 7:05 GMT+01:00, Gagandeep Singh : > Thanks, sure will take care next time :) Next task for you is to find out what "top-posting" means and avoid it here;-) Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mai

Re: [FFmpeg-devel] [PATCH] area changed:in cfhd height initialization was buggy for chroma plane

2018-03-16 Thread Gagandeep Singh
Thanks, sure will take care next time :) On Fri, 16 Mar 2018, 20:26 Carl Eugen Hoyos, wrote: > 2018-03-16 11:27 GMT+01:00, Gagandeep Singh : > > From: Gagandeep Singh > > Thank you for the important patch! > > The first line of the commit message should not start with "area changed" > but somet

Re: [FFmpeg-devel] [PATCH] area changed:in cfhd height initialization was buggy for chroma plane

2018-03-16 Thread Carl Eugen Hoyos
2018-03-16 11:27 GMT+01:00, Gagandeep Singh : > From: Gagandeep Singh Thank you for the important patch! The first line of the commit message should not start with "area changed" but something similar to "lavc/cfhd: " which means you can also remove "cfhd" from the rest of the first line. > des

[FFmpeg-devel] [PATCH] area changed:in cfhd height initialization was buggy for chroma plane

2018-03-16 Thread Gagandeep Singh
From: Gagandeep Singh description:when the chroma_y_shift was not present, the FFALIGN used to round the height was unnecessary for 0 chroma shift in y direction. --- libavcodec/cfhd.c | 6 +++--- libavcodec/tests/codec_desc | Bin 0 -> 189776 bytes 2 files changed, 3 insertions(+),