Re: [FFmpeg-devel] [PATCH] avcodec/adpcm: consolidate tables into adpcm_data.c

2020-03-10 Thread Moritz Barsnick
On Tue, Mar 10, 2020 at 15:10:39 +, Zane van Iperen wrote: > "Moritz Barsnick" wrote: > > Does it actually build? Nothing seems to depend on adpcm_data.o. > As for dependencies, seems there's 48 references to adpcm_data.o, all in > libavcodec/Makefile: Sorry, I actually missed that you didn'

Re: [FFmpeg-devel] [PATCH] avcodec/adpcm: consolidate tables into adpcm_data.c

2020-03-10 Thread Zane van Iperen
On Tue, 10 Mar 2020 15:47:08 +0100 "Moritz Barsnick" wrote: > On Tue, Mar 10, 2020 at 14:15:26 +, Zane van Iperen wrote: > > It was just to clean things up a bit by keeping them together. > > Otherwise, 'tis no matter. > > Does it actually build? Nothing seems to depend on adpcm_data.o. >

Re: [FFmpeg-devel] [PATCH] avcodec/adpcm: consolidate tables into adpcm_data.c

2020-03-10 Thread Moritz Barsnick
On Tue, Mar 10, 2020 at 14:15:26 +, Zane van Iperen wrote: > It was just to clean things up a bit by keeping them together. > Otherwise, 'tis no matter. Does it actually build? Nothing seems to depend on adpcm_data.o. Moritz ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH] avcodec/adpcm: consolidate tables into adpcm_data.c

2020-03-10 Thread Paul B Mahol
I fail to see how useful this is. Unless you plan to write encoder it is not useful. On 3/10/20, Zane van Iperen wrote: > Signed-off-by: Zane van Iperen > --- > libavcodec/adpcm.c | 67 +++-- > libavcodec/adpcm_data.c | 29 ++ > libavcode

Re: [FFmpeg-devel] [PATCH] avcodec/adpcm: consolidate tables into adpcm_data.c

2020-03-10 Thread Zane van Iperen
On Tue, 10 Mar 2020 14:52:25 +0100 "Paul B Mahol" wrote: > I fail to see how useful this is. > Unless you plan to write encoder it is not useful. > It was just to clean things up a bit by keeping them together. Otherwise, 'tis no matter. Zane ___ ff

[FFmpeg-devel] [PATCH] avcodec/adpcm: consolidate tables into adpcm_data.c

2020-03-10 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavcodec/adpcm.c | 67 +++-- libavcodec/adpcm_data.c | 29 ++ libavcodec/adpcm_data.h | 4 +++ 3 files changed, 51 insertions(+), 49 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c in