Re: [FFmpeg-devel] [PATCH] avcodec/apedec: fix undefined left shifts of negative numbers

2015-09-29 Thread Ganesh Ajjanagadde
On Tue, Sep 29, 2015 at 11:22 AM, Ronald S. Bultje wrote: > Hi, > > On Tue, Sep 29, 2015 at 11:04 AM, Ganesh Ajjanagadde > wrote: > >> On Tue, Sep 29, 2015 at 9:24 AM, Hendrik Leppkes >> wrote: >> > On Sun, Sep 20, 2015 at 4:18 AM, Ganesh Ajjanagadde >> > wrote: >> >> This fixes -Wshift-negativ

Re: [FFmpeg-devel] [PATCH] avcodec/apedec: fix undefined left shifts of negative numbers

2015-09-29 Thread Ronald S. Bultje
Hi, On Tue, Sep 29, 2015 at 11:04 AM, Ganesh Ajjanagadde wrote: > On Tue, Sep 29, 2015 at 9:24 AM, Hendrik Leppkes > wrote: > > On Sun, Sep 20, 2015 at 4:18 AM, Ganesh Ajjanagadde > > wrote: > >> This fixes -Wshift-negative-value reported with clang 3.7+, e.g > >> > http://fate.ffmpeg.org/log.

Re: [FFmpeg-devel] [PATCH] avcodec/apedec: fix undefined left shifts of negative numbers

2015-09-29 Thread Ganesh Ajjanagadde
On Tue, Sep 29, 2015 at 9:24 AM, Hendrik Leppkes wrote: > On Sun, Sep 20, 2015 at 4:18 AM, Ganesh Ajjanagadde > wrote: >> This fixes -Wshift-negative-value reported with clang 3.7+, e.g >> http://fate.ffmpeg.org/log.cgi?time=20150919172459&log=compile&slot=x86_64-darwin-clang-polly-notiling-3.7.

Re: [FFmpeg-devel] [PATCH] avcodec/apedec: fix undefined left shifts of negative numbers

2015-09-29 Thread Hendrik Leppkes
On Sun, Sep 20, 2015 at 4:18 AM, Ganesh Ajjanagadde wrote: > This fixes -Wshift-negative-value reported with clang 3.7+, e.g > http://fate.ffmpeg.org/log.cgi?time=20150919172459&log=compile&slot=x86_64-darwin-clang-polly-notiling-3.7. > Note that the patch crucially depends on int >= 32 bits, > an

Re: [FFmpeg-devel] [PATCH] avcodec/apedec: fix undefined left shifts of negative numbers

2015-09-29 Thread Ganesh Ajjanagadde
On Tue, Sep 29, 2015 at 9:08 AM, Michael Niedermayer wrote: > On Tue, Sep 29, 2015 at 08:08:54AM -0400, Ganesh Ajjanagadde wrote: >> On Tue, Sep 29, 2015 at 4:11 AM, Paul B Mahol wrote: >> > On 9/25/15, Ganesh Ajjanagadde wrote: >> >> On Sat, Sep 19, 2015 at 10:18 PM, Ganesh Ajjanagadde >> >> w

Re: [FFmpeg-devel] [PATCH] avcodec/apedec: fix undefined left shifts of negative numbers

2015-09-29 Thread Michael Niedermayer
On Tue, Sep 29, 2015 at 08:08:54AM -0400, Ganesh Ajjanagadde wrote: > On Tue, Sep 29, 2015 at 4:11 AM, Paul B Mahol wrote: > > On 9/25/15, Ganesh Ajjanagadde wrote: > >> On Sat, Sep 19, 2015 at 10:18 PM, Ganesh Ajjanagadde > >> wrote: > >>> This fixes -Wshift-negative-value reported with clang 3

Re: [FFmpeg-devel] [PATCH] avcodec/apedec: fix undefined left shifts of negative numbers

2015-09-29 Thread Ganesh Ajjanagadde
On Tue, Sep 29, 2015 at 4:11 AM, Paul B Mahol wrote: > On 9/25/15, Ganesh Ajjanagadde wrote: >> On Sat, Sep 19, 2015 at 10:18 PM, Ganesh Ajjanagadde >> wrote: >>> This fixes -Wshift-negative-value reported with clang 3.7+, e.g >>> http://fate.ffmpeg.org/log.cgi?time=20150919172459&log=compile&sl

Re: [FFmpeg-devel] [PATCH] avcodec/apedec: fix undefined left shifts of negative numbers

2015-09-29 Thread Paul B Mahol
On 9/25/15, Ganesh Ajjanagadde wrote: > On Sat, Sep 19, 2015 at 10:18 PM, Ganesh Ajjanagadde > wrote: >> This fixes -Wshift-negative-value reported with clang 3.7+, e.g >> http://fate.ffmpeg.org/log.cgi?time=20150919172459&log=compile&slot=x86_64-darwin-clang-polly-notiling-3.7. >> Note that the

Re: [FFmpeg-devel] [PATCH] avcodec/apedec: fix undefined left shifts of negative numbers

2015-09-25 Thread Ganesh Ajjanagadde
On Sat, Sep 19, 2015 at 10:18 PM, Ganesh Ajjanagadde wrote: > This fixes -Wshift-negative-value reported with clang 3.7+, e.g > http://fate.ffmpeg.org/log.cgi?time=20150919172459&log=compile&slot=x86_64-darwin-clang-polly-notiling-3.7. > Note that the patch crucially depends on int >= 32 bits, > a

[FFmpeg-devel] [PATCH] avcodec/apedec: fix undefined left shifts of negative numbers

2015-09-19 Thread Ganesh Ajjanagadde
This fixes -Wshift-negative-value reported with clang 3.7+, e.g http://fate.ffmpeg.org/log.cgi?time=20150919172459&log=compile&slot=x86_64-darwin-clang-polly-notiling-3.7. Note that the patch crucially depends on int >= 32 bits, an assumption made in many places in the codebase. Signed-off-by: Gan