[FFmpeg-devel] [PATCH] avcodec/ccaption_dec: Make real-time latency configurable

2021-05-25 Thread Pavel Koshevoy
Un-hardcode the 200ms minimum latency between emitting subtitle events so that those that wish to receive a subtitle event for every screen change could do so. --- libavcodec/ccaption_dec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/ccaption_dec.c b/libavcode

[FFmpeg-devel] [PATCH] avcodec/ccaption_dec: Make real-time latency configurable

2021-06-05 Thread Pavel Koshevoy
Un-hardcode the 200ms minimum latency between emitting subtitle events so that those that wish to receive a subtitle event for every screen change could do so. The problem with delaying realtime output by any amount is that it is unknown when the next byte pair that would trigger output will happe

Re: [FFmpeg-devel] [PATCH] avcodec/ccaption_dec: Make real-time latency configurable

2021-05-25 Thread Moritz Barsnick
On Tue, May 25, 2021 at 20:16:29 -0600, Pavel Koshevoy wrote: > -sub->pts > ctx->last_real_time + av_rescale_q(200, ms_tb, > AV_TIME_BASE_Q)) { > +sub->pts >= ctx->last_real_time + > av_rescale_q(ctx->real_time_latency_msec, ms_tb, AV_TIME_BASE_Q)) { [...] > +{ "real_time_late

Re: [FFmpeg-devel] [PATCH] avcodec/ccaption_dec: Make real-time latency configurable

2021-05-26 Thread Pavel Koshevoy
On Wed, May 26, 2021, 00:18 Moritz Barsnick wrote: > On Tue, May 25, 2021 at 20:16:29 -0600, Pavel Koshevoy wrote: > > -sub->pts > ctx->last_real_time + av_rescale_q(200, ms_tb, > AV_TIME_BASE_Q)) { > > +sub->pts >= ctx->last_real_time + > av_rescale_q(ctx->real_time_latency_msec,

Re: [FFmpeg-devel] [PATCH] avcodec/ccaption_dec: Make real-time latency configurable

2021-05-29 Thread Pavel Koshevoy
On Tue, May 25, 2021 at 8:16 PM Pavel Koshevoy wrote: > Un-hardcode the 200ms minimum latency between emitting subtitle events > so that those that wish to receive a subtitle event for every screen > change could do so. > --- > libavcodec/ccaption_dec.c | 4 +++- > 1 file changed, 3 insertions(+

[FFmpeg-devel] [PATCH] avcodec/ccaption_dec: Make real-time latency configurable v2

2021-05-29 Thread Pavel Koshevoy
Un-hardcode the 200ms minimum latency between emitting subtitle events so that those that wish to receive a subtitle event for every screen change could do so. The problem with delaying realtime output by any amount is that it is unknown when the next byte pair that would trigger output will happe

Re: [FFmpeg-devel] [PATCH] avcodec/ccaption_dec: Make real-time latency configurable v2

2021-06-03 Thread Pavel Koshevoy
On Sat, May 29, 2021, 08:51 Pavel Koshevoy wrote: > Un-hardcode the 200ms minimum latency between emitting subtitle events > so that those that wish to receive a subtitle event for every screen > change could do so. > > The problem with delaying realtime output by any amount is that it is > unkno

Re: [FFmpeg-devel] [PATCH] avcodec/ccaption_dec: Make real-time latency configurable v2

2021-06-04 Thread Valerii Zapodovnikov
v2 is done by "git send-email -v2 -1" not what you did here. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "u

Re: [FFmpeg-devel] [PATCH] avcodec/ccaption_dec: Make real-time latency configurable v2

2021-06-04 Thread Pavel Koshevoy
On Fri, Jun 4, 2021 at 4:56 PM Valerii Zapodovnikov wrote: > v2 is done by "git send-email -v2 -1" not what you did here. > Thanks, I didn't know that. I am unclear -- do you want me to resubmit the patch? I can just apply and push it myself if there are no objections, although I am not the m

Re: [FFmpeg-devel] [PATCH] avcodec/ccaption_dec: Make real-time latency configurable v2

2021-06-05 Thread Valerii Zapodovnikov
Sure, please resend and change status on your old patch as superseeded on patchwork. Sigh. As for maintainer, LGTM from me (interesting, is just saying those 4 latters enough to get patchwork flag of it?). So if you can push while not being the mainteiner, please do it, the coding acceptions here a