On Fri, Oct 09, 2020 at 01:48:46PM +0100, Kieran O Leary wrote:
> On Fri, Oct 9, 2020 at 12:10 PM Paul B Mahol wrote:
>
> > On Fri, Oct 09, 2020 at 10:08:45AM +0100, Kieran O Leary wrote:
> > > Pinging as I think my comment got lost in the conversation, my main
> > concern
> > > is about the Prin
On Fri, Oct 9, 2020 at 12:10 PM Paul B Mahol wrote:
> On Fri, Oct 09, 2020 at 10:08:45AM +0100, Kieran O Leary wrote:
> > Pinging as I think my comment got lost in the conversation, my main
> concern
> > is about the Printing Density value aka 1,
>
> This patch is for encoder, not for decoder (we
On Fri, Oct 09, 2020 at 10:08:45AM +0100, Kieran O Leary wrote:
> Pinging as I think my comment got lost in the conversation, my main concern
> is about the Printing Density value aka 1,
This patch is for encoder, not for decoder (well decoder also need fixing but
later).
The meaning of 1 value
Pinging as I think my comment got lost in the conversation, my main concern
is about the Printing Density value aka 1,
K
On Thu, Oct 8, 2020 at 10:25 AM Kieran O Leary
wrote:
> Woah, more amazing film preservation patches, thank you!
> From my uninformed reading of the code, does this only supp
>>
>>>
>>> [..]
>>> +static int get_dpx_pri(int color_pri)
>>> +{
>>> +switch (color_pri) {
>>> +case AVCOL_PRI_BT709:
>>> +return 6;
>>> +case AVCOL_PRI_SMPTE240M:
>>> +case AVCOL_PRI_SMPTE170M:
>>> +return 9;
>>
>> I think perhaps this should be 8 (ITU 601 525)
On Thu, Oct 08, 2020 at 12:27:02PM +0100, Harry Mallon wrote:
>
>
> > On 7 Oct 2020, at 22:02, Paul B Mahol wrote:
> >
> > Signed-off-by: Paul B Mahol
> > ---
> > libavcodec/dpxenc.c | 36 ++--
> > tests/ref/lavf/dpx | 2 +-
> > 2 files changed, 35 insertions(+)
> On 7 Oct 2020, at 22:02, Paul B Mahol wrote:
>
> Signed-off-by: Paul B Mahol
> ---
> libavcodec/dpxenc.c | 36 ++--
> tests/ref/lavf/dpx | 2 +-
> 2 files changed, 35 insertions(+), 3 deletions(-)
>
> diff --git a/libavcodec/dpxenc.c b/libavcodec/dpxenc.c
> i
Woah, more amazing film preservation patches, thank you!
From my uninformed reading of the code, does this only support the
detection of Linear, 709, 240M, 170M, Gamm22? The reason I ask is that you
frequently see Printing Density appear as well, which has a value of '1'
in the 801/802 offset..
Signed-off-by: Paul B Mahol
---
libavcodec/dpxenc.c | 36 ++--
tests/ref/lavf/dpx | 2 +-
2 files changed, 35 insertions(+), 3 deletions(-)
diff --git a/libavcodec/dpxenc.c b/libavcodec/dpxenc.c
index a5960334d5..56840a8d33 100644
--- a/libavcodec/dpxenc.c
+++ b
