Re: [FFmpeg-devel] [PATCH] avcodec/dpxenc: support colour metadata in DPX encoder, fixes ticket #6023

2017-02-03 15:46 GMT+01:00 Vittorio Giovara : > if (priv_trc_opt = "") { Why is this useful? >if (avctx->color_trc == AVCOL_BT709) > buf[801] = DPX_BT709 >else if (avctx->color_trc == AVCOL_BT601) > buf[801] = DPX_BT601 I would suggest a switch()

Re: [FFmpeg-devel] [PATCH] avcodec/dpxenc: support colour metadata in DPX encoder, fixes ticket #6023

On Fri, Feb 3, 2017 at 2:10 PM, Kieran O Leary wrote: > Hi Vittorio! > > thanks for getting back to me. > > On Fri, Feb 3, 2017 at 12:57 PM, Vittorio Giovara > wrote: >> >> >> >> Hey Kieran, >> I think the code looks fine. I am just wondering

Re: [FFmpeg-devel] [PATCH] avcodec/dpxenc: support colour metadata in DPX encoder, fixes ticket #6023

Vittorio Giovara wrote: >I think the code looks fine. I am just wondering if we >should also offer the possibility to set these flags from >the standard context options (-color_trc and others). I'm >aware that not all values match or are valid but maybe a >small conversion table or extending the

Re: [FFmpeg-devel] [PATCH] avcodec/dpxenc: support colour metadata in DPX encoder, fixes ticket #6023

Hi Vittorio! thanks for getting back to me. On Fri, Feb 3, 2017 at 12:57 PM, Vittorio Giovara < vittorio.giov...@gmail.com> wrote: > > > Hey Kieran, > I think the code looks fine. I am just wondering if we should also > offer the possibility to set these flags from the standard context >

Re: [FFmpeg-devel] [PATCH] avcodec/dpxenc: support colour metadata in DPX encoder, fixes ticket #6023

On Wed, Feb 1, 2017 at 1:42 PM, Kieran O Leary wrote: > Hello, > > I'm cc'ing Vittorio as I don't think that he's subscribed to the list but > he's contributed to dpxenc.c and recent colorspace filters. The same with > Kate Murray from the Library of Congress who knows a

Re: [FFmpeg-devel] [PATCH] avcodec/dpxenc: support colour metadata in DPX encoder, fixes ticket #6023

Hi On 2 Feb 2017 08:20, "Carl Eugen Hoyos" wrote: 2017-02-01 23:37 GMT+01:00 Kieran O Leary : > DPX contains some values that are super-specific to film, such as 'Printing > Density'. I do not see that value in either of those enums but it's a >

Re: [FFmpeg-devel] [PATCH] avcodec/dpxenc: support colour metadata in DPX encoder, fixes ticket #6023

Hi James and Carl, Thanks for getting back to me. It looks like your comments are similar, though you might be asking to pull the information from different places? more below On Wed, Feb 1, 2017 at 5:01 PM, James Almer wrote: > > I may be missing something and apologizes if

Re: [FFmpeg-devel] [PATCH] avcodec/dpxenc: support colour metadata in DPX encoder, fixes ticket #6023

On 2/1/2017 9:42 AM, Kieran O Leary wrote: > Hello, > > I'm cc'ing Vittorio as I don't think that he's subscribed to the list but > he's contributed to dpxenc.c and recent colorspace filters. The same with > Kate Murray from the Library of Congress who knows a lot more about DPX > than me.

Re: [FFmpeg-devel] [PATCH] avcodec/dpxenc: support colour metadata in DPX encoder, fixes ticket #6023

2017-02-01 13:42 GMT+01:00 Kieran O Leary : > +static const AVOption options[] = { > +{"trc", "Transfer Characteristics", OFFSET(transfer_characteristic), > AV_OPT_TYPE_INT, {.i64 = 2}, 0, 12, VE }, > +{"clr", "Colorimetric Specification", >

[FFmpeg-devel] [PATCH] avcodec/dpxenc: support colour metadata in DPX encoder, fixes ticket #6023

Hello, I'm cc'ing Vittorio as I don't think that he's subscribed to the list but he's contributed to dpxenc.c and recent colorspace filters. The same with Kate Murray from the Library of Congress who knows a lot more about DPX than me. Apologies if this is inappropriate. I mostly based this