Re: [FFmpeg-devel] [PATCH] avcodec/extract_extradata: zero initialize the padding bytes of the exported extradata

2018-03-09 Thread wm4
On Fri, 9 Mar 2018 21:57:38 +0100 Hendrik Leppkes wrote: > On Fri, Mar 9, 2018 at 9:52 PM, wm4 wrote: > > On Fri, 9 Mar 2018 13:31:45 -0300 > > James Almer wrote: > > > >> On 3/9/2018 12:47 PM, Derek Buitenhuis wrote: > >> > On 3/9/2018 3:22 PM, James Almer wrote: > >> >> Yes, but it's sl

Re: [FFmpeg-devel] [PATCH] avcodec/extract_extradata: zero initialize the padding bytes of the exported extradata

2018-03-09 Thread Hendrik Leppkes
On Fri, Mar 9, 2018 at 9:52 PM, wm4 wrote: > On Fri, 9 Mar 2018 13:31:45 -0300 > James Almer wrote: > >> On 3/9/2018 12:47 PM, Derek Buitenhuis wrote: >> > On 3/9/2018 3:22 PM, James Almer wrote: >> >> Yes, but it's slower, and the buffer is guaranteed to be written to with >> >> actual data afte

Re: [FFmpeg-devel] [PATCH] avcodec/extract_extradata: zero initialize the padding bytes of the exported extradata

2018-03-09 Thread Paul B Mahol
On 3/9/18, wm4 wrote: > On Fri, 9 Mar 2018 13:31:45 -0300 > James Almer wrote: > >> On 3/9/2018 12:47 PM, Derek Buitenhuis wrote: >> > On 3/9/2018 3:22 PM, James Almer wrote: >> >> Yes, but it's slower, and the buffer is guaranteed to be written to >> >> with >> >> actual data after being allocat

Re: [FFmpeg-devel] [PATCH] avcodec/extract_extradata: zero initialize the padding bytes of the exported extradata

2018-03-09 Thread wm4
On Fri, 9 Mar 2018 13:31:45 -0300 James Almer wrote: > On 3/9/2018 12:47 PM, Derek Buitenhuis wrote: > > On 3/9/2018 3:22 PM, James Almer wrote: > >> Yes, but it's slower, and the buffer is guaranteed to be written to with > >> actual data after being allocated. > >> > >> This is a filter that

Re: [FFmpeg-devel] [PATCH] avcodec/extract_extradata: zero initialize the padding bytes of the exported extradata

2018-03-09 Thread James Almer
On 3/9/2018 12:47 PM, Derek Buitenhuis wrote: > On 3/9/2018 3:22 PM, James Almer wrote: >> Yes, but it's slower, and the buffer is guaranteed to be written to with >> actual data after being allocated. >> >> This is a filter that may run once per processed packet, so the less >> overhead the better

Re: [FFmpeg-devel] [PATCH] avcodec/extract_extradata: zero initialize the padding bytes of the exported extradata

2018-03-09 Thread Derek Buitenhuis
On 3/9/2018 3:22 PM, James Almer wrote: > Yes, but it's slower, and the buffer is guaranteed to be written to with > actual data after being allocated. > > This is a filter that may run once per processed packet, so the less > overhead the better. Not sure I buy the "speed" argument here, but OK.

Re: [FFmpeg-devel] [PATCH] avcodec/extract_extradata: zero initialize the padding bytes of the exported extradata

2018-03-09 Thread James Almer
On 3/9/2018 12:18 PM, Derek Buitenhuis wrote: > On 3/8/2018 4:02 PM, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavcodec/extract_extradata_bsf.c | 4 >> 1 file changed, 4 insertions(+) > > Can't most (or all) of these be fixed by using av_mallocz? Yes, but it's slower, an

Re: [FFmpeg-devel] [PATCH] avcodec/extract_extradata: zero initialize the padding bytes of the exported extradata

2018-03-09 Thread Derek Buitenhuis
On 3/8/2018 4:02 PM, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/extract_extradata_bsf.c | 4 > 1 file changed, 4 insertions(+) Can't most (or all) of these be fixed by using av_mallocz? - Derek ___ ffmpeg-devel mailing lis

[FFmpeg-devel] [PATCH] avcodec/extract_extradata: zero initialize the padding bytes of the exported extradata

2018-03-08 Thread James Almer
Signed-off-by: James Almer --- libavcodec/extract_extradata_bsf.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/extract_extradata_bsf.c b/libavcodec/extract_extradata_bsf.c index d40907a675..0bffe8f42c 100644 --- a/libavcodec/extract_extradata_bsf.c +++ b/libavcodec/extract_