Re: [FFmpeg-devel] [PATCH] avcodec/ff_mpv_encode_end: fix a crash for null s->avctx

2020-08-30 Thread Michael Niedermayer
On Sun, Aug 30, 2020 at 05:07:03PM +0800, Guangxin Xu wrote: > thanks, James and Michael. > Are we ready to merge this? ive applied the avctx change patch which should fix this thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No human being will ever know th

Re: [FFmpeg-devel] [PATCH] avcodec/ff_mpv_encode_end: fix a crash for null s->avctx

2020-08-30 Thread Guangxin Xu
thanks, James and Michael. Are we ready to merge this? thanks On Wed, Aug 26, 2020 at 5:51 AM Michael Niedermayer wrote: > On Tue, Aug 25, 2020 at 11:37:59AM -0300, James Almer wrote: > > On 8/25/2020 6:35 AM, Xu Guangxin wrote: > > > Steps to reproduce: > > > 1. ./configure --enable-debug=3 --d

Re: [FFmpeg-devel] [PATCH] avcodec/ff_mpv_encode_end: fix a crash for null s->avctx

2020-08-25 Thread Michael Niedermayer
On Tue, Aug 25, 2020 at 11:37:59AM -0300, James Almer wrote: > On 8/25/2020 6:35 AM, Xu Guangxin wrote: > > Steps to reproduce: > > 1. ./configure --enable-debug=3 --disable-libx264 && make install > > 2. ffmpeg -i input.mp4 -profile:v baseline output.mp4 -y > > > > you will see a crash like this:

Re: [FFmpeg-devel] [PATCH] avcodec/ff_mpv_encode_end: fix a crash for null s->avctx

2020-08-25 Thread James Almer
On 8/25/2020 12:08 PM, Guangxin Xu wrote: > Hi James, > thanks for the review. > We can't assume s->avctx == avctx. in > https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/smvjpegdec.c, it > will be assigned to a new allocated codec context. > Currently, it's no mpeg video encoder doing this,

Re: [FFmpeg-devel] [PATCH] avcodec/ff_mpv_encode_end: fix a crash for null s->avctx

2020-08-25 Thread Guangxin Xu
Hi James, thanks for the review. We can't assume s->avctx == avctx. in https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/smvjpegdec.c, it will be assigned to a new allocated codec context. Currently, it's no mpeg video encoder doing this, but in the future, some subclass maybe. On Tue, Aug 2

Re: [FFmpeg-devel] [PATCH] avcodec/ff_mpv_encode_end: fix a crash for null s->avctx

2020-08-25 Thread James Almer
On 8/25/2020 6:35 AM, Xu Guangxin wrote: > Steps to reproduce: > 1. ./configure --enable-debug=3 --disable-libx264 && make install > 2. ffmpeg -i input.mp4 -profile:v baseline output.mp4 -y > > you will see a crash like this: > [mpeg4 @ 0x575854c0] [Eval @ 0x7fffbf80] Undefined constant or

[FFmpeg-devel] [PATCH] avcodec/ff_mpv_encode_end: fix a crash for null s->avctx

2020-08-25 Thread Xu Guangxin
Steps to reproduce: 1. ./configure --enable-debug=3 --disable-libx264 && make install 2. ffmpeg -i input.mp4 -profile:v baseline output.mp4 -y you will see a crash like this: [mpeg4 @ 0x575854c0] [Eval @ 0x7fffbf80] Undefined constant or missing '(' in 'baseline' [mpeg4 @ 0x575854c0]