Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

2020-04-11 Thread Paul B Mahol
On 4/11/20, Nicolas George wrote: > Paul B Mahol (12020-04-11): >> I never found developer that have coverity in brain or run patches via >> it. > > Exactly. And I hope you have the insight to count yourself in these > numbers. > > This is exactly why we need reviews: individually, we are fallible

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

2020-04-11 Thread Nicolas George
Paul B Mahol (12020-04-11): > I never found developer that have coverity in brain or run patches via it. Exactly. And I hope you have the insight to count yourself in these numbers. This is exactly why we need reviews: individually, we are fallible, collectively we are still fallible, but much le

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

2020-04-11 Thread Paul B Mahol
On 4/11/20, Nicolas George wrote: > Paul B Mahol (12020-04-11): >> Or they want to force someone into specific nits. > > Respectfully, I think things would go a lot better around here if people > were to assume good will instead of ill intent. We are all working for > the good of FFmpeg, here, or

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

2020-04-11 Thread Nicolas George
Paul B Mahol (12020-04-11): > Or they want to force someone into specific nits. Respectfully, I think things would go a lot better around here if people were to assume good will instead of ill intent. We are all working for the good of FFmpeg, here, or at least we are. As for the merits of review

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

2020-04-11 Thread Paul B Mahol
On 4/11/20, Anton Khirnov wrote: > Quoting Paul B Mahol (2020-04-11 11:29:40) >> On 4/11/20, Anton Khirnov wrote: >> > 100%? Meaning you think no patches should go to the mailing list? >> > >> > Or only some specific patches are exempt? Based on what criterion? And >> > who applies it? >> > And m

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

2020-04-11 Thread Anton Khirnov
Quoting Paul B Mahol (2020-04-11 11:29:40) > On 4/11/20, Anton Khirnov wrote: > > 100%? Meaning you think no patches should go to the mailing list? > > > > Or only some specific patches are exempt? Based on what criterion? And > > who applies it? > > And most importantly, why? > > Only trivial pa

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

2020-04-11 Thread Anton Khirnov
Quoting Carl Eugen Hoyos (2020-04-11 11:56:40) > > > > Furthermore, I would strongly suggest you stop making such > > > comments that are not helpful. > > > > What about my comment is "not helpful"? > > And how is you expressing your personal opinion different > > from me doing the same? > > Yes,

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

2020-04-11 Thread Paul B Mahol
On 4/11/20, Anton Khirnov wrote: > Quoting Paul B Mahol (2020-04-11 10:59:34) >> On 4/11/20, Anton Khirnov wrote: >> > Quoting Carl Eugen Hoyos (2020-04-09 18:13:53) >> >> Am Do., 9. Apr. 2020 um 14:39 Uhr schrieb Andreas Rheinhardt >> >> : >> >> > >> >> > Signed-off-by: Andreas Rheinhardt >> >>

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

2020-04-11 Thread Paul B Mahol
On 4/11/20, Nicolas George wrote: > Anton Khirnov (12020-04-11): >> It is done the way we, as a whole community, decide it is done. In >> practice, many people send ALL of their patches to the ML. > > I am with Anton on this one. Rules are not set in stone, “and even stone > changes, anyway”. > >

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

2020-04-11 Thread Nicolas George
Anton Khirnov (12020-04-11): > It is done the way we, as a whole community, decide it is done. In > practice, many people send ALL of their patches to the ML. I am with Anton on this one. Rules are not set in stone, “and even stone changes, anyway”. And I think too it would be much better if all

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

2020-04-11 Thread Carl Eugen Hoyos
Am Sa., 11. Apr. 2020 um 11:27 Uhr schrieb Anton Khirnov : > > Quoting Carl Eugen Hoyos (2020-04-11 11:06:44) > > Am Sa., 11. Apr. 2020 um 10:58 Uhr schrieb Anton Khirnov > > : > > > > Fortunately, this is not how it's done here. > > It is done the way we, as a whole community, decide it is done.

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

2020-04-11 Thread Anton Khirnov
Quoting Carl Eugen Hoyos (2020-04-11 11:06:44) > Am Sa., 11. Apr. 2020 um 10:58 Uhr schrieb Anton Khirnov : > > Fortunately, this is not how it's done here. It is done the way we, as a whole community, decide it is done. In practice, many people send ALL of their patches to the ML. > > Furtherm

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

2020-04-11 Thread Anton Khirnov
Quoting Paul B Mahol (2020-04-11 10:59:34) > On 4/11/20, Anton Khirnov wrote: > > Quoting Carl Eugen Hoyos (2020-04-09 18:13:53) > >> Am Do., 9. Apr. 2020 um 14:39 Uhr schrieb Andreas Rheinhardt > >> : > >> > > >> > Signed-off-by: Andreas Rheinhardt > >> > --- > >> > libavcodec/jpeg2000dec.c | 5

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

2020-04-11 Thread Carl Eugen Hoyos
Am Sa., 11. Apr. 2020 um 10:58 Uhr schrieb Anton Khirnov : > > Quoting Carl Eugen Hoyos (2020-04-09 18:13:53) > > Am Do., 9. Apr. 2020 um 14:39 Uhr schrieb Andreas Rheinhardt > > : > > > > > > Signed-off-by: Andreas Rheinhardt > > > --- > > > libavcodec/jpeg2000dec.c | 5 +++-- > > > 1 file chang

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

2020-04-11 Thread Paul B Mahol
On 4/11/20, Anton Khirnov wrote: > Quoting Carl Eugen Hoyos (2020-04-09 18:13:53) >> Am Do., 9. Apr. 2020 um 14:39 Uhr schrieb Andreas Rheinhardt >> : >> > >> > Signed-off-by: Andreas Rheinhardt >> > --- >> > libavcodec/jpeg2000dec.c | 5 +++-- >> > 1 file changed, 3 insertions(+), 2 deletions(-

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

2020-04-11 Thread Anton Khirnov
Quoting Carl Eugen Hoyos (2020-04-09 18:13:53) > Am Do., 9. Apr. 2020 um 14:39 Uhr schrieb Andreas Rheinhardt > : > > > > Signed-off-by: Andreas Rheinhardt > > --- > > libavcodec/jpeg2000dec.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/libavcodec/jpeg2000d

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

2020-04-09 Thread Carl Eugen Hoyos
Am Do., 9. Apr. 2020 um 18:35 Uhr schrieb Andreas Rheinhardt : > Ok. Should patches like the ones contained in the patchset [1] also be > pushed directly? > > - Andreas > > [1]: https://ffmpeg.org/pipermail/ffmpeg-devel/2019-October/252107.html Imo, after you tested them: Definitely. Carl Eugen

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

2020-04-09 Thread Andreas Rheinhardt
Carl Eugen Hoyos: > Am Do., 9. Apr. 2020 um 14:39 Uhr schrieb Andreas Rheinhardt > : >> >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/jpeg2000dec.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg2000dec.c >> i

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

2020-04-09 Thread Carl Eugen Hoyos
Am Do., 9. Apr. 2020 um 14:39 Uhr schrieb Andreas Rheinhardt : > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/jpeg2000dec.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg2000dec.c > index 846e31d0a2..9684e57b34 10

[FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

2020-04-09 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/jpeg2000dec.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg2000dec.c index 846e31d0a2..9684e57b34 100644 --- a/libavcodec/jpeg2000dec.c +++ b/libavcodec/jpeg2000dec.c @@ -862,6 +