Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-04 Thread Muhammad Faiz
On Fri, May 5, 2017 at 3:15 AM, Kyle Swanson wrote: > Hi, > > On Tue, May 2, 2017 at 12:18 PM, wm4 wrote: >> On Tue, 2 May 2017 16:16:35 +0200 >> Nicolas George wrote: >> >>> Le duodi 12 floréal, an CCXXV, Paul B Mahol a écrit : >>> > This is all one big mess. >>> >>> It is, but I will not take

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-04 Thread wm4
On Fri, 5 May 2017 00:05:35 +0200 Nicolas George wrote: > Le quintidi 15 floréal, an CCXXV, Nicolas George a écrit : > > Absolutely not, these change were there for a reason, that reason is > > still valid. > > Also, the bug is not in libavfilter, so reverting changes in libavfilter > makes no

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-04 Thread Nicolas George
Le quintidi 15 floréal, an CCXXV, Nicolas George a écrit : > Absolutely not, these change were there for a reason, that reason is > still valid. Also, the bug is not in libavfilter, so reverting changes in libavfilter makes no sense. Regards, -- Nicolas George signature.asc Description: Dig

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-04 Thread wm4
On Thu, 4 May 2017 22:24:15 +0200 Nicolas George wrote: > Le quintidi 15 floréal, an CCXXV, Kyle Swanson a écrit : > > I believe this is still broken on git master and is present on release > > Well, nobody fixed it. > > > 3.3. If a proper fix is going to take time, > > There is no reason

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-04 Thread Nicolas George
Le quintidi 15 floréal, an CCXXV, Kyle Swanson a écrit : > I believe this is still broken on git master and is present on release Well, nobody fixed it. > 3.3. If a proper fix is going to take time, There is no reason it should, the issue is rather simple. >

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-04 Thread Kyle Swanson
Hi, On Tue, May 2, 2017 at 12:18 PM, wm4 wrote: > On Tue, 2 May 2017 16:16:35 +0200 > Nicolas George wrote: > >> Le duodi 12 floréal, an CCXXV, Paul B Mahol a écrit : >> > This is all one big mess. >> >> It is, but I will not take responsibility when it is not mine. >> >> Libavfilter was in need

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-02 Thread wm4
On Tue, 2 May 2017 16:16:35 +0200 Nicolas George wrote: > Le duodi 12 floréal, an CCXXV, Paul B Mahol a écrit : > > This is all one big mess. > > It is, but I will not take responsibility when it is not mine. > > Libavfilter was in need of a serious overhaul. I do not see you denying > it, an

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-02 Thread Nicolas George
Le duodi 12 floréal, an CCXXV, Paul B Mahol a écrit : > This is all one big mess. It is, but I will not take responsibility when it is not mine. Libavfilter was in need of a serious overhaul. I do not see you denying it, and you suffered from the limitations it was causing as much as anybody else

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-02 Thread Muhammad Faiz
On Mon, May 1, 2017 at 11:45 PM, Ronald S. Bultje wrote: > Hi, > > On Mon, May 1, 2017 at 12:44 PM, Ronald S. Bultje > wrote: > >> Hi, >> >> On Sun, Apr 30, 2017 at 1:16 PM, wm4 wrote: >> >>> I think it's probably ok to push your current patch, since the original >>> author of the patch who brok

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-01 Thread Paul B Mahol
On 5/1/17, Muhammad Faiz wrote: > On Tue, May 2, 2017 at 1:05 AM, Paul B Mahol wrote: >> On 5/1/17, Muhammad Faiz wrote: >>> On Tue, May 2, 2017 at 12:45 AM, Paul B Mahol wrote: On 5/1/17, Muhammad Faiz wrote: > On Mon, May 1, 2017 at 11:22 PM, Kyle Swanson wrote: >> Hi, >> >

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-01 Thread Muhammad Faiz
On Tue, May 2, 2017 at 1:05 AM, Paul B Mahol wrote: > On 5/1/17, Muhammad Faiz wrote: >> On Tue, May 2, 2017 at 12:45 AM, Paul B Mahol wrote: >>> On 5/1/17, Muhammad Faiz wrote: On Mon, May 1, 2017 at 11:22 PM, Kyle Swanson wrote: > Hi, > > On Mon, May 1, 2017 at 3:18 AM, Paul

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-01 Thread Paul B Mahol
On 5/1/17, Muhammad Faiz wrote: > On Tue, May 2, 2017 at 12:45 AM, Paul B Mahol wrote: >> On 5/1/17, Muhammad Faiz wrote: >>> On Mon, May 1, 2017 at 11:22 PM, Kyle Swanson wrote: Hi, On Mon, May 1, 2017 at 3:18 AM, Paul B Mahol wrote: > On 4/30/17, Nicolas George wrote: >>>

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-01 Thread Muhammad Faiz
On Tue, May 2, 2017 at 12:45 AM, Paul B Mahol wrote: > On 5/1/17, Muhammad Faiz wrote: >> On Mon, May 1, 2017 at 11:22 PM, Kyle Swanson wrote: >>> Hi, >>> >>> On Mon, May 1, 2017 at 3:18 AM, Paul B Mahol wrote: On 4/30/17, Nicolas George wrote: > Le primidi 11 floreal, an CCXXV, Muham

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-01 Thread Paul B Mahol
On 5/1/17, Muhammad Faiz wrote: > On Mon, May 1, 2017 at 11:22 PM, Kyle Swanson wrote: >> Hi, >> >> On Mon, May 1, 2017 at 3:18 AM, Paul B Mahol wrote: >>> On 4/30/17, Nicolas George wrote: Le primidi 11 floreal, an CCXXV, Muhammad Faiz a ecrit : > Are you working on these? Because cur

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-01 Thread Muhammad Faiz
On Mon, May 1, 2017 at 11:22 PM, Kyle Swanson wrote: > Hi, > > On Mon, May 1, 2017 at 3:18 AM, Paul B Mahol wrote: >> On 4/30/17, Nicolas George wrote: >>> Le primidi 11 floreal, an CCXXV, Muhammad Faiz a ecrit : Are you working on these? Because currently I'm not. >>> >>> There is nothing

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-01 Thread Ronald S. Bultje
Hi, On Mon, May 1, 2017 at 12:44 PM, Ronald S. Bultje wrote: > Hi, > > On Sun, Apr 30, 2017 at 1:16 PM, wm4 wrote: > >> I think it's probably ok to push your current patch, since the original >> author of the patch who broke this probably won't fix it. > > > I don't like the patch because it es

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-01 Thread Ronald S. Bultje
Hi, On Sun, Apr 30, 2017 at 1:16 PM, wm4 wrote: > I think it's probably ok to push your current patch, since the original > author of the patch who broke this probably won't fix it. I don't like the patch because it essentially duplicates the C implementation of the DSP function. If we do that

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-01 Thread Kyle Swanson
Hi, On Mon, May 1, 2017 at 3:18 AM, Paul B Mahol wrote: > On 4/30/17, Nicolas George wrote: >> Le primidi 11 floreal, an CCXXV, Muhammad Faiz a ecrit : >>> Are you working on these? Because currently I'm not. >> >> There is nothing to work on yet: the message you answer to is raising a >> questi

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-01 Thread Paul B Mahol
On 4/30/17, Nicolas George wrote: > Le primidi 11 floreal, an CCXXV, Muhammad Faiz a ecrit : >> Are you working on these? Because currently I'm not. > > There is nothing to work on yet: the message you answer to is raising a > question about the global design of the internal API. That question > n

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-04-30 Thread Muhammad Faiz
On Mon, May 1, 2017 at 12:06 AM, Nicolas George wrote: > Le primidi 11 floréal, an CCXXV, Muhammad Faiz a écrit : >> Are you working on these? Because currently I'm not. > > There is nothing to work on yet: the message you answer to is raising a > question about the global design of the internal A

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-04-30 Thread Muhammad Faiz
On Mon, May 1, 2017 at 12:16 AM, wm4 wrote: > On Sun, 30 Apr 2017 23:55:02 +0700 > Muhammad Faiz wrote: > >> On Thu, Apr 27, 2017 at 3:51 PM, Nicolas George wrote: >> > L'octidi 8 floréal, an CCXXV, Michael Niedermayer a écrit : >> >> I agree >> >> in fact i added such a flag in 2011 >> >> (4d3

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-04-30 Thread wm4
On Sun, 30 Apr 2017 23:55:02 +0700 Muhammad Faiz wrote: > On Thu, Apr 27, 2017 at 3:51 PM, Nicolas George wrote: > > L'octidi 8 floréal, an CCXXV, Michael Niedermayer a écrit : > >> I agree > >> in fact i added such a flag in 2011 > >> (4d34b6c1a1254850e39a36f08f4d2730092a54db) > >> within th

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-04-30 Thread Nicolas George
Le primidi 11 floréal, an CCXXV, Muhammad Faiz a écrit : > Are you working on these? Because currently I'm not. There is nothing to work on yet: the message you answer to is raising a question about the global design of the internal API. That question needs an answer before any work can be done, a

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-04-30 Thread Muhammad Faiz
On Thu, Apr 27, 2017 at 3:51 PM, Nicolas George wrote: > L'octidi 8 floréal, an CCXXV, Michael Niedermayer a écrit : >> I agree >> in fact i added such a flag in 2011 >> (4d34b6c1a1254850e39a36f08f4d2730092a54db) >> within the API of that time to avfilter > > It was not a bad idea, but it should

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-04-27 Thread Nicolas George
L'octidi 8 floréal, an CCXXV, Michael Niedermayer a écrit : > I agree > in fact i added such a flag in 2011 (4d34b6c1a1254850e39a36f08f4d2730092a54db) > within the API of that time to avfilter It was not a bad idea, but it should not be limited to filters. A few comments. * First, the framequeue

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-04-26 Thread Michael Niedermayer
On Wed, Apr 26, 2017 at 10:05:40PM +0200, wm4 wrote: > On Thu, 27 Apr 2017 01:41:04 +0700 > Muhammad Faiz wrote: > > > On Wed, Apr 26, 2017 at 8:53 PM, wm4 wrote: > > > On Wed, 26 Apr 2017 20:09:58 +0700 > > > Muhammad Faiz wrote: > > > > > >> On Wed, Apr 26, 2017 at 5:34 PM, wm4 wrote: >

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-04-26 Thread wm4
On Thu, 27 Apr 2017 01:41:04 +0700 Muhammad Faiz wrote: > On Wed, Apr 26, 2017 at 8:53 PM, wm4 wrote: > > On Wed, 26 Apr 2017 20:09:58 +0700 > > Muhammad Faiz wrote: > > > >> On Wed, Apr 26, 2017 at 5:34 PM, wm4 wrote: > >> > On Wed, 26 Apr 2017 17:16:05 +0700 > >> > Muhammad Faiz wrote:

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-04-26 Thread Muhammad Faiz
On Wed, Apr 26, 2017 at 8:53 PM, wm4 wrote: > On Wed, 26 Apr 2017 20:09:58 +0700 > Muhammad Faiz wrote: > >> On Wed, Apr 26, 2017 at 5:34 PM, wm4 wrote: >> > On Wed, 26 Apr 2017 17:16:05 +0700 >> > Muhammad Faiz wrote: >> > >> >> This should fix Ticket6349 >> >> >> >> Since 383057f8e744efeaaa36

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-04-26 Thread wm4
On Wed, 26 Apr 2017 20:09:58 +0700 Muhammad Faiz wrote: > On Wed, Apr 26, 2017 at 5:34 PM, wm4 wrote: > > On Wed, 26 Apr 2017 17:16:05 +0700 > > Muhammad Faiz wrote: > > > >> This should fix Ticket6349 > >> > >> Since 383057f8e744efeaaa3648a59bc577b25b055835, framequeue may > >> generate unal

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-04-26 Thread Michael Niedermayer
On Wed, Apr 26, 2017 at 05:16:05PM +0700, Muhammad Faiz wrote: > This should fix Ticket6349 > > Since 383057f8e744efeaaa3648a59bc577b25b055835, framequeue may > generate unaligned frame data. > > Signed-off-by: Muhammad Faiz > --- > libavcodec/libmp3lame.c | 13 + > 1 file changed,

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-04-26 Thread Muhammad Faiz
On Wed, Apr 26, 2017 at 5:34 PM, wm4 wrote: > On Wed, 26 Apr 2017 17:16:05 +0700 > Muhammad Faiz wrote: > >> This should fix Ticket6349 >> >> Since 383057f8e744efeaaa3648a59bc577b25b055835, framequeue may >> generate unaligned frame data. >> >> Signed-off-by: Muhammad Faiz >> --- >> libavcodec/

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-04-26 Thread wm4
On Wed, 26 Apr 2017 17:16:05 +0700 Muhammad Faiz wrote: > This should fix Ticket6349 > > Since 383057f8e744efeaaa3648a59bc577b25b055835, framequeue may > generate unaligned frame data. > > Signed-off-by: Muhammad Faiz > --- > libavcodec/libmp3lame.c | 13 + > 1 file changed, 9 ins

[FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-04-26 Thread Muhammad Faiz
This should fix Ticket6349 Since 383057f8e744efeaaa3648a59bc577b25b055835, framequeue may generate unaligned frame data. Signed-off-by: Muhammad Faiz --- libavcodec/libmp3lame.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/libavcodec/libmp3lame.c b/libavcode