Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc.c: Fix linking with codec interface with msvc.

2015-01-10 Thread Michael Niedermayer
On Sat, Jan 10, 2015 at 06:18:16PM +, Timothy Gu wrote: > On Sat Jan 10 2015 at 3:28:36 AM Matt Oliver wrote: > > > This uses the appropriate libvpx accessor function for accessing the codec > > interface correctly on any platform which correct link errors on windows. > > > > LGTM. The acces

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc.c: Fix linking with codec interface with msvc.

2015-01-10 Thread Timothy Gu
On Sat Jan 10 2015 at 3:28:36 AM Matt Oliver wrote: > This uses the appropriate libvpx accessor function for accessing the codec > interface correctly on any platform which correct link errors on windows. > LGTM. The accessors have been there since 0.9.5, and we only support 0.9.7 for encoding.

[FFmpeg-devel] [PATCH] avcodec/libvpxenc.c: Fix linking with codec interface with msvc.

2015-01-10 Thread Matt Oliver
This uses the appropriate libvpx accessor function for accessing the codec interface correctly on any platform which correct link errors on windows. Reasoning is that the default libvpx msvc build uses module definitions to export data. Data exports in msvc like this are actually exported as pointe