Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Try to fix subsampling default

2019-10-11 Thread Michael Niedermayer
On Sat, Sep 28, 2019 at 07:13:59PM +0300, Skakov Pavel wrote: > >This ensures the default ycbcr_subsampling is 2 while also > >ensuring the subsampling values are correct for all pixel formats. > >This solution while it takes a few lines more code should be more > >robust > > In TIFF specification

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Try to fix subsampling default

2019-09-28 Thread Skakov Pavel
This ensures the default ycbcr_subsampling is 2 while also ensuring the subsampling values are correct for all pixel formats. This solution while it takes a few lines more code should be more robust In TIFF specification only CbCr subsampling is allowed. The field is explicitly named "YCbCrSubs

[FFmpeg-devel] [PATCH] avcodec/tiff: Try to fix subsampling default

2019-09-26 Thread Michael Niedermayer
This ensures the default ycbcr_subsampling is 2 while also ensuring the subsampling values are correct for all pixel formats. This solution while it takes a few lines more code should be more robust Found-by: Skakov Pavel Signed-off-by: Michael Niedermayer --- libavcodec/tiff.c | 13 +--