Re: [FFmpeg-devel] [PATCH] avcodec/utils: fix check for invalid timebase when decoding subtitles

2015-12-28 Thread Hendrik Leppkes
On Sun, Dec 27, 2015 at 9:29 PM, Andreas Cadhalpun wrote: > On 27.12.2015 21:13, Hendrik Leppkes wrote: >> On Sun, Dec 27, 2015 at 9:03 PM, Andreas Cadhalpun >> wrote: >>> On 27.12.2015 20:43, Hendrik Leppkes wrote: On Sun,

Re: [FFmpeg-devel] [PATCH] avcodec/utils: fix check for invalid timebase when decoding subtitles

2015-12-27 Thread Andreas Cadhalpun
On 27.12.2015 20:10, Hendrik Leppkes wrote: > Invalid timebases have a zero numerator, not denominator. A timebase with zero numerator is probably invalid, but a timebase with zero denominator is not even well defined. So this comment doesn't seem quite right. > Fixes a integer divison by zero.

Re: [FFmpeg-devel] [PATCH] avcodec/utils: fix check for invalid timebase when decoding subtitles

2015-12-27 Thread Andreas Cadhalpun
On 27.12.2015 20:43, Hendrik Leppkes wrote: > On Sun, Dec 27, 2015 at 8:29 PM, Andreas Cadhalpun > wrote: >> On 27.12.2015 20:10, Hendrik Leppkes wrote: >>> Invalid timebases have a zero numerator, not denominator. >> >> A timebase with zero numerator is probably

Re: [FFmpeg-devel] [PATCH] avcodec/utils: fix check for invalid timebase when decoding subtitles

2015-12-27 Thread Hendrik Leppkes
On Sun, Dec 27, 2015 at 8:29 PM, Andreas Cadhalpun wrote: > On 27.12.2015 20:10, Hendrik Leppkes wrote: >> Invalid timebases have a zero numerator, not denominator. > > A timebase with zero numerator is probably invalid, but a timebase > with zero denominator is

[FFmpeg-devel] [PATCH] avcodec/utils: fix check for invalid timebase when decoding subtitles

2015-12-27 Thread Hendrik Leppkes
Invalid timebases have a zero numerator, not denominator. Fixes a integer divison by zero. --- libavcodec/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index 19f3f0a..33295ed 100644 --- a/libavcodec/utils.c +++

Re: [FFmpeg-devel] [PATCH] avcodec/utils: fix check for invalid timebase when decoding subtitles

2015-12-27 Thread Hendrik Leppkes
On Sun, Dec 27, 2015 at 9:03 PM, Andreas Cadhalpun wrote: > On 27.12.2015 20:43, Hendrik Leppkes wrote: >> On Sun, Dec 27, 2015 at 8:29 PM, Andreas Cadhalpun >> wrote: >>> On 27.12.2015 20:10, Hendrik Leppkes wrote: Invalid

Re: [FFmpeg-devel] [PATCH] avcodec/utils: fix check for invalid timebase when decoding subtitles

2015-12-27 Thread Andreas Cadhalpun
On 27.12.2015 21:13, Hendrik Leppkes wrote: > On Sun, Dec 27, 2015 at 9:03 PM, Andreas Cadhalpun > wrote: >> On 27.12.2015 20:43, Hendrik Leppkes wrote: >>> On Sun, Dec 27, 2015 at 8:29 PM, Andreas Cadhalpun >>> wrote: On