Re: [FFmpeg-devel] [PATCH] avcodec: add minimal teletext subtitle decoder

2020-06-14 Thread Carl Eugen Hoyos
Am So., 14. Juni 2020 um 17:52 Uhr schrieb Marton Balint : > > > > On Sun, 14 Jun 2020, Carl Eugen Hoyos wrote: > > > Am So., 14. Juni 2020 um 17:40 Uhr schrieb Marton Balint : > >> > >> > >> > >> On Sun, 14 Jun 2020, Carl Eugen Hoyos wrote: > >> > >> > Am So., 14. Juni 2020 um 16:26 Uhr schrieb

Re: [FFmpeg-devel] [PATCH] avcodec: add minimal teletext subtitle decoder

2020-06-14 Thread Marton Balint
On Sun, 14 Jun 2020, Carl Eugen Hoyos wrote: Am So., 14. Juni 2020 um 17:40 Uhr schrieb Marton Balint : On Sun, 14 Jun 2020, Carl Eugen Hoyos wrote: > Am So., 14. Juni 2020 um 16:26 Uhr schrieb Marton Balint : >> >> >> >> On Sun, 14 Jun 2020, Carl Eugen Hoyos wrote: >> >> > Am So., 14.

Re: [FFmpeg-devel] [PATCH] avcodec: add minimal teletext subtitle decoder

2020-06-14 Thread Carl Eugen Hoyos
Am So., 14. Juni 2020 um 17:40 Uhr schrieb Marton Balint : > > > > On Sun, 14 Jun 2020, Carl Eugen Hoyos wrote: > > > Am So., 14. Juni 2020 um 16:26 Uhr schrieb Marton Balint : > >> > >> > >> > >> On Sun, 14 Jun 2020, Carl Eugen Hoyos wrote: > >> > >> > Am So., 14. Juni 2020 um 12:05 Uhr schrieb

Re: [FFmpeg-devel] [PATCH] avcodec: add minimal teletext subtitle decoder

2020-06-14 Thread Marton Balint
On Sun, 14 Jun 2020, Carl Eugen Hoyos wrote: Am So., 14. Juni 2020 um 16:26 Uhr schrieb Marton Balint : On Sun, 14 Jun 2020, Carl Eugen Hoyos wrote: > Am So., 14. Juni 2020 um 12:05 Uhr schrieb Paul B Mahol : >> >> [...] this patch should be merged. > > I still believe this is one of the

Re: [FFmpeg-devel] [PATCH] avcodec: add minimal teletext subtitle decoder

2020-06-14 Thread Paul B Mahol
On 6/14/20, Marton Balint wrote: > > > On Sun, 14 Jun 2020, Paul B Mahol wrote: > >> Nothing happened of this, so this patch should be merged. > > What do you mean? Ass output support got added to libzvbi-teletextdec in > 2018. And how is ass output support relevant to give FFmpeg decoder

Re: [FFmpeg-devel] [PATCH] avcodec: add minimal teletext subtitle decoder

2020-06-14 Thread Carl Eugen Hoyos
Am So., 14. Juni 2020 um 16:26 Uhr schrieb Marton Balint : > > > > On Sun, 14 Jun 2020, Carl Eugen Hoyos wrote: > > > Am So., 14. Juni 2020 um 12:05 Uhr schrieb Paul B Mahol : > >> > >> [...] this patch should be merged. > > > > I still believe this is one of the most important missing > >

Re: [FFmpeg-devel] [PATCH] avcodec: add minimal teletext subtitle decoder

2020-06-14 Thread Marton Balint
On Sun, 14 Jun 2020, Carl Eugen Hoyos wrote: Am So., 14. Juni 2020 um 12:05 Uhr schrieb Paul B Mahol : [...] this patch should be merged. I still believe this is one of the most important missing features Which one? As far as I remember I integrated all the features (including

Re: [FFmpeg-devel] [PATCH] avcodec: add minimal teletext subtitle decoder

2020-06-14 Thread Carl Eugen Hoyos
Am So., 14. Juni 2020 um 12:05 Uhr schrieb Paul B Mahol : > > [...] this patch should be merged. I still believe this is one of the most important missing features and this patch is therefore very much in need of a rebase and resend but an option to select a subtitle page was missing from the

Re: [FFmpeg-devel] [PATCH] avcodec: add minimal teletext subtitle decoder

2020-06-14 Thread Marton Balint
On Sun, 14 Jun 2020, Paul B Mahol wrote: Nothing happened of this, so this patch should be merged. What do you mean? Ass output support got added to libzvbi-teletextdec in 2018. Regards, Marton On 4/26/18, Marton Balint wrote: On Thu, 26 Apr 2018, Aman Gupta wrote: On Thu, Apr

Re: [FFmpeg-devel] [PATCH] avcodec: add minimal teletext subtitle decoder

2020-06-14 Thread Paul B Mahol
Nothing happened of this, so this patch should be merged. On 4/26/18, Marton Balint wrote: > > On Thu, 26 Apr 2018, Aman Gupta wrote: > >> On Thu, Apr 26, 2018 at 8:12 AM, Nicolas George wrote: >> >>> Aman Gupta (2018-04-26): >>> > Another reason I discounted libzvbi is because it seems

Re: [FFmpeg-devel] [PATCH] avcodec: add minimal teletext subtitle decoder

2018-04-26 Thread Marton Balint
On Thu, 26 Apr 2018, Aman Gupta wrote: On Thu, Apr 26, 2018 at 8:12 AM, Nicolas George wrote: Aman Gupta (2018-04-26): > Another reason I discounted libzvbi is because it seems unmaintained, > without a new release is over 5 years. Did the teletext standard evolve in the

Re: [FFmpeg-devel] [PATCH] avcodec: add minimal teletext subtitle decoder

2018-04-26 Thread Michael Niedermayer
On Tue, Apr 24, 2018 at 07:07:58PM -0700, Aman Gupta wrote: > From: Aman Gupta > > Based largely on VLC's modules/codec/telx.c. > > Processes only teletext pages marked as subtitles, so depending > on the stream it might not produce any output. > > Subtitles are rendered

Re: [FFmpeg-devel] [PATCH] avcodec: add minimal teletext subtitle decoder

2018-04-26 Thread Michael Niedermayer
On Thu, Apr 26, 2018 at 03:15:08AM +0200, Marton Balint wrote: > > > On Thu, 26 Apr 2018, Carl Eugen Hoyos wrote: > > >2018-04-25 4:07 GMT+02:00, Aman Gupta : > > > >>Processes only teletext pages marked as subtitles, so > >>depending on the stream it might not produce any

Re: [FFmpeg-devel] [PATCH] avcodec: add minimal teletext subtitle decoder

2018-04-26 Thread Aman Gupta
On Thu, Apr 26, 2018 at 8:12 AM, Nicolas George wrote: > Aman Gupta (2018-04-26): > > Another reason I discounted libzvbi is because it seems unmaintained, > > without a new release is over 5 years. > > Did the teletext standard evolve in the past five years? > I don't know,

Re: [FFmpeg-devel] [PATCH] avcodec: add minimal teletext subtitle decoder

2018-04-26 Thread Nicolas George
Aman Gupta (2018-04-26): > Another reason I discounted libzvbi is because it seems unmaintained, > without a new release is over 5 years. Did the teletext standard evolve in the past five years? Regards, -- Nicolas George signature.asc Description: Digital signature

Re: [FFmpeg-devel] [PATCH] avcodec: add minimal teletext subtitle decoder

2018-04-26 Thread Aman Gupta
On Wed, Apr 25, 2018 at 9:17 PM, Aman Gupta wrote: > > On Wed, Apr 25, 2018 at 6:15 PM Marton Balint wrote: > >> >> >> On Thu, 26 Apr 2018, Carl Eugen Hoyos wrote: >> >> > 2018-04-25 4:07 GMT+02:00, Aman Gupta : >> > >> >> Processes only

Re: [FFmpeg-devel] [PATCH] avcodec: add minimal teletext subtitle decoder

2018-04-26 Thread Aman Gupta
On Thu, Apr 26, 2018 at 4:35 AM, Carl Eugen Hoyos wrote: > 2018-04-26 5:02 GMT+02:00, Aman Gupta : > > On Wed, Apr 25, 2018 at 5:30 PM Carl Eugen Hoyos > wrote: > > > >> 2018-04-25 4:07 GMT+02:00, Aman Gupta : > >> > >> >

Re: [FFmpeg-devel] [PATCH] avcodec: add minimal teletext subtitle decoder

2018-04-26 Thread Carl Eugen Hoyos
2018-04-26 5:02 GMT+02:00, Aman Gupta : > On Wed, Apr 25, 2018 at 5:30 PM Carl Eugen Hoyos wrote: > >> 2018-04-25 4:07 GMT+02:00, Aman Gupta : >> >> > Processes only teletext pages marked as subtitles, so >> > depending on the stream it might

Re: [FFmpeg-devel] [PATCH] avcodec: add minimal teletext subtitle decoder

2018-04-25 Thread Aman Gupta
On Tue, Apr 24, 2018 at 7:08 PM Aman Gupta wrote: > From: Aman Gupta > > Based largely on VLC's modules/codec/telx.c. > > Processes only teletext pages marked as subtitles, so depending > on the stream it might not produce any output. > > Subtitles are rendered

Re: [FFmpeg-devel] [PATCH] avcodec: add minimal teletext subtitle decoder

2018-04-25 Thread Aman Gupta
On Wed, Apr 25, 2018 at 6:15 PM Marton Balint wrote: > > > On Thu, 26 Apr 2018, Carl Eugen Hoyos wrote: > > > 2018-04-25 4:07 GMT+02:00, Aman Gupta : > > > >> Processes only teletext pages marked as subtitles, so > >> depending on the stream it might not produce

Re: [FFmpeg-devel] [PATCH] avcodec: add minimal teletext subtitle decoder

2018-04-25 Thread Aman Gupta
On Wed, Apr 25, 2018 at 5:30 PM Carl Eugen Hoyos wrote: > 2018-04-25 4:07 GMT+02:00, Aman Gupta : > > > Processes only teletext pages marked as subtitles, so > > depending on the stream it might not produce any output. > > Shouldn't there be at least an

Re: [FFmpeg-devel] [PATCH] avcodec: add minimal teletext subtitle decoder

2018-04-25 Thread Carl Eugen Hoyos
2018-04-26 3:15 GMT+02:00, Marton Balint : > > > On Thu, 26 Apr 2018, Carl Eugen Hoyos wrote: > >> 2018-04-25 4:07 GMT+02:00, Aman Gupta : >> >>> Processes only teletext pages marked as subtitles, so >>> depending on the stream it might not produce any output. >>

Re: [FFmpeg-devel] [PATCH] avcodec: add minimal teletext subtitle decoder

2018-04-25 Thread Marton Balint
On Thu, 26 Apr 2018, Carl Eugen Hoyos wrote: 2018-04-25 4:07 GMT+02:00, Aman Gupta : Processes only teletext pages marked as subtitles, so depending on the stream it might not produce any output. Shouldn't there be at least an option to output whatever page was requested?

Re: [FFmpeg-devel] [PATCH] avcodec: add minimal teletext subtitle decoder

2018-04-25 Thread Carl Eugen Hoyos
2018-04-25 4:07 GMT+02:00, Aman Gupta : > Processes only teletext pages marked as subtitles, so > depending on the stream it might not produce any output. Shouldn't there be at least an option to output whatever page was requested? +1 for not needing an external dependency.

Re: [FFmpeg-devel] [PATCH] avcodec: add minimal teletext subtitle decoder

2018-04-25 Thread Michael Niedermayer
On Wed, Apr 25, 2018 at 09:32:43PM +0200, Marton Balint wrote: > > > On Tue, 24 Apr 2018, Aman Gupta wrote: > > >From: Aman Gupta > > > >Based largely on VLC's modules/codec/telx.c. > > > >Processes only teletext pages marked as subtitles, so depending > >on the stream it might

Re: [FFmpeg-devel] [PATCH] avcodec: add minimal teletext subtitle decoder

2018-04-25 Thread Marton Balint
On Tue, 24 Apr 2018, Aman Gupta wrote: From: Aman Gupta Based largely on VLC's modules/codec/telx.c. Processes only teletext pages marked as subtitles, so depending on the stream it might not produce any output. Subtitles are rendered directly to ASS, with support for

[FFmpeg-devel] [PATCH] avcodec: add minimal teletext subtitle decoder

2018-04-24 Thread Aman Gupta
From: Aman Gupta Based largely on VLC's modules/codec/telx.c. Processes only teletext pages marked as subtitles, so depending on the stream it might not produce any output. Subtitles are rendered directly to ASS, with support for background colors and a best-effort at screen