Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-05-23 Thread Michael Niedermayer
On Sat, May 23, 2015 at 01:54:24AM -0300, James Almer wrote: > On 23/05/15 12:34 AM, James Almer wrote: > > On 22/05/15 10:43 PM, Michael Niedermayer wrote: > >> applied > >> > >> i think the AVOption table and AVClass name could still be improved > >> to match each encoder more individually, i don

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-05-22 Thread James Almer
On 23/05/15 12:34 AM, James Almer wrote: > On 22/05/15 10:43 PM, Michael Niedermayer wrote: >> applied >> >> i think the AVOption table and AVClass name could still be improved >> to match each encoder more individually, i dont think both >> support all options >> >> Thanks > > I thought classes c

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-05-22 Thread James Almer
On 22/05/15 10:43 PM, Michael Niedermayer wrote: > applied > > i think the AVOption table and AVClass name could still be improved > to match each encoder more individually, i dont think both > support all options > > Thanks I thought classes couldn't be shared between different components, as i

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-05-22 Thread Michael Niedermayer
On Fri, May 22, 2015 at 05:28:06PM +, Urvang Joshi wrote: > On Thu, May 21, 2015 at 6:48 PM Michael Niedermayer > wrote: > > > On Wed, May 20, 2015 at 01:54:59AM +, Urvang Joshi wrote: > > > On Thu, May 14, 2015 at 7:21 PM Michael Niedermayer > > > wrote: > > > > > > > On Fri, May 15, 20

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-05-21 Thread Michael Niedermayer
On Wed, May 20, 2015 at 01:54:59AM +, Urvang Joshi wrote: > On Thu, May 14, 2015 at 7:21 PM Michael Niedermayer > wrote: > > > On Fri, May 15, 2015 at 01:29:19AM +, Urvang Joshi wrote: > > > On Fri, May 8, 2015 at 8:22 AM Michael Niedermayer > > wrote: > > > > > > > On Thu, May 07, 2015

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-05-14 Thread Michael Niedermayer
On Fri, May 15, 2015 at 01:29:19AM +, Urvang Joshi wrote: > On Fri, May 8, 2015 at 8:22 AM Michael Niedermayer wrote: > > > On Thu, May 07, 2015 at 09:28:43PM +, Urvang Joshi wrote: > > > On Thu, Apr 30, 2015 at 12:05 PM Michael Niedermayer > > > wrote: > > > > > > > On Wed, Apr 29, 2015

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-05-08 Thread Michael Niedermayer
On Thu, May 07, 2015 at 09:28:43PM +, Urvang Joshi wrote: > On Thu, Apr 30, 2015 at 12:05 PM Michael Niedermayer > wrote: > > > On Wed, Apr 29, 2015 at 11:53:40PM +, Urvang Joshi wrote: > > > On Mon, Apr 27, 2015 at 5:03 PM Michael Niedermayer > > > wrote: > > > > > > > On Mon, Apr 27, 2

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-04-30 Thread Michael Niedermayer
On Wed, Apr 29, 2015 at 11:53:40PM +, Urvang Joshi wrote: > On Mon, Apr 27, 2015 at 5:03 PM Michael Niedermayer > wrote: > > > On Mon, Apr 27, 2015 at 10:18:52PM +, Urvang Joshi wrote: > > > On Thu, Apr 23, 2015 at 2:51 PM Michael Niedermayer > > > wrote: > > > > > > > On Thu, Apr 16, 20

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-04-27 Thread James Almer
On 27/04/15 9:02 PM, Michael Niedermayer wrote: > Ok, so the patch adds many #ifs to both the muxer and > encoder, and there are more changes in the encoder than the muxer > the commit message which is 1 single line only speaks about the encoder > and the patch is only about the muxer. > Did i unde

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-04-27 Thread Michael Niedermayer
On Mon, Apr 27, 2015 at 10:18:52PM +, Urvang Joshi wrote: > On Thu, Apr 23, 2015 at 2:51 PM Michael Niedermayer > wrote: > > > On Thu, Apr 16, 2015 at 10:40:14PM +, Urvang Joshi wrote: > > > On Thu, Apr 16, 2015 at 3:09 PM James Almer wrote: > > > > > > > On 16/04/15 4:18 PM, Urvang Josh

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-04-23 Thread Michael Niedermayer
On Thu, Apr 23, 2015 at 11:51:15PM +0200, Michael Niedermayer wrote: > On Thu, Apr 16, 2015 at 10:40:14PM +, Urvang Joshi wrote: > > On Thu, Apr 16, 2015 at 3:09 PM James Almer wrote: > > > > > On 16/04/15 4:18 PM, Urvang Joshi wrote: > > > > Hi, > > > > Here's the patch without whitespace ch

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-04-23 Thread Michael Niedermayer
On Thu, Apr 16, 2015 at 10:40:14PM +, Urvang Joshi wrote: > On Thu, Apr 16, 2015 at 3:09 PM James Almer wrote: > > > On 16/04/15 4:18 PM, Urvang Joshi wrote: > > > Hi, > > > Here's the patch without whitespace changes. > > > > > > Thanks, > > > Urvang > > > > This patch doesn't apply cleanly.

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-04-16 Thread Urvang Joshi
On Thu, Apr 16, 2015 at 3:09 PM James Almer wrote: > On 16/04/15 4:18 PM, Urvang Joshi wrote: > > Hi, > > Here's the patch without whitespace changes. > > > > Thanks, > > Urvang > > This patch doesn't apply cleanly. Looks like something weird with the > indentation still. > Was this patch handmad

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-04-16 Thread James Almer
On 16/04/15 4:18 PM, Urvang Joshi wrote: > Hi, > Here's the patch without whitespace changes. > > Thanks, > Urvang This patch doesn't apply cleanly. Looks like something weird with the indentation still. Was this patch handmade? It says the hash for libwebpenc.c is 95d56ac (same as git head),

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-04-16 Thread Urvang Joshi
Hi, Here's the patch without whitespace changes. Thanks, Urvang On Thu, Apr 16, 2015 at 11:50 AM Urvang Joshi wrote: > Hi Michael, > Sorry for my misunderstanding earlier. > I was told offline that the usual practice in FFmpeg is to land the > non-whitespace diff first, followed by a separate r

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-04-16 Thread Urvang Joshi
Hi Michael, Sorry for my misunderstanding earlier. I was told offline that the usual practice in FFmpeg is to land the non-whitespace diff first, followed by a separate reindent commit. Let me separate out the two and send the non-whitespace diff shortly. On Thu, Apr 16, 2015 at 11:35 AM Urvang J

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-04-16 Thread Urvang Joshi
Hello Michael, On Thu, Apr 16, 2015 at 5:26 AM Michael Niedermayer wrote: > On Thu, Apr 16, 2015 at 12:28:22AM +, Urvang Joshi wrote: > > Hi, > > Here's an updated patch that used 'HAVE_WEBP_MUX_H' as you suggested. I > > also updated the patch to work with the latest libwebp code (from > >

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-04-16 Thread Michael Niedermayer
On Thu, Apr 16, 2015 at 12:28:22AM +, Urvang Joshi wrote: > Hi, > Here's an updated patch that used 'HAVE_WEBP_MUX_H' as you suggested. I > also updated the patch to work with the latest libwebp code (from > https://gerrit.chromium.org/gerrit/gitweb?p=webm/libwebp.git) please dont reindent the

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-03-31 Thread Pascal Massimino
Hi, On Sat, Mar 28, 2015 at 4:51 AM, James Almer wrote: > On 27/03/15 7:02 AM, Pascal Massimino wrote: > > diff --git a/libavformat/webpenc.c b/libavformat/webpenc.c > > index ee110de..d4411a9 100644 > > --- a/libavformat/webpenc.c > > +++ b/libavformat/webpenc.c > > @@ -24,10 +24,20 @@ > > #in

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-03-27 Thread James Almer
On 27/03/15 7:02 AM, Pascal Massimino wrote: > diff --git a/libavformat/webpenc.c b/libavformat/webpenc.c > index ee110de..d4411a9 100644 > --- a/libavformat/webpenc.c > +++ b/libavformat/webpenc.c > @@ -24,10 +24,20 @@ > #include "avformat.h" > #include "internal.h" > > +#include > +#if (WEBP

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-03-27 Thread Michael Niedermayer
On Fri, Mar 27, 2015 at 01:54:31PM -0300, James Almer wrote: > On 27/03/15 1:50 PM, Michael Niedermayer wrote: > > On Fri, Mar 27, 2015 at 05:01:58PM +0100, Pascal Massimino wrote: > >> Michael, > >> > >> On Fri, Mar 27, 2015 at 1:37 PM, Michael Niedermayer > >> wrote: > >> > >>> On Fri, Mar 27, 2

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-03-27 Thread James Almer
On 27/03/15 1:50 PM, Michael Niedermayer wrote: > On Fri, Mar 27, 2015 at 05:01:58PM +0100, Pascal Massimino wrote: >> Michael, >> >> On Fri, Mar 27, 2015 at 1:37 PM, Michael Niedermayer >> wrote: >> >>> On Fri, Mar 27, 2015 at 11:02:09AM +0100, Pascal Massimino wrote: Hi, $subject

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-03-27 Thread Michael Niedermayer
On Fri, Mar 27, 2015 at 05:01:58PM +0100, Pascal Massimino wrote: > Michael, > > On Fri, Mar 27, 2015 at 1:37 PM, Michael Niedermayer > wrote: > > > On Fri, Mar 27, 2015 at 11:02:09AM +0100, Pascal Massimino wrote: > > > Hi, > > > > > > $subject > > > > > > $attached says: > > >

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-03-27 Thread Pascal Massimino
Michael, On Fri, Mar 27, 2015 at 1:37 PM, Michael Niedermayer wrote: > On Fri, Mar 27, 2015 at 11:02:09AM +0100, Pascal Massimino wrote: > > Hi, > > > > $subject > > > > $attached says: > > > > This API is available at head

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-03-27 Thread Michael Niedermayer
On Fri, Mar 27, 2015 at 11:02:09AM +0100, Pascal Massimino wrote: > Hi, > > $subject > > $attached says: > > This API is available at head (MUX_ABI_VERSION >= 0x0104), is stable, > and will be made official in future releas

[FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-03-27 Thread Pascal Massimino
Hi, $subject $attached says: This API is available at head (MUX_ABI_VERSION >= 0x0104), is stable, and will be made official in future release. For compatibility, the previous code is left as fallback. Dont' forget to use