On 2016-10-18 2:20 PM, Michael Niedermayer wrote:
On Tue, Oct 18, 2016 at 12:46:56PM -0400, Greg Rowe wrote:
see
libavfilter/asrc_sine.c
this code should probably be reused / factored
(note, any code moving/factoring of existing code should be in a
seperate patch)
Since silenceremove works
On Tue, Oct 18, 2016 at 12:46:56PM -0400, Greg Rowe wrote:
> >see
> >libavfilter/asrc_sine.c
> >this code should probably be reused / factored
> >(note, any code moving/factoring of existing code should be in a
> > seperate patch)
>
> Since silenceremove works only on AV_SAMPLE_FMT_DBL is it OK
see
libavfilter/asrc_sine.c
this code should probably be reused / factored
(note, any code moving/factoring of existing code should be in a
seperate patch)
Since silenceremove works only on AV_SAMPLE_FMT_DBL is it OK to use
floating point for the generated tone or is it recommended to create
On Fri, Oct 14, 2016 at 06:09:51PM +, Greg Rowe wrote:
> Michael,
>
> In the attached patch I've tried to make all of the changes you've pointed
> out. I also renamed tone_hz to tone_frequency on Moritz Barsnick's
> suggestion.
>
> Is there a good way to generate the tone while avoiding
On Fri, Oct 14, 2016 at 18:09:51 +, Greg Rowe wrote:
You attached the old patch. ;-)
Is there a good way to generate the tone while avoiding floating
point operations?
Well that's embarrassing. I'll fix that after we figure out how best to
handle the tone generation. :)
Good point:
On Fri, Oct 14, 2016 at 18:09:51 +, Greg Rowe wrote:
> In the attached patch I've tried to make all of the changes you've
> pointed out. I also renamed tone_hz to tone_frequency on Moritz
> Barsnick's suggestion.
You attached the old patch. ;-)
> Is there a good way to generate the tone
Michael,
In the attached patch I've tried to make all of the changes you've pointed out.
I also renamed tone_hz to tone_frequency on Moritz Barsnick's suggestion.
Is there a good way to generate the tone while avoiding floating point
operations? If there is then don't bother reviewing this
On Thu, Oct 13, 2016 at 08:48:11PM +, Greg Rowe wrote:
> The attached patch adds two optional parameters to af_silenceremove for the
> purpose of inserting a tone in place of where silence was removed. This
> alerts the user that silence has been trimmed from the original stream. The
>
The attached patch adds two optional parameters to af_silenceremove for the
purpose of inserting a tone in place of where silence was removed. This alerts
the user that silence has been trimmed from the original stream. The
parameters are tone_duration which defaults to 0.0 which disables the
