Re: [FFmpeg-devel] [PATCH] avfilter/image2: Add source file path and basename to each packet side data.

2019-12-26 Thread Alexandre Heitor Schmidt
> About security > The file path can reveal a wide range of information like > The platform used, > The username, > A potentially writable location > And a lot more depending on how the directories are layed out > > About privacy > The username is commonly related to the users real name, thats >

Re: [FFmpeg-devel] [PATCH] avfilter/image2: Add source file path and basename to each packet side data.

2019-12-26 Thread Alexandre Heitor Schmidt
> you may have to only activate this (or at least the full path metadata) feature > if the user explicitly requests it. Probably the best way to do that is to > introduce a new option of the image2 demuxer, probably with an AV_OPT_TYPE_FLAGS > type. Do you mean image2 should, for example,

Re: [FFmpeg-devel] [PATCH] avfilter/image2: Add source file path and basename to each packet side data.

2019-12-23 Thread Michael Niedermayer
On Mon, Dec 23, 2019 at 12:19:21AM +, alexandre.schm...@gmail.com wrote: > > > > not sure why i just now realize it but > > > > Storing the source path is problematic privacy and security wise > > > > Thanks > > > > What does this means? That it won't be applied? > > Can you give an example

Re: [FFmpeg-devel] [PATCH] avfilter/image2: Add source file path and basename to each packet side data.

2019-12-23 Thread Marton Balint
On Mon, 23 Dec 2019, alexandre.schm...@gmail.com wrote: not sure why i just now realize it but Storing the source path is problematic privacy and security wise Thanks What does this means? That it won't be applied? It only means that you may have to only activate this (or at least the

Re: [FFmpeg-devel] [PATCH] avfilter/image2: Add source file path and basename to each packet side data.

2019-12-22 Thread alexandre.schm...@gmail.com
> > not sure why i just now realize it but > > Storing the source path is problematic privacy and security wise > > Thanks > What does this means? That it won't be applied? Can you give an example on why this would be a security issue, considering you already have it anywhere, only not available

Re: [FFmpeg-devel] [PATCH] avfilter/image2: Add source file path and basename to each packet side data.

2019-12-22 Thread Michael Niedermayer
On Sat, Dec 21, 2019 at 05:32:26PM +, Alexandre Heitor Schmidt wrote: > > In the commit msg, > > > >> libavformat/img2dec.c: Modify image2 demuxer to make available > >> two special metadata entries called lavf.image2dec.source_basename > >> and lavf.image2dec.source_basename, which

Re: [FFmpeg-devel] [PATCH] avfilter/image2: Add source file path and basename to each packet side data.

2019-12-21 Thread Alexandre Heitor Schmidt
> In the commit msg, > >> libavformat/img2dec.c: Modify image2 demuxer to make available >> two special metadata entries called lavf.image2dec.source_basename >> and lavf.image2dec.source_basename, which represents, respectively, >> the complete path to the source image for the current frame and

Re: [FFmpeg-devel] [PATCH] avfilter/image2: Add source file path and basename to each packet side data.

2019-12-21 Thread Gyan
On 21-12-2019 10:00 pm, Alexandre Heitor Schmidt wrote: I fixed it again. Some {} weren't escaped by the "@" character, thus causing this error. The new patch follows attached. In the commit msg, libavformat/img2dec.c: Modify image2 demuxer to make available two special metadata

Re: [FFmpeg-devel] [PATCH] avfilter/image2: Add source file path and basename to each packet side data.

2019-12-21 Thread Alexandre Heitor Schmidt
Sorry, Nicolas. I'm new here. I'll keep the mails short for sure. Hopefully my next submissions won't take this long to process, as now I know more about how the entire thing works. Even reading the docs regarding patch submissions (which I did), there are things that I had to learn by trial &

Re: [FFmpeg-devel] [PATCH] avfilter/image2: Add source file path and basename to each packet side data.

2019-12-21 Thread Nicolas George
Alexandre Heitor Schmidt (12019-12-21): > I fixed it again. Some {} weren't escaped by the "@" character, thus causing > this error. How did this happen? Did you not build ffmpeg completely (and run FATE) before sending the patch? Also, could you please trim your mails? >250 lines of quote for

Re: [FFmpeg-devel] [PATCH] avfilter/image2: Add source file path and basename to each packet side data.

2019-12-21 Thread Alexandre Heitor Schmidt
On 19/12/2019 16:46, Michael Niedermayer wrote: > On Tue, Dec 17, 2019 at 02:30:39PM +, Alexandre Heitor Schmidt wrote: >> On 17/12/2019 00:35, Marton Balint wrote: >>> On Mon, 16 Dec 2019, Alexandre Heitor Schmidt wrote: This is the second time I'm submiting this patch, now modified to

Re: [FFmpeg-devel] [PATCH] avfilter/image2: Add source file path and basename to each packet side data.

2019-12-21 Thread Alexandre Heitor Schmidt
On 19/12/2019 16:46, Michael Niedermayer wrote: > On Tue, Dec 17, 2019 at 02:30:39PM +, Alexandre Heitor Schmidt wrote: >> On 17/12/2019 00:35, Marton Balint wrote: >>> On Mon, 16 Dec 2019, Alexandre Heitor Schmidt wrote: This is the second time I'm submiting this patch, now modified to

Re: [FFmpeg-devel] [PATCH] avfilter/image2: Add source file path and basename to each packet side data.

2019-12-19 Thread Michael Niedermayer
On Tue, Dec 17, 2019 at 02:30:39PM +, Alexandre Heitor Schmidt wrote: > On 17/12/2019 00:35, Marton Balint wrote: > > On Mon, 16 Dec 2019, Alexandre Heitor Schmidt wrote: > >> This is the second time I'm submiting this patch, now modified to be > >> less intrusive, as sugested by Marton

Re: [FFmpeg-devel] [PATCH] avfilter/image2: Add source file path and basename to each packet side data.

2019-12-17 Thread Alexandre Heitor Schmidt
On 17/12/2019 00:35, Marton Balint wrote: > On Mon, 16 Dec 2019, Alexandre Heitor Schmidt wrote: >> This is the second time I'm submiting this patch, now modified to be >> less intrusive, as sugested by Marton Balint, and hopefully without git >> send-email messing up with the diff by replacing

Re: [FFmpeg-devel] [PATCH] avfilter/image2: Add source file path and basename to each packet side data.

2019-12-16 Thread Marton Balint
On Mon, 16 Dec 2019, Alexandre Heitor Schmidt wrote: This is the second time I'm submiting this patch, now modified to be less intrusive, as sugested by Marton Balint, and hopefully without git send-email messing up with the diff by replacing '@' within documentation entries. The patch

Re: [FFmpeg-devel] [PATCH] avfilter/image2: Add source file path and basename to each packet side data.

2019-12-16 Thread Alexandre Heitor Schmidt
It didn't work. For some reason, when I send the patch, entries like this: +@item +Plot special @var{source_basename} metadata, extracted from each input frame, or +the string "NA" if the metadata is not defined. +@example

[FFmpeg-devel] [PATCH] avfilter/image2: Add source file path and basename to each packet side data.

2019-12-16 Thread Alexandre Heitor Schmidt
This is the second time I'm submiting this patch, now modified to be less intrusive, as sugested by Marton Balint, and hopefully without git send-email messing up with the diff by replacing '@' within documentation entries. The patch modifies image2 filter to make available two special metadata