Re: [FFmpeg-devel] [PATCH] avfilter: add tremolo filter

2015-09-21 Thread Kyle Swanson
> Doesn't produce similar output as sox. > > Looks like there is no need to use generate_wave_table > as phase is calculated differently, even tremolo from > tap plugins do something different. > > Can you elaborate this approach? This filter is just amplitude modulation. Just took a listen

Re: [FFmpeg-devel] [PATCH] avfilter: add tremolo filter

2015-09-21 Thread Kyle Swanson
I've made these changes and have re-submitted as a new patch. Thanks! On Sun, Sep 20, 2015 at 2:46 AM, Paul B Mahol wrote: > Dana 20. 9. 2015. 06:28 osoba "Kyle Swanson" napisala je: >> >> Signed-off-by: Kyle Swanson >> --- >> doc/filters.texi

[FFmpeg-devel] [PATCH] avfilter: add tremolo filter

2015-09-21 Thread Kyle Swanson
Signed-off-by: Kyle Swanson --- doc/filters.texi | 19 + libavfilter/Makefile | 1 + libavfilter/af_tremolo.c | 177 +++ libavfilter/allfilters.c | 1 + libavfilter/version.h| 2 +- 5 files changed, 199

Re: [FFmpeg-devel] [PATCH] avfilter: add tremolo filter

2015-09-21 Thread Lou Logan
On Mon, 21 Sep 2015 10:16:43 -0500, Kyle Swanson wrote: > Signed-off-by: Kyle Swanson > --- > doc/filters.texi | 19 + > libavfilter/Makefile | 1 + > libavfilter/af_tremolo.c | 177 > +++ > libavfilter/allfilters.c |

Re: [FFmpeg-devel] [PATCH] avfilter: add tremolo filter

2015-09-21 Thread Paul B Mahol
On 9/21/15, Kyle Swanson wrote: > Signed-off-by: Kyle Swanson > --- > doc/filters.texi | 19 + > libavfilter/Makefile | 1 + > libavfilter/af_tremolo.c | 177 > +++ > libavfilter/allfilters.c | 1 + >

Re: [FFmpeg-devel] [PATCH] avfilter: add tremolo filter

2015-09-20 Thread Paul B Mahol
Dana 20. 9. 2015. 06:28 osoba "Kyle Swanson" napisala je: > > Signed-off-by: Kyle Swanson > --- > doc/filters.texi | 19 ++ > libavfilter/Makefile | 1 + > libavfilter/af_tremolo.c | 173 +++ >

Re: [FFmpeg-devel] [PATCH] avfilter: add tremolo filter

2015-09-20 Thread Clément Bœsch
On Sat, Sep 19, 2015 at 11:28:15PM -0500, Kyle Swanson wrote: [...] > +static int filter_frame(AVFilterLink *inlink, AVFrame *in) > +{ > +AVFilterContext *ctx = inlink->dst; > +AVFilterLink *outlink = ctx->outputs[0]; > +AVFrame *out; > + > +if (av_frame_is_writable(in)) { > +

[FFmpeg-devel] [PATCH] avfilter: add tremolo filter

2015-09-19 Thread Kyle Swanson
Signed-off-by: Kyle Swanson --- doc/filters.texi | 19 ++ libavfilter/Makefile | 1 + libavfilter/af_tremolo.c | 173 +++ libavfilter/allfilters.c | 1 + libavfilter/version.h| 2 +- 5 files changed, 195