Re: [FFmpeg-devel] [PATCH] avfilter: add wpsnr video filter

2021-11-09 Thread Andreas Rheinhardt
Ronald S. Bultje: > Hi Thomas, > > On Fri, Oct 29, 2021 at 9:12 AM Tomas Härdin wrote: > >> tor 2021-10-28 klockan 21:09 +0200 skrev Paul B Mahol: >>> +const uint16_t *src = (const uint16_t *)ssrc; >> >> This is not -fstrict-aliasing safe >> > > I don't believe that is correct. It's true we

Re: [FFmpeg-devel] [PATCH] avfilter: add wpsnr video filter

2021-10-30 Thread Tomas Härdin
lör 2021-10-30 klockan 10:28 -0400 skrev Ronald S. Bultje: > Hi, > > On Sat, Oct 30, 2021 at 4:57 AM Tomas Härdin > wrote: > > > Maybe we should upgrade to C11 then? This gives us access to more > > useful language features. Type-generic expressions look very useful > > > > https://stackoverfl

Re: [FFmpeg-devel] [PATCH] avfilter: add wpsnr video filter

2021-10-30 Thread Ronald S. Bultje
Hi, On Sat, Oct 30, 2021 at 4:57 AM Tomas Härdin wrote: > Maybe we should upgrade to C11 then? This gives us access to more > useful language features. Type-generic expressions look very useful > https://stackoverflow.com/a/7005988 (same thread, further down) appears to suggest the exact same l

Re: [FFmpeg-devel] [PATCH] avfilter: add wpsnr video filter

2021-10-30 Thread Paul B Mahol
On Sat, Oct 30, 2021 at 12:28 AM Tomas Härdin wrote: > fre 2021-10-29 klockan 19:43 +0200 skrev Paul B Mahol: > > On Fri, Oct 29, 2021 at 7:26 PM Tomas Härdin > > wrote: > > > > > fre 2021-10-29 klockan 19:17 +0200 skrev Paul B Mahol: > > > > On Fri, Oct 29, 2021 at 6:59 PM Tomas Härdin > > > >

Re: [FFmpeg-devel] [PATCH] avfilter: add wpsnr video filter

2021-10-30 Thread Tomas Härdin
fre 2021-10-29 klockan 21:17 -0400 skrev Ronald S. Bultje: > Hi Thomas, > > On Fri, Oct 29, 2021 at 9:12 AM Tomas Härdin > wrote: > > > tor 2021-10-28 klockan 21:09 +0200 skrev Paul B Mahol: > > > +    const uint16_t *src = (const uint16_t *)ssrc; > > > > This is not -fstrict-aliasing safe > >

Re: [FFmpeg-devel] [PATCH] avfilter: add wpsnr video filter

2021-10-29 Thread Ronald S. Bultje
Hi Thomas, On Fri, Oct 29, 2021 at 9:12 AM Tomas Härdin wrote: > tor 2021-10-28 klockan 21:09 +0200 skrev Paul B Mahol: > > +const uint16_t *src = (const uint16_t *)ssrc; > > This is not -fstrict-aliasing safe > I don't believe that is correct. It's true we're not allowed to cast between tw

Re: [FFmpeg-devel] [PATCH] avfilter: add wpsnr video filter

2021-10-29 Thread Tomas Härdin
fre 2021-10-29 klockan 19:43 +0200 skrev Paul B Mahol: > On Fri, Oct 29, 2021 at 7:26 PM Tomas Härdin > wrote: > > > fre 2021-10-29 klockan 19:17 +0200 skrev Paul B Mahol: > > > On Fri, Oct 29, 2021 at 6:59 PM Tomas Härdin > > > wrote: > > > > > > > fre 2021-10-29 klockan 17:00 +0200 skrev Paul

Re: [FFmpeg-devel] [PATCH] avfilter: add wpsnr video filter

2021-10-29 Thread Paul B Mahol
On Fri, Oct 29, 2021 at 7:26 PM Tomas Härdin wrote: > fre 2021-10-29 klockan 19:17 +0200 skrev Paul B Mahol: > > On Fri, Oct 29, 2021 at 6:59 PM Tomas Härdin > > wrote: > > > > > fre 2021-10-29 klockan 17:00 +0200 skrev Paul B Mahol: > > > > On Fri, Oct 29, 2021 at 4:46 PM Tomas Härdin > > > >

Re: [FFmpeg-devel] [PATCH] avfilter: add wpsnr video filter

2021-10-29 Thread Tomas Härdin
fre 2021-10-29 klockan 19:17 +0200 skrev Paul B Mahol: > On Fri, Oct 29, 2021 at 6:59 PM Tomas Härdin > wrote: > > > fre 2021-10-29 klockan 17:00 +0200 skrev Paul B Mahol: > > > On Fri, Oct 29, 2021 at 4:46 PM Tomas Härdin > > > wrote: > > > > > > > fre 2021-10-29 klockan 15:33 +0200 skrev Paul

Re: [FFmpeg-devel] [PATCH] avfilter: add wpsnr video filter

2021-10-29 Thread Paul B Mahol
On Fri, Oct 29, 2021 at 6:59 PM Tomas Härdin wrote: > fre 2021-10-29 klockan 17:00 +0200 skrev Paul B Mahol: > > On Fri, Oct 29, 2021 at 4:46 PM Tomas Härdin > > wrote: > > > > > fre 2021-10-29 klockan 15:33 +0200 skrev Paul B Mahol: > > > > On Fri, Oct 29, 2021 at 3:12 PM Tomas Härdin > > > >

Re: [FFmpeg-devel] [PATCH] avfilter: add wpsnr video filter

2021-10-29 Thread Tomas Härdin
fre 2021-10-29 klockan 17:00 +0200 skrev Paul B Mahol: > On Fri, Oct 29, 2021 at 4:46 PM Tomas Härdin > wrote: > > > fre 2021-10-29 klockan 15:33 +0200 skrev Paul B Mahol: > > > On Fri, Oct 29, 2021 at 3:12 PM Tomas Härdin > > > wrote: > > > > > > > > > +static double get_hx(const uint8_t *src,

Re: [FFmpeg-devel] [PATCH] avfilter: add wpsnr video filter

2021-10-29 Thread Paul B Mahol
On Fri, Oct 29, 2021 at 4:46 PM Tomas Härdin wrote: > fre 2021-10-29 klockan 15:33 +0200 skrev Paul B Mahol: > > On Fri, Oct 29, 2021 at 3:12 PM Tomas Härdin > > wrote: > > > > > > > +static double get_hx(const uint8_t *src, int linesize, int w, > > > > int h) > > > > +{ > > > > +int64_t sum

Re: [FFmpeg-devel] [PATCH] avfilter: add wpsnr video filter

2021-10-29 Thread Tomas Härdin
fre 2021-10-29 klockan 15:33 +0200 skrev Paul B Mahol: > On Fri, Oct 29, 2021 at 3:12 PM Tomas Härdin > wrote: > > > > > +static double get_hx(const uint8_t *src, int linesize, int w, > > > int h) > > > +{ > > > +    int64_t sum = 0; > > > + > > > +    for (int y = 0; y < h; y++) { > > > +   

Re: [FFmpeg-devel] [PATCH] avfilter: add wpsnr video filter

2021-10-29 Thread Paul B Mahol
On Fri, Oct 29, 2021 at 3:12 PM Tomas Härdin wrote: > tor 2021-10-28 klockan 21:09 +0200 skrev Paul B Mahol: > > > > +FRAMESYNC_DEFINE_CLASS(wpsnr, WPSNRContext, fs); > > + > > +#define COMPUTE_HX(type, stype, depth) \ > > +static void compute_hx##depth(const uint8_t *ssrc, \ > >

Re: [FFmpeg-devel] [PATCH] avfilter: add wpsnr video filter

2021-10-29 Thread Tomas Härdin
tor 2021-10-28 klockan 21:09 +0200 skrev Paul B Mahol: > > +FRAMESYNC_DEFINE_CLASS(wpsnr, WPSNRContext, fs); > + > +#define COMPUTE_HX(type, stype, depth)   \ > +static void compute_hx##depth(const uint8_t *ssrc,   \ > +  int linesize,  \ > +

[FFmpeg-devel] [PATCH] avfilter: add wpsnr video filter

2021-10-28 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_wpsnr.c | 894 +++ 3 files changed, 896 insertions(+) create mode 100644 libavfilter/vf_wpsnr.c diff --git a/libavfilter/Makefile b/libavfilte