Re: [FFmpeg-devel] [PATCH] avformat/avformat: Remove redundant "NOT PART OF PUBLIC API"

2020-05-22 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Andreas Rheinhardt: >> AVStream.request_probe as well as AVStream.mux_ts_offset are below the >> separator of public and private fields, so that a further "NOT PART OF >> PUBLIC API" is redundant. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> I initially also wanted to

Re: [FFmpeg-devel] [PATCH] avformat/avformat: Remove redundant "NOT PART OF PUBLIC API"

2020-05-21 Thread Andreas Rheinhardt
Andreas Rheinhardt: > AVStream.request_probe as well as AVStream.mux_ts_offset are below the > separator of public and private fields, so that a further "NOT PART OF > PUBLIC API" is redundant. > > Signed-off-by: Andreas Rheinhardt > --- > I initially also wanted to remove the internal note for

Re: [FFmpeg-devel] [PATCH] avformat/avformat: Remove redundant "NOT PART OF PUBLIC API"

2020-03-19 Thread Derek Buitenhuis
On 18/03/2020 14:31, Andreas Rheinhardt wrote: > I initially also wanted to remove the internal note for AVStream's private > fields ("be aware that physically removing these fields will break > ABI"), but then I became aware that ffmpeg.c uses several of them > (pts_wrap_bits, first_dts, cur_dts,

[FFmpeg-devel] [PATCH] avformat/avformat: Remove redundant "NOT PART OF PUBLIC API"

2020-03-18 Thread Andreas Rheinhardt
AVStream.request_probe as well as AVStream.mux_ts_offset are below the separator of public and private fields, so that a further "NOT PART OF PUBLIC API" is redundant. Signed-off-by: Andreas Rheinhardt --- I initially also wanted to remove the internal note for AVStream's private fields ("be